Re: RFR: 8233942: Update to 609.1 version of WebKit

2020-01-22 Thread Arun Joseph
On Mon, 20 Jan 2020 16:39:15 GMT, Guru Hb wrote: > Updated GTK Webkit 2.26 (609.1) into jfx. Marked as reviewed by ajoseph (Author). - PR: https://git.openjdk.java.net/jfx/pull/91

Re: RFR: 8233942: Update to 609.1 version of WebKit

2020-01-22 Thread Johan Vos
On Mon, 20 Jan 2020 16:39:15 GMT, Guru Hb wrote: > Updated GTK Webkit 2.26 (609.1) into jfx. Marked as reviewed by jvos (Reviewer). - PR: https://git.openjdk.java.net/jfx/pull/91

Re: RFR: 8233942: Update to 609.1 version of WebKit

2020-01-21 Thread Kevin Rushforth
On Mon, 20 Jan 2020 16:39:15 GMT, Guru Hb wrote: > Updated GTK Webkit 2.26 (609.1) into jfx. Everything looks good to me. Here are a couple things I noticed that may warrant a follow-up issue to address them: 1. Unimplemented methods: * FileSystemJava.cpp: * truncateFile *

Re: RFR: 8233942: Update to 609.1 version of WebKit

2020-01-21 Thread Kevin Rushforth
On Tue, 21 Jan 2020 18:02:14 GMT, Kevin Rushforth wrote: >> Updated GTK Webkit 2.26 (609.1) into jfx. > > A sanity check of the patch looks good to me: I did a build / test on all > three platforms. I'll do a bit more testing, and also review the > JavaFX-specific files, before completing my r

Re: RFR: 8233942: Update to 609.1 version of WebKit

2020-01-21 Thread Kevin Rushforth
On Mon, 20 Jan 2020 16:39:15 GMT, Guru Hb wrote: > Updated GTK Webkit 2.26 (609.1) into jfx. A sanity check of the patch looks good to me: I did a build / test on all three platforms. I'll do a bit more testing, and also review the JavaFX-specific files, before completing my review. To the la

RFR: 8233942: Update to 609.1 version of WebKit

2020-01-21 Thread Guru Hb
Updated GTK Webkit 2.26 (609.1) into jfx. - Commits: - 8b48b1e0: 8233942: Update to 609.1 version of WebKit Changes: https://git.openjdk.java.net/jfx/pull/91/files Webrev: https://webrevs.openjdk.java.net/jfx/91/webrev.00 Issue: https://bugs.openjdk.java.net/browse/JDK-8233942

[RFR] 8233942: Update to 609.1 version of WebKit

2020-01-20 Thread Guru
Hi Kevin, Johan, Please review the fix for : JBS : https://bugs.openjdk.java.net/browse/JDK-8233942 PR : https://github.com/openjdk/jfx/pull/91 Fix has latest GTK Webkit 2.26 (609.1) merged into jfx.