Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-07 Thread Nir Lisker
On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-07 Thread Ambarish Rapte
On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-04 Thread Kevin Rushforth
On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-04 Thread Nir Lisker
On Thu, 27 Jan 2022 19:01:32 GMT, Kevin Rushforth wrote: >> I think the description should focus on the meaning of the respective term >> in the lighting equation, and not on a non-technical analogy. In this case, >> the analogy is a bit misleading on several aspects, including the fact that

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

2022-02-04 Thread Nir Lisker
> Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to `LightBase` since > different light types share

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v4]

2022-01-28 Thread Kevin Rushforth
On Thu, 27 Jan 2022 19:57:13 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v4]

2022-01-27 Thread Nir Lisker
> Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to `LightBase` since > different light types share

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v2]

2022-01-27 Thread Kevin Rushforth
On Thu, 27 Jan 2022 17:28:15 GMT, Nir Lisker wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v3]

2022-01-27 Thread Nir Lisker
> Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to `LightBase` since > different light types share

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v2]

2022-01-27 Thread Kevin Rushforth
On Thu, 27 Jan 2022 17:14:51 GMT, Nir Lisker wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/LightBase.java line 119: >> >>> 117: *The transparency (alpha) component of a light is ignored. >>> 118: * >>> 119: * There are no guarantee that these behaviors will not change. >>

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v2]

2022-01-27 Thread Kevin Rushforth
On Thu, 27 Jan 2022 15:45:44 GMT, Michael Strauß wrote: >> What examples would you use? >> >> If a light in a room is strong it will barely cast shadows since its >> reflections from all directions eliminate them. >> >> Maybe I should mention that Ambient light can be used with a dark color

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v2]

2022-01-27 Thread Nir Lisker
> Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to `LightBase` since > different light types share

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

2022-01-27 Thread Nir Lisker
On Tue, 25 Jan 2022 01:17:51 GMT, Kevin Rushforth wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

2022-01-27 Thread Michael Strauß
On Thu, 27 Jan 2022 15:07:26 GMT, Nir Lisker wrote: >> Ambient light is a light that comes from all directions, scattered from >> different surfaces and it does not cast shadow. So I think the example of >> strong light and moon light should be avoided. Moon light is more like the >> Sun

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

2022-01-27 Thread Nir Lisker
On Tue, 25 Jan 2022 06:21:37 GMT, Ambarish Rapte wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/AmbientLight.java line 37: >> >>> 35: * >>> 36: * {@code AmbientLight}s can represent strong light sources in an >>> enclosed area where the lights bounces from many >>> 37: *

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

2022-01-25 Thread Ambarish Rapte
On Sun, 16 Jan 2022 22:54:22 GMT, Nir Lisker wrote: > Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

2022-01-25 Thread Ambarish Rapte
On Tue, 25 Jan 2022 00:40:18 GMT, Kevin Rushforth wrote: >> Now that the standard concrete light types were added, there is an >> opportunity to rearrange and rewrite some of the class docs. Here is a >> summary of the changes: >> >> * Moved the explanations of attenuation and direction up to

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

2022-01-24 Thread Kevin Rushforth
On Sun, 16 Jan 2022 22:54:22 GMT, Nir Lisker wrote: > Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to

[jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

2022-01-16 Thread Nir Lisker
Now that the standard concrete light types were added, there is an opportunity to rearrange and rewrite some of the class docs. Here is a summary of the changes: * Moved the explanations of attenuation and direction up to `LightBase` since different light types share characteristics.

Re: [jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

2022-01-16 Thread Nir Lisker
On Sun, 16 Jan 2022 22:54:22 GMT, Nir Lisker wrote: > Now that the standard concrete light types were added, there is an > opportunity to rearrange and rewrite some of the class docs. Here is a > summary of the changes: > > * Moved the explanations of attenuation and direction up to