Re: [Rev 02] RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Ambarish Rapte
On Fri, 20 Dec 2019 19:20:56 GMT, Frederic Thevenet wrote: >> This is a PR for >> [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627). >> >> When running a JavaFX application in macOS guest VM, the main stage is >> completely blank, with the following errors: CGLChoosePixelFormat

Re: [Rev 02] RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Kevin Rushforth
On Fri, 20 Dec 2019 17:41:00 GMT, Frederic Thevenet wrote: >> This is a PR for >> [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627). >> >> When running a JavaFX application in macOS guest VM, the main stage is >> completely blank, with the following errors: CGLChoosePixelFormat

Re: [Rev 02] RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Frederic Thevenet
> This is a PR for > [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627). > > When running a JavaFX application in macOS guest VM, the main stage is > completely blank, with the following errors: CGLChoosePixelFormat error: > 10002, CGLCreateContext error: 10002 > This behavior was

Re: [Rev 01] RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Kevin Rushforth
On Fri, 20 Dec 2019 10:05:48 GMT, Ambarish Rapte wrote: >> As mentioned in the description of >> [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627), following >> error is printed >> CGLChoosePixelFormat error: 10002 >> >> According to the documentation at [CGL Error >>

Re: [Rev 01] RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Frederic Thevenet
> This is a PR for > [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627). > > When running a JavaFX application in macOS guest VM, the main stage is > completely blank, with the following errors: CGLChoosePixelFormat error: > 10002, CGLCreateContext error: 10002 > This behavior was

Re: RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Frederic Thevenet
On Fri, 20 Dec 2019 14:06:30 GMT, Kevin Rushforth wrote: >> It looks good then, please update PR without `err != kCGLNoError` > > Something like this, maybe? > > if (pix == NULL) { > NSLog(@"CGLChoosePixelFormat: unable to find a pixel format, trying > again with reduced

Re: RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Kevin Rushforth
On Fri, 20 Dec 2019 14:03:02 GMT, Ambarish Rapte wrote: >> OK, so we're in agreement on the fix itself. Good. >> >> The existing logging done right before the function returns will indeed log >> a complete failure to find a valid pixel format. It won't, however, log the >> fact that the

Re: RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Kevin Rushforth
On Fri, 20 Dec 2019 13:53:38 GMT, Frederic Thevenet wrote: >> Actually, the existing check uses `err == kCGLNoError` which seems backwards >> (and likely is a big part of why this bug is happening). My recommendation >> is to not add in the check for `err != kCGLNoError`, and just use `if

Re: RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Ambarish Rapte
On Fri, 20 Dec 2019 14:01:44 GMT, Kevin Rushforth wrote: >> Actually, `err == kCGLNoError` was used before and not `err != kCGLNoError` >> (i.e. equals and not different) and that is in fact the reason for the bug >> (in conjunction with the AND). >> As you note, it's unfortunate that the

Re: RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Frederic Thevenet
On Fri, 20 Dec 2019 13:50:16 GMT, Kevin Rushforth wrote: >> From the documentation, the check `pix == NULL` seems sufficient, but the >> `err != kCGLNoError` was used before, so I just want to keep it safe. If the >> issue occurs without error getting printed it will be difficult to trace. As

Re: RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Ambarish Rapte
On Fri, 20 Dec 2019 10:23:36 GMT, Frederic Thevenet wrote: >> Additionally the if condition at line 105 can be changed to match with the >> change. as, >> `if (pix == NULL || err != kCGLNoError)` > > Could you please be more specific on why you suggest the check be expended > with `|| err

Re: RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread thevenet . fred
Please ignore that; I just RTFM, its all good now ;) - Mail original - De: "Frederic Thevenet" À: "openjfx-dev" Envoyé: Vendredi 20 Décembre 2019 11:31:45 Objet: Re: RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine On Fri, 20 D

Re: RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Frederic Thevenet
On Fri, 20 Dec 2019 10:05:48 GMT, Ambarish Rapte wrote: >> As mentioned in the description of >> [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627), following >> error is printed >> CGLChoosePixelFormat error: 10002 >> >> According to the documentation at [CGL Error >>

Re: RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Frederic Thevenet
On Fri, 20 Dec 2019 09:55:18 GMT, Ambarish Rapte wrote: >> modules/javafx.graphics/src/main/native-glass/mac/GlassView3D.m line 97: >> >>> 96: if (pix == NULL) >>> 97: { >>> 98: const CGLPixelFormatAttribute attributes2[] = >> >> The change looks good. >> I would

Re: RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Ambarish Rapte
On Fri, 20 Dec 2019 10:02:16 GMT, Ambarish Rapte wrote: >> https://bugs.openjdk.java.net/browse/JDK-8235627 > > As mentioned in the description of > [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627), following > error is printed > CGLChoosePixelFormat error: 10002 > >

Re: RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Ambarish Rapte
On Tue, 10 Dec 2019 13:12:37 GMT, Frederic Thevenet wrote: > https://bugs.openjdk.java.net/browse/JDK-8235627 As mentioned in the description of [JDK-8235627](https://bugs.openjdk.java.net/browse/JDK-8235627), following error is printed CGLChoosePixelFormat error: 10002 According to the

Re: RFR: 8235627: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-20 Thread Ambarish Rapte
On Fri, 20 Dec 2019 09:50:35 GMT, Ambarish Rapte wrote: >> https://bugs.openjdk.java.net/browse/JDK-8235627 > > modules/javafx.graphics/src/main/native-glass/mac/GlassView3D.m line 97: > >> 96: if (pix == NULL) >> 97: { >> 98: const CGLPixelFormatAttribute

Re: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-10 Thread Kevin Rushforth
yet). Anyway, it doesn't matter; I can now go forward with my PR. Thanks again. Fred. - Mail original - De: "Michael Paus" À: "openjfx-dev" Envoyé: Mardi 10 Décembre 2019 11:59:30 Objet: Re: Blank stages when running JavaFX app in a macOS virtual machine Hi, maybe y

Re: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-10 Thread thevenet . fred
original - De: "Michael Paus" À: "openjfx-dev" Envoyé: Mardi 10 Décembre 2019 11:59:30 Objet: Re: Blank stages when running JavaFX app in a macOS virtual machine Hi, maybe you lost the response mail or it went into your trash. I guess this is your bug repo

Re: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-10 Thread Michael Paus
this moving forward. Many thanks, Fred. - Mail original - De: "thevenet fred" À: "Kevin Rushforth" Cc: "openjfx-dev" Envoyé: Mardi 3 Décembre 2019 18:46:57 Objet: Re: Blank stages when running JavaFX app in a macOS virtual machine Ok thanks, will do tha

Re: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-10 Thread thevenet . fred
running JavaFX app in a macOS virtual machine Ok thanks, will do that. Regards, Frederic Thevenet - Mail original - De: "Kevin Rushforth" À: "openjfx-dev" Envoyé: Mardi 3 Décembre 2019 18:35:49 Objet: Re: Blank stages when running JavaFX app in a macOS virtual machin

RE: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-03 Thread Frederic Thevenet
In this precise case, it is kCGLPFAAccelerated Regards Frederic Thevenet -Original Message- From: Sergey Bylokhov [mailto:sergey.bylok...@oracle.com] Sent: 03 December 2019 21:20 To: thevenet.f...@free.fr; openjfx-dev Subject: Re: Blank stages when running JavaFX app in a macOS virtual

Re: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-03 Thread Sergey Bylokhov
Just curious what attribute caused the first request to fail. Is it related to kCGLPFAAccelerated or XXXSize? 87 kCGLPFAAccelerated, 88 kCGLPFAColorSize, 32, 89 kCGLPFAAlphaSize, 8, 90 kCGLPFADepthSize, depth, 91

Re: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-03 Thread thevenet . fred
Ok thanks, will do that. Regards, Frederic Thevenet - Mail original - De: "Kevin Rushforth" À: "openjfx-dev" Envoyé: Mardi 3 Décembre 2019 18:35:49 Objet: Re: Blank stages when running JavaFX app in a macOS virtual machine A new follow-on bug ID will be needed. W

Re: Blank stages when running JavaFX app in a macOS virtual machine

2019-12-03 Thread Kevin Rushforth
A new follow-on bug ID will be needed. We never reopen a JBS issue once it has been resolved as fixed by a changeset that has been pushed. -- Kevin On 12/3/2019 7:11 AM, thevenet.f...@free.fr wrote: Hello, When running a JavaFX application in macOS guest VM, the main stage is completely

Blank stages when running JavaFX app in a macOS virtual machine

2019-12-03 Thread thevenet . fred
Hello, When running a JavaFX application in macOS guest VM, the main stage is completely blank, with the following errors: CGLChoosePixelFormat error: 10002, CGLCreateContext error: 10002 This behavior was observed with a macOS 10.15 guest OS on both VMWare player and VirtualBox, on a Windows