On Mon, 28 Jun 2021 18:12:33 GMT, Phil Race wrote:
>> It's still a good idea to follow the pattern, so yes let's make the new
>> methods final. We can file a cleanup bug for the existing ones (and since
>> the class is final, we can do it without compatibility concerns).
>>
>> Also, I built
On Fri, 25 Jun 2021 21:10:16 GMT, Kevin Rushforth wrote:
>> But the JobSettings class is final .. is it still necessary ?
>
> It's still a good idea to follow the pattern, so yes let's make the new
> methods final. We can file a cleanup bug for the existing ones (and since the
> class is
On Thu, 24 Jun 2021 23:06:54 GMT, Phil Race wrote:
>> modules/javafx.graphics/src/main/java/javafx/print/JobSettings.java line 541:
>>
>>> 539: * @since 17
>>> 540: */
>>> 541: public String getOutputFile() {
>>
>> This should be final (as should the setter). I see that other
On Thu, 24 Jun 2021 22:42:00 GMT, Kevin Rushforth wrote:
>> Phil Race has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8223717: javafx printing: Support Specifying Print to File in the API
>> - 8223717: javafx printing: Support
On Thu, 24 Jun 2021 22:34:36 GMT, Phil Race wrote:
>> This enhancement adds the String property outputFileProperty() to the
>> JobSettings class.
>> The value should be a string that references a local file encoded as a URL.
>> If this is non-null and set to a location that the user has
On Thu, 24 Jun 2021 22:34:36 GMT, Phil Race wrote:
>> This enhancement adds the String property outputFileProperty() to the
>> JobSettings class.
>> The value should be a string that references a local file encoded as a URL.
>> If this is non-null and set to a location that the user has
> This enhancement adds the String property outputFileProperty() to the
> JobSettings class.
> The value should be a string that references a local file encoded as a URL.
> If this is non-null and set to a location that the user has permission to
> write to,
> then the printer output will be
