Re: RFR: 8254691: Enable GitHub actions for jfx repo [v2]

2020-10-31 Thread Johan Vos
On Wed, 28 Oct 2020 14:43:52 GMT, Kevin Rushforth wrote: >> This is a proposed fix for >> [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable >> GitHub actions for the jfx repo. It is similar in purpose to what was done >> for the jdk repo. >> >> Once this is

Re: RFR: 8254691: Enable GitHub actions for jfx repo [v2]

2020-10-31 Thread Kevin Rushforth
On Sat, 31 Oct 2020 14:35:09 GMT, Kevin Rushforth wrote: >> This works fine. I have a minor comment (about using 15.0.1, but since we >> don't use that in build.properties either, I think it's not an issue), and >> apart from that, this looks very good. > > I'd rather update the boot JDK to

Re: RFR: 8254691: Enable GitHub actions for jfx repo [v2]

2020-10-31 Thread Kevin Rushforth
On Fri, 30 Oct 2020 17:05:37 GMT, Johan Vos wrote: >> Looks good to me. Verified a dummy PR with two commits. >> Actions executed correctly on both commits. Also verified that test failure >> is reported correctly and failed test can be found in log under Actions >> section. > > This works

Re: RFR: 8254691: Enable GitHub actions for jfx repo [v2]

2020-10-30 Thread Johan Vos
On Thu, 29 Oct 2020 18:30:47 GMT, Ambarish Rapte wrote: >> Kevin Rushforth has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >>

Re: RFR: 8254691: Enable GitHub actions for jfx repo [v2]

2020-10-30 Thread Johan Vos
On Wed, 28 Oct 2020 14:43:52 GMT, Kevin Rushforth wrote: >> This is a proposed fix for >> [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable >> GitHub actions for the jfx repo. It is similar in purpose to what was done >> for the jdk repo. >> >> Once this is

Re: RFR: 8254691: Enable GitHub actions for jfx repo [v2]

2020-10-29 Thread Ambarish Rapte
On Wed, 28 Oct 2020 14:43:52 GMT, Kevin Rushforth wrote: >> This is a proposed fix for >> [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable >> GitHub actions for the jfx repo. It is similar in purpose to what was done >> for the jdk repo. >> >> Once this is

Re: RFR: 8254691: Enable GitHub actions for jfx repo [v2]

2020-10-28 Thread Kevin Rushforth
> This is a proposed fix for > [JDK-8254691](https://bugs.openjdk.java.net/browse/JDK-8254691) to enable > GitHub actions for the jfx repo. It is similar in purpose to what was done > for the jdk repo. > > Once this is integrated, and subsequently merged into your personal fork, a > GitHub