On Thu, 29 Oct 2020 18:30:47 GMT, Ambarish Rapte <ara...@openjdk.org> wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Merge branch 'master' into 8254691-github-actions >> - Ignore additional branches; minor cleanup >> - WIP: 8254691: Enable GitHub actions for jfx repo >> >> Initial working version on Linux, Mac, Windows > > Looks good to me. Verified a dummy PR with two commits. > Actions executed correctly on both commits. Also verified that test failure > is reported correctly and failed test can be found in log under Actions > section. This works fine. I have a minor comment (about using 15.0.1, but since we don't use that in build.properties either, I think it's not an issue), and apart from that, this looks very good. ------------- PR: https://git.openjdk.java.net/jfx/pull/338
