Re: RFR: 8271091: Missing API docs in UI controls classes [v5]

2021-10-28 Thread Nir Lisker
On Thu, 28 Oct 2021 14:27:52 GMT, Ajit Ghaisas wrote: >> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - >> [JDK-82

Re: RFR: 8271091: Missing API docs in UI controls classes [v5]

2021-10-28 Thread Kevin Rushforth
On Thu, 28 Oct 2021 14:27:52 GMT, Ajit Ghaisas wrote: >> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - >> [JDK-82

Re: RFR: 8271091: Missing API docs in UI controls classes [v5]

2021-10-28 Thread Kevin Rushforth
On Thu, 28 Oct 2021 23:30:32 GMT, Kevin Rushforth wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix review comments > > modules/javafx.controls/src/main/java/javafx/scene/control/PopupControl.java > line 1132: >

Re: RFR: 8271091: Missing API docs in UI controls classes [v5]

2021-10-28 Thread Kevin Rushforth
On Thu, 28 Oct 2021 14:27:52 GMT, Ajit Ghaisas wrote: >> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - >> [JDK-82

Re: RFR: 8271091: Missing API docs in UI controls classes [v5]

2021-10-28 Thread Ajit Ghaisas
> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. > Note : > - The javadoc needs to be generated with the JDK 18 EA build. > - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - > [JDK-8271085](https://bugs.openjdk.java.net/browse/JDK-8271085) > -

Re: RFR: 8271091: Missing API docs in UI controls classes [v4]

2021-10-28 Thread Ajit Ghaisas
On Wed, 27 Oct 2021 16:12:11 GMT, Nir Lisker wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix review comments > > modules/javafx.controls/src/main/java/javafx/scene/control/CheckMenuItem.java > line 89: > >> 8

Re: RFR: 8271091: Missing API docs in UI controls classes [v4]

2021-10-27 Thread Nir Lisker
On Tue, 26 Oct 2021 06:24:35 GMT, Ajit Ghaisas wrote: >> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - >> [JDK-82

Re: RFR: 8271091: Missing API docs in UI controls classes [v4]

2021-10-27 Thread Ajit Ghaisas
On Wed, 20 Oct 2021 15:45:52 GMT, Nir Lisker wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix review comments > > Took a quick look at the new docs. I didn't check the resulting HTML or the > corrected of the d

Re: RFR: 8271091: Missing API docs in UI controls classes [v4]

2021-10-26 Thread Kevin Rushforth
On Tue, 26 Oct 2021 06:24:35 GMT, Ajit Ghaisas wrote: >> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - >> [JDK-82

Re: RFR: 8271091: Missing API docs in UI controls classes [v4]

2021-10-25 Thread Ajit Ghaisas
> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. > Note : > - The javadoc needs to be generated with the JDK 18 EA build. > - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - > [JDK-8271085](https://bugs.openjdk.java.net/browse/JDK-8271085) > -

Re: RFR: 8271091: Missing API docs in UI controls classes [v3]

2021-10-25 Thread Ajit Ghaisas
On Mon, 25 Oct 2021 22:53:53 GMT, Kevin Rushforth wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix review comments > > modules/javafx.controls/src/main/java/javafx/scene/control/PopupControl.java > line 179: >

Re: RFR: 8271091: Missing API docs in UI controls classes [v3]

2021-10-25 Thread Kevin Rushforth
On Mon, 25 Oct 2021 17:47:38 GMT, Ajit Ghaisas wrote: >> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - >> [JDK-82

Re: RFR: 8271091: Missing API docs in UI controls classes [v3]

2021-10-25 Thread Ajit Ghaisas
> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. > Note : > - The javadoc needs to be generated with the JDK 18 EA build. > - 2 javadoc warnings in javafx.controls TabPane class will be fixed under - > [JDK-8271085](https://bugs.openjdk.java.net/browse/JDK-8271085) > -

Re: RFR: 8271091: Missing API docs in UI controls classes [v2]

2021-10-25 Thread Ajit Ghaisas
On Fri, 22 Oct 2021 13:37:38 GMT, Kevin Rushforth wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> javadoc minor corrections > > modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java > line 470

Re: RFR: 8271091: Missing API docs in UI controls classes [v2]

2021-10-22 Thread Kevin Rushforth
On Thu, 21 Oct 2021 08:58:37 GMT, Ajit Ghaisas wrote: >> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - There are still 20 javadoc warnings remaining in javafx.controls module >> and 3 war

Re: RFR: 8271091: Missing API docs in UI controls classes [v2]

2021-10-21 Thread Ajit Ghaisas
> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. > Note : > - The javadoc needs to be generated with the JDK 18 EA build. > - There are still 20 javadoc warnings remaining in javafx.controls module and > 3 warnings remaining in javafx.web module. The root cause is diffe

Re: RFR: 8271091: Missing API docs in UI controls classes

2021-10-20 Thread Michael Strauß
On Wed, 20 Oct 2021 15:23:07 GMT, Nir Lisker wrote: >> This PR fixes javadoc warnings in javafx.controls and javafx.web modules. >> Note : >> - The javadoc needs to be generated with the JDK 18 EA build. >> - There are still 20 javadoc warnings remaining in javafx.controls module >> and 3 warni

Re: RFR: 8271091: Missing API docs in UI controls classes

2021-10-20 Thread Nir Lisker
On Wed, 20 Oct 2021 14:42:44 GMT, Ajit Ghaisas wrote: > This PR fixes javadoc warnings in javafx.controls and javafx.web modules. > Note : > - The javadoc needs to be generated with the JDK 18 EA build. > - There are still 20 javadoc warnings remaining in javafx.controls module and > 3 warnings

RFR: 8271091: Missing API docs in UI controls classes

2021-10-20 Thread Ajit Ghaisas
This PR fixes javadoc warnings in javafx.controls and javafx.web modules. Note : - The javadoc needs to be generated with the JDK 18 EA build. - There are still 20 javadoc warnings remaining in javafx.controls module and 3 warnings remaining in javafx.web module. The root cause is different and t