Review-Request for JDK-8209765

Hi, I'd like to request a review for JDK-8209765 available as a PR on Github: https://github.com/javafxports/openjdk-jfx/pull/153 Thanks. -- Michael Ennen

[12] Review request: 8203379: Remove javapackager sources from OpenJFX repo

Please review the following to remove the javapackager sources and build logic from the openjfx repo: https://bugs.openjdk.java.net/browse/JDK-8203379 http://cr.openjdk.java.net/~kcr/8203379/webrev.00/ See JBS for more information. -- Kevin

Review Request: JDK-8209015: Update Eclipse project files

Hi, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8209015 http://cr.openjdk.java.net/~nlisker/8209015/webrev.00/ Thanks, Nir

[11] Review request: 8209507: Incorrect copyright header for some Ensemble samples

Phil, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8209507 http://cr.openjdk.java.net/~kcr/8209507/webrev/ This fixes a bug in the copyright header of two source files in the Ensemble sample. -- Kevin

[11] Review request: 8209358: Broken links in API docs for css page, fxml page, and all image files

Please review the following simple fix to copy the javadoc resources into the correct place when using JDK 11 (or later) as a boot JDK: https://bugs.openjdk.java.net/browse/JDK-8209358 http://cr.openjdk.java.net/~kcr/8209358/webrev/ -- Kevin

[12] Review request: 8209040: Change JavaFX release version to 12

Please review the following to bump the feature version (aka major version) of openjfx to 12: https://bugs.openjdk.java.net/browse/JDK-8209040 http://cr.openjdk.java.net/~kcr/8209040/webrev/ As a note, I will wait to push this until the repo is tagged with 11+22 (the RDP2 build). I will then

[11] Review request: 8201563: Update copyright header for files modified in 2018

Please review the following to update the date in the copyright header (JDK-8201563) and also fix a garbled copyright header (JDK-8202357). https://bugs.openjdk.java.net/browse/JDK-8201563 https://bugs.openjdk.java.net/browse/JDK-8202357 http://cr.openjdk.java.net/~kcr/8201563/webrev/ -- Kevin

Review Request JDK-8207932 : Wrong rendering of variation sequences

Hi, I'd like to request a review for JDK-8207932. [1] https://bugs.openjdk.java.net/browse/JDK-8207932 [2] https://github.com/javafxports/openjdk-jfx/pull/126 Includes 2 patches (1) rendering variation sequences (for Win,MAC only) 55d85b5 https://github.com/javafxports/openjdk-jfx/pul

[11] Review request: 8208610: Incorrect check for calling class in FXMLLoader::getDefaultClassLoader

Please review the following: https://bugs.openjdk.java.net/browse/JDK-8208610 http://cr.openjdk.java.net/~kcr/8208610/webrev/ Evaluation is in JBS. -- Kevin

Review Request: JDK-8204653: Fix mistakes in FX API docs

Hi Kevin, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8204653 http://cr.openjdk.java.net/~nlisker/8204653/webrev.00/ I did not include a fix for https://github.com/javafxports/openjdk-jfx/issues/122, which is pending.

Review-Request for JDK-8208076 (display INVISIBLE_GLYPH_ID as square box on Windows)

Hi. I'd like to request a review for JDK-8208076 [1] available as a PR [2] on the Github-Mirror. Thanks Akira Nakajima [1]https://bugs.openjdk.java.net/browse/JDK-8208076 [2]https://github.com/javafxports/openjdk-jfx/pull/137 -- Company: NTT Co

Re: Review-Request for JDK-8207370

hael Ennen wrote: Hi, I'd like to request a review for JDK-8207370 available as a PR on Github: https://github.com/javafxports/openjdk-jfx/pull/135 Thanks. -- Michael Ennen

Re: Review-Request for JDK-8207370

Hi Michael, Excuse me for the simple question, but how to you enable those tests (as in: what options do you provide to gradle)? Fix looks trivial to me, but want to double check. - Johan On Mon, Jul 23, 2018 at 11:36 PM Michael Ennen wrote: > Hi, > > I'd like to request a

Re: Review Request JDK-8187100 [JavaFX] To make display Variation Selectors(SVS/IVS) on Win(VISTA-) and MacOS(10.6-)

This is being tracked here: https://bugs.openjdk.java.net/browse/JDK-8207932 As an RFE, this can be considered for openjfx12. -- Kevin On 7/5/2018 11:59 PM, Nakajima Akira wrote: Hi All. patch: https://github.com/javafxports/openjdk-jfx/pull/126 This is separated from http://mail.openjdk.

Re: Review Request Re: [PATCH] Fix bug to handle minus value glyph_id on Windows

As an FYI, this is filed in JBS as: https://bugs.openjdk.java.net/browse/JDK-8207839 and is now being reviewed. -- Kevin On 7/5/2018 8:10 PM, Nakajima Akira wrote: Hi All. I created github account today  and re-posted this patch to github. Please review the following fix: patch: https

Review-Request for JDK-8207377

Hi, I'd like to request a review for JDK-8207377 available as a PR on Github: https://github.com/javafxports/openjdk-jfx/pull/140 Thanks. -- Michael Ennen

Review-Request for JDK-8207370

Hi, I'd like to request a review for JDK-8207370 available as a PR on Github: https://github.com/javafxports/openjdk-jfx/pull/135 Thanks. -- Michael Ennen

Review-Request for JDK-8207794

Hi, I'd like to request a review for JDK-8207794 [1] available as a PR [2] on the Github-Mirror. Thanks Tom [1]https://bugs.openjdk.java.net/browse/JDK-8207794 [2]https://github.com/javafxports/openjdk-jfx/pull/139

Review-Request for JDK-8207372

Hi, I'd like to request a review for the fix of JDK-8207372. The change is at https://github.com/javafxports/openjdk-jfx/pull/134 Thanks. -- Michael Ennen

[11] Review request: 8207015: jlink javafx.graphics on Windows fails: PluginException: Duplicate resources

Please review the following PR on GItHub. Once approved there, I will merge it to develop and then push it to the jfx-dev HG repo. https://bugs.openjdk.java.net/browse/JDK-8207015 https://github.com/javafxports/openjdk-jfx/pull/136 -- Kevin

[openjfx11] Review request for 8206995: Remove unused WebKit files

Hi, Please review the fix for following bug, Bug: https://bugs.openjdk.java.net/browse/JDK-8206995 Patch: https://bugs.openjdk.java.net/secure/attachment/77667/rt.patch Thanks, Arun

Re: review request for 8205919: artifacts for maven central

+1 On 7/13/2018 3:40 AM, Johan Vos wrote: PR 83 (https://github.com/javafxports/openjdk-jfx/pull/83) is ready to be merged. The JBS issue is at https://bugs.openjdk.java.net/browse/JDK-8205919 webrev: http://cr.openjdk.java.net/~jvos/8205919/webrev.00/rt.patch The GitHub PR is approved by Kevi

review request for 8205919: artifacts for maven central

PR 83 (https://github.com/javafxports/openjdk-jfx/pull/83) is ready to be merged. The JBS issue is at https://bugs.openjdk.java.net/browse/JDK-8205919 webrev: http://cr.openjdk.java.net/~jvos/8205919/webrev.00/rt.patch The GitHub PR is approved by Kevin, if I get a +1 on the webrev I can do that

[openjfx11] Review request for 8206899: DRT crashes randomly when running 'dom/html/level2/html/AppletsCollection.html'

Hi, Please review the following fix, https://bugs.openjdk.java.net/browse/JDK-8206899 <https://bugs.openjdk.java.net/browse/JDK-8206899> http://cr.openjdk.java.net/~arajkumar/8206899/webrev <http://cr.openjdk.java.net/~arajkumar/8206899/webrev> Root-cause: Problem is due to t

Review Request JDK-8187100 [JavaFX] To make display Variation Selectors(SVS/IVS) on Win(VISTA-) and MacOS(10.6-)

Hi All. patch: https://github.com/javafxports/openjdk-jfx/pull/126 This is separated from http://mail.openjdk.java.net/pipermail/openjfx-dev/2018-June/022005.html and modified to simple patch for Win(VISTA or later) and MacOS(10.6 or later). I checked on Windows7 and Windows10. But I could

RE: [11] Review Request:JDK-8186187 Modify return type of public API StyleConverter.getEnumConverter()

Hi Kevin, Ajit Please review the updated patch with test case: HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/fx/8186187/webrev.01/"http://cr.openjdk.java.net/~pkbalakr/fx/8186187/webrev.01/ Regards, Prem From: Prem Balakrishnan Sent: Monday, May 14, 2018 5:04 PM

Review Request Re: [PATCH] Fix bug to handle minus value glyph_id on Windows

Hi All. I created github account today and re-posted this patch to github. Please review the following fix: patch: https://github.com/javafxports/openjdk-jfx/pull/125 Regards, Akira Nakajima -- Company: NTT Comware Corporation Name: Akira Nakajima E-Mail

Re: GitHub review for JDK-8203345: Memory leak in VirtualFlow when screen reader is enabled

Note that this has already been merged into the 'develop' branch on GitHub. Barring any objections, I'll push it to openjfx-dev tomorrow. On 7/5/2018 1:06 PM, Bernhard Lutzmann wrote: Hi, please review the following pull request on GitHub: JBS: https://bugs.openjdk.java

GitHub review for JDK-8203345: Memory leak in VirtualFlow when screen reader is enabled

Hi, please review the following pull request on GitHub: JBS: https://bugs.openjdk.java.net/browse/JDK-8203345 PR: https://github.com/javafxports/openjdk-jfx/pull/78 Thanks, Bernhard

[11] Review request: 8090763: FX Robot API

Most of you should be aware of this already: The review for the public FX Robot API, contributed by Michael Ennen (and sponsored by me), has been proceeding on GitHub: https://bugs.openjdk.java.net/browse/JDK-8090763 https://github.com/javafxports/openjdk-jfx/pull/36 My review is now done, so

[11] Review request: 8201231 : java.lang.NullPointerException at WindowStage.setPlatformEnabled

Hi, Please review this fix : Webrev : http://cr.openjdk.java.net/~dkumar/primanga/8201231/webrev.00/ JBS : https://bugs.openjdk.java.net/browse/JDK-8201231 Thanks, Priyanka

[11] Review request: 8199474: Update to 606.1 version of WebKit

webkit — Contains changes other than "modules/javafx.web/src/main/native", it will be useful _only_ for review. 2. rt.changeset.gz — Actual changeset file in compressed format which contains all the changes from “rt” directory, uncompress before using it(gunzip rt.changeset.gz) and do the

[openjfx11] Review request for 8204856: WebEngine document becomes null after PAGE_REPLACED event

Hi, Please review the following fix: patch: http://cr.openjdk.java.net/~arajkumar/8204856/webrev/ <http://cr.openjdk.java.net/~arajkumar/8204856/webrev/> bug: https://bugs.openjdk.java.net/browse/JDK-8204856 <https://bugs.openjdk.java.net/browse/JDK-8204856> Root cause: When e

Re: Review-Request for JDK-8191661

+1 -- Kevin On 6/20/2018 1:07 AM, Tom Schindl wrote: Hi, I'd like to request a review for the fix of JDK-8191661. The change is at https://github.com/javafxports/openjdk-jfx/pull/100 Tom

Review-Request for JDK-8191661

Hi, I'd like to request a review for the fix of JDK-8191661. The change is at https://github.com/javafxports/openjdk-jfx/pull/100 Tom

Re: [11] Review request: 8200446: Update minimum boot JDK to 10

nse to use 'var' gratuitously). I'll remind that there's a style guide at http://openjdk.java.net/projects/amber/LVTIstyle.html. - Nir On Thu, Jun 14, 2018 at 4:33 PM, Kevin Rushforth mailto:kevin.rushfo...@oracle.com>> wrote: Please review the following to b

Re: [11] Review request: 8200446: Update minimum boot JDK to 10

er/LVTIstyle.html. - Nir On Thu, Jun 14, 2018 at 4:33 PM, Kevin Rushforth wrote: > Please review the following to bump the minimum boot JDK required for > JavaFX builds to JDK 10. Note that the review will be done on github, but > it is OK to reply to this thread with

[11] Review request: 8200446: Update minimum boot JDK to 10

Please review the following to bump the minimum boot JDK required for JavaFX builds to JDK 10. Note that the review will be done on github, but it is OK to reply to this thread with comments if you don't have a github account. https://bugs.openjdk.java.net/browse/JDK-8200446

Re: OpenJFX code review policies, etc.

ould be clarified. The short version of the proposal is: ... 2. Revised code review policies for different types of changes: simple, low-impact fixes (1 Reviewer); higher-impact fixes (2 Reviewers + allow time for others to chime in); Features / API changes (CSR approval, including app

Re: OpenJFX code review policies, etc.

ets of eye balls were on it. -phil. On 05/24/2018 10:36 AM, Kevin Rushforth wrote: Phil pointed out one glaring typo in the summary and also a couple things in the details that could be clarified. The short version of the proposal is: ... 2. Revised code review policies for different types

[11] Review request: 8203801: Missing Classpath exception in PrismLoaderGlue.stg file

Phil, Please review the following to fix up the copyright header: https://bugs.openjdk.java.net/browse/JDK-8203801 http://cr.openjdk.java.net/~kcr/8203801/webrev/ -- Kevin

[11] Review request for 8202393: App Transport Security blocks http media on macOS with JDK build using new compilers

Hi Kevin, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8202393 Added exception to allow HTTP protocol in AVFoundation when building with SDK 10.11. Thanks, Alexander

Re: GitHub review for JDK-8201553: Update FX build to use gradle 4.8

/ GitHub commit: https://github.com/javafxports/openjdk-jfx/commit/04dc51b698347ce53420777abff4b2c472e45d32 -- Kevin On 6/6/2018 11:00 AM, Kevin Rushforth wrote: Hi Phil & Johan, I have initiated a pull request on GitHub as a review for: JBS: https://bugs.openjdk.java.net/browse/JDK-820155

GitHub review for JDK-8201553: Update FX build to use gradle 4.8

Hi Phil & Johan, I have initiated a pull request on GitHub as a review for: JBS: https://bugs.openjdk.java.net/browse/JDK-8201553 PR: https://github.com/javafxports/openjdk-jfx/pull/92 It is now ready to be reviewed, and once the review is done, merged into the develop branch of the Gi

Re: OpenJFX code review policies, etc.

> > Ultimately it will be a judgment call. I can't speak for Johan, but what > I usually do is see whether the proposed feature is a good fit for the > API, doesn't raise any compatibility concerns, is supportable, testable, > etc., and then get to the more detailed review of th

Re: OpenJFX code review policies, etc.

reviewers/experts (names and mail) according to their field, as done in the outdated Wiki [1]. This way contributors know who to address in a review request mail. Currently, I need to filter a subcomponent in JIRA and see who provides the fixes there to know who to ask. That is a good idea. Reviving

[11] Review request for 8199527: Upgrade GStreamer to 1.14

Hi Kevin, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8199527 Upgraded GStreamer to 1.14. Thanks, Alexander

Re: OpenJFX code review policies, etc.

r, via email, send a message with subject or body 'help' to >> > openjfx-dev-requ...@openjdk.java.net >> > >> > You can reach the person managing the list at >> > openjfx-dev-ow...@openjdk.java.net >> > >> > When replyin

[11] Review request for 8203698: JavaFX WebView crashes when visiting certain web sites

  Hi Kevin, Arun Please review the below fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8203698   webrev:  http://cr.openjdk.java.net/~mbilla/8203698/webrev.00/ Thanks, Murali

[11] Review Request JDK-8201285 DateCell text color are not updated correctly when DateCell with disable = true is reused

Hi Kevin, Ajit Request you to review following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8201285 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/fx/8201285/webrev00/"http://cr.openjdk.java.net/~pkbalakr/fx/8201285/webrev00/ Regards, Prem

Re: OpenJFX code review policies, etc.

Phil pointed out one glaring typo in the summary and also a couple things in the details that could be clarified. The short version of the proposal is: ... 2. Revised code review policies for different types of changes: simple, low-impact fixes (1 Reviewer); higher-impact fixes (2 Reviewers

Re: OpenJFX code review policies, etc.

field, as done in the outdated Wiki [1]. This way contributors know who to address in a review request mail. Currently, I need to filter a subcomponent in JIRA and see who provides the fixes there to know who to ask. B. We need to set formal guidelines for becoming a Reviewer. The JDK uses a >

Re: OpenJFX code review policies, etc.

ev-requ...@openjdk.java.net > > > > You can reach the person managing the list at > > openjfx-dev-ow...@openjdk.java.net > > > > When replying, please edit your Subject line so it i

OpenJFX code review policies, etc.

; openjfx-dev-ow...@openjdk.java.net > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of openjfx-dev digest..." > > > Today's Topics: > >1. OpenJFX code review policies, etc. (Kevin Rushforth) > > &

OpenJFX code review policies, etc.

To: OpenJFX Developers As I mentioned in a message last week [1] I would like to restart the discussion we started a few months ago [2] around making it easier to contribute code to OpenJFX. To this end, I like to make some concrete proposals around code review / API review policies. Before

Re: Review Request: JDK-8195974: Replace use of java.util.logging

> but if the test class is deployed on the class path / unnamed > > module then the test class should still be able to > > configure/access java.logging to verify the behaviour > > of the module under test. > > > > best regards, > > > > --

Re: Review Request: JDK-8195974: Replace use of java.util.logging

est class  should still be able to > configure/access java.logging to verify the behaviour > of the module under test. > > best regards, > > -- daniel > > > On 20/05/2018 13:00, openjfx-dev-requ...@openjdk.java.net wrote: >> Hi, >> >> Please review t

Re: Review Request: JDK-8195974: Replace use of java.util.logging

is deployed on the class path / unnamed > module then the test class should still be able to > configure/access java.logging to verify the behaviour > of the module under test. > > best regards, > > -- daniel > > > On 20/05/2018 13:00, openjfx-dev-requ...@openjdk.java.net wro

Re: Review Request: JDK-8195974: Replace use of java.util.logging

, -- daniel On 20/05/2018 13:00, openjfx-dev-requ...@openjdk.java.net wrote: Hi, Please review the fix approach for: https://bugs.openjdk.java.net/browse/JDK-8195974 http://cr.openjdk.java.net/~nlisker/8195974/webrev.00/ Many details in the issue. Thanks, Nir

[openjfx11] Review request for 8203294: [Linux] Link libgcc and libstdc++ statically to support gcc-7.x

Hi, Please review the following fix: http://cr.openjdk.java.net/~arajkumar/8203294/webrev Root cause: Currently C and C++ standard libraries are linked dynamically(except javafx.web), it may restrict the usage of javafx on old Linux distros when we upgrade to latest compiler(GCC 7.3

Re: [11] Review request: 8203378: JDK build fails to compile javafx.graphics module-info.java if FX was built with OpenJDK

/021740.html > > [2] https://bugs.openjdk.java.net/browse/JDK-8195974 > > - Nir > > On Mon, May 21, 2018 at 8:54 PM, Kevin Rushforth < > kevin.rushfo...@oracle.com> wrote: > >> Phil or Ajit, >> >> Please review the following simple fix: >> >>

Re: [11] Review request: 8203378: JDK build fails to compile javafx.graphics module-info.java if FX was built with OpenJDK

Phil or Ajit, Please review the following simple fix: https://bugs.openjdk.java.net/browse/JDK-8203378 <https://bugs.openjdk.java.net/browse/JDK-8203378> http://cr.openjdk.java.net/~kcr/8203378/webrev.00/ <http://cr.openjdk.java.net/%7Ekcr/8203378/webrev.00/> This

Re: [11] Review request: 8203378: JDK build fails to compile javafx.graphics module-info.java if FX was built with OpenJDK

rowse/JDK-8195974 - Nir On Mon, May 21, 2018 at 8:54 PM, Kevin Rushforth wrote: > Phil or Ajit, > > Please review the following simple fix: > > https://bugs.openjdk.java.net/browse/JDK-8203378 > http://cr.openjdk.java.net/~kcr/8203378/webrev.00/ > > This remo

[11] Review request: 8203378: JDK build fails to compile javafx.graphics module-info.java if FX was built with OpenJDK

Phil or Ajit, Please review the following simple fix: https://bugs.openjdk.java.net/browse/JDK-8203378 http://cr.openjdk.java.net/~kcr/8203378/webrev.00/ This removes one qualified export from javafx.graphics to the no-longer-built jdk.packager module. More details in JBS. Note to Eclipse

Review Request: JDK-8195974: Replace use of java.util.logging in javafx with System logger

Hi, Please review the fix approach for: https://bugs.openjdk.java.net/browse/JDK-8195974 http://cr.openjdk.java.net/~nlisker/8195974/webrev.00/ Many details in the issue. Thanks, Nir

[11] Review request: 8201261: Ability to override the dependency repositories used by gradle

Phil, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8201261 http://cr.openjdk.java.net/~kcr/8201261/webrev.00/ This adds support for two new gradle properties, JFX_DEPS_URL and JDK_DOCS_LINK, replacing logic currently in the closed build. Details are in JBS

[11] Review Request:JDK-8186187 Modify return type of public API StyleConverter.getEnumConverter()

Hi Kevin, Ajit Request you to review following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8186187 Webrev: http://cr.openjdk.java.net/~pkbalakr/fx/8186187/webrev.00/ Regards, Prem

[11] Review request: JDK-8202368: Create jmods for standalone javafx modules

Please review the following build change to produce jmods for the standalone FX SDK: https://bugs.openjdk.java.net/browse/JDK-8202368 http://cr.openjdk.java.net/~kcr/8202368/webrev.00/ See the JBS issue for more details. My plan is to get this in on Monday so it can be part of next week&#

[11] Review request : JDK-8196827 : test.javafx.scene.control.ComboBoxTest - generates NullPointerException

Hi, Please review below fix. Bug : https://bugs.openjdk.java.net/browse/JDK-8196827 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8196827/webrev.0/ Regards, Ajit

[8u] Review request: 8201619: [TESTBUG] Bad HG merge causes some web tests to be skipped by mistake

Murali, Please review this simple test-only fix to correct a bad merge: https://bugs.openjdk.java.net/browse/JDK-8201619 http://cr.openjdk.java.net/~kcr/8201619/webrev/ This only affects 8u-dev, since the merge in questions was done when merging changes from 8u171 into 8u172. -- Kevin

[11] Review request: 8198329: Support FX build / test using JDK that doesn't include javafx.* modules

Please review this RFE to add support for creating a standalone FX SDK and supporting building / running apps and tests using OpenJDK (without FX modules) + the FX standalone SDK. https://bugs.openjdk.java.net/browse/JDK-8198329 http://cr.openjdk.java.net/~kcr/8198329/webrev.00/ Details are

Re: [11] Review request: 8202036: Update OpenJFX license files to match OpenJDK

+1 -phil. On 04/20/2018 11:14 AM, Kevin Rushforth wrote: Phil, Please review the following simple patch to update the OpenJFX license files to match the JDK project (including adding two missing files). https://bugs.openjdk.java.net/browse/JDK-8202036 http://cr.openjdk.java.net/~kcr

[11] Review request: 8202036: Update OpenJFX license files to match OpenJDK

Phil, Please review the following simple patch to update the OpenJFX license files to match the JDK project (including adding two missing files). https://bugs.openjdk.java.net/browse/JDK-8202036 http://cr.openjdk.java.net/~kcr/8202036/webrev/ Thanks. -- Kevin

[11] Review request for 8197987: Update libxslt to version 1.1.32

Hi Kevin, Please review the following fix for JDK-8197987 <https://bugs.openjdk.java.net/browse/JDK-8197987>, JavaFX specific file changes: http://cr.openjdk.java.net/~arajkumar/8197987/webrev/jfx_changes <http://cr.openjdk.java.net/~arajkumar/8197987/webrev/jfx_changes> Changes

[11] Review request for 8200418: webPage.executeCommand("removeFormat", null) removes the style of the body element

  Hi Kevin, Arun Please review the below simple fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8200418   webrev:  http://cr.openjdk.java.net/~mbilla/8200418/webrev.00/ Thanks, Murali

[8u-dev]Review Request : JDK-8198200 : Table auto resize ignores column resize policy

Hi Kevin, Ajit Request you to review this 8u-dev backport : Bug : https://bugs.openjdk.java.net/browse/JDK-8192800 Webrev : HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/fx/8192800/8u/webrev.01/"http://cr.openjdk.java.net/~pkbalakr/fx/8192800/8u/webrev.01/

Re: [11] Review request: 8199357: Remove references to applets and Java Web Start from FX

Removing Applets from Java, an easy programming model, to put web objects up on the internet. A Blunder of a decision. But, sure clean it up. On Apr 10, 2018, at 6:45 PM, Kevin Rushforth wrote: Phil & Ajit, Please review these changes: https://bugs.openjdk.java.net/browse/JDK-819

[8u-dev] Review Request : JDK-8189677 : RadioMenuItem fires extra NULL value in property

Hi Kevin, Request you to review this 8u-dev backport : Bug : https://bugs.openjdk.java.net/browse/JDK-8189677 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8189677/8u/webrev.0/ Regards, Ajit

[11] Review request: 8199357: Remove references to applets and Java Web Start from FX

Phil & Ajit, Please review these changes: https://bugs.openjdk.java.net/browse/JDK-8199357 http://cr.openjdk.java.net/~kcr/8199357/webrev.00/ Details are in JBS. -- Kevin

[11] Review request for 8200629: Update SQLite to version 3.23.0

Hi, Please review the following fix for JDK-8200629 <https://bugs.openjdk.java.net/browse/JDK-8200629>, cmake related changes: http://cr.openjdk.java.net/~arajkumar/8200629/webrev/cmake changeset (includes cmake & sqlite upstream changes): http://cr.openjdk.java.net/~arajkumar/8200

[11] Review request : JDK-8177380 : Add standard colors in ColorPicker color palette

Hi, Request you to review this simple RFE. RFE : https://bugs.openjdk.java.net/browse/JDK-8177380 Fix : http://cr.openjdk.java.net/~aghaisas/fx/e8177380/webrev.0/ Regards, Ajit

[11] Review request for 8201176: gradle :web:test should print a warning if COMPILE_WEBKIT is false

Hi Kevin, Please review the below simple fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8201176   webrev:  http://cr.openjdk.java.net/~mbilla/8201176/webrev.00/ Thanks, Murali

Review Request: JDK-8200587: Fix mistakes in FX API docs

Hi Kevin, After JDK-8200749 is committed, please review the fixes for documentation mistakes: https://bugs.openjdk.java.net/browse/JDK-8200587 http://cr.openjdk.java.net/~nlisker/8200587/webrev.00/ Thanks, Nir

[11] Review request : JDK-8185854 : [JavaFX 9] NPE on non-editable ComboBox in TabPane with custom Skin

Hi, Please review below fix. Bug : https://bugs.openjdk.java.net/browse/JDK-8185854 Fix : http://cr.openjdk.java.net/~aghaisas/fx/8185854/webrev.0/ Request you to review. Regards, Ajit

[11] Review Request: JDK 8152187 Make fitWidth of ImageView stylable as fit-width

Hi Kevin, Ajit Request you to review following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8152187 Webrev: http://cr.openjdk.java.net/~pkbalakr/fx/8152187/webrev.00/ Regards, Prem

Re: Review request: 8200300: better gradle error message

+1 Johan Vos wrote: Please review the webrev http://cr.openjdk.java.net/~jvos/8200300/webrev.00/ which fixes https://bugs.openjdk.java.net/browse/JDK-8200300

Review request: 8200300: better gradle error message

Please review the webrev http://cr.openjdk.java.net/~jvos/8200300/webrev.00/ which fixes https://bugs.openjdk.java.net/browse/JDK-8200300

Re: [11] Review request: 8199841: Add gradle wrapper files to build

Looks good. - Johan On Thu, Mar 29, 2018 at 6:40 PM Kevin Rushforth wrote: > Hi Johan, > > Please review the following to add gradle wrapper: > > https://bugs.openjdk.java.net/browse/JDK-8199841 > http://cr.openjdk.java.net/~kcr/8199841/webrev.00/ > > This is the aggre

[11] Review request: 8199841: Add gradle wrapper files to build

Hi Johan, Please review the following to add gradle wrapper: https://bugs.openjdk.java.net/browse/JDK-8199841 http://cr.openjdk.java.net/~kcr/8199841/webrev.00/ This is the aggregation of two changesets pushed to the github mirror: https://github.com/javafxports/openjdk-jfx/commit

Re: [11] Review request: 8200277: Compiling native media code fails when using OpenJDK build as boot JDK

Actually, that was a pointer to the merge changeset on GitHub. Here is the actual changeset in question (the contents are identical) https://github.com/javafxports/openjdk-jfx/commit/b7279fa9572472be803139898e3407fd860e2e75 -- Kevin Kevin Rushforth wrote: Please review the following: https

[11] Review request: 8200277: Compiling native media code fails when using OpenJDK build as boot JDK

Please review the following: https://bugs.openjdk.java.net/browse/JDK-8200277 https://github.com/javafxports/openjdk-jfx/commit/ccd5aa2ca090f0844778def02c1c1243c87fb7d4 This was merged into the GitHub sandbox 'develop' branch here: https://github.com/javafxports/openjdk-jfx/pull/47 -- Kevin

Re: [11] Review request : JDK-8195799 : Use System logger instead of platform logger in javafx modules

his, looks fine. Mandy On 3/26/18 4:36 AM, Ajit Ghaisas wrote: Thanks all for the review. I have addressed the review comments in -http://cr.openjdk.java.net/~aghaisas/fx/8195799/webrev.1/ The changes are - 1. Addressed the (c) year inaccuracies in files - modules/javafx.base/src/main/java

Re: [11] Review request : JDK-8195799 : Use System logger instead of platform logger in javafx modules

st stuff is using java.util.Logging could this not be ported to PlatformLogger? Tom On 26.03.18 22:46, Kevin Rushforth wrote: This looks fine to me now. -- Kevin Ajit Ghaisas wrote: Thanks all for the review. I have addressed the review comments in - http://cr.openjdk.java.net/~aghaisas

Re: [11] Review request : JDK-8195799 : Use System logger instead of platform logger in javafx modules

Minor question on this: I see the test stuff is using java.util.Logging could this not be ported to PlatformLogger? Tom On 26.03.18 22:46, Kevin Rushforth wrote: > This looks fine to me now. > > -- Kevin > > > Ajit Ghaisas wrote: >> Thanks all for the review. >>

RE: [11] Review request : JDK-8195799 : Use System logger instead of platform logger in javafx modules

Thanks for the review. As suggested, I have added Mandy’s point about loggers map to be addressed as part of JDK-8200236.   Regards, Ajit   From: Kevin Rushforth Sent: Tuesday, March 27, 2018 2:16 AM To: mandy chung Cc: Ajit Ghaisas; Daniel Fuchs; openjfx-dev@openjdk.java.net Subject: Re

Re: [11] Review request : JDK-8195799 : Use System logger instead of platform logger in javafx modules

This looks fine to me now. -- Kevin Ajit Ghaisas wrote: Thanks all for the review. I have addressed the review comments in - http://cr.openjdk.java.net/~aghaisas/fx/8195799/webrev.1/ The changes are - 1. Addressed the (c) year inaccuracies in files - modules/javafx.base/src/main/java/com

Re: [11] Review request : JDK-8195799 : Use System logger instead of platform logger in javafx modules

return new PlatformLogger(System.getLogger(name)); Other than this, looks fine. Mandy On 3/26/18 4:36 AM, Ajit Ghaisas wrote: Thanks all for the review. I have addressed the review comments in - http://cr.openjdk.java.net/~aghaisas/fx/8195799/webrev.1/ The changes are - 1. Addressed the (c) year inacc

Re: [11] Review request : JDK-8195799 : Use System logger instead of platform logger in javafx modules

You don't need the loggers map and getLogger method can simply return return new PlatformLogger(System.getLogger(name)); Other than this, looks fine. Mandy On 3/26/18 4:36 AM, Ajit Ghaisas wrote: Thanks all for the review. I have addressed the review comments in -

Re: [11] Review request : JDK-8195799 : Use System logger instead of platform logger in javafx modules

Hi Ajit, Looks good to me. I obviously didn't review the build changes. best regards, -- daniel On 26/03/2018 12:36, Ajit Ghaisas wrote: Thanks all for the review. I have addressed the review comments in -http://cr.openjdk.java.net/~aghaisas/fx/8195799/webrev.1/ The changes ar

RE: [11] Review request : JDK-8195799 : Use System logger instead of platform logger in javafx modules

Thanks all for the review. I have addressed the review comments in - http://cr.openjdk.java.net/~aghaisas/fx/8195799/webrev.1/ The changes are - 1. Addressed the (c) year inaccuracies in files - modules/javafx.base/src/main/java/com/sun/javafx/collections/SetListenerHelper.java modules

<    1   2   3   4   5   6   7   8   9   10   >