On Tue, 24 May 2022 21:35:15 GMT, Marius Hanl wrote:
> The `valueProperty()` and `chronologyProperty()` listener are now added in
> the second constructor of `DatePicker`
> (`public DatePicker(LocalDate localDate)`) instead of the first one (`public
> DatePicker()`).
> Therefore, both
On Tue, 24 May 2022 09:51:29 GMT, Jose Pereda wrote:
>> This PR fixes an issue with selection of multiple items in TableView and
>> TreeTableView controls that gets moved unexpectedly when new items are added
>> even way below the selected items.
>>
>> A couple of tests have been added. They
On Fri, 6 May 2022 10:16:41 GMT, Jose Pereda wrote:
> This PR extends the check if a treeItem is expanded to all its ancestors, as
> in case one ancestor is collapsed, all its children will be hidden.
>
> 4 tests are included, two for TreeView and two for TreeTableView.
This looks good to me.
On Thu, 19 May 2022 14:23:55 GMT, Robert Lichtenberger
wrote:
>> Separate test class added for TreeTableView case.
>> Fix is analogous to JDK-8251480.
>
> Robert Lichtenberger has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - 8285197:
On Thu, 5 May 2022 16:21:45 GMT, Jose Pereda wrote:
> This PR fixes an issue with selection of multiple items in TableView and
> TreeTableView controls that gets moved unexpectedly when new items are added
> even way below the selected items.
>
> A couple of tests have been added. They fail
On Thu, 21 Apr 2022 08:38:20 GMT, Robert Lichtenberger
wrote:
> Separate test class added for TreeTableView case.
> Fix is analogous to JDK-8251480.
The fix looks good.
The newly introduced test file needs some cosmetic cleanups.
On Thu, 21 Apr 2022 11:23:35 GMT, Ajit Ghaisas wrote:
> This PR is to cleanup a few `javafx.controls` unit tests that were ignored.
>
> Here is the list of targeted unit test classes-
> - Ignored tests re-enabled and fixed - `DateCellTest`, `CellTest`,
> `PaginationTest`
&g
On Thu, 21 Apr 2022 08:37:11 GMT, Jose Pereda wrote:
>> This PR fixes
>> JDK-[8193442](https://bugs.openjdk.java.net/browse/JDK-8193442), but also
>> [JDK-8187596](https://bugs.openjdk.java.net/browse/JDK-8187596), and
>> verifies that the tests mentioned in
>>
On Fri, 22 Apr 2022 06:27:49 GMT, Ambarish Rapte wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address review comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene
`PopupControlTest`
>
> Results of `javafx.controls` unit tests-
> **Before this PR :**
> Total tests - 8610
> Failures - 0
> Ignored - 246
>
> **After this PR :**
> Total tests - 8608
> Failures - 0
> Ignored - 235
Ajit Ghaisas has updated the pull request incre
This PR is to cleanup a few `javafx.controls` unit tests that were ignored.
Here is the list of targeted unit test classes-
- Ignored tests re-enabled and fixed - `DateCellTest`, `CellTest`,
`PaginationTest`
- Ignored tests removed - `RadioMenuItemTest`, `PopupControlTest`
Results of
On Thu, 10 Feb 2022 10:16:36 GMT, Jose Pereda wrote:
>> This PR converts the change's `from` field from a list of tablePositions
>> into a list of selected indices of rows.
>>
>> It includes two tests for TableView and one for TreeTableView (the second
>> test wasn't included due to an
>>
On Wed, 30 Mar 2022 12:22:23 GMT, Robert Lichtenberger
wrote:
>> This fix respects a row factory, if present.
>> It will put the cell that is used to measure the column width as child below
>> the row.
>> In that way the row's style will be used.
>
> Robert Lichtenberger has updated the pull
On Wed, 30 Mar 2022 10:57:48 GMT, Robert Lichtenberger
wrote:
>> findSibling adapted to only use visible menus when calculating the
>> index.
>
> Robert Lichtenberger has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8251480:
On Tue, 29 Mar 2022 12:11:54 GMT, Robert Lichtenberger
wrote:
> > Have you considered keeping the same while loop in findSibling() method and
> > skipping invisible Menus in it? This is to avoid creating and traversing a
> > new list.
>
> This would not give the correct result. findSibling
On Tue, 22 Mar 2022 14:42:07 GMT, Robert Lichtenberger
wrote:
> findSibling adapted to only use visible menus when calculating the
> index.
Have you considered keeping the same while loop in findSibling() method and
skipping invisible Menus in it?
This is to avoid creating and traversing a
On Wed, 9 Mar 2022 07:48:53 GMT, John Hendrikx wrote:
>> I added a test case for `SpinnerSkin` that checks the arrow positioning.
>>
>> While adding the tests I discovered more problems with the positioning aside
>> from the one mentioned in the JBS ticket.
>>
>> 1) Vertical split arrow
On Tue, 1 Mar 2022 06:12:59 GMT, Abhinay Agarwal wrote:
>> This regression was caused in PR #667 in which I didn't take into account
>> the lower bounds. I have added more tests and one manual test along with the
>> fix. The manual test can be used to identify any future issues with paths
>>
On Fri, 18 Feb 2022 15:21:49 GMT, Alexander Scherbatiy
wrote:
> There is the bouncing when scrolling a node on a ScrollPane to the
> right/bottom (the node on the scroll pane is scrolled further than its
> width/height so the background is visible and then automatically is scrolled
> back to
On Thu, 23 Dec 2021 17:43:19 GMT, Florian Kirmaier
wrote:
> Fixing memoryleak, related to touch events in ScrollPaneWhen touchDetected or
> mouseDown is true, the sbTouch animation is running,
> and the node is removed from the Scene, then the animation will never stop,
> causing a memory
On Mon, 21 Feb 2022 12:35:34 GMT, eduardsdv wrote:
>> If the InputMethod's node is not in the scene, the default text location
>> point is returned.
>
> eduardsdv has updated the pull request incrementally with one additional
> commit since the last revision:
>
>8281953: Format
On Thu, 17 Feb 2022 12:57:27 GMT, eduardsdv wrote:
> If the InputMethod's node is not in the scene, the default text location
> point is returned.
The fix looks good.
I thought about returning `null` if either the scene or the window is null. As
we need to fix this corner case, whether
On Mon, 7 Feb 2022 10:53:00 GMT, Ajit Ghaisas wrote:
> This is a Javadoc cleanup and correction fix for the TabPane as described in
> the JBS.
>
> Changes done for all the Properties of the TabPane -
> - Moved the property description to be over the property field.
> - Remov
On Wed, 9 Feb 2022 14:04:55 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/TreeView.java
>> line 341:
>>
>>> 339: setFocusModel(new TreeViewFocusModel(this));
>>> 340:
>>> 341: setOnEditCommit(DEFAULT_EDIT_COMMIT_HANDLER);
>>
>>
On Wed, 2 Feb 2022 14:18:18 GMT, Jeanette Winzenburg
wrote:
> Issue was TreeView commit editing implementation violated the spec'ed
> mechanism:
>
> - no default commit handler on TreeView
> - TreeCell modifying the data directly
>
> Fix is to move the saving of the edited value from cell
On Wed, 9 Feb 2022 13:34:13 GMT, Nir Lisker wrote:
>> Good suggestion.
>>
>> Also optional, you can remove the `` since they are not needed for the
>> initial paragraph.
>
> There are many redundant `` tags in the property docs too if you want to
> deal with them as well for consistency (not
nd Property method.
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
Address additional review comments
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/728/files
- new: https://git.openjdk.java.net/jfx/pull/
On Wed, 2 Feb 2022 14:18:18 GMT, Jeanette Winzenburg
wrote:
> Issue was TreeView commit editing implementation violated the spec'ed
> mechanism:
>
> - no default commit handler on TreeView
> - TreeCell modifying the data directly
>
> Fix is to move the saving of the edited value from cell
nd Property method.
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
Address review comments
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/728/files
- new: https://git.openjdk.java.net/jfx/pull/728/files/31ae34d7.
On Mon, 7 Feb 2022 16:17:32 GMT, Nir Lisker wrote:
>> This is a Javadoc cleanup and correction fix for the TabPane as described in
>> the JBS.
>>
>> Changes done for all the Properties of the TabPane -
>> - Moved the property description to be over the property field.
>> - Removed the
On Mon, 7 Feb 2022 16:24:46 GMT, Kevin Rushforth wrote:
>> This is a Javadoc cleanup and correction fix for the TabPane as described in
>> the JBS.
>>
>> Changes done for all the Properties of the TabPane -
>> - Moved the property description to be over the property field.
>> - Removed the
On Mon, 7 Feb 2022 18:46:55 GMT, Jose Pereda wrote:
>> This PR adds a predicate to TableView and TreeTableView selection models
>> order to remove rows from the selection only when there are no selected
>> cells in that given row, when cell selection is enabled.
>>
>> Two tests have been
This is a Javadoc cleanup and correction fix for the TabPane as described in
the JBS.
Changes done for all the Properties of the TabPane -
- Moved the property description to be over the property field.
- Removed the unnecessary docs on property setter/getter and Property method.
-
On Wed, 2 Feb 2022 15:29:51 GMT, Ambarish Rapte wrote:
>> Update JavaFX WebKit to GTK WebKit 2.34 (613.1).
>>
>> Verified the updated version build, tests run and sanity testing.
>> This does not cause any issues except a unit test failure
>> `IrresponsiveScriptTest`.
>> It is recorded and
On Fri, 7 Jan 2022 19:36:45 GMT, Jose Pereda wrote:
> This PR adds a predicate to TableView and TreeTableView selection models
> order to remove rows from the selection only when there are no selected cells
> in that given row, when cell selection is enabled.
>
> Two tests have been added as
On Thu, 27 Jan 2022 20:48:40 GMT, Marius Hanl wrote:
>> When a divider is moved via drag or code it will call **requestLayout()**
>> for the **SplitPane**.
>> While this is fine, it is also called when the
>> **SplitPaneSkin#layoutChildren(..)** method is repositioning the divider.
>>
>> This
On Wed, 19 Jan 2022 15:18:48 GMT, Kevin Rushforth wrote:
> Fixed a test dependency issue in `build.gradle` that causes a compilation
> failure when running `gradle test` if the `Assumptions` API from JUnit5 is
> used. I added a test that fails to compile without the build fix and passes
>
On Tue, 30 Nov 2021 12:32:37 GMT, Jeanette Winzenburg
wrote:
> The misbehaviour was that an edit handler received both a commit and cancel
> event when cell commitEdit is called. That happened whenever a collaborator
> reset the controls editing state (either directly or indirectly) while
>
On Mon, 17 Jan 2022 15:32:13 GMT, eduardsdv wrote:
>> The NPE occurs when the skinnable is removed from the scene while the popup
>> is showing.
>> The MenuButtonSkinBase, when popup becomes hidden, tries to remove Mnemonics
>> from the scene and runs into NPE.
>> To avoid NPE a null-check is
On Tue, 11 Jan 2022 14:42:19 GMT, eduardsdv wrote:
> The NPE occurs when the skinnable is removed from the scene while the popup
> is showing.
> The MenuButtonSkinBase, when popup becomes hidden, tries to remove Mnemonics
> from the scene and runs into NPE.
> To avoid NPE a null-check is added
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote:
> Update the API specification for the `Window` and `Stage` classes to clarify
> that the values for some properties and methods can be changed or ignored by
> the platform. Several of the properties already have a comment to the effect
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote:
> Update the API specification for the `Window` and `Stage` classes to clarify
> that the values for some properties and methods can be changed or ignored by
> the platform. Several of the properties already have a comment to the effect
On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote:
> Update the API specification for the `Window` and `Stage` classes to clarify
> that the values for some properties and methods can be changed or ignored by
> the platform. Several of the properties already have a comment to the effect
On Fri, 7 Jan 2022 08:04:53 GMT, Abhinay Agarwal wrote:
>> This work improves the performance of `MultipleSelectionModel` over large
>> data sets by caching some values and avoiding unnecessary calls to
>> `SelectedIndicesList#size`. It further improves the performance by reducing
>> the
On Wed, 29 Dec 2021 15:39:39 GMT, Michael Strauß wrote:
> `CssParser.parse(URL)` is specified to assume UTF-8 file encoding, but
> (implicitly) uses the default charset to read the file, potentially resulting
> in incorrect interpretation of the file content.
>
> This can be fixed by
On Wed, 29 Dec 2021 15:39:39 GMT, Michael Strauß wrote:
> `CssParser.parse(URL)` is specified to assume UTF-8 file encoding, but
> (implicitly) uses the default charset to read the file, potentially resulting
> in incorrect interpretation of the file content.
>
> This can be fixed by
On Thu, 16 Dec 2021 12:54:27 GMT, Jeanette Winzenburg
wrote:
>> Extracted static test utility methods from EditAndScrollTest into new
>> VirtualizedControlTestUtils, added rudimentary tests for the methods.
>
> Jeanette Winzenburg has updated the pull request incrementally with one
>
On Wed, 15 Dec 2021 22:57:26 GMT, Kevin Rushforth wrote:
>> Build change to strip the non-global symbols from native shared libraries on
>> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative`
>> build.
>>
>> Here is a before / after size comparison. All sizes in KBytes:
On Thu, 9 Dec 2021 12:43:54 GMT, Jeanette Winzenburg
wrote:
> Extracted static test utility methods from EditAndScrollTest into new
> VirtualizedControlTestUtils, added rudimentary tests for the methods.
This looks good except for a typo which is not introduced by you!
On Fri, 10 Dec 2021 15:24:44 GMT, eduardsdv wrote:
>> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
>> element but to the bottom of the last element.
>
> eduardsdv has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 6 Dec 2021 14:58:52 GMT, eduardsdv wrote:
>> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
>> element but to the bottom of the last element.
>
> eduardsdv has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Tue, 31 Aug 2021 16:28:53 GMT, Kevin Rushforth wrote:
> This PR removes the obsolete applet implementation from JavaFX. It is an
> ongoing maintenance burden to carry around this legacy code. Also, cleaning
> this up could help in the implementation of GTK4, Wayland, and Metal, since
> we
On Thu, 2 Dec 2021 22:49:45 GMT, Michael Strauß wrote:
>> This PR fixes an issue where the scroll delta of ScrollPane incorrectly
>> depends on the size of its content.
>> This leads to extremely slow scrolling when the content is only slightly
>> larger than the ScrollPane.
>
> Michael Strauß
On Fri, 3 Dec 2021 11:16:28 GMT, Johan Vos wrote:
> The hard values have been changed a number of times, and I believe it is not
> really a good metric.
I agree completely.
> Rather than requiring that the amount of calls should be a fixed number, I
> think it makes more sense to ensure that
On Tue, 30 Nov 2021 11:02:41 GMT, Johan Vos wrote:
>> After (re)setting the number of elements, make sure to do at least some
>> estimation of the total size.
>> Added a testcase for this scenario.
>
> Johan Vos has updated the pull request incrementally with one additional
> commit since the
On Thu, 25 Nov 2021 00:29:36 GMT, Kevin Rushforth wrote:
>> As indicated in the bug report, WebView needs to call to
>> `CookieManager::getDefault` within a `doPrivileged` block so that it will
>> work when a security manager is enabled. There are two calls in
>>
On Thu, 25 Nov 2021 15:46:01 GMT, Jeanette Winzenburg
wrote:
> Issue was that mouse pressed on the scrollbars of all virtualized controls
> cancelled the edit. That's inconsistent with other scroll triggers
> (mouseWheel, programmatic). Fixed by removing the cancel.
>
> Added tests that
On Tue, 2 Nov 2021 10:49:45 GMT, Michael Strauß wrote:
> This PR fixes an issue where the scroll delta of ScrollPane incorrectly
> depends on the size of its content.
> This leads to extremely slow scrolling when the content is only slightly
> larger than the ScrollPane.
On Mon, 22 Nov 2021 14:04:01 GMT, Abhinay Agarwal wrote:
>> PathElements were skipped in AreaChart if the data point were outside axis
>> bounds and had duplicate value for either x or y. This is now fixed with
>> this PR.
>
> Abhinay Agarwal has updated the pull request incrementally with one
On Mon, 15 Nov 2021 18:26:00 GMT, Kevin Rushforth wrote:
> Now that JavaFX has updated to gradle 7.3 -- see
> [JDK-8276142](https://bugs.openjdk.java.net/browse/JDK-8276142) / PR #671 --
> we can update the boot JDK used to build JavaFX to JDK 17.0.1.
>
> I have run a smoke test on all three
On Fri, 19 Nov 2021 11:42:16 GMT, Jeanette Winzenburg
wrote:
>> Cleanup of Tree-/TableRowSkin to support switching skins
>>
>> The misbehavior/s
>> - memory leaks due to manually registered listeners that were not removed
>> - side-effects due to listeners still active on old skin (like NPEs)
On Mon, 15 Nov 2021 13:28:40 GMT, Jeanette Winzenburg
wrote:
>> My PR is already merged, so this is not a problem. :)
>> I dont know, but since this is only fixing a (also before) wrong comment it
>> might be okay as it is very minor? :)
>
> FYI: now the listener registration - including the
On Mon, 15 Nov 2021 13:11:06 GMT, Jeanette Winzenburg
wrote:
>> Cleanup of Tree-/TableRowSkin to support switching skins
>>
>> The misbehavior/s
>> - memory leaks due to manually registered listeners that were not removed
>> - side-effects due to listeners still active on old skin (like NPEs)
On Fri, 12 Nov 2021 09:44:47 GMT, Abhinay Agarwal wrote:
> PathElements were skipped in AreaChart if the data point were outside axis
> bounds and had duplicate value for either x or y. This is now fixed with this
> PR.
On Sat, 30 Oct 2021 20:40:12 GMT, Michael Strauß wrote:
>> This PR fixes an issue with mnemonic parsing by removing the restriction
>> that a mnemonic symbol must be a letter. Now, it can be any character except
>> whitespace.
>
> Michael Strauß has updated the pull request incrementally with
On Fri, 29 Oct 2021 07:31:05 GMT, Ajit Ghaisas wrote:
> This PR deprecates mistakenly exposed field from class javafx.scene.shape.Box.
This pull request has now been integrated.
Changeset: d9e1ad97
Author: Ajit Ghaisas
URL:
https://git.openjdk.java.net/jfx/com
On Fri, 29 Oct 2021 13:58:35 GMT, Michael Strauß wrote:
>> This PR fixes an issue with mnemonic parsing by removing the restriction
>> that a mnemonic symbol must be a letter. Now, it can be any character except
>> whitespace.
>
> Michael Strauß has updated the pull request incrementally with
On Fri, 29 Oct 2021 12:34:50 GMT, Michael Strauß wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/TextBinding.java
>> line 238:
>>
>>> 236: }
>>> 237:
>>> 238: return !isExtendedMnemonic(s, position);
>>
>> I am not sure why do we need to
> This PR deprecates mistakenly exposed field from class javafx.scene.shape.Box.
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
review fix
-
Changes:
- all: https://git.openjdk.java.net/jfx/pull/655/files
-
On Wed, 20 Oct 2021 16:54:35 GMT, Michael Strauß wrote:
> This PR fixes an issue with mnemonic parsing by removing the restriction that
> a mnemonic symbol must be a letter. Now, it can be any character except
> whitespace.
On Fri, 22 Oct 2021 10:36:24 GMT, Jeanette Winzenburg
wrote:
>> cell startEdit is supposed to update the editing location on its associated
>> control - was done in ListCell, not in Tree-/TableCell nor TreeCell.
>>
>> Fix was to add control.edit(..). Note that ListCell was also touched to use
This PR deprecates mistakenly exposed field from class javafx.scene.shape.Box.
-
Commit messages:
- Deprecate DEFAULT_SIZE constant field
Changes: https://git.openjdk.java.net/jfx/pull/655/files
Webrev: https://webrevs.openjdk.java.net/?repo=jfx=655=00
Issue:
On Wed, 20 Oct 2021 14:42:44 GMT, Ajit Ghaisas wrote:
> This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
> Note :
> - The javadoc needs to be generated with the JDK 18 EA build.
> - 2 javadoc warnings in javafx.controls TabPane class will be fixed und
On Fri, 22 Oct 2021 11:23:07 GMT, Ajit Ghaisas wrote:
> This PR fixes javadoc warnings primarily in javafx.graphics module along with
> a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>
> Note :
> - The javadoc needs to be generated with the
wse/JDK-8271085)
> - There are still 20 javadoc warnings remaining in javafx.controls module and
> 3 warnings remaining in javafx.web module. The root cause is different and
> they will be addressed under
> [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996)
Ajit Ghaisas h
On Wed, 27 Oct 2021 16:12:11 GMT, Nir Lisker wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control
modules. The root cause is
> different and they will be addressed under
> [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996)
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
fix review comments
-
On Wed, 27 Oct 2021 16:06:38 GMT, Nir Lisker wrote:
> Added a few more comments, otherwise looks fine.
Thanks for your detailed review.
> modules/javafx.graphics/src/main/java/javafx/stage/PopupWindow.java line 156:
>
>> 154:
>> 155: /**
>> 156: * Creates a {@code PopupWindow}.
>
>
On Wed, 20 Oct 2021 15:45:52 GMT, Nir Lisker wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix review comments
>
> Took a quick look at the new docs. I didn't check the resu
On Tue, 26 Oct 2021 09:54:43 GMT, Ajit Ghaisas wrote:
>> This PR fixes javadoc warnings primarily in javafx.graphics module along
>> with a remaining few in javafx.fxml, javafx.base and javafx.media modules.
>>
>> Note :
>> - The javadoc needs to be gene
On Wed, 27 Oct 2021 09:56:46 GMT, Jeanette Winzenburg
wrote:
>> Cleanup of Tree-/TableRowSkin to support switching skins
>>
>> The misbehavior/s
>> - memory leaks due to manually registered listeners that were not removed
>> - side-effects due to listeners still active on old skin (like NPEs)
On Wed, 27 Oct 2021 09:50:32 GMT, Jeanette Winzenburg
wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkin.java
>> line 134:
>>
>>> 132: // that when it changes, we can appropriately add /
>>> remove cells that may or may not
>>> 133:
On Fri, 24 Sep 2021 16:01:38 GMT, Jeanette Winzenburg
wrote:
> Cleanup of Tree-/TableRowSkin to support switching skins
>
> The misbehavior/s
> - memory leaks due to manually registered listeners that were not removed
> - side-effects due to listeners still active on old skin (like NPEs)
>
>
On Mon, 25 Oct 2021 23:27:19 GMT, Kevin Rushforth wrote:
> Looks good with a couple suggestions on `setScene`. We might want to also
> file a follow-up javadoc bug so we can get rid of the javadocs for that
> method altogether.
I have filed -
modules. The root cause is
> different and they will be addressed under
> [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996)
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
fix review comments
-
wse/JDK-8271085)
> - There are still 20 javadoc warnings remaining in javafx.controls module and
> 3 warnings remaining in javafx.web module. The root cause is different and
> they will be addressed under
> [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996)
Ajit Ghaisas h
On Mon, 25 Oct 2021 22:53:53 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control
wse/JDK-8271085)
> - There are still 20 javadoc warnings remaining in javafx.controls module and
> 3 warnings remaining in javafx.web module. The root cause is different and
> they will be addressed under
> [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996)
Ajit Ghaisas h
On Fri, 22 Oct 2021 13:37:38 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> javadoc minor corrections
>
> modules/javafx.controls/src/main/java/javafx/scene/c
On Fri, 22 Oct 2021 15:00:58 GMT, Kevin Rushforth wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8271090 - fix review comments
>
> modules/javafx.graphics/src/main/java/jav
On Fri, 22 Oct 2021 15:30:36 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/shape/Box.java line 91:
>>
>>> 89: * Default size of the {@code Box}.
>>> 90: */
>>> 91: public static final double DEFAULT_SIZE = 2;
>>
>> This field was exposed by
On Fri, 22 Oct 2021 14:37:14 GMT, Nir Lisker wrote:
>> Ajit Ghaisas has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8271090 - fix review comments
>
> modules/javafx.media/src/main/java/javafx/scene/medi
modules. The root cause is
> different and they will be addressed under
> [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996)
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
8271090 - fix review comments
---
On Sat, 2 Oct 2021 23:53:02 GMT, Marius Hanl wrote:
> This PR fixes a visual glitch which may happen when showing a dialog.
> When a max height is set and the pref height of the dialog content is bigger
> the dialog starts to flicker between the max height and the pref height.
>
> This happens
This PR fixes javadoc warnings primarily in javafx.graphics module along with a
remaining few in javafx.fxml, javafx.base and javafx.media modules.
Note :
- The javadoc needs to be generated with the JDK 18 EA build.
- There are still few remaining warnings in these modules. The root cause is
The root cause is different and
> they will be addressed under
> [JDK-8270996](https://bugs.openjdk.java.net/browse/JDK-8270996)
Ajit Ghaisas has updated the pull request incrementally with one additional
commit since the last revision:
javadoc minor corrections
-
Ch
This PR fixes javadoc warnings in javafx.controls and javafx.web modules.
Note :
- The javadoc needs to be generated with the JDK 18 EA build.
- There are still 20 javadoc warnings remaining in javafx.controls module and 3
warnings remaining in javafx.web module. The root cause is different and
On Thu, 14 Oct 2021 12:32:24 GMT, Kevin Rushforth wrote:
> The failure was caused by a change that was done in connection with the
> WebKit 610.2 update,
> [JDK-8259635](https://bugs.openjdk.java.net/browse/JDK-8259635). The
> `FrameLoaderClient::userAgent` function was changed in WebKit
On Wed, 6 Oct 2021 12:22:54 GMT, Robert Lichtenberger
wrote:
> Ist there anything left for me to do? IIRC someone must now /sponsor this
> change and then I can /integrate it, right?
This PR needs two review approvals; currently it has one.
We shall wait for @kevinrushforth to review and
On Mon, 27 Sep 2021 05:27:25 GMT, Robert Lichtenberger
wrote:
>> This PR fixes JDK-8274137 by removing the optimization from updateHbar()
>> that will no-op the method in case the VirtualFlow is invisible or currently
>> has no scene.
>> Since changes to the hBar's value can happen even if
1 - 100 of 449 matches
Mail list logo
