Re: Proposal: Bump minimum JDK version for JavaFX 20 to JDK 17

2022-07-20 Thread Thomas Reinhardt
Hi, I would assume that all projects with many dependencies are upgrading their JDK slowly. Because you obviously need all your dependencies to support the new JDK. Which means that the JDK is necessarily the last thing to update. With our project we have hundreds of dependencies, some

RFR: 8290765: Remove parent disabled/treeVisible listeners

2022-07-20 Thread Michael Strauß
`Node` adds InvalidationListeners to its parent's `disabled` and `treeVisible` properties and calls its own `updateDisabled()` and `updateTreeVisible(boolean)` methods when the property values change. These listeners are not required, since `Node` can easily call the `updateDisabled()` and

Re: RFR: 8271395: Fixing crash at printing [v2]

2022-07-20 Thread Kevin Rushforth
On Wed, 8 Sep 2021 07:52:31 GMT, Florian Kirmaier wrote: >> This PR switches the Thread to the QuantumRenderer, in the case the Disposer >> is called from another Thread - the printing Thread. >> I'm open for better solutions on how to fix this Issue. >> Initially i thought there is also a Race

Re: RFR: 8271395: Fixing crash at printing [v2]

2022-07-20 Thread Kevin Rushforth
On Wed, 20 Jul 2022 19:33:43 GMT, Phil Race wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8271395 >> QuantumRenderer is no longer public > >

Proposal: Add Skin.install() method

2022-07-20 Thread Andy Goryachev
Hi, I'd like to propose an API change in Skin interface (details below). Your feedback will be greatly appreciated! Thank you, -andy Summary --- Introduce a new Skin.install() method with an empty default implementation. Modify Control.setSkin(Skin) implementation to invoke

Re: RFR: 8271395: Fixing crash at printing [v2]

2022-07-20 Thread Phil Race
On Wed, 8 Sep 2021 07:52:31 GMT, Florian Kirmaier wrote: >> This PR switches the Thread to the QuantumRenderer, in the case the Disposer >> is called from another Thread - the printing Thread. >> I'm open for better solutions on how to fix this Issue. >> Initially i thought there is also a Race

Re: RFR: 8271395: Fixing crash at printing [v2]

2022-07-20 Thread Phil Race
On Wed, 8 Sep 2021 07:52:31 GMT, Florian Kirmaier wrote: >> This PR switches the Thread to the QuantumRenderer, in the case the Disposer >> is called from another Thread - the printing Thread. >> I'm open for better solutions on how to fix this Issue. >> Initially i thought there is also a Race

Re: Proposal: Bump minimum JDK version for JavaFX 20 to JDK 17

2022-07-20 Thread Matthias Bläsing
Hi, Am Mittwoch, dem 20.07.2022 um 15:40 +0300 schrieb Nir Lisker: > The idea that an LTS JDK version is a good jumping point relies on > the assumption that users upgrade their JDK slowly (once every 2-3 > years), but their JavaFX fast (once every 6 months). That is, they > want LTS for their

Re: [jfx19] RFR: 8290348: TreeTableView jumping to top [v2]

2022-07-20 Thread Kevin Rushforth
On Sun, 17 Jul 2022 18:59:22 GMT, Johan Vos wrote: >> Do not recalculate total estimated size recursively. >> >> In the (unlikely) event that the recalculation triggers a new recalculation >> (e.g. when the height of a Cell is changed), do not start this recalculation. >> The cache and cache

Re: [jfx19] RFR: 8290348: TreeTableView jumping to top [v3]

2022-07-20 Thread Kevin Rushforth
On Tue, 19 Jul 2022 10:36:07 GMT, Johan Vos wrote: >> Do not recalculate total estimated size recursively. >> >> In the (unlikely) event that the recalculation triggers a new recalculation >> (e.g. when the height of a Cell is changed), do not start this recalculation. >> The cache and cache

Re: Proposal: Bump minimum JDK version for JavaFX 20 to JDK 17

2022-07-20 Thread Nir Lisker
In my opinion, each JDK version should be evaluated according to its benefits to JavaFX and not according to LTS, which is a foreign concept to OpenJDK. The JDK moved to a 6 months release plan so it can innovate faster without waiting several years to release an important feature, and if we go

Re: [jfx19] RFR: 8290348: TreeTableView jumping to top [v3]

2022-07-20 Thread Ajit Ghaisas
On Tue, 19 Jul 2022 10:36:07 GMT, Johan Vos wrote: >> Do not recalculate total estimated size recursively. >> >> In the (unlikely) event that the recalculation triggers a new recalculation >> (e.g. when the height of a Cell is changed), do not start this recalculation. >> The cache and cache

Re: Proposal: Bump minimum JDK version for JavaFX 20 to JDK 17

2022-07-20 Thread Johan Vos
Dealing with the second question (when do we bump the version post-JFX20), On Tue, Jul 19, 2022 at 10:39 PM Philip Race wrote: ... > What to do in future (ie what is the policy) is a separate question > > OpenJDK LTS releases will be every two years in future, so there is a > reasonable