On Fri, 12 Aug 2022 17:21:24 GMT, Andy Goryachev wrote:
>> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect
>> statement "Is functionally equivalent to calling
>> getSelectedIndices().contains(index)."
>> 2. reimplement TableView.TableViewSelectionModel.isSelected(int) meth
On Wed, 17 Aug 2022 22:35:37 GMT, Andy Goryachev wrote:
>> If there are folders that aren't generated by the build task, we should note
>> it in the build page of the wiki.
>
> not sure what you are referring to - getLucene task does not create any
> folders. no wiki changes are needed.
It cr
On Wed, 17 Aug 2022 22:22:02 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs i
On Wed, 17 Aug 2022 22:22:02 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs i
On Fri, 12 Aug 2022 17:21:24 GMT, Andy Goryachev wrote:
>> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect
>> statement "Is functionally equivalent to calling
>> getSelectedIndices().contains(index)."
>> 2. reimplement TableView.TableViewSelectionModel.isSelected(int) meth
On Wed, 17 Aug 2022 22:31:05 GMT, Nir Lisker wrote:
>>> For lucene, you'd need to run
>>>
>>> ```
>>> /bin/sh gradlew getLucene
>>> ```
>>>
>>> to bring in the dependencies which are not a part of the repository.
>>
>> Btw, `gradle apps` will also work.
>
> If there are folders that aren't ge
On Wed, 17 Aug 2022 22:22:02 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs i
On Wed, 17 Aug 2022 22:17:30 GMT, Kevin Rushforth wrote:
>> For lucene, you'd need to run
>
>> For lucene, you'd need to run
>>
>> ```
>> /bin/sh gradlew getLucene
>> ```
>>
>> to bring in the dependencies which are not a part of the repository.
>
> Btw, `gradle apps` will also work.
If ther
On Wed, 17 Aug 2022 22:05:24 GMT, Andy Goryachev wrote:
>> apps/samples/.classpath line 21:
>>
>>> 19: >> path="Ensemble8/lib/lucene-core-7.7.3.jar"/>
>>> 20: >> path="Ensemble8/lib/lucene-grouping-7.7.3.jar"/>
>>> 21: >> path="Ensemble8/lib/lucene-queryparser-7.7.3.jar"/
> The goal of this change is to make sure jfx repo can be imported as a gradle
> project in eclipse and all nested projects in the workspace compile with no
> errors.
>
> - updated .classpath entries in apps/
> - added utf-8 prefs in .settings/
Andy Goryachev has updated the pull request increm
On Wed, 17 Aug 2022 20:26:12 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 13 additional
>> commits s
On Wed, 17 Aug 2022 20:30:10 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 13 additional
>> commits s
On Tue, 9 Aug 2022 21:43:04 GMT, Andy Goryachev wrote:
> Thank you all! If there are no more objections, I'd like to get this
> integrated, as it will save me from duplicate branches and continuous
> cherry-picking.
You don't need to do that. Unless 2 branches work on the same code, there will
On Tue, 16 Aug 2022 15:58:38 GMT, Andy Goryachev wrote:
>> The goal of this change is to make sure jfx repo can be imported as a gradle
>> project in eclipse and all nested projects in the workspace compile with no
>> errors.
>>
>> - updated .classpath entries in apps/
>> - added utf-8 prefs i
On Wed, 17 Aug 2022 12:02:04 GMT, Ambarish Rapte wrote:
> Update libjpeg to current version release [9e](http://www.ijg.org/) of
> 16-Jan-2022
>
> reference: https://jpegclub.org/reference/reference-sources/
>
> Verified all test run on Windows and MacOS
Looks good. I tested on all three plat
The issue is caused by TreeTableRow incorrectly selected when cell selection
mode is enabled.
Changes:
- modified TreeTableRow.updateSelection()
-
Commit messages:
- 8292353: update selection
Changes: https://git.openjdk.org/jfx/pull/875/files
Webrev: https://webrevs.openjdk.org/
On Wed, 17 Aug 2022 16:36:24 GMT, Ambarish Rapte wrote:
>> Accessibility is not implemented for JavaFX dialogs. This change is to
>> implement the accessibility on windows platform.
>> Without this fix : On Windows platform, content of Dialog are not read by
>> Windows Narrator or JAWS.
>> With
On Sun, 27 Feb 2022 11:42:58 GMT, Paul wrote:
> I hit on JDK-8181084 while making some changes to Scene Builder, so I decided
> to investigate.
>
> Please note: I have not done any Objective-C or MacOS development before. So
> I would really like some feedback from someone else who knows this
On Mon, 15 Aug 2022 10:03:11 GMT, Nir Lisker wrote:
>> Command to run the system test:
>> `gradle -PFULL_TEST=true -PUSE_ROBOT=true systemTests:test --tests
>> test.robot.test3d.PointLightIlluminationTest`
>>
>> I ran all the tests, only above test failed:
>> Command to run all the system tests
On Wed, 17 Aug 2022 13:45:10 GMT, Kevin Rushforth wrote:
> I get the following exception on macOS with VoiceOver when opening any dialog:
It is fixed in next
[commit](https://github.com/openjdk/jfx/pull/873/commits/39d1896751fe6709469ff79380ad15e7493f4879)
It was caused when VoiceOver reques
> Accessibility is not implemented for JavaFX dialogs. This change is to
> implement the accessibility on windows platform.
> Without this fix : On Windows platform, content of Dialog are not read by
> Windows Narrator or JAWS.
> With this fix:
> 1. Windows narrator reads the dialog correctly
> 2
On Wed, 17 Aug 2022 13:33:47 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comment : mac NPE
>
> modules/javafx.graphics/src/main/java/javafx/scene/AccessibleRole.java line
> 832:
>
> Accessibility is not implemented for JavaFX dialogs. This change is to
> implement the accessibility on windows platform.
> Without this fix : On Windows platform, content of Dialog are not read by
> Windows Narrator or JAWS.
> With this fix:
> 1. Windows narrator reads the dialog correctly
> 2
On Wed, 10 Aug 2022 10:06:21 GMT, Jay Bhaskar wrote:
> Issue: xml not well-formed error occurs at XML document parser.
> Issue: doEnd() call not needed for JAVA platform, as it is making
> XMLDocumentParserLibxml2 xml not well-formed error.
Additional testing reveals a test failure on macOS tha
On Mon, 15 Aug 2022 10:29:17 GMT, Jeanette Winzenburg
wrote:
>> unnecessary in the case of TableRow.
>> the change in TreeTableRow was necessary because otherwise selecting a cell
>> by mouse selected the whole row.
>
>> unnecessary in the case of TableRow.
>
> that is .. why exactly?
>
>> t
On Wed, 17 Aug 2022 14:35:27 GMT, Ambarish Rapte wrote:
> This is almost a clean backport, except a small conflict in a test file
> `LoadTest.java`.
>
> The conflict was because
> [fix](https://github.com/openjdk/jfx/commit/15e52d8f) for
> [JDK-8253696](https://bugs.openjdk.org/browse/JDK-82
On Wed, 17 Aug 2022 14:35:27 GMT, Ambarish Rapte wrote:
> This is almost a clean backport, except a small conflict in a test file
> `LoadTest.java`.
>
> The conflict was because
> [fix](https://github.com/openjdk/jfx/commit/15e52d8f) for
> [JDK-8253696](https://bugs.openjdk.org/browse/JDK-82
This is almost a clean backport, except a small conflict in a test file
`LoadTest.java`.
The conflict was because [fix](https://github.com/openjdk/jfx/commit/15e52d8f)
for [JDK-8253696](https://bugs.openjdk.org/browse/JDK-8253696) is not
backported to jfx11u.
A test `testLoadLocalCSS()` was ad
On Wed, 17 Aug 2022 14:35:27 GMT, Ambarish Rapte wrote:
> This is almost a clean backport, except a small conflict in a test file
> `LoadTest.java`.
>
> The conflict was because
> [fix](https://github.com/openjdk/jfx/commit/15e52d8f) for
> [JDK-8253696](https://bugs.openjdk.org/browse/JDK-82
On Wed, 17 Aug 2022 06:35:38 GMT, Ajit Ghaisas wrote:
>>> hmm .. in TreeTableViewSelectionModelImplTest, I don't see any of the
>>> testRowSelectionAfterSelectAndHideLastColumnXX nor
>>> testSelectRowWhenInSingleCellSelectionModeIsSelected, what am I missing?
>>
>> you are right... I am so sor
This bumps the boot JDK used to build jfx17u to JDK 17.0.4. The minimum JDK
that can run JavaFX 17.0.x is unchanged and remains at JDK 11.
-
Commit messages:
- 8291051: Update boot JDK to 17.0.4
Changes: https://git.openjdk.org/jfx17u/pull/78/files
Webrev: https://webrevs.openjdk.
On Wed, 17 Aug 2022 14:28:16 GMT, Kevin Rushforth wrote:
> This bumps the boot JDK used to build jfx17u to JDK 17.0.4. The minimum JDK
> that can run JavaFX 17.0.x is unchanged and remains at JDK 11.
Reviewer: @arapte
-
PR: https://git.openjdk.org/jfx17u/pull/78
On Wed, 17 Aug 2022 13:36:52 GMT, Ambarish Rapte wrote:
> Clean backport to jfx11u
This pull request has now been integrated.
Changeset: 190dddfb
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx11u/commit/190dddfbac436be26ad9e1f99eeeb7b9ae7990a6
Stats: 15 lines in 2 files
On Wed, 17 Aug 2022 13:35:47 GMT, Ambarish Rapte wrote:
> Clean backport to jfx11u.
This pull request has now been integrated.
Changeset: 19268eb0
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx11u/commit/19268eb01c0686b143bbb8bfc34c05a09c13931b
Stats: 5 lines in 2 files
On Wed, 17 Aug 2022 13:34:42 GMT, Ambarish Rapte wrote:
> Clean backport to jfx11u.
This pull request has now been integrated.
Changeset: d3e8fe12
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx11u/commit/d3e8fe126591d7df04601ff3661eaf6d8151de13
Stats: 180 lines in 3 file
On Wed, 17 Aug 2022 13:33:12 GMT, Ambarish Rapte wrote:
> Clean backport to jfx11u.
This pull request has now been integrated.
Changeset: 24e053bb
Author:Ambarish Rapte
URL:
https://git.openjdk.org/jfx11u/commit/24e053bb62faf2a99c16f528e9030c416418edc2
Stats: 1509 lines in 11 fi
On Wed, 17 Aug 2022 13:30:54 GMT, Ambarish Rapte wrote:
> Not a clean backport.
> Following two files are not present in jfx11.
>
> 1. .github/workflows/submit.yml
> 2. gradle/verification-metadata.xml
This pull request has now been integrated.
Changeset: dd358152
Author:Ambarish Rapte
UR
On Wed, 17 Aug 2022 13:30:54 GMT, Ambarish Rapte wrote:
> Not a clean backport.
> Following two files are not present in jfx11.
>
> 1. .github/workflows/submit.yml
> 2. gradle/verification-metadata.xml
LGTM
-
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.org/jfx11u/pu
On Wed, 17 Aug 2022 08:26:48 GMT, Ambarish Rapte wrote:
> Accessibility is not implemented for JavaFX dialogs. This change is to
> implement the accessibility on windows platform.
> Without this fix : On Windows platform, content of Dialog are not read by
> Windows Narrator or JAWS.
> With this
Clean backport to jfx11u
-
Commit messages:
- 8284676: TreeTableView loses sort ordering when applied on empty table
Changes: https://git.openjdk.org/jfx11u/pull/108/files
Webrev: https://webrevs.openjdk.org/?repo=jfx11u&pr=108&range=00
Issue: https://bugs.openjdk.org/browse/JDK-
Clean backport to jfx11u.
-
Commit messages:
- 8289952: Visual Studio libs msvcp140_1.dll and msvcp140_2.dll missing from
build
Changes: https://git.openjdk.org/jfx11u/pull/107/files
Webrev: https://webrevs.openjdk.org/?repo=jfx11u&pr=107&range=00
Issue: https://bugs.openjdk.org
Clean backport to jfx11u.
-
Commit messages:
- 8289587: IllegalArgumentException: Color.rgb's red parameter (-16776961)
expects color values 0-255
Changes: https://git.openjdk.org/jfx11u/pull/106/files
Webrev: https://webrevs.openjdk.org/?repo=jfx11u&pr=106&range=00
Issue: https
Clean backport to jfx11u.
-
Commit messages:
- 8088420: JavaFX WebView memory leak via EventListener
Changes: https://git.openjdk.org/jfx11u/pull/105/files
Webrev: https://webrevs.openjdk.org/?repo=jfx11u&pr=105&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8088420
Stats:
On Wed, 17 Aug 2022 13:30:54 GMT, Ambarish Rapte wrote:
> Not a clean backport.
> Following two files are not present in jfx11.
>
> 1. .github/workflows/submit.yml
> 2. gradle/verification-metadata.xml
@kevinrushforth
Please take a look, this is not a clean backport.
-
PR: https:
Not a clean backport.
Following two files are not present in jfx11.
1. .github/workflows/submit.yml
2. gradle/verification-metadata.xml
-
Commit messages:
- 8283786: Update to Visual Studio 2022 version 17.1.0 on Windows
Changes: https://git.openjdk.org/jfx11u/pull/104/files
Webre
On Wed, 17 Aug 2022 08:26:48 GMT, Ambarish Rapte wrote:
> Accessibility is not implemented for JavaFX dialogs. This change is to
> implement the accessibility on windows platform.
> Without this fix : On Windows platform, content of Dialog are not read by
> Windows Narrator or JAWS.
> With this
On Wed, 17 Aug 2022 07:29:55 GMT, Paul wrote:
>> I hit on JDK-8181084 while making some changes to Scene Builder, so I
>> decided to investigate.
>>
>> Please note: I have not done any Objective-C or MacOS development before. So
>> I would really like some feedback from someone else who knows
On Wed, 17 Aug 2022 12:02:04 GMT, Ambarish Rapte wrote:
> Update libjpeg to current version release [9e](http://www.ijg.org/) of
> 16-Jan-2022
>
> reference: https://jpegclub.org/reference/reference-sources/
>
> Verified all test run on Windows and MacOS
Can you rerun the macOS GHA job? It ti
On Tue, 26 Jul 2022 09:46:26 GMT, Jose Pereda wrote:
>> Paul has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> A few more minor code cleanups
>
> Looks good
@jperedadnr can you re-review (only minor change since you last approved it)?
--
On Wed, 17 Aug 2022 07:29:55 GMT, Paul wrote:
>> I hit on JDK-8181084 while making some changes to Scene Builder, so I
>> decided to investigate.
>>
>> Please note: I have not done any Objective-C or MacOS development before. So
>> I would really like some feedback from someone else who knows
Update libjpeg to current version release [9e](http://www.ijg.org/) of
16-Jan-2022
reference: https://jpegclub.org/reference/reference-sources/
Verified all test run on Windows and MacOS
-
Commit messages:
- Merge branch 'master' into jpeg-9e
- lib jpeg 9e
Changes: https://git.o
On Tue, 16 Aug 2022 21:48:37 GMT, Kevin Rushforth wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed dpqs javadoc + tests (setupOnce)
>
> modules/javafx.graphics/src/main/java/com/sun/marlin/DualPivotQuicksor
On Thu, 13 Jan 2022 08:35:08 GMT, Johan Vos wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added test for huge polygon coords
>
> Building and testing works, I am looking into the diffs as well now.
> The Dual
Accessibility is not implemented for JavaFX dialogs. This change is to
implement the accessibility on windows platform.
Without this fix : On Windows platform, content of Dialog are not read by
Windows Narrator or JAWS.
With this fix:
1. Windows narrator reads the dialog correctly
2. JAWS fails t
On Tue, 26 Jul 2022 09:15:36 GMT, Paul wrote:
>> I hit on JDK-8181084 while making some changes to Scene Builder, so I
>> decided to investigate.
>>
>> Please note: I have not done any Objective-C or MacOS development before. So
>> I would really like some feedback from someone else who knows
> I hit on JDK-8181084 while making some changes to Scene Builder, so I decided
> to investigate.
>
> Please note: I have not done any Objective-C or MacOS development before. So
> I would really like some feedback from someone else who knows this stuff
> better.
>
> Anyway, after some googlin
56 matches
Mail list logo
