On Wed, 28 Sep 2022 20:24:47 GMT, Florian Kirmaier
wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293444: review comments
>
> if you use `checker.setAsReferenced(object)` then the specified object won't
> be
> - added Skin.install()
> - javadoc changes for Skinnable.setSkin(Skin)
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
8290844: unit tests
-
Changes:
- all: https://git.openjdk.org/jfx/pull/845/files
- new:
> - added Skin.install()
> - javadoc changes for Skinnable.setSkin(Skin)
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains 18 additional
On Sat, 24 Sep 2022 03:07:00 GMT, Alexander Matveev
wrote:
> There was two problems:
> - uri.getPath() was returning null for jar URI, since it is not a standard
> URI and thus we did not detect file type based on extension.
> - Our signature detection for MP3 had a bug and did not detect
On Wed, 28 Sep 2022 18:02:53 GMT, Andy Goryachev wrote:
>> Using Weak*Listeners eliminates the memory leak.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8293444: review comments
if you use
> - added Skin.install()
> - javadoc changes for Skinnable.setSkin(Skin)
>
> no code changes for Skinnable.setSkin(Skin) yet.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
8290844: review comments
-
Changes:
-
> The issue is caused by TreeTableRow incorrectly selected when cell selection
> mode is enabled.
>
> Changes:
> - modified TreeTableRow.updateSelection()
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
8292353: review comments
Hi,
Running this code:
var label = new Label();
var tf = new TextField();
label.textProperty().bind(tf.textProperty().map(t -> {
System.out.println("in");
return t;
}));
produces the output::
in
in
>From what I see, the lambda should be called once, but it's called twice.
Looks like
On Tue, 20 Sep 2022 19:06:19 GMT, Andy Goryachev wrote:
>> The issue is caused by TreeTableRow incorrectly selected when cell selection
>> mode is enabled.
>>
>> Changes:
>> - modified TreeTableRow.updateSelection()
>
> Andy Goryachev has updated the pull request incrementally with one
On Wed, 28 Sep 2022 16:20:59 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8292353: review comments
>
>
On Fri, 9 Sep 2022 20:47:56 GMT, Andy Goryachev wrote:
>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>>
>> no code changes for Skinnable.setSkin(Skin) yet.
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The
On Wed, 28 Sep 2022 08:41:42 GMT, Ambarish Rapte wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293444: memory buddy
>
>
On Wed, 28 Sep 2022 10:16:47 GMT, Florian Kirmaier
wrote:
> A small comment about the memory test with
> [JMemoryBuddy](https://github.com/Sandec/JMemoryBuddy).
Thank you for suggestion. I will definitely use it in other tests!
Here it won't work because in the part of the test one instance
> Using Weak*Listeners eliminates the memory leak.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
8293444: review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/900/files
- new:
On Wed, 28 Sep 2022 08:46:41 GMT, Ambarish Rapte wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8293444: memory buddy
>
>
On Tue, 20 Sep 2022 19:06:19 GMT, Andy Goryachev wrote:
>> The issue is caused by TreeTableRow incorrectly selected when cell selection
>> mode is enabled.
>>
>> Changes:
>> - modified TreeTableRow.updateSelection()
>
> Andy Goryachev has updated the pull request incrementally with one
On Tue, 27 Sep 2022 01:22:41 GMT, Alexander Matveev
wrote:
>> There was two problems:
>> - uri.getPath() was returning null for jar URI, since it is not a standard
>> URI and thus we did not detect file type based on extension.
>> - Our signature detection for MP3 had a bug and did not
On Fri, 16 Sep 2022 18:04:07 GMT, Andy Goryachev wrote:
>> Using Weak*Listeners eliminates the memory leak.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8293444: memory buddy
A small comment about the memory test
On Fri, 16 Sep 2022 18:04:07 GMT, Andy Goryachev wrote:
>> Using Weak*Listeners eliminates the memory leak.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8293444: memory buddy
Fix looks good,
Providing some minor
On Fri, 16 Sep 2022 18:04:07 GMT, Andy Goryachev wrote:
>> Using Weak*Listeners eliminates the memory leak.
>
> Andy Goryachev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8293444: memory buddy
20 matches
Mail list logo
