Re: RFR: 8294809: ListenerHelper for managing and disconnecting listeners [v9]

2022-11-14 Thread Ajit Ghaisas
On Mon, 14 Nov 2022 21:26:52 GMT, Kevin Rushforth wrote: >> you are correct: the original intent for this class was to make it a general >> purpose facility to help with listeners, something that might be useful at >> the application level (and it used `ListenerHelper.get(Node)`). Since that

Re: RFR: 8221708 Update Eclipse project files [v4]

2022-11-14 Thread Nir Lisker
On Sun, 13 Nov 2022 02:27:55 GMT, John Hendrikx wrote: >> See https://bugs.openjdk.org/browse/JDK-8221708 > > John Hendrikx has updated the pull request incrementally with one additional > commit since the last revision: > > Fix controls classpath I updated https://wiki.openjdk.org/display/

Re: Plans for gtk glass backend

2022-11-14 Thread Nir Lisker
Is https://bugs.openjdk.org/browse/JDK-8275033 related? On Tue, Nov 15, 2022 at 2:14 AM Thiago Milczarek Sayão < thiago.sa...@gmail.com> wrote: > I took a look at it, and It seems "by design". > Child stages can be larger, it just can't cover the desktop bar. > If you run in a kiosk style setup y

Re: Plans for gtk glass backend

2022-11-14 Thread Thiago Milczarek Sayão
I took a look at it, and It seems "by design". Child stages can be larger, it just can't cover the desktop bar. If you run in a kiosk style setup you can probably hide the bar. It makes sense to me from a security perspective. -- Thiago. Em seg., 14 de nov. de 2022 às 11:25, John Hendrikx escre

Re: RFR: 8294809: ListenerHelper for managing and disconnecting listeners [v9]

2022-11-14 Thread Kevin Rushforth
On Mon, 14 Nov 2022 20:26:54 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ListenerHelper.java >> line 70: >> >>> 68: * >>> 69: */ >>> 70: public class ListenerHelper implements IDisconnectable { >> >> This class is mixing two things- >> 1

Re: RFR: 8294809: ListenerHelper for managing and disconnecting listeners [v9]

2022-11-14 Thread Kevin Rushforth
On Mon, 14 Nov 2022 20:19:09 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ListenerHelper.java >> line 87: >> >>> 85: >>> 86: public static ListenerHelper get(SkinBase skin) { >>> 87: return accessor.apply(skin); >> >> `accessor`

Re: RFR: 8294809: ListenerHelper for managing and disconnecting listeners [v9]

2022-11-14 Thread Andy Goryachev
On Mon, 14 Nov 2022 10:32:47 GMT, Ajit Ghaisas wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 24 additional >> commits

Re: RFR: 8294809: ListenerHelper for managing and disconnecting listeners [v10]

2022-11-14 Thread Andy Goryachev
> Introduction > > There is a number of places where various listeners (strong as well as weak) > are added, to be later disconnected in one go. For example, Skin > implementations use dispose() method to clean up the listeners installed in > the corresponding Control (sometimes using > Lambda

Re: RFR: 8294809: ListenerHelper for managing and disconnecting listeners [v9]

2022-11-14 Thread Andy Goryachev
On Mon, 14 Nov 2022 09:08:11 GMT, Ajit Ghaisas wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 24 additional >> commits

Re: RFR: 8294809: ListenerHelper for managing and disconnecting listeners [v9]

2022-11-14 Thread Andy Goryachev
On Mon, 14 Nov 2022 10:20:59 GMT, Ajit Ghaisas wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 24 additional >> commits

Re: RFR: 8291853: [CSS] ClassCastException in CssStyleHelper calculateValue [v2]

2022-11-14 Thread Andy Goryachev
On Mon, 14 Nov 2022 18:20:26 GMT, Kevin Rushforth wrote: > Let's do file a follow-up bug. [JDK-8296825](https://bugs.openjdk.org/browse/JDK-8296825) - PR: https://git.openjdk.org/jfx/pull/947

Integrated: 8291853: [CSS] ClassCastException in CssStyleHelper calculateValue

2022-11-14 Thread Andy Goryachev
On Thu, 10 Nov 2022 17:52:50 GMT, Andy Goryachev wrote: > A race condition exists where a derived color depends on another derived > color which has not been yet defined or processed. The only side effect of > this condition is a ClassCastException - the color eventually gets resolved. > > So

Integrated: 8268877: TextInputControlSkin: incorrect inputMethod event handler after switching skin

2022-11-14 Thread Andy Goryachev
On Tue, 27 Sep 2022 19:36:46 GMT, Andy Goryachev wrote: > Using new Skin.install() method to properly set and remove > inputMethodRequests property in TextInputControl. > > This avoids memory leaks resulting from skin change, as well as honors > user-set properties when installing an uninstall

Re: RFR: 8291853: [CSS] ClassCastException in CssStyleHelper calculateValue [v2]

2022-11-14 Thread Kevin Rushforth
On Thu, 10 Nov 2022 20:11:55 GMT, Andy Goryachev wrote: >> A race condition exists where a derived color depends on another derived >> color which has not been yet defined or processed. The only side effect of >> this condition is a ClassCastException - the color eventually gets resolved. >>

Re: Discussion: Naming API method

2022-11-14 Thread Andy Goryachev
I'd pick "whenever" or "onCondition". "updateWhen" sounds like an update, which I think it is not. "when" seems too vague. Disclaimer: English is not my native language. -andy From: openjfx-dev on behalf of Kevin Rushforth Date: Monday, 2022/11/14 at 09:40 To: openjfx-dev@openjdk.org Sub

Re: Discussion: Naming API method

2022-11-14 Thread Kevin Rushforth
I also think this will be a useful feature to get into JavaFX. As for the name of the method, the only one of them I don't like is "conditionOn". That name doesn't suggest (to me anyway) what its purpose is. I think any of the ones with "when" in the name would work. I have a slight preference

Integrated: 8285503: SwingNodeDnDMemoryLeakTest::testSwingNodeMemoryLeak fails sometimes

2022-11-14 Thread Ajit Ghaisas
On Thu, 10 Nov 2022 12:01:53 GMT, Ajit Ghaisas wrote: > Root cause: The test unreliability comes from the 250ms sleep between > `System.gc()` calls. > Other system tests such as `TabPaneHeaderLeakTest`, > `AccordionTitlePaneLeakTest` and `ShapeViewOrderLeakTest` etc sleep for 500ms > between `

AW: Plans for gtk glass backend

2022-11-14 Thread Anafinow, Andrej
https://mail.openjdk.org/pipermail/openjfx-dev/2022-March/033802.html Von: openjfx-dev im Auftrag von John Hendrikx Gesendet: Montag, 14. November 2022 15:25:16 An: openjfx-dev@openjdk.org Betreff: Re: Plans for gtk glass backend I have an issue related to chil

Discussion: Naming API method

2022-11-14 Thread John Hendrikx
Hi, I'm working on https://github.com/openjdk/jfx/pull/830 where I asked for some opinions on the naming of a new method I'd like to introduce in ObservableValue. I wrote a (perhaps too large) comment about the possible names and rationales: https://github.com/openjdk/jfx/pull/830#issuecomme

Re: Plans for gtk glass backend

2022-11-14 Thread John Hendrikx
I have an issue related to child stages not being allowed to be as large as their parent stage under Linux.  It's somewhere fairly deep in the system, and I was wondering if that would be near these things you are planning to do.  I wouldn't know myself how to fix it, but can help where I can:

Integrated: 8296589: PixelBufferDrawTest fails on some systems

2022-11-14 Thread Lukasz Kostyra
On Wed, 9 Nov 2022 18:00:31 GMT, Lukasz Kostyra wrote: > Issue happening on some hardware due to slightly different pixel values being > returned. > > Increased tolerance of asserts in compareColor function to allow these tests > to pass (0.01 delta is still tighter than other similar tests wh

Re: RFR: 8285503: SwingNodeDnDMemoryLeakTest::testSwingNodeMemoryLeak fails sometimes [v2]

2022-11-14 Thread Kevin Rushforth
On Mon, 14 Nov 2022 07:04:36 GMT, Ajit Ghaisas wrote: >> Root cause: The test unreliability comes from the 250ms sleep between >> `System.gc()` calls. >> Other system tests such as `TabPaneHeaderLeakTest`, >> `AccordionTitlePaneLeakTest` and `ShapeViewOrderLeakTest` etc sleep for >> 500ms betw

Plans for gtk glass backend

2022-11-14 Thread Thiago Milczarek Sayão
Hi, I have some plans to work on gtk glass backend, not necessarily in this order: 1) Unify WindowContextBase and WindowContextTop - those were separated for applet support that were removed 2) Remove gtk2 Support 3) Add gesture support 4) Rework AlwaysOnTop, exploring _NET_WM_STATE_ABOVE 5) Fix

Re: RFR: 8291853: [CSS] ClassCastException in CssStyleHelper calculateValue [v2]

2022-11-14 Thread Ajit Ghaisas
On Thu, 10 Nov 2022 20:11:55 GMT, Andy Goryachev wrote: >> A race condition exists where a derived color depends on another derived >> color which has not been yet defined or processed. The only side effect of >> this condition is a ClassCastException - the color eventually gets resolved. >>

Re: RFR: 8294809: ListenerHelper for managing and disconnecting listeners [v9]

2022-11-14 Thread Ajit Ghaisas
On Fri, 4 Nov 2022 20:30:53 GMT, Andy Goryachev wrote: >> Introduction >> >> There is a number of places where various listeners (strong as well as weak) >> are added, to be later disconnected in one go. For example, Skin >> implementations use dispose() method to clean up the listeners instal