> Refactoring and renaming changes to some of the D3D pipeline files and a few
> changes on the Java side. These are various "leftovers" from previous issues
> that we didn't want to touch at the time in order to confine the scope of the
> changes. They will make future work easier.
>
> Since t
On Thu, 1 Sep 2022 11:23:44 GMT, Nir Lisker wrote:
>> Refactoring and renaming changes to some of the D3D pipeline files and a few
>> changes on the Java side. These are various "leftovers" from previous issues
>> that we didn't want to touch at the time in order to confine the scope of
>> the
On Mon, 12 Dec 2022 22:42:16 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new fluen
On Mon, 12 Dec 2022 22:42:16 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new fluen
On Mon, 12 Dec 2022 22:42:16 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new fluen
On Mon, 12 Dec 2022 22:27:49 GMT, Andy Goryachev wrote:
>> Okay I see what you're getting at, your first suggestion would not be
>> correct, it's supposed to be what you suggest in the 2nd one. So what I
>> want is:
>>
>> (scrollMagnitude / nanosPassed) * NANOS_TO_SECONDS
>>
>> or:
>>
On Sat, 3 Dec 2022 22:17:55 GMT, John Hendrikx wrote:
> This includes a fix for the precision problem we've found as part of the
> graphics warnings clean ups.
>
> I've included two commits, one with just the minimal fix, and one with the
> clean ups. I can drop off the 2nd commit if it is dee
On Mon, 12 Dec 2022 22:00:09 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/RotateGestureRecognizer.java
>> line 60:
>>
>>> 58: String s =
>>> System.getProperty("com.sun.javafx.gestures.rotate.threshold");
>>> 59: if (s !=
On Mon, 12 Dec 2022 17:16:37 GMT, Andy Goryachev wrote:
>> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
>> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>>
>> We propose to address all these issues by replacing the old column resize
>> algorithm wi
> This PR adds a new (lazy*) property on `Node` which provides a boolean which
> indicates whether or not the `Node` is currently part of a `Scene`, which in
> turn is part of a currently showing `Window`.
>
> It also adds a new fluent binding method on `ObservableValue` dubbed `when`
> (open f
On Mon, 12 Dec 2022 22:11:09 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 17 commits:
>>
>> - Merge branch 'openjdk:master' into feature/conditional-bindings
>> - Remove example re
On Mon, 12 Dec 2022 22:15:46 GMT, John Hendrikx wrote:
>> That would be equivalent yes.
>>
>> Perhaps it is because `timePassed` was a `double` before measured in seconds
>> while I'm now doing the calculation with nano seconds?
>
> Okay I see what you're getting at, your first suggestion would
On Mon, 12 Dec 2022 21:57:18 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new fluen
On Mon, 12 Dec 2022 22:05:14 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/ZoomGestureRecognizer.java
>> line 277:
>>
>>> 275:
>>> 276: if (nanosPassed >
>>> INITIAL_VELOCITY_THRESHOLD_NANOS) {
>>> 277:
On Mon, 12 Dec 2022 22:08:57 GMT, John Hendrikx wrote:
>> your change is equivalent to
>>
>> (scrollMagnitude * NANOS_TO_SECONDS) / nanosPassed
>>
>> is that correct?
>
> That would be equivalent yes.
>
> Perhaps it is because `timePassed` was a `double` before measured in seconds
> while I'
On Mon, 12 Dec 2022 22:05:44 GMT, Andy Goryachev wrote:
>> I think it's correct, unless you have reason to believe why it wouldn't be.
>> `scrollMagnitude` is a double, and the division and multiplication that
>> follow it will be all done as doubles.
>
> your change is equivalent to
>
> (sc
On Mon, 12 Dec 2022 22:03:31 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/ScrollGestureRecognizer.java
>> line 252:
>>
>>> 250: factorX = deltaX / scrollMagnitude;
>>> 251: factorY = deltaY / scrollM
On Mon, 12 Dec 2022 16:51:01 GMT, Andy Goryachev wrote:
>> This includes a fix for the precision problem we've found as part of the
>> graphics warnings clean ups.
>>
>> I've included two commits, one with just the minimal fix, and one with the
>> clean ups. I can drop off the 2nd commit if it
> This PR adds a new (lazy*) property on `Node` which provides a boolean which
> indicates whether or not the `Node` is currently part of a `Scene`, which in
> turn is part of a currently showing `Window`.
>
> It also adds a new fluent binding method on `ObservableValue` dubbed `when`
> (open f
On Sun, 11 Dec 2022 20:31:24 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new fluen
> This PR adds style themes as a first-class concept to OpenJFX. A style theme
> is a collection of stylesheets and the logic that governs them. Style themes
> can respond to OS notifications and update their stylesheets dynamically.
> This PR also re-implements Caspian and Modena as style theme
> This PR adds style themes as a first-class concept to OpenJFX. A style theme
> is a collection of stylesheets and the logic that governs them. Style themes
> can respond to OS notifications and update their stylesheets dynamically.
> This PR also re-implements Caspian and Modena as style theme
On Sat, 10 Dec 2022 10:38:07 GMT, Dean Wookey wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
>> MenuButtonSkinBase c
On Sat, 10 Dec 2022 15:29:15 GMT, Kevin Rushforth wrote:
>> consistent - the other policies have two paragraphs, see TableView : 382 and
>> 483
>
> What I meant is that `TableView::CONSTRAINED_RESIZE_POLICY_FLEX_NEXT_COLUMN`
> and `TreeTableView::CONSTRAINED_RESIZE_POLICY_FLEX_NEXT_COLUMN` are
> The current CONSTRAINED_RESIZE_POLICY has a number of issues as explained in
> [JDK-8292810](https://bugs.openjdk.org/browse/JDK-8292810).
>
> We propose to address all these issues by replacing the old column resize
> algorithm with a different one, which not only honors all the constraints
On Sat, 3 Dec 2022 22:17:55 GMT, John Hendrikx wrote:
> This includes a fix for the precision problem we've found as part of the
> graphics warnings clean ups.
>
> I've included two commits, one with just the minimal fix, and one with the
> clean ups. I can drop off the 2nd commit if it is dee
Another idea is to use a static map that maps a node to its "graphic
parent". That will save on memory at the expense of a lookup.
On Thu, Dec 1, 2022 at 11:53 PM Nir Lisker wrote:
> Are we convinced that a node can't be both a graphic and a clip, or
> something else? The docs for clip specify t
27 matches
Mail list logo
