RFR: 8301022: Video distortion is observed while playing youtube video

2023-02-21 Thread Jay Bhaskar
Issue: current update is breaking the rendering of media controls on youtube video playback For the Webkit Gtk platform, the layout class name is returned as AdwaitaLayoutTraits which is incompatible with the JAVA platform. Solution: Use mediaControlsAdwaitaJavaScript and

Re: CSS styling of Shape in TextFlow causes flickering

2023-02-21 Thread Scott Palmer
Even if I always kept the TextFlow as a graphic on the cells, I would need to change its children to show the correct shape and text. So there would normally be changes to the children when updateItem is called, just one level deeper in the node hierarchy.It makes sense that in most circumstances

Re: CSS styling of Shape in TextFlow causes flickering

2023-02-21 Thread John Hendrikx
It's a bit hard to say if this is a bug or not. I think this happens any time when children are added during layout. Most controls will avoid doing this, but when Cells are involved, there is another layer of indirection. I think the View classes manage their cells during layout, and since

Re: CSS styling of Shape in TextFlow causes flickering

2023-02-21 Thread John Hendrikx
I saw you resolved the issue already in your next mail. As you're modifying the Cell when it is being updated, it won't be so easy to do the same thing I'm doing.  For me, the problem was that adding additional cells only when they're needed is done during `layoutChildren`, which is after CSS

Re: RFR: 8303038: Glass gtk3 sends scroll events with delta(x,y) = 0

2023-02-21 Thread Glavo
On Wed, 22 Feb 2023 01:11:55 GMT, Thiago Milczarek Sayao wrote: > Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this > scroll event type, deltas are sent to java with the value equal to zero. Are you sure this PR fixes this problem? I tested it and not only did it

Re: CSS styling of Shape in TextFlow causes flickering

2023-02-21 Thread Scott Palmer
Well I managed to work around it by placing the applyCss() call on the Cell itself, rather than the Shape node that I was styling. I'm still not sure if I'm doing something wrong, if this is just how it's done and the applyCss() call is the correct thing to do for this case, or if this should be

RFR: 8303038: Glass gtk3 sends scroll events with delta(x,y) = 0

2023-02-21 Thread Thiago Milczarek Sayao
Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this scroll event type, deltas are sent to java with the value equal to zero. - Commit messages: - Fix scroll event - Merge branch 'openjdk:master' into master - Merge branch 'openjdk:master' into master -

Re: RFR: 8303038: Glass gtk3 sends scroll events with delta(x,y) = 0

2023-02-21 Thread Thiago Milczarek Sayao
On Wed, 22 Feb 2023 01:11:55 GMT, Thiago Milczarek Sayao wrote: > Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this > scroll event type, deltas are sent to java with the value equal to zero. @Glavo fixed the scroll bug you commented on #999. - PR:

Re: RFR: 8303026: [TextField] IOOBE on setting text with control characters that replaces existing text

2023-02-21 Thread Andy Goryachev
On Tue, 21 Feb 2023 23:11:52 GMT, Jose Pereda wrote: > This PR fixes a regression after > [JDK-8212102](https://bugs.openjdk.org/browse/JDK-8212102). > > When a TextField control has some previous content, and new text with only > invalid characters (0x7F, new line, tabs, <0x20) is set, >

RFR: 8303026: [TextField] IOOBE on setting text with control characters that replaces existing text

2023-02-21 Thread Jose Pereda
This PR fixes a regression after [JDK-8212102](https://bugs.openjdk.org/browse/JDK-8212102). When a TextField control has some previous content, and new text with only invalid characters (0x7F, new line, tabs, <0x20) is set, `TextInputControl::filterInput` is used to strip them out, and the

Re: RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout [v3]

2023-02-21 Thread Martin Fox
> The algorithm in `KeyCharacterCombination.match` relies on the call > `Toolkit.getKeyCodeForChar` which is difficult to implement correctly. It > defies the way most keyboard API’s work and no platform has got it right yet. > In particular the Mac and Linux implementations have to resort to a

Re: CSS styling of Shape in TextFlow causes flickering

2023-02-21 Thread John Hendrikx
I've run into something similar, maybe even the same issue. My issue was that modifying the list of cell children (in a Skin for ListView) caused a 1 frame white flicker (my application is black, so it was annoying) because no CSS was applied yet to those newly added children.  This occured

Re: RFR: 8090123: Items are no longer visible when collection is changed [v3]

2023-02-21 Thread Andy Goryachev
On Tue, 21 Feb 2023 06:05:54 GMT, Karthik P K wrote: >> When a large number of items were scrolled in the `ChoiceBox`, the scrolled >> offset was carried forward when the list is replaced with small number of >> items. Hence the scroll up arrow was displayed with empty popup. >> >> Changed

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v8]

2023-02-21 Thread John Hendrikx
On Tue, 21 Feb 2023 16:31:10 GMT, John Hendrikx wrote: >> This contains the following: >> - Nested changes or invalidations using ExpressionHelper are delayed until >> the current emission completes >> - This fixes odd change events being produced (with incorrect oldValue) >> - Also fixes a

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v8]

2023-02-21 Thread John Hendrikx
On Tue, 21 Feb 2023 16:31:10 GMT, John Hendrikx wrote: >> This contains the following: >> - Nested changes or invalidations using ExpressionHelper are delayed until >> the current emission completes >> - This fixes odd change events being produced (with incorrect oldValue) >> - Also fixes a

Re: CSS styling of Shape in TextFlow causes flickering

2023-02-21 Thread Andy Goryachev
Scott, can you try styling these nodes via the scene stylesheet (Scene.getStylesheets())? -andy From: openjfx-dev on behalf of Scott Palmer Date: Monday, February 20, 2023 at 11:59 To: openjfx-dev Subject: CSS styling of Shape in TextFlow causes flickering I'm seeing an odd issue with using

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v8]

2023-02-21 Thread John Hendrikx
> This contains the following: > - Nested changes or invalidations using ExpressionHelper are delayed until > the current emission completes > - This fixes odd change events being produced (with incorrect oldValue) > - Also fixes a bug in ExpressionHelper where a nested change would unlock >

Re: RFR: 8278021: Fix warnings in macOS glass native code and treat warnings as errors [v2]

2023-02-21 Thread Martin Fox
> Turning on warnings-as-errors for the macOS glass native code. Deprecated > declarations are excluded and still appear as warnings. > > In the code that tries to locate the application's dock icon there were three > instances where `NO` was being passed into a method that required a pointer

Re: RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v7]

2023-02-21 Thread Kevin Rushforth
On Tue, 21 Feb 2023 13:38:09 GMT, Glavo wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Improve exception > > import com.jfoenix.controls.JFXScrollPane; > import javafx.application.Application; > import

Re: RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v7]

2023-02-21 Thread Glavo
On Tue, 21 Feb 2023 00:29:13 GMT, Thiago Milczarek Sayao wrote: >> Simple PR to remove gtk2 library compilation and loading. > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Improve exception import

Re: RFR: 8090123: Items are no longer visible when collection is changed [v3]

2023-02-21 Thread Lukasz Kostyra
On Tue, 21 Feb 2023 06:05:54 GMT, Karthik P K wrote: >> When a large number of items were scrolled in the `ChoiceBox`, the scrolled >> offset was carried forward when the list is replaced with small number of >> items. Hence the scroll up arrow was displayed with empty popup. >> >> Changed

Re: RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v7]

2023-02-21 Thread Thiago Milczarek Sayao
On Tue, 21 Feb 2023 10:59:18 GMT, Glavo wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Improve exception > > I think there is a noteworthy situation: JFoenix's smooth scrolling does not > work when

Re: RFR: 8173321: TableView: Click on right trough has no effect when cell height is higher than viewport height [v9]

2023-02-21 Thread Ajit Ghaisas
On Sat, 18 Feb 2023 15:32:48 GMT, JoachimSchriek wrote: >> This is my (joachim.schr...@gmx.de) first contribution to openjfx. My >> Contributor Agreement is signed but still in review. >> So please be patient with an absolute beginner as contributor ... . >> The work of this pull request was

Re: RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v7]

2023-02-21 Thread Glavo
On Tue, 21 Feb 2023 00:29:13 GMT, Thiago Milczarek Sayao wrote: >> Simple PR to remove gtk2 library compilation and loading. > > Thiago Milczarek Sayao has updated the pull request incrementally with one > additional commit since the last revision: > > Improve exception I think there is a