Re: RFR: 8299335: Monkey Tester Application [v13]

2023-04-28 Thread Karthik P K
On Thu, 27 Apr 2023 23:29:22 GMT, Andy Goryachev wrote: >> Monkey Tester - a JavaFX application designed to support manual ad-hoc >> testing of individual JavaFX controls. Unlike Ensemble, the goal of this >> application is to facilitate manual testing rather than demonstrate the >> capabilit

Re: RFR: 8302816: Refactor sorting-related classes [v2]

2023-04-28 Thread Ambarish Rapte
On Wed, 26 Apr 2023 10:16:54 GMT, Nir Lisker wrote: >> Most of the changes revolve around unifying the sorting methods for a >> collection with `Comparable` elements with sorting methods that take an >> external `Comparator` by passing `Comparator.naturalOrder()` from the former >> to the latt

Re: RFR: 8302816: Refactor sorting-related classes [v3]

2023-04-28 Thread Nir Lisker
> Most of the changes revolve around unifying the sorting methods for a > collection with `Comparable` elements with sorting methods that take an > external `Comparator` by passing `Comparator.naturalOrder()` from the former > to the latter. This eliminates method duplication and some warnings

Re: RFR: 8302816: Refactor sorting-related classes [v2]

2023-04-28 Thread Nir Lisker
On Fri, 28 Apr 2023 06:30:28 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - Added missing space >> - Merge branch 'master' into 8302816_Refactor_sorting-related_cl

RFR: 8304922: [testbug] SliderTooltipNPETest fails on Linux

2023-04-28 Thread Karthik P K
The test was failing on the first run and then it was not failing. Cause for the failure looked to be the UI state not getting updated. Hence added call to `Toolkit` `firePulse` method. Able to run the test consistently without failure in Linux after the fix. - Commit messages: -

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v2]

2023-04-28 Thread John Hendrikx
On Thu, 27 Apr 2023 19:43:14 GMT, Andy Goryachev wrote: >> What are we trying to achieve here I'm wondering? Because if it is to slowly >> exhaustively test more and more of the problem space during each build, then >> I really disagree with the methodology. >> >> We're confident that this is

Re: RFR: 8302816: Refactor sorting-related classes [v2]

2023-04-28 Thread Kevin Rushforth
On Fri, 28 Apr 2023 11:20:39 GMT, Nir Lisker wrote: >> modules/javafx.base/src/main/java/com/sun/javafx/collections/ObservableListWrapper.java >> line 45: >> >>> 43: * >>> 44: */ >>> 45: public class ObservableListWrapper extends >>> ModifiableObservableListBase implements SortableList, Rand

Re: RFR: 8302816: Refactor sorting-related classes [v2]

2023-04-28 Thread Nir Lisker
On Fri, 28 Apr 2023 12:46:38 GMT, Kevin Rushforth wrote: >> The formatter is set to 120 characters in a line, I think it's fine to leave >> as is. > > If you were already modifying this, then sure. I don't think Ambarish's point > was about the line being too long. In this case, the rewrapping

Re: RFR: 8302816: Refactor sorting-related classes [v2]

2023-04-28 Thread Kevin Rushforth
On Fri, 28 Apr 2023 12:58:24 GMT, Nir Lisker wrote: >> If you were already modifying this, then sure. I don't think Ambarish's >> point was about the line being too long. In this case, the rewrapping is on >> otherwise unmodified lines of code, so is unrelated to your PR. > > Alright. I don't m

Re: RFR: 8304922: [testbug] SliderTooltipNPETest fails on Linux

2023-04-28 Thread Kevin Rushforth
On Fri, 28 Apr 2023 12:06:51 GMT, Karthik P K wrote: > The test was failing on the first run and then it was not failing. Cause for > the failure looked to be the UI state not getting updated. Hence added call > to `Toolkit` `firePulse` method. > > Able to run the test consistently without fai

Re: RFR: 8304922: [testbug] SliderTooltipNPETest fails on Linux

2023-04-28 Thread Karthik P K
On Fri, 28 Apr 2023 13:04:44 GMT, Kevin Rushforth wrote: >> The test was failing on the first run and then it was not failing. Cause for >> the failure looked to be the UI state not getting updated. Hence added call >> to `Toolkit` `firePulse` method. >> >> Able to run the test consistently wi

Re: RFR: 8299335: Monkey Tester Application [v9]

2023-04-28 Thread Andy Goryachev
On Fri, 28 Apr 2023 06:32:04 GMT, Karthik P K wrote: > The text getting wrapped in TextArea of Monkey Tester without selecting wrap > text option initially could be Monkey tester issue? I wonder if this is a product bug. In some cases, a change in one of the properties in the property sheet r

Re: RFR: 8299335: Monkey Tester Application [v14]

2023-04-28 Thread Andy Goryachev
> Monkey Tester - a JavaFX application designed to support manual ad-hoc > testing of individual JavaFX controls. Unlike Ensemble, the goal of this > application is to facilitate manual testing rather than demonstrate the > capabilities of JavaFX. > > Feedback and suggestions are always welcom

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v2]

2023-04-28 Thread Andy Goryachev
On Fri, 28 Apr 2023 12:25:19 GMT, John Hendrikx wrote: >> Not sure I quite understand what you are asking, so - >> >> 1. the test is good, it's a reasonable approach for a situation with a large >> space. An exhaustive tests using floats that I ran passes, no need (I >> think) to run it on ev

Re: RFR: 8297071: Provide gradle "TEST_ONLY" flag to completely suppress building the sdk and shims [v3]

2023-04-28 Thread Kevin Rushforth
On Thu, 27 Apr 2023 21:22:22 GMT, Ambarish Rapte wrote: >> Add `TEST_ONLY` flag to gradle with default value as false. >> Add new task named `shims`, This task depends on all shim tasks from all >> projects. Hence it will build all shim classes. >> >> If TEST_ONLY is set to true, the all non te

Re: RFR: 8299335: Monkey Tester Application [v15]

2023-04-28 Thread Andy Goryachev
> Monkey Tester - a JavaFX application designed to support manual ad-hoc > testing of individual JavaFX controls. Unlike Ensemble, the goal of this > application is to facilitate manual testing rather than demonstrate the > capabilities of JavaFX. > > Feedback and suggestions are always welcom

Re: RFR: 8299335: Monkey Tester Application [v15]

2023-04-28 Thread Kevin Rushforth
On Fri, 28 Apr 2023 21:33:54 GMT, Andy Goryachev wrote: >> Monkey Tester - a JavaFX application designed to support manual ad-hoc >> testing of individual JavaFX controls. Unlike Ensemble, the goal of this >> application is to facilitate manual testing rather than demonstrate the >> capabilit

Re: RFR: 8299335: Monkey Tester Application [v14]

2023-04-28 Thread Kevin Rushforth
On Fri, 28 Apr 2023 16:47:24 GMT, Andy Goryachev wrote: >> Monkey Tester - a JavaFX application designed to support manual ad-hoc >> testing of individual JavaFX controls. Unlike Ensemble, the goal of this >> application is to facilitate manual testing rather than demonstrate the >> capabilit

Re: RFR: 8299335: Monkey Tester Application [v16]

2023-04-28 Thread Andy Goryachev
> Monkey Tester - a JavaFX application designed to support manual ad-hoc > testing of individual JavaFX controls. Unlike Ensemble, the goal of this > application is to facilitate manual testing rather than demonstrate the > capabilities of JavaFX. > > Feedback and suggestions are always welcom

Re: RFR: 8299335: Monkey Tester Application [v14]

2023-04-28 Thread Andy Goryachev
On Fri, 28 Apr 2023 20:28:13 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments > > tests/manual/monkey/build.xml line 97: > >> 95: >> 96: >> 97: > > Suggestion: Add a `ja

Withdrawn: 8290037: Bindings should clean up after themselves when their weak listeners go out of scope

2023-04-28 Thread duke
On Thu, 14 Jul 2022 14:48:14 GMT, John Hendrikx wrote: > This is an initial (incomplete) implementation of 8290037 for evaluation. > > If the approach is agreed, I will modify the rest of the `*PropertyBase` > classes which use weak listeners, and add some tests. > > I didn't use `Cleaner` bec

Withdrawn: 8295078: TextField blurry when inside an TitledPane -> AnchorPane

2023-04-28 Thread duke
On Tue, 11 Oct 2022 09:05:34 GMT, Marius Hanl wrote: > The problem here is, that the `AnchorPane` does not use its snapped insets. > Therefore, the fix is to replace all `getInsets().getXXX` calls with their > corresponding `snappedXXXInset()` methods. > > Note: The reason the `AnchorPane` insi

Withdrawn: 8286867: Update #getGlyphCode return a negative number

2023-04-28 Thread duke
On Fri, 13 May 2022 05:34:08 GMT, Tomator wrote: > When I used BlueJ, I found a problem with Chinese display. > /javafx.graphics/com/sun/javafx/font/CompositeGlyphMapper.java#getGlyphCode > may return a negative number when no font library is specified in Linux,and > this could cause java.lang

Withdrawn: [WIP]8267425: Intermittent failure of HonorDeveloperSettingsTest unit test

2023-04-28 Thread duke
On Thu, 20 May 2021 07:18:28 GMT, Ambarish Rapte wrote: > The same failure was earlier fixed at PR #496, which seems insufficient. > The changes in this PR were also tried ealier in the PR #496 but later > removed, as they seemed not necessary. > Fix is to clean up the test, by removing all chil

Withdrawn: 8261221: Tooltip bigger than screen size blinks - shows and hides over and over again

2023-04-28 Thread duke
On Fri, 5 Feb 2021 10:46:49 GMT, Paweł Kruszczyński wrote: > `Tooltip` is no longer hiding upon receiving > `MouseEvent.MOUSE_ENTERED_TARGET` event inside it. Pressing mouse on > overlaying tooltip also kills the tooltip, so the infinite duration tooltip > can be closed. This pull request has

Withdrawn: 8262023: Scrolled button is pressed using Monocle on Raspberry Pi with Touchscreen

2023-04-28 Thread duke
On Fri, 19 Feb 2021 14:19:35 GMT, Alexander Scherbatiy wrote: > The issue is reproduced on Raspberry Pi 3 B+ with Touchscreen display. > > To reproduce the issue run the > [ScrollPaneSample](https://bugs.openjdk.java.net/secure/attachment/93270/ScrollPaneSample.java) > with Monocle: >> sudo j

Withdrawn: 8230231: font-family not updated in HTMLEditor

2023-04-28 Thread duke
On Wed, 9 Oct 2019 13:05:22 GMT, Hadzic Samir wrote: > Fix for https://github.com/javafxports/openjdk-jfx/issues/573 > > Issue on JBS bug tracking : https://bugs.openjdk.java.net/browse/JDK-8230231 > > Fix: Check for quote when updating the font-family comboBox. > > A new font is added as a re

Withdrawn: 8090110: Very bad TextArea of performance in a language environment that uses the Chinese character (KANJI)

2023-04-28 Thread duke
On Wed, 23 Sep 2020 15:41:43 GMT, yosbits wrote: > * https://bugs.openjdk.java.net/browse/JDK-8090110 > * https://bugs.openjdk.java.net/browse/JDK-8089418 > > TextArea slows down as the number of characters increases. This problem can > be greatly improved by setting the clip of the display are

Withdrawn: 8255572: Axis does not compute preferred height properly when autoRanging is off

2023-04-28 Thread duke
On Thu, 29 Oct 2020 15:15:22 GMT, Jonathan Vusich wrote: > As noted in the corresponding JBS issue, `Axis` does not properly compute its > preferred height when `autoRanging` is turned off. The simplest fix seems to > be changing `CategoryAxis` so that `tickLabelRotation` is set to 90 degrees

Withdrawn: 8253086: Optimization of removeAll and retainAll of ObservableListWrapper

2023-04-28 Thread duke
On Mon, 14 Sep 2020 09:57:26 GMT, yosbits wrote: > https://bugs.openjdk.java.net/browse/JDK-8253086 > > ObservableListWrapper.java > * public boolean removeAll(Collection c) > * public boolean retainAll(Collection c) > > These two methods use BitSet, but it doesn't make sense. > By rewriting t

Withdrawn: 8185887: TableRowSkinBase fails to correctly virtualize cells in horizontal direction

2023-04-28 Thread duke
On Mon, 24 Feb 2020 07:39:43 GMT, yosbits wrote: > If there are many columns, the current TableView will stall scrolling. > Resolving this performance issue requires column virtualization. > Virtualization mode is enabled when the row height is fixed by the following > method. > > `tableView.