On Fri, 12 May 2023 22:48:31 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix PseudoClassTest
>
> modules/javafx.graphics/src/main/java/javafx/css/Match.java line 74:
>
>> 72: * Gets
> The class `PseudoClassState` is private API, but was exposed erroneously in
> the CSS API. Instead, `Set` should have been used. This PR
> corrects this.
John Hendrikx has updated the pull request incrementally with three additional
commits since the last revision:
- Override hashCode with
On Fri, 12 May 2023 22:44:50 GMT, Kevin Rushforth wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix PseudoClassTest
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 519:
>
>> 517:
Not scripts, but yes, the JDK uses pandoc to process their markdown
files. I'd prefer not to go down that route at this time. The docs we
are talking about can be rendered directly by the GitHub UI.
-- Kevin
On 5/12/2023 2:00 PM, Andy Goryachev wrote:
Looks like JDK uses a different flavor
On Fri, 12 May 2023 21:26:51 GMT, Andy Goryachev wrote:
>> Fixed a memory leak in TreeTableView by reverting to register**Listener
>> (which is ok in this particular situation) - the leak is specific to
>> TreeTableRowSkin.
>>
>> Added a unit test.
>
> Andy Goryachev has updated the pull reque
Yes, this seems like a good idea. I'm less sure about scattering
module-specific docs in the module dir, but let's start with a top-level
"doc" directory and see where we get. Also, I'd stick with just Markdown
for now.
-- Kevin
On 5/12/2023 1:57 PM, Marius Hanl wrote:
I like this idea as we
On Sat, 8 Apr 2023 19:43:51 GMT, John Hendrikx wrote:
>>> I think that Match is supposed to be immutable, given the non-public
>>> constructor. Match itself will never change the set (and nothing else will)
>>> so making it observable seems unnecessary.
>>
>> Agreed.
>>
>>> In other words, si
On Sun, 9 Apr 2023 09:22:54 GMT, John Hendrikx wrote:
>> The class `PseudoClassState` is private API, but was exposed erroneously in
>> the CSS API. Instead, `Set` should have been used. This PR
>> corrects this.
>
> John Hendrikx has updated the pull request incrementally with one additional
Apart from the first line which may have special significance, GitHub
renders this nicely enough when you activate the preview.
I didn't mean to specifically suggest a special flavor of markdown, just
that we should ensure it looks okay on GitHub as that will often be the
viewer used.
--John
On Fri, 12 May 2023 19:53:35 GMT, Andy Goryachev wrote:
> Also, probably unrelated to this PR: the outlines placed by VoiceOver are
> shifted to the wrong positions on the secondary monitor
Definitely unrelated, but it should be filed as a bug. I remember seeing this
before, but I don't see a
On 5/12/23 12:02 PM, John Hendrikx wrote:
The build documentation may be a good candidate to place there as well.
I'm all for it. Some of us were in agreement on moving at least the
build instructions back in November 2022. See the following thread on
the mailing list from a pull request disc
On Fri, 12 May 2023 22:06:04 GMT, Andy Goryachev wrote:
> I can't find anything like VoiceOver on Windows 11. Do you need JAWS or
> similar to test?
You can use Windows Narrator.
-
PR Comment: https://git.openjdk.org/jfx/pull/1088#issuecomment-1546368615
On Fri, 12 May 2023 10:36:12 GMT, Ambarish Rapte wrote:
>> Issue:
>> CheckBoxTreeItem extends TreeItem and adds a CheckBox.
>> The state of this CheckBox is not visible to an accessibility client
>> application.
>> If we analyze a simple program that contains a CheckBoxTreeItem using a
>> windo
On Fri, 12 May 2023 21:35:25 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/AccessibleAttribute.java
>> line 828:
>>
>>> 826: * This enum describes the values for TOGGLE_STATE attribute.
>>> 827: *
>>> 828: * @see TOGGLE_STATE
>>
>> this might
On Fri, 12 May 2023 22:10:43 GMT, Kevin Rushforth wrote:
>> Hopefully, this is just an Eclipse limitation. I'll check the actual javadoc
>> (which I was planning to do anyway).
>
> It does work in the actual javadocs (so almost certainly an Eclipse issue).
>
> Minor suggestion: use `{@link ...}
On Sun, 9 Apr 2023 09:22:54 GMT, John Hendrikx wrote:
>> The class `PseudoClassState` is private API, but was exposed erroneously in
>> the CSS API. Instead, `Set` should have been used. This PR
>> corrects this.
>
> John Hendrikx has updated the pull request incrementally with one additional
On Fri, 12 May 2023 10:36:12 GMT, Ambarish Rapte wrote:
>> Issue:
>> CheckBoxTreeItem extends TreeItem and adds a CheckBox.
>> The state of this CheckBox is not visible to an accessibility client
>> application.
>> If we analyze a simple program that contains a CheckBoxTreeItem using a
>> windo
On Fri, 12 May 2023 21:34:20 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/win/WinAccessible.java
>> line 436:
>>
>>> 434: case TAB_ITEM: return
>>> getContainerAccessible(AccessibleRole.TAB_PANE);
>>> 435: case PAGE_ITEM:
On Fri, 12 May 2023 19:53:35 GMT, Andy Goryachev wrote:
> Testing with VoiceOver on Mac M1 Ventura 13.3.1(a): undetermined checkbox is
> pronounced as "mixed checkbox" - is this expected behavior?
This is a Windows-only fix, so the behavior should be unchanged on Mac from
before this fix. The
On Fri, 12 May 2023 10:36:12 GMT, Ambarish Rapte wrote:
>> Issue:
>> CheckBoxTreeItem extends TreeItem and adds a CheckBox.
>> The state of this CheckBox is not visible to an accessibility client
>> application.
>> If we analyze a simple program that contains a CheckBoxTreeItem using a
>> windo
On Fri, 12 May 2023 18:24:29 GMT, Andy Goryachev wrote:
>> Ambarish Rapte has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> co
> Fixed a memory leak in TreeTableView by reverting to register**Listener
> (which is ok in this particular situation) - the leak is specific to
> TreeTableRowSkin.
>
> Added a unit test.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revisi
On Fri, 12 May 2023 18:13:46 GMT, John Hendrikx wrote:
>> Even though I don't particularly like register*Listener() because of its
>> asymmetric nature (when it comes to removing listeners), here we do need to
>> create weak listeners that get unregistered upon `dispose()`. We need weak
>> li
On Tue, 9 May 2023 05:10:25 GMT, Karthik P K wrote:
>> Since surrogate pairs are internally considered as 2 characters and text
>> field is null in `HitInfo` when `getInsertionIndex` is invoked from
>> `TextFlow`, wrong insertion index was returned.
>>
>> Updated code to calculate insertion in
Looks like JDK uses a different flavor of markdown:
> % Testing the JDK
https://github.com/openjdk/jdk/blob/38838b344af00b32251b3141350ba4deb3962d6f/doc/testing.md?plain=1#LL1C18-L1C18
Are there any scripts that process the .md in jdk?
-andy
From: openjfx-dev on behalf of Marius Hanl
Date:
I like this idea as well. And I agree, especially the snapping insight are good to document as this topic really isn't trivial.
I think we should stick to the official JDK, which also follows the idea suggested by John.
See here: https://github.com/openjdk/jdk/tree/master/doc
-> There is a doc fold
On Fri, 12 May 2023 07:57:27 GMT, John Hendrikx wrote:
>> here: yes!
>
> This looks good to me, the snapping as explained by Andy is how it should be.
> A source of error can be still be that floating point calculations can
> introduce small deviations so sometimes it is needed to resnap after
On Fri, 12 May 2023 18:40:20 GMT, John Hendrikx wrote:
>>> I think once there is an unsnapped parent, all children should probably
>>> also be unsnapped (ie. the property should work like the visible property;
>>> if I turn it off for one parent, all children become invisible/unsnapped).
>>
>>
On Fri, 12 May 2023 20:39:16 GMT, Andy Goryachev wrote:
> I think CSR needs to be out of Draft status to move this PR along.
I changed the status to Proposed.
-
PR Comment: https://git.openjdk.org/jfx/pull/1090#issuecomment-1546273668
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote:
>> This PR adds the following methods to the `EventTarget` interface:
>> 1. `addEventHandler`
>> 2. `removeEventHandler`
>> 3. `addEventFilter`
>> 4. `removeEventFilter`
>
> Michael Strauß has updated the pull request incrementally with one
On Mon, 17 Apr 2023 06:00:19 GMT, Michael Strauß wrote:
>> This PR adds the following methods to the `EventTarget` interface:
>> 1. `addEventHandler`
>> 2. `removeEventHandler`
>> 3. `addEventFilter`
>> 4. `removeEventFilter`
>
> Michael Strauß has updated the pull request incrementally with one
On Fri, 12 May 2023 17:25:22 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/shims/java/javafx/scene/control/skin/TableHeaderRowShim.java
>> line 38:
>>
>>> 36:
>>> 37: public static ContextMenu getColumnPopupMenu(TableHeaderRow
>>> tableHeaderRow) {
>>> 38: return table
On Thu, 11 May 2023 19:39:36 GMT, Marius Hanl wrote:
> This PR changes the `columnPopupMenu`, so that it is created lazily.
>
> The problem here is, that the `columnPopupMenu` is always initialized and
> updated via bindings, even if the table menu button is never shown
> (`setTableMenuButtonV
On Fri, 12 May 2023 10:36:12 GMT, Ambarish Rapte wrote:
>> Issue:
>> CheckBoxTreeItem extends TreeItem and adds a CheckBox.
>> The state of this CheckBox is not visible to an accessibility client
>> application.
>> If we analyze a simple program that contains a CheckBoxTreeItem using a
>> windo
On Fri, 12 May 2023 16:26:42 GMT, Carl Döbbelin wrote:
> > > Looks good. Do you want to replace `HostUtils`'s OS detection with
> > > `PlatformUtil` (or were they split on purpose)?
> >
> >
> > I think this might be a good change, but I'll leave it up to
> > @EstelonAgarwaen . To minimize the
I think this is a great idea!
Some projects use a separate wiki, but sometimes it backfires when domain name
changes or wiki software gets updated.
Making certain parts of documentation such as these notes, a part of the code
repository not only eliminates these failure modes, but provides addi
In PR https://github.com/openjdk/jfx/pull/910 a lot of "new" insights
were gained in the snapping logic. Michael Strauss suggested
documenting this, and I thought we may as well discuss this on the
mailing list instead of continuing the discussion in that PR.
In my normal line of work, I usua
On Fri, 12 May 2023 16:20:35 GMT, Kevin Rushforth wrote:
>>> In this case getWidth() may not be snapped since the titled pane has been
>>> laid out by an unsnapped parent.
>>
>> And when that happens, you can't do anything about it either. If you adjust
>> the width, you risk not covering the
On Fri, 12 May 2023 17:19:29 GMT, Andy Goryachev wrote:
> I think it's probably not worth doing. When the application developer sets
> snapping off when it's on by default, they do it for a reason, so the current
> behavior is the right one. May be they want to smooth some transition during
>
On Fri, 12 May 2023 15:52:56 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java
>> line 103:
>>
>>> 101: updateTreeItem();
>>> 102: // There used to be an isDirty = true statement here, but
>>> this was
>>
On Thu, 11 May 2023 19:39:36 GMT, Marius Hanl wrote:
> This PR changes the `columnPopupMenu`, so that it is created lazily.
>
> The problem here is, that the `columnPopupMenu` is always initialized and
> updated via bindings, even if the table menu button is never shown
> (`setTableMenuButtonV
On Thu, 11 May 2023 19:39:36 GMT, Marius Hanl wrote:
> This PR changes the `columnPopupMenu`, so that it is created lazily.
>
> The problem here is, that the `columnPopupMenu` is always initialized and
> updated via bindings, even if the table menu button is never shown
> (`setTableMenuButtonV
On Fri, 12 May 2023 11:08:57 GMT, Lukasz Kostyra wrote:
>> This PR changes the `columnPopupMenu`, so that it is created lazily.
>>
>> The problem here is, that the `columnPopupMenu` is always initialized and
>> updated via bindings, even if the table menu button is never shown
>> (`setTableMen
On Thu, 11 May 2023 19:39:36 GMT, Marius Hanl wrote:
> This PR changes the `columnPopupMenu`, so that it is created lazily.
>
> The problem here is, that the `columnPopupMenu` is always initialized and
> updated via bindings, even if the table menu button is never shown
> (`setTableMenuButtonV
On Thu, 11 May 2023 19:39:36 GMT, Marius Hanl wrote:
> This PR changes the `columnPopupMenu`, so that it is created lazily.
>
> The problem here is, that the `columnPopupMenu` is always initialized and
> updated via bindings, even if the table menu button is never shown
> (`setTableMenuButtonV
On Thu, 11 May 2023 19:39:36 GMT, Marius Hanl wrote:
> This PR changes the `columnPopupMenu`, so that it is created lazily.
>
> The problem here is, that the `columnPopupMenu` is always initialized and
> updated via bindings, even if the table menu button is never shown
> (`setTableMenuButtonV
On Fri, 12 May 2023 16:20:35 GMT, Kevin Rushforth wrote:
>>> In this case getWidth() may not be snapped since the titled pane has been
>>> laid out by an unsnapped parent.
>>
>> And when that happens, you can't do anything about it either. If you adjust
>> the width, you risk not covering the
On Wed, 10 May 2023 18:47:16 GMT, Carl Döbbelin wrote:
> Replaced querying of `System.getProperty("os.name")` to check for OS with the
> use of the methods provided by `PlatformUtils`
This pull request has now been integrated.
Changeset: 70953643
Author:Carl Döbbelin
Committer: Marius Han
On Fri, 12 May 2023 15:09:35 GMT, Kevin Rushforth wrote:
> > Looks good. Do you want to replace `HostUtils`'s OS detection with
> > `PlatformUtil` (or were they split on purpose)?
>
> I think this might be a good change, but I'll leave it up to @EstelonAgarwaen
> . To minimize the intrusion, y
On Fri, 12 May 2023 07:49:29 GMT, John Hendrikx wrote:
>> I think once there is an unsnapped parent, all children should probably also
>> be unsnapped (ie. the property should work like the visible property; if I
>> turn it off for one parent, all children become invisible/unsnapped).
>>
>> Th
On Thu, 11 May 2023 20:19:38 GMT, Carl Döbbelin wrote:
>> Replaced querying of `System.getProperty("os.name")` to check for OS with
>> the use of the methods provided by `PlatformUtils`
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revi
On Fri, 12 May 2023 15:28:51 GMT, Carl Döbbelin wrote:
>> Wikipedia says it's currently at the level of macOS Ventura
>>
>> 22.4.0 | March 27, 2023 | macOS 13.3, iOS 16.4, iPadOS 16.4, watchOS 9.4 and
>> tvOS 16.4
>>
>> https://en.wikipedia.org/wiki/Darwin_(operating_system)#Darwin_20_onwards
On Thu, 11 May 2023 20:19:38 GMT, Carl Döbbelin wrote:
>> Replaced querying of `System.getProperty("os.name")` to check for OS with
>> the use of the methods provided by `PlatformUtils`
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revi
> Fixed a memory leak in TreeTableView by reverting to register**Listener
> (which is ok in this particular situation) - the leak is specific to
> TreeTableRowSkin.
>
> Added a unit test.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revisi
On Fri, 12 May 2023 08:13:01 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> one more test case
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java
> line
On Fri, 12 May 2023 08:15:50 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> one more test case
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableRowSkin.java
> line
On Fri, 12 May 2023 15:24:27 GMT, Andy Goryachev wrote:
>> Darwin OS was a precursor of OS X that followed after rhapsody. As its own
>> OS it stopped being supported in 2002. since kevin was discussing to only
>> support MacOS 11 or newer in jfx 21, i think its safe to say we dont support
>>
On Fri, 12 May 2023 15:18:29 GMT, Carl Döbbelin wrote:
>> Do we officially support Darwin OS?
>
> Darwin OS was a precursor of OS X that followed after rhapsody. As its own OS
> it stopped being supported in 2002. since kevin was discussing to only
> support MacOS 11 or newer in jfx 21, i think
On Fri, 12 May 2023 15:15:09 GMT, Andy Goryachev wrote:
>> I initially had the same thought. What this actually highlights, though, is
>> the danger of having this sort of check scattered in multiple places, but
>> done differently. If it was important that "darwin" be recognized (it
>> isn't)
On Fri, 12 May 2023 15:00:55 GMT, Kevin Rushforth wrote:
>> I'd still prefer to use PlatformUtil, since this is a cleaner solution that
>> the variety of methods used before:
>>
>> osNameLowerCase.startsWith("wind"
>> "ios".equals(System.getProperty("os.name")
>> osName.startsWith("Windows"
>>
On Thu, 11 May 2023 20:25:49 GMT, Marius Hanl wrote:
>> The problem here is, that the `AnchorPane` does not use its snapped insets.
>> Therefore, the fix is to replace all `getInsets().getXXX` calls with their
>> corresponding `snappedXXXInset()` methods.
>>
>> Note: The reason the `AnchorPane`
On Thu, 11 May 2023 20:11:07 GMT, Nir Lisker wrote:
> Looks good. Do you want to replace `HostUtils`'s OS detection with
> `PlatformUtil` (or were they split on purpose)?
I think this might be a good change, but I'll leave it up to @EstelonAgarwaen .
To minimize the intrusion, you could just c
> Crashes started happening due to macOS DnD API change from macOS 10.14
> onwards. 10.14 incrodues some [DnD
> constrains](https://developer.apple.com/documentation/macos-release-notes/appkit-release-notes-for-macos-10_14#Drag-and-Drop)
> which our DnD code happened to trigger on some occasions
On Fri, 12 May 2023 14:56:29 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Platform.java line 67:
>>
>>> 65: }
>>> 66:
>>> 67: if (PlatformUtil.isMac()) {
>>
>> this change might be ok, but it is not strictly equivalent.
>> before,
On Fri, 12 May 2023 14:45:43 GMT, Andy Goryachev wrote:
>> Carl Döbbelin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> made launcherimpl one line
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Platform.java line 67:
>
>> 6
On Thu, 11 May 2023 20:19:38 GMT, Carl Döbbelin wrote:
>> Replaced querying of `System.getProperty("os.name")` to check for OS with
>> the use of the methods provided by `PlatformUtils`
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revi
On Thu, 11 May 2023 16:24:20 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/native-glass/mac/GlassDraggingSource.m line
>> 44:
>>
>>> 42: return self->dragOperation;
>>> 43: }
>>> 44:
>>
>> `sourceOperationMaskForDraggingContext` replaces the deprecated
>> `draggingSourc
On Thu, 11 May 2023 17:49:49 GMT, Kevin Rushforth wrote:
>> Good catch (which reminds me that I need to get back to your warnings PR).
>> This might misbehave on macOS 10.12 then, but I haven't seen a machine that
>> old in a few years, so it would be difficult to test.
>>
>> We really should
On Thu, 11 May 2023 20:19:38 GMT, Carl Döbbelin wrote:
>> Replaced querying of `System.getProperty("os.name")` to check for OS with
>> the use of the methods provided by `PlatformUtils`
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revi
On Thu, 11 May 2023 19:39:36 GMT, Marius Hanl wrote:
> This PR changes the `columnPopupMenu`, so that it is created lazily.
>
> The problem here is, that the `columnPopupMenu` is always initialized and
> updated via bindings, even if the table menu button is never shown
> (`setTableMenuButtonV
On Thu, 11 May 2023 20:25:49 GMT, Marius Hanl wrote:
>> The problem here is, that the `AnchorPane` does not use its snapped insets.
>> Therefore, the fix is to replace all `getInsets().getXXX` calls with their
>> corresponding `snappedXXXInset()` methods.
>>
>> Note: The reason the `AnchorPane`
On Mon, 8 May 2023 16:46:54 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/AccessibleAttribute.java
>> line 357:
>>
>>> 355: * @since 21
>>> 356: */
>>> 357: TOGGLE_STATE(Integer.class),
>>
>> Would a dedicated enum be a better choice here?
>
>
On Tue, 9 May 2023 15:08:30 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> co
> Issue:
> CheckBoxTreeItem extends TreeItem and adds a CheckBox.
> The state of this CheckBox is not visible to an accessibility client
> application.
> If we analyze a simple program that contains a CheckBoxTreeItem using a
> windows application "Accessibility Insights for Window", we can notic
> Issue:
> CheckBoxTreeItem extends TreeItem and adds a CheckBox.
> The state of this CheckBox is not visible to an accessibility client
> application.
> If we analyze a simple program that contains a CheckBoxTreeItem using a
> windows application "Accessibility Insights for Window", we can notic
On Thu, 11 May 2023 22:28:27 GMT, Andy Goryachev wrote:
>> Even if you are using weak listeners, `dispose` should remove them.
>
> revered back to using register*Listener, which creates a weak listener and
> also disconnects them in dispose()
I removed this change, and ran the tests, no failure
On Thu, 11 May 2023 22:38:58 GMT, Andy Goryachev wrote:
>> Fixed a memory leak in TreeTableView by reverting to register**Listener
>> (which is ok in this particular situation) - the leak is specific to
>> TreeTableRowSkin.
>>
>> Added a unit test.
>
> Andy Goryachev has updated the pull reque
On Thu, 11 May 2023 20:25:49 GMT, Marius Hanl wrote:
>> The problem here is, that the `AnchorPane` does not use its snapped insets.
>> Therefore, the fix is to replace all `getInsets().getXXX` calls with their
>> corresponding `snappedXXXInset()` methods.
>>
>> Note: The reason the `AnchorPane`
On Thu, 11 May 2023 19:58:46 GMT, Andy Goryachev wrote:
>> I agree but that is also what I do here, isn't it?
>
> here: yes!
This looks good to me, the snapping as explained by Andy is how it should be.
A source of error can be still be that floating point calculations can
introduce small dev
On Fri, 12 May 2023 07:44:04 GMT, John Hendrikx wrote:
>> I wonder.
>>
>> This might be a contrived example: what would happen if the parent
>> containing the TitledPane is unsnapped, but TitledPane is?
>> In this case getWidth() may not be snapped since the titled pane has been
>> laid out by
On Thu, 11 May 2023 23:00:34 GMT, Andy Goryachev wrote:
>> Well, given that we (should) snap everything including the calculation of
>> the width, I expected that the `areaWidth` and `height`, which are basically
>> `getWidth` and `getHeight` are already snapped.
>> That was at least my thinki
81 matches
Mail list logo
