On Mon, 17 Jan 2022 20:25:08 GMT, Martin Fox wrote:
> The Robot implementation on Linux did not consult the current layout when
> mapping from a KeyCode to a hardware code. Internally it retrieved results
> for all the layouts but just picked the first one it saw leading to random
> effects.
- Fixed by checking for `NULL` pointer after memory allocation.
- In `NativeVideoBuffer` `std::nothrow` was added when allocating `jint` array,
so `new` will return `NULL` instead of throwing exception. This done for
consistency and also it is not clear how well JNI handles C++ exceptions in
On Sun, 6 Aug 2023 11:46:32 GMT, Jay Bhaskar wrote:
> Issue : Enabling modern media controls on webkit 616.1 does not load button
> images on HTML5 Video Element
> Solution: Add resources and correct MediaControl Stylesheet
Reviewers: @kevinrushforth @HimaBinduMeda
-
PR Comment:
On Mon, 7 Aug 2023 14:09:51 GMT, Lukasz Kostyra wrote:
>> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()`
>> and before `show()`.
>> Now the `sizeToScene` flag is unset in these methods to ensure the right
>> values are set when the window is shown.
>
>
Clean backport
-
Commit messages:
- Backport af8950e7ebfa1f0705cc9ef5ab50ce25571c00d4
Changes: https://git.openjdk.org/jfx21u/pull/6/files
Webrev: https://webrevs.openjdk.org/?repo=jfx21u=6=00
Issue: https://bugs.openjdk.org/browse/JDK-8313711
Stats: 637 lines in 88 files
On Mon, 7 Aug 2023 14:23:50 GMT, Hima Bindu Meda wrote:
> Clean backport
This pull request has now been integrated.
Changeset: bb6cbae9
Author:Hima Bindu Meda
URL:
https://git.openjdk.org/jfx21u/commit/bb6cbae996a529cd8d8bf30bf7b1c35fa920112e
Stats: 637 lines in 88 files
On Thu, 3 Aug 2023 14:57:50 GMT, Guillaume Tâche wrote:
> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and
> before `show()`.
> Now the `sizeToScene` flag is unset in these methods to ensure the right
> values are set when the window is shown.
Overall LGTM,
On Mon, 24 Jul 2023 18:34:22 GMT, Alexander Zuev wrote:
>> also
>> 8309629: Create implementation of NSAccessibilityRadioButton protocol
>>
>> Create implementation of NSAccessibilityCheckBox and
>> NSAccessibilityRadioButton protocols
>> Add workaround for the wrong focus owner announcement
On Sun, 6 Aug 2023 07:45:54 GMT, Ambarish Rapte wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add newline at the end of the header files.
>
>
On Mon, 7 Aug 2023 09:30:47 GMT, Prasanta Sadhukhan
wrote:
> Since this PR solves issue 2 issues in windows and has not regressed anything
> in mac (behaves same before and after fix), can we commit this and raise a
> windows-toolkit JBS issue for mac to see why render scale is not updated
On Mon, 7 Aug 2023 04:55:23 GMT, Jayathirth D V wrote:
> We should not use stack for array memory allocations in JNI.
> Updated pango.c to use malloc for arrays and release them at appropriate
> places.
Looks good.
One slight clarification:
> We should not use stack for array memory
On Thu, 3 Aug 2023 17:54:48 GMT, Hima Bindu Meda wrote:
> Cherry-picked commits from webkitgtk-2.40.5.
> Verified build on windows, mac and linux. Sanity testing looks fine. No
> issues seen
This pull request has now been integrated.
Changeset: af8950e7
Author:Hima Bindu Meda
URL:
On Mon, 7 Aug 2023 04:18:31 GMT, Hima Bindu Meda wrote:
>> Cherry-picked commits from webkitgtk-2.40.5.
>> Verified build on windows, mac and linux. Sanity testing looks fine. No
>> issues seen
>
> Hima Bindu Meda has updated the pull request incrementally with one
> additional commit since
So far, BorderPane does the calculation for the children min/pref width/height
taken into account only the margin applied to them, if any, but not the total
padding that could be applied as well to the BorderPane itself.
However, this padding needs to be taken into account as well, and this PR
On Thu, 3 Aug 2023 14:57:50 GMT, Guillaume Tâche wrote:
> `setHeight()` / `setWidth()` were ignored if called after `sizeToScene()` and
> before `show()`.
> Now the `sizeToScene` flag is unset in these methods to ensure the right
> values are set when the window is shown.
Don't see any
On Fri, 4 Aug 2023 13:37:10 GMT, Kevin Rushforth wrote:
>> modules/javafx.web/src/main/native/Source/JavaScriptCore/b3/B3DuplicateTails.cpp
>> line 89:
>>
>>> 87:
>>> 88: if (canCopyBlock)
>>> 89: candidates.add(block);
>>
>> The indentation looks off here.
>
> I'll
On Thu, 3 Aug 2023 18:05:52 GMT, Andy Goryachev wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Call updateSceneState with lock and in FX thread
>
>
On Mon, 7 Aug 2023 04:18:31 GMT, Hima Bindu Meda wrote:
>> Cherry-picked commits from webkitgtk-2.40.5.
>> Verified build on windows, mac and linux. Sanity testing looks fine. No
>> issues seen
>
> Hima Bindu Meda has updated the pull request incrementally with one
> additional commit since
On Mon, 7 Aug 2023 08:52:01 GMT, John Hendrikx wrote:
> Are you sure it works correctly on Windows now?
I have tested EmbeddedFrameBug in windows10 with primary scale 1.25 and
secondary scale 1.75 and it worked for me..
-
PR Comment:
On Mon, 7 Aug 2023 08:23:35 GMT, Prasanta Sadhukhan
wrote:
> > > > both windows (using EmbeddedFrameBug class listed earlier) shows O100%
> > > > for primary retina screen (should be 200%).
> > >
> > >
> > > @hjohn Seems like @andy-goryachev-oracle is telling it regressed after
> > >
On Mon, 7 Aug 2023 07:56:27 GMT, John Hendrikx wrote:
> > > both windows (using EmbeddedFrameBug class listed earlier) shows O100%
> > > for primary retina screen (should be 200%).
> >
> >
> > @hjohn Seems like @andy-goryachev-oracle is telling it regressed after
> > `updateSceneState`
On Fri, 4 Aug 2023 06:21:55 GMT, Prasanta Sadhukhan
wrote:
>> When the JavaFX scene is set before it is really shown, then the scale
>> factors are not properly propagated to the EmbeddedWindow, resulting in
>> showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
>
On Thu, 27 Jul 2023 16:59:59 GMT, Andy Goryachev wrote:
> I would love to review this, but for some reason, I could not get Japanese
> IME to work on my windows 11...
Does it work now?
or Can anyone else review this please?
-
PR Comment:
On Fri, 4 Aug 2023 05:46:35 GMT, Prasanta Sadhukhan
wrote:
> both windows (using EmbeddedFrameBug class listed earlier) shows O100% for
> primary retina screen (should be 200%).
@hjohn Seems like @andy-goryachev-oracle is telling it regressed after
`updateSceneState` integration as
On Mon, 7 Aug 2023 04:55:23 GMT, Jayathirth D V wrote:
> We should not use stack for array memory allocations in JNI.
> Updated pango.c to use malloc for arrays and release them at appropriate
> places.
LGTM
-
Marked as reviewed by arapte (Reviewer).
PR Review:
25 matches
Mail list logo
