On Thu, 16 Nov 2023 06:54:04 GMT, Karthik P K wrote:
>> The change listener on caretPositionProperty() was not getting invoked on
>> replacing the content with same text as there was no change in caret
>> position. Since the textProperty invalidation sets the forward bias to true
>> by
Vote: Yes.- MariusAm 16.11.23, 16:54 schrieb Kevin Rushforth :
I hereby nominate Martin Fox [1] to OpenJFX Committer.
Martin is an OpenJFX community member, who has contributed 12 commits
[2] to OpenJFX.
Votes are due by November 30, 2023 at 16:00 UTC.
Only current
Vote: Yes.- MariusAm 16.11.23, 16:39 schrieb Kevin Rushforth :
I hereby nominate Florian Kirmaier [1] to OpenJFX Committer.
Florian is an OpenJFX community member, who has contributed 24 commits
[2] to OpenJFX.
Votes are due by November 30, 2023 at 16:00 UTC.
Only
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote:
> With the help of debug build which pinpointed the crash, I found the commit
> in upstream WebKit core that caused the crash. That commit was subsequently
> reverted not long after it was initially committed. This reverted commit
>
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally
Hi Andy and List,
I did some checking on the internal KeyBinding, and I think it has a
broken hashCode/equals implementation, which if used as part of a map (I
think they aren't currently) would mean it won't find always find the
correct (or any) match with a simple Map#get.
This is because
On Wed, 29 Nov 2023 22:28:56 GMT, Nir Lisker wrote:
> > There are definitely some (preexisting) oddities of how CSS styleable
> > properties are managed. And it's good to examine them in the context of
> > this newly proposed utility method. Having said that, it still seems to me
> > that
For those still interested, I've updated
https://github.com/openjdk/jfx/pull/1265 with a replaced ButtonBehavior
and SpinnerBehavior, using concepts laid out in
https://gist.github.com/hjohn/c7b1bf9d4a4770b1b3ae854b20fbaa94
Any feedback is welcome, I think it's making progress, and the
On Tue, 28 Nov 2023 23:34:30 GMT, Andy Goryachev wrote:
>> Provide a public utility method for use by custom and core Nodes to simplify
>> boilerplate around styleable properties as well as to save some memory.
>>
>>
>> /**
>> * Utility method which combines {@code CssMetaData} items
On Wed, 29 Nov 2023 22:03:49 GMT, Kevin Rushforth wrote:
> I did a quick test instrumenting the destructor with print statements, and
> I'm pretty sure I know why it's crashing. You don't initialize `preferences`
> in the constructor, so the null check in the destructor is reading
>
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request incrementally
On Tue, 28 Nov 2023 23:34:30 GMT, Andy Goryachev wrote:
>> Provide a public utility method for use by custom and core Nodes to simplify
>> boilerplate around styleable properties as well as to save some memory.
>>
>>
>> /**
>> * Utility method which combines {@code CssMetaData} items
On Fri, 24 Nov 2023 19:26:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance
On Tue, 28 Nov 2023 23:34:30 GMT, Andy Goryachev wrote:
>> Provide a public utility method for use by custom and core Nodes to simplify
>> boilerplate around styleable properties as well as to save some memory.
>>
>>
>> /**
>> * Utility method which combines {@code CssMetaData} items
On Mon, 27 Nov 2023 18:30:27 GMT, Andy Goryachev wrote:
> Provide a public utility method for use by custom and core Nodes to simplify
> boilerplate around styleable properties as well as to save some memory.
>
>
> /**
> * Utility method which combines {@code CssMetaData} items in
On Wed, 29 Nov 2023 21:21:43 GMT, Andy Goryachev wrote:
> 3. Adding two pointers to every Node is not a good solution, in my opinion.
> Replacing lazy initialization with a busy one is not a good solution. Am I
> missing something here?
Given that it is a huge hassle to implement your own
On Fri, 24 Nov 2023 19:26:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and stage appearance
On Wed, 29 Nov 2023 21:09:37 GMT, Nir Lisker wrote:
> But it's limited because it has been artificially limited. It's a special
> case of ` List combine(List, T... items)`, which is a general
> utility method. Just duplicating this method for specific `T`'s doesn't make
> it more fitting for
On Tue, 28 Nov 2023 23:34:30 GMT, Andy Goryachev wrote:
>> Provide a public utility method for use by custom and core Nodes to simplify
>> boilerplate around styleable properties as well as to save some memory.
>>
>>
>> /**
>> * Utility method which combines {@code CssMetaData} items
On Wed, 29 Nov 2023 15:54:17 GMT, Andy Goryachev wrote:
> > I'm unconvinced that this is the way to solve the issue it describes in its
> > doc. The problem is that each control wants to add its own css metadata to
> > that of its parent (recursively), and that the list is immutable (or
> >
On Tue, 28 Nov 2023 23:34:30 GMT, Andy Goryachev wrote:
>> Provide a public utility method for use by custom and core Nodes to simplify
>> boilerplate around styleable properties as well as to save some memory.
>>
>>
>> /**
>> * Utility method which combines {@code CssMetaData} items
On Wed, 29 Nov 2023 19:29:20 GMT, Andy Goryachev wrote:
> I do wonder if `combineStyleables` or `ofStyleables` might be a better name
> than just `combine`? I don't have a strong opinion.
That seems like it would be a misnomer. The proposed method combines the
metadata of styleable
On Wed, 29 Nov 2023 19:19:29 GMT, Kevin Rushforth wrote:
> I do wonder if `combineStyleables` or `ofStyleables` might be a better name
> than just `combine`? I don't have a strong opinion.
My initial name was a poor choice, I much prefer @mstr2 's suggestion `combine`
now. I think
On Tue, 28 Nov 2023 23:34:30 GMT, Andy Goryachev wrote:
>> Provide a public utility method for use by custom and core Nodes to simplify
>> boilerplate around styleable properties as well as to save some memory.
>>
>>
>> /**
>> * Utility method which combines {@code CssMetaData} items
On Mon, 27 Nov 2023 20:22:40 GMT, Thorsten Fischer wrote:
>> Hi,
>>
>> I did open the bug report. Some notes to this PR:
>>
>> My colleagues and I are able to reproduce this bug regularly, even though it
>> takes sometimes up to 3 or 4 weeks until the D3DERR_DEVICEHUNG error shows
>> up. We
On Mon, 27 Nov 2023 20:22:40 GMT, Thorsten Fischer wrote:
>> Hi,
>>
>> I did open the bug report. Some notes to this PR:
>>
>> My colleagues and I are able to reproduce this bug regularly, even though it
>> takes sometimes up to 3 or 4 weeks until the D3DERR_DEVICEHUNG error shows
>> up. We
On Tue, 28 Nov 2023 19:00:04 GMT, Kevin Rushforth wrote:
> With the help of debug build which pinpointed the crash, I found the commit
> in upstream WebKit core that caused the crash. That commit was subsequently
> reverted not long after it was initially committed. This reverted commit
>
Thank you Andy.
It looks like a work-around that I can use, but maybe it should be
supported in a plain FilteredList<>.
Em qua., 29 de nov. de 2023 às 15:11, Andy Goryachev <
andy.goryac...@oracle.com> escreveu:
> Found this
>
>
>
>
>
On Mon, 27 Nov 2023 20:22:40 GMT, Thorsten Fischer wrote:
>> Hi,
>>
>> I did open the bug report. Some notes to this PR:
>>
>> My colleagues and I are able to reproduce this bug regularly, even though it
>> takes sometimes up to 3 or 4 weeks until the D3DERR_DEVICEHUNG error shows
>> up. We
Found this
https://stackoverflow.com/questions/17958337/javafx-tableview-with-filteredlist-jdk-8-does-not-sort-by-column
-andy
From: openjfx-dev on behalf of Thiago Milczarek
Sayão
Date: Wednesday, November 29, 2023 at 05:59
To: openjfx-dev
Subject: Should using a FilteredList<> on a
On Mon, 27 Nov 2023 20:22:40 GMT, Thorsten Fischer wrote:
>> Hi,
>>
>> I did open the bug report. Some notes to this PR:
>>
>> My colleagues and I are able to reproduce this bug regularly, even though it
>> takes sometimes up to 3 or 4 weeks until the D3DERR_DEVICEHUNG error shows
>> up. We
On Wed, 29 Nov 2023 15:42:47 GMT, Andy Goryachev wrote:
> > stored in a `CopyOnWriteArrayList`
>
> I am sorry, are you proposing to add two pointers to each Node?
I was responding to Nir, seeing if there is an option to make the entire
management of CSS properties simpler.
> > when Skin
Updated libxslt to v1.1.39. Verified build on all platforms.No issue seen.
-
Commit messages:
- white space corrections
- update version info in libxslt.md
- configure libxslt on linux
- configure libxslt on windows
- update libxslt to v1.1.39
Changes:
On Tue, 19 Sep 2023 11:56:39 GMT, Florian Kirmaier
wrote:
> The Method javafx.print.getWidth and getHeight returns a double of points.
> But the values are always rounded to full integers. This causes especially
> problems,
> with mm based Papers.
>
> I asked in the mailing list, with the
On Wed, 29 Nov 2023 16:09:49 GMT, Michael Strauß wrote:
> This introduces yet another moving part, namely that the list of styleable
> properties can change when the control skin is changed.
This functionality is outside of the scope of this PR, completely unrelated.
The part that is being
On Mon, 27 Nov 2023 20:22:40 GMT, Thorsten Fischer wrote:
>> Hi,
>>
>> I did open the bug report. Some notes to this PR:
>>
>> My colleagues and I are able to reproduce this bug regularly, even though it
>> takes sometimes up to 3 or 4 weeks until the D3DERR_DEVICEHUNG error shows
>> up. We
On Wed, 29 Nov 2023 15:57:46 GMT, Andy Goryachev wrote:
> > when Skin changes happen
>
> can you please explain how Skins have managed to enter the discussion?
> Styleable properties are a part of the Control, they have nothing to do with
> Skins.
Skins seem to be everywhere. In particular,
On Wed, 29 Nov 2023 07:38:45 GMT, John Hendrikx wrote:
> when Skin changes happen
can you please explain how Skins have managed to enter the discussion?
Styleable properties are a part of the Control, they have nothing to do with
Skins.
-
PR Comment:
On Wed, 29 Nov 2023 02:44:31 GMT, Nir Lisker wrote:
> I'm unconvinced that this is the way to solve the issue it describes in its
> doc. The problem is that each control wants to add its own css metadata to
> that of its parent (recursively), and that the list is immutable (or
>
On Wed, 29 Nov 2023 07:38:45 GMT, John Hendrikx wrote:
> stored in a `CopyOnWriteArrayList`
I am sorry, are you proposing to add two pointers to each Node?
-
PR Comment: https://git.openjdk.org/jfx/pull/1296#issuecomment-1832162481
On Mon, 27 Nov 2023 17:07:38 GMT, Martin Fox wrote:
> The changes submitted in PR #1209 broke IME input on macOS 12 and 13 (at
> least on Apple Silicon). Calling charactersByApplyingModifiers on an NSEvent
> alters its state in some way that confuses NSTextInputContext.handleEvent.
> The
Hi,
When using a FiltereList<> on a TableView, column sorting is disabled. Is
it expected?
https://gist.github.com/tsayao/80dd7bb2dfd66d2ec220e27c5ae4017b
-- Thiago.
On Sat, 5 Aug 2023 12:28:16 GMT, Thorsten Fischer wrote:
> Hi,
>
> I did open the bug report. Some notes to this PR:
>
> My colleagues and I are able to reproduce this bug regularly, even though it
> takes sometimes up to 3 or 4 weeks until the D3DERR_DEVICEHUNG error shows
> up. We are
43 matches
Mail list logo
