On Mon, 5 Feb 2024 09:45:25 GMT, Marius Hanl wrote:
> I will review this PR soon as well.
The discussion about a "bigger" solution aside I think the PR is still of value
to improve performance, so I look forward to your review.
-
PR Comment: https://git.openjdk.org/jfx/pull/1358#is
On Tue, 6 Feb 2024 15:53:07 GMT, Andy Goryachev wrote:
> > So maybe we should:
> >
> > * Provide an API that let's the client specify how many rows should be
> > taken into account
> > * Make resizeColumnToFitContent available for clients
>
> Let's create an RFE. What would be your recommendat
On Wed, 24 Jan 2024 14:55:21 GMT, Laurent Bourgès wrote:
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
This pull request has now been integrated.
Changeset: 172c491d
Author:Laurent Bourgès
URL:
https://git.openjdk.org/jfx/commit/172c491dae4b774012589d991c898f
On Tue, 6 Feb 2024 18:09:40 GMT, Andy Goryachev wrote:
> Fails with "Emojis" data set (magenta line indicates where):
>
I forgot to mention that I didn't test with emojis. I wanted to make it work
with text with all scenario and then move to emojis. Now that we have text
related issues fixed,
On Tue, 6 Feb 2024 13:49:13 GMT, Laurent Bourgès wrote:
>> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
>
> minor cleanup to simplify test and fixed impo
Hi Kevin,
my suggestion would be to annotate and document the preview API (at
least annotations do show up by default in most IDEs), and emit a
one-time runtime warning when the API is used (this works for methods
and constructors). This would make it quite visible to developers that
they are usin
On Mon, 21 Aug 2023 21:44:12 GMT, Andy Goryachev wrote:
> Requesting content layout when font changes.
>
> This change makes the visual impact of
> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
> perhaps both bugs should be fixed at the same time.
Reviewers: @ara
On Tue, 6 Feb 2024 21:35:12 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly an
Announcing new features and encouraging testing of those features is a
good idea. We should do that more often, especially in cases where
feedback on the API is important. Developers who are willing to download
the ea builds (SDK or JMODs) can do so right away, since builds are
published weekly
In order for preview features and incubating features to not cause more
problems than they solve, there needs to be a robust way to ensure that
applications and libraries don't use them without knowing that they are
doing so. We know how to do that for a feature that lives in its own
module (an
On Wed, 31 Jan 2024 00:34:57 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in comm
On Tue, 6 Feb 2024 21:38:41 GMT, Andy Goryachev wrote:
> > specific to strike though
>
> I don't think so. I can turn it off and nothing changes, same for underline.
> I am not sure why it all suddenly started to fail - I did a clean build
> twice...
Can you see if the new `TextLayoutTest` sy
Requesting content layout when font changes.
This change makes the visual impact of
[JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
perhaps both bugs should be fixed at the same time.
-
Commit messages:
- Merge branch 'master' into 8307117.wrap
- reque
On Mon, 21 Aug 2023 21:44:12 GMT, Andy Goryachev wrote:
> Requesting content layout when font changes.
>
> This change makes the visual impact of
> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so
> perhaps both bugs should be fixed at the same time.
keep alive
kee
On Tue, 6 Feb 2024 21:35:43 GMT, John Hendrikx wrote:
> specific to strike though
I don't think so. I can turn it off and nothing changes, same for underline.
I am not sure why it all suddenly started to fail - I did a clean build twice...
-
PR Comment: https://git.openjdk.org/j
On Wed, 31 Jan 2024 00:34:57 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in comm
> The SimpleSelector and CompoundSelector classes are public classes in an
> exported package, javafx.css, but they are not intended to be used by
> applications. They are implementation details. They cannot be constructed
> directly and no other JavaFX API accepts or returns a SimpleSelector or
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> It is important to note that even though the constraints are given by the
> user in unsnapped coordinates, they are converted to snapped values,
On Thu, 15 Jun 2023 19:38:00 GMT, Andy Goryachev wrote:
> Modified the resize algorithm to work well with fractional scale, thanks for
> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>
> It is important to note that even though the constraints are given by the
> user in un
On Tue, 30 Jan 2024 00:35:24 GMT, John Hendrikx wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix bug which confused char index with glyph index
>
> I think that it may be wise to do some clean-up of the code su
On Wed, 31 Jan 2024 00:34:57 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in comm
On Tue, 6 Feb 2024 10:31:18 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of
On Tue, 6 Feb 2024 10:31:18 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of
On Tue, 6 Feb 2024 13:49:13 GMT, Laurent Bourgès wrote:
>> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
>
> minor cleanup to simplify test and fixed impo
Hi Andy,
Thank you; yes, that report was also myself via bugreport.java.com, I think
-- I didn't actually realise it ended up anywhere.
The mail I dropped here though is somewhat easier to digest / has less
typos (for anyone interested)!
Kind Regards,
Cormac
On Tue, 6 Feb 2024 at 16:11, Andy
Thank you for reporting the issue!
Is this the same scenario as described in
https://bugs.openjdk.org/browse/JDK-8321323 ?
-andy
From: openjfx-dev on behalf of Cormac Redmond
Date: Monday, February 5, 2024 at 12:31
To: openjfx-dev@openjdk.org
Subject: TreeTableView / FilteredList momentary
On Fri, 2 Feb 2024 13:30:19 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly an
On Tue, 6 Feb 2024 06:24:18 GMT, Robert Lichtenberger
wrote:
> So maybe we should:
>
> * Provide an API that let's the client specify how many rows should be taken
> into account
> * Make resizeColumnToFitContent available for clients
Let's create an RFE.
What would be your recommendation for
I would add that during the 6 month release cycle, there is usually some
time to get new features out in an ea release and receive early feedback
that way. Maybe even in time that it can be incorporated into the next
release if it is reasonable.
In this concrete case there was no ea build avai
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
Laurent Bourgès has updated the pull request incrementally with one additional
commit since the last revision:
minor cleanup to simplify test and fixed imports
-
Changes:
- all: https://git.openjdk.org/jfx/pu
On Mon, 29 Jan 2024 09:09:40 GMT, Karthik P K wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed test package
>
> modules/javafx.graphics/src/main/java/com/sun/marlin/ArrayCacheDouble.java
> line 168:
>
>>
On Tue, 6 Feb 2024 00:06:58 GMT, Laurent Bourgès wrote:
>> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
>
> improved rendez-vous to collect stderr
Provi
On Thu, 1 Feb 2024 09:20:35 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
> conditions were not considered, hence hit test values such as character index
> and insertion index values were incorrect.
>
> Added checks for RTL orientation of nodes and fixed the issue in
> `getHitInfo()` to calculat
Thank you for sharing this info,
I think it can be very interesting for the JavaFX community since most
of us use JPackage to bundle our JavaFX apps :)
Regards,
Davide
Il 05/02/2024 20:03, Kevin Rushforth ha scritto:
For others who might be curious, Davide filed a bug via
bugreport.java.com a
35 matches
Mail list logo
