On Fri, 12 Jul 2024 15:54:24 GMT, Markus Mack wrote:
>> This PR is a fix for another IOOBE that I discovered while working on #1476.
>>
>> The PR simplifies the code for adding a series that already contains data by
>> adding the data points one-by-one.
>>
g the duplicate data items resulting from
> multiplying by 0.
> Without this change `testSeriesRemoveAnimatedStyleClasses` would fail because
> it counts the number of plot children, where the duplicates are now removed.
Markus Mack has updated the pull request incrementally with one add
g the duplicate data items resulting from
> multiplying by 0.
> Without this change `testSeriesRemoveAnimatedStyleClasses` would fail because
> it counts the number of plot children, where the duplicates are now removed.
Markus Mack has updated the pull request with a new target base du
On Mon, 24 Jun 2024 22:10:38 GMT, Markus Mack wrote:
> This PR is a fix for another IOOBE that I discovered while working on #1476.
>
> The PR simplifies the code for adding a series that already contains data by
> adding the data points one-by-one.
> As far as I can
I'd say this is a good idea. Both variants are good, we might want to
mention CSS in the first one, though.
Not sure how others do it, but I regularly struggle to find out which
code properties correspond to which CSS styles. This is particularly the
case for names like "background",
On Thu, 27 Jun 2024 20:22:24 GMT, Markus Mack wrote:
> This PR fixes the placement of `BarChart` bars and category tick marks,
> particularly when adding data / multiple series and enabling animations.
> It covers all cases mentioned in the JBS ticket and adds a unit test.
>
&g
ituation as well.
>
> Note this does not fix
> [JDK-8334873](https://bugs.openjdk.org/browse/JDK-8334873) where bars get
> stuck while having different widths. There seem to be additional issues which
> seem not directly related to the changed code and are probably out of scope
>
This PR fixes the placement of `BarChart` bars and category tick marks,
particularly when adding data / multiple series and enabling animations.
It covers all cases mentioned in the JBS ticket and adds a unit test.
The settable `barGap` and `categoryGap` now should also behave as expected.
On Tue, 25 Jun 2024 15:14:14 GMT, Markus Mack wrote:
> This PR ensures the `tickMarksUpdated()` method (overriden with minor tick
> mark layout code in subclasses) is called during `Chart` `Axis` layout when
> needed.
> Previously, it was only called when tick mark length or range
lues, which would need to be made at least
> package-private however (with a shim). This implementation checks the tick
> mark `Path` shape instead, which is already publicly accessible (but could be
> considered an implementation detail).
Markus Mack has updated the pull request incre
On Tue, 25 Jun 2024 22:48:26 GMT, Marius Hanl wrote:
>> Markus Mack has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - cleanup imports
>> - add clarifying comment to test
>
> modules/javafx.controls/s
On Tue, 25 Jun 2024 21:51:36 GMT, Andy Goryachev wrote:
>> I think we need to create that as it turned out it's not the same as the
>> minor tick problem fixed by this PR.
>
> but wait: this may not be a different issue. I see a slightly different
> behavior relative to the master branch:
>
On Tue, 25 Jun 2024 21:43:58 GMT, Andy Goryachev wrote:
>> yes, the BarChart issue (which I actually want to get fixed) will need
>> additional fixes in other classes. I could add those to this PR, but
>> probably it's best to handle them in another ticket+PR to keep this PR
>> affecting all
lues, which would need to be made at least
> package-private however (with a shim). This implementation checks the tick
> mark `Path` shape instead, which is already publicly accessible (but could be
> considered an implementation detail).
Markus Mack has updated the pull request increm
On Tue, 25 Jun 2024 20:06:29 GMT, Andy Goryachev wrote:
>> Markus Mack has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - cleanup imports
>> - add clarifying comment to test
>
> modules/javafx.contr
This PR ensures the `tickMarksUpdated()` method (overriden with minor tick mark
layout code in subclasses) is called during `Chart` `Axis` layout when needed.
Previously, it was only called when tick mark length or range was changed,
which is not happening during axis animations, causing minor
This PR is a fix for another IOOBE that I discovered while working on #1476.
The PR simplifies the code for adding a series that already contains data by
adding the data points one-by-one.
As far as I can see no attempt was previously made to optimize the bulk
operation except for some trivial
On Sat, 22 Jun 2024 10:55:28 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a
On Fri, 21 Jun 2024 16:11:52 GMT, Markus Mack wrote:
> This PR makes the `XYChart` axes properties return the correct parent XYChart
> object.
This pull request has now been integrated.
Changeset: 17c2dba0
Author:Markus Mack
Committer: Andy Goryachev
URL:
https://git.openj
On Wed, 19 Jun 2024 10:21:52 GMT, Markus Mack wrote:
> This PR provides the test case given in the JBS issue, and a simple fix for
> the index calculation when inserting data after previous data with duplicate
> categories.
>
> Also, I've added a comment to `BarChart`s java
On Sat, 22 Jun 2024 10:55:28 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a
vious code already loops over all
> categories to check if they are present, typically nested in a loop adding
> many data items, thus already scaling quadratically when adding lots of
> mostly unique data points.
Markus Mack has updated the pull request incrementally with one addition
On Fri, 21 Jun 2024 22:07:22 GMT, Andy Goryachev wrote:
>> Markus Mack has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> testAddingDataAtIndex & fix
>
> modules/javafx.controls/src/main/java/javafx/sce
On Fri, 21 Jun 2024 15:22:41 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a
vious code already loops over all
> categories to check if they are present, typically nested in a loop adding
> many data items, thus already scaling quadratically when adding lots of
> mostly unique data points.
Markus Mack has updated the pull request incrementally with one
On Fri, 21 Jun 2024 16:11:52 GMT, Markus Mack wrote:
> This PR makes the `XYChart` axes properties return the correct parent XYChart
> object.
in `StackedAreaChart` there's another one
-
PR Comment: https://git.openjdk.org/jfx/pull/1485#issuecomment-2183103384
> This PR makes the `XYChart` axes properties return the correct parent XYChart
> object.
Markus Mack has updated the pull request incrementally with one additional
commit since the last revision:
Set correct bean for properties in AreaChart / StackedAreaChart
-
C
This PR makes the `XYChart` axes properties return the correct parent XYChart
object.
-
Commit messages:
- XYChart: Set correct bean of axes properties
Changes: https://git.openjdk.org/jfx/pull/1485/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=1485=00
Issue:
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a
vious code already loops over all
> categories to check if they are present, typically nested in a loop adding
> many data items, thus already scaling quadratically when adding lots of
> mostly unique data points.
Markus Mack has updated the pull request incrementally with one
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a
On Thu, 20 Jun 2024 17:44:41 GMT, Markus Mack wrote:
>> This PR provides the test case given in the JBS issue, and a simple fix for
>> the index calculation when inserting data after previous data with duplicate
>> categories.
>>
>> Also, I've added a
On Thu, 20 Jun 2024 17:59:13 GMT, Andy Goryachev wrote:
>> You'll need to add an additional point after adding the one with duplicate
>> categories to see the exception in the console. Using the "Add Point" button
>> in the monkey tester after using the context menu entry should reproduce the
On Thu, 20 Jun 2024 16:52:49 GMT, Andy Goryachev wrote:
>> However, I don't see the issue if I just add a duplicate data point after
>> the chart is rendered (the code jumps to line 218 (edit: 216, sorry) in the
>> master branch).
>>
>> This makes me think that perhaps the fix should include
vious code already loops over all
> categories to check if they are present, typically nested in a loop adding
> many data items, thus already scaling quadratically when adding lots of
> mostly unique data points.
Markus Mack has updated the pull request incrementally with one
On Wed, 19 Jun 2024 10:21:52 GMT, Markus Mack wrote:
> This PR provides the test case given in the JBS issue, and a simple fix for
> the index calculation when inserting data after previous data with duplicate
> categories.
>
> Also, I've added a comment to `BarChart`s java
This PR provides the test case given in the JBS issue, and a simple fix for the
index calculation when inserting data after previous data with duplicate
categories.
Also, I've added a comment to `BarChart`s javadoc, clarifying the behavior that
was apparently assumed (but broken) previously.
On Wed, 5 Jun 2024 21:59:13 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://www.w3.org/TR/css-transitions-1/).
>>
>> ### Future enhancements
>> CSS transition support for backgrounds and borders: #1471
>>
>> ### Limitations
>> This implementation supports both
On Tue, 21 May 2024 14:25:51 GMT, Michael Strauß wrote:
> This PR fixes a bug
> ([JDK-8289115](https://bugs.openjdk.org/browse/JDK-8289115)) that was
> introduced with #394, which changed the following line in the
> `NotifyTouchInput` function (ViewContainer.cpp):
>
> - const bool isDirect =
I'd love to see this feature in JavaFX. This would allow for much
cleaner (and better reusable) implementations of modern-looking UI which
I'd like to have for current and future JavaFX projects. In the current
state of JavaFX, you'd usually need to roll your own custom control
skins which is
40 matches
Mail list logo
