Re: Eclipse and Gradle in OpenJFX

2024-06-18 Thread Thiago Milczarek Sayão
Andy, We kind of did the opposite for Intellij (got rid of the .iml files and went for gradle import): https://github.com/openjdk/jfx/pull/1009 I couldn't get it to detect the manual tests tho. Changing some gradle files worked, but would require a deeper review, so we went without it. --

Platform diferences

2024-06-17 Thread Thiago Milczarek Sayão
. -- Thiago -- Forwarded message - De: Andy Goryachev Date: seg., 17 de jun. de 2024 às 16:51 Subject: Re: [openjdk/jfx] 833: Linux Debian: Maximized stage shrinks when opening another stage (PR #1460) To: openjdk/jfx Cc: Thiago Milczarek Sayão , Mention < m

Toolkit Window Decorations

2024-05-23 Thread Thiago Milczarek Sayão
Hi, At some point we will need "Client Side" decorations on JavaFX to support modern gnome desktop on Linux as they moved to have client side decorations on everything. Mutter (the gnome compositor) does not even support "server side" decorations. On Wayland it's an extension for KDE only.

Re: [External] : Re: Wayland

2024-04-30 Thread Thiago Milczarek Sayão
Rushforth < kevin.rushfo...@oracle.com> escreveu: > Thank you. > > -- Kevin > > > On 4/29/2024 2:35 PM, Thiago Milczarek Sayão wrote: > > I thought about possible legal conflicts. > > The code is on my github - I'm exploring and testing before starting the > r

Re: Wayland

2024-04-29 Thread Thiago Milczarek Sayão
you > create a PR. > > -- Kevin > > > On 4/28/2024 2:45 PM, Thiago Milczarek Sayão wrote: > > Hi, > > I managed to display a very basic wayland toplevel surface from java: > https://github.com/tsayao/glass-wayland > > If you are using intellij, just run the

Re: Wayland

2024-04-28 Thread Thiago Milczarek Sayão
e a shared memory :) Credits to (I adapted it to ouput jextract compatible code): https://github.com/gfxstrand/wayland-java/tree/master/scanner Cheers Em ter., 23 de abr. de 2024 às 09:11, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > I'm doing some work here: > htt

Re: shutdown after test

2024-04-24 Thread Thiago Milczarek Sayão
I don't know if it's related. But when running systemTests with Robot, it gets stuck on a Swing test - it never exits. Em qua., 24 de abr. de 2024 às 08:42, Johan Vos escreveu: > While working on the systemtests for the Headless platform, I noticed > timing issues with the Marlin QPath Test.

Re: parallel threads when building webkit

2024-04-24 Thread Thiago Milczarek Sayão
Johan, I often have to try to build it a few times before it succeeds (on Linux). And I used an old Ryzen 7 1700X with 16 threads, 16GB. I have now upgraded it, but I haven't built webkit yet. I'm really scared of it :) So limiting the threads seems like a good idea. Em qua., 24 de abr. de

Re: Wayland

2024-04-23 Thread Thiago Milczarek Sayão
eshold= >> 0 {product} {default} >> intx Tier3CompileThreshold= >> 2000 {product} {default} >> intx Tier4CompileThreshold =

Re: Wayland

2024-04-22 Thread Thiago Milczarek Sayão
to request code >> reviews with FFM and have it ready for integration by Java 25. >> >> On Mon, Apr 22, 2024 at 5:49 PM Thiago Milczarek Sayão < >> thiago.sa...@gmail.com> wrote: >> >>> I was just experimenting, but it seems to be less work th

Re: Wayland

2024-04-22 Thread Thiago Milczarek Sayão
everything to JNI. -- Thiago. Em seg., 22 de abr. de 2024 às 11:21, Kevin Rushforth < kevin.rushfo...@oracle.com> escreveu: > Note also that we cannot use Panama in the JavaFX internals yet, since > the minimum version of the JDK is 21. > > -- Kevin > > > On 4/21/2024

Re: Wayland

2024-04-21 Thread Thiago Milczarek Sayão
uide for jextract at > https://github.com/openjdk/jextract/blob/master/doc/GUIDE.md. When > working with complex headers (includes upon includes), it's important to > specify the correct target header. > > On Sun, Apr 21, 2024 at 11:35 PM Thiago Milczarek Sayão < >

Re: Wayland

2024-04-21 Thread Thiago Milczarek Sayão
the events with wl_registry_add_listener, but currently the code generation for this is not working. Em dom., 21 de abr. de 2024 às 16:39, Nir Lisker escreveu: > What are wl_ types? jextract only supports c headers. > > On Sun, Apr 21, 2024 at 10:31 PM Thiago Milczarek Sayão <

Wayland

2024-04-21 Thread Thiago Milczarek Sayão
Hi, I did a small test app to explore Wayland client and portals (for Robot and dialogs such as file open/save). https://github.com/tsayao/wayland-test/blob/main/wayland-test.c It seems it will work as a glass backend, but some walls will be hit on the way :) I have tried to use jextract (from

Re: Possible leak on setOnAction

2024-04-21 Thread Thiago Milczarek Sayão
else I didn't find. That's my theory for now. Em sáb., 20 de abr. de 2024 às 10:47, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > Yeah, I've been doing some investigating. > > Using the below example, when the "Refresh Menu" button is clicked, it > w

Re: Possible leak on setOnAction

2024-04-20 Thread Thiago Milczarek Sayão
also be GC'd. They are > however much smaller, so as long as they don't reference a Stage it is > probably not noticeable memory wise. > > An inspection with VisualVM should give an answer (or you could make a > MenuItem very large by attaching some huge objects to it that are not > referen

Re: Possible leak on setOnAction

2024-04-19 Thread Thiago Milczarek Sayão
; from the menu item's eventHandler, shouldn't it? > > > > -andy > > > > *From: *openjfx-dev on behalf of Thiago > Milczarek Sayão > *Date: *Friday, April 19, 2024 at 05:47 > *To: *John Hendrikx > *Cc: *openjfx-dev@openjdk.org > *Subject: *Re: Possible lea

Re: Possible leak on setOnAction

2024-04-19 Thread Thiago Milczarek Sayão
memory. > > I'd look into the above first before trying other solutions. > > --John > > > On 18/04/2024 17:50, Thiago Milczarek Sayão wrote: > > I was investigating, > > It probably should be menuItem.setOnAction(new WeakEventHandler<>(e -> > stage.

Re: Possible leak on setOnAction

2024-04-18 Thread Thiago Milczarek Sayão
ler { > > private final Stage stage; > > public $1(Stage s) { > > this.stage = s; // holds the reference and causes the leak > > } > > public void handle(ActionEvent ev) { > > stage.toFront(); > > } > > } > > > > -andy

Possible leak on setOnAction

2024-04-18 Thread Thiago Milczarek Sayão
Hi, I'm pretty sure setOnAction is holding references. I have a "Open Windows" menu on my application where it lists the Stages opened and if you click, it calls stage.toFront(): menuItem.seOnAction(e -> stage.toFront()) I had many crash reports, all OOM. I got the hprof files and analyzed

Re: What about 5000 issues?

2024-04-17 Thread Thiago Milczarek Sayão
Pavel, There are companies that offers paid support, like Gluon. It's an open source project, you can also submit a fix. -- Thiago Em qua., 17 de abr. de 2024 04:46, PavelTurk escreveu: > Hello all. > > I've been using JavaFX for a long time. JavaFX is great, but unfortunately > rather

Re: [openjdk/jfx] Draft: Prefer EGL over GLX to allow further development towards Wayland (PR #1381)

2024-04-02 Thread Thiago Milczarek Sayão
Thanks Lukasz. ll look into the points brought up. I'm unsure on scenarios where GLX will work and EGL will not, but Gtk has GLX fallback. I will look into it (maybe ask on a Mesa development channel). The force flag is a nice idea. It's not a formal JBS issue yet because I don't know if it fits

Re: Prefer EGL over GLX on Linux

2024-04-01 Thread Thiago Milczarek Sayão
I was looking for comments :) Em dom., 31 de mar. de 2024 às 18:34, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > Hi, > > I am doing some efforts here: > https://github.com/openjdk/jfx/pull/1381 > > Why? > > This is initial Wayland support work, sin

Prefer EGL over GLX on Linux

2024-03-31 Thread Thiago Milczarek Sayão
Hi, I am doing some efforts here: https://github.com/openjdk/jfx/pull/1381 Why? This is initial Wayland support work, since it will require EGL to draw to a Wayland surface. EGL is also supported on Xorg. The idea is to prefer EGL and fallback to GLX as it's done in Gtk, for example. I don't

Project Wakefield

2024-03-24 Thread Thiago Milczarek Sayão
Hi, I watched the presentation of Project Wakefield: https://youtu.be/5gfZDx6IOD4?si=vusIcnKGFLzO8IfG Doing it on JavaFX would be much much easier. Rendering thru es2 works by just replacing GLX with EGL. Then the glass events we just replace GTK with Wayland-client. Project Wakefield came

Re: UI scaling issues when physical and logical screen resolutions differ on Linux

2024-02-23 Thread Thiago Milczarek Sayão
Christopher, -Dglass.gtk.uiScale=`gsettings get org.gnome.desktop.interface text-scaling-factor` Probably works. Em qua., 21 de fev. de 2024 às 01:57, Christopher Schnick < crschn...@xpipe.io> escreveu: > So I tested this on my Asahi Fedora Linux KDE setup. So you were right > about the

Re: Proposal: RichTextArea Control (Incubator)

2024-02-23 Thread Thiago Milczarek Sayão
This is a good point, Martin. I would expect the JavaFX RTA to be basic, but extendable - to allow companies to offer commercial options for particular needs based on it. I don't see a single RTA component that would be useful for every need. Use case examples (that I could think of): - An IDE

[Linux] JavaFX is displaying unicode characters incorrectly

2024-02-22 Thread Thiago Milczarek Sayão
Hi, This possible bug is reported here: https://bugs.openjdk.org/browse/JDK-8322251 Running the code bellow produces incorrect text on Ubuntu 24.04 (still not released). I would like to fix it, but some hints would be appreciated. I might be missing a font, but the same text render fine on GTK

Re: Info on OpenJFX architecture

2023-12-26 Thread Thiago Milczarek Sayão
Hi Keerthivasan, Answers below. Em ter., 26 de dez. de 2023 às 15:32, Keerthivasan Raghavan < mail2akas...@gmail.com> escreveu: > Hi All, > > I am a newbie to the desktop/embedded linux graphics and widget toolkit. > > The following is a list of questions about how OpenJFX is >

Re: EGL on JavaFX/X11

2023-12-26 Thread Thiago Milczarek Sayão
Hi, For anyone interested: https://github.com/tsayao/jfx/tree/egl It's just a quick port to make it run, still needs work. Em seg., 25 de dez. de 2023 às 19:54, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > Hi, > > I did manage to run JavaFX with EGL on Linu

EGL on JavaFX/X11

2023-12-25 Thread Thiago Milczarek Sayão
Hi, I did manage to run JavaFX with EGL on Linux/X11. It's required for Wayland. Would it be useful to anticipate it for X11? Using the 3DLighting sample I did not see any significant performance differences. Gtk: https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540 Firefox:

Compiling Plataform Preferences on Ubuntu 16.04

2023-12-18 Thread Thiago Milczarek Sayão
Hi, I get some compilation errors when building JavaFX on Ubuntu 16.04, which seems related to the newly introduced Platform preferences API. Should we bother to make it work? In file included from

Unicode characters on JavaFx with latest Ubuntu

2023-12-17 Thread Thiago Milczarek Sayão
Hi, I've reported this bug: https://bugs.openjdk.org/browse/JDK-8322251 Unicode characters are being displayed as "generic squares" on JavaFx on Ubuntu 23.10. Any ideas where I should look into it? -- Thiago.

Re: The crisp fonts saga

2023-12-12 Thread Thiago Milczarek Sayão
The dates don't match since the change is from 4 months ago and 23.04 was released on April. So it was some other change. Em ter., 12 de dez. de 2023 13:03, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > Fonts started to look better on Ubuntu 23.04 > > https://g

Re: The crisp fonts saga

2023-12-12 Thread Thiago Milczarek Sayão
Fonts started to look better on Ubuntu 23.04 https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/6190 May be related to this change. Em ter., 12 de dez. de 2023 11:10, Mark Raynsford escreveu: > Hello! > > I've never been particularly satisfied with the font rendering in > JavaFX. In

Re: Reflective discovery of styleable properties

2023-12-06 Thread Thiago Milczarek Sayão
Hi, Maybe it could generate the boilerplate like Lombok does? So it has the benefits of eliminating error-prone boilerplate code and the benefits of not having the cost of reflection at runtime. -- Thiago. Em qua., 6 de dez. de 2023 às 10:28, John Hendrikx escreveu: > I also like this route,

Re: Reflective discovery of styleable properties

2023-12-05 Thread Thiago Milczarek Sayão
Hi, Reflection is probably already being used in JavaFX and I think it's probably fine, but there's the case of graalvm native compiled JavaFX apps. -- Thiago. Em ter., 5 de dez. de 2023 às 08:42, John Hendrikx escreveu: > It looks good, and IMHO would be a major clean up, and would simplify

Re: Should using a FilteredList<> on a TableView disable column sorting?

2023-11-29 Thread Thiago Milczarek Sayão
.com/questions/17958337/javafx-tableview-with-filteredlist-jdk-8-does-not-sort-by-column > > > > -andy > > > > *From: *openjfx-dev on behalf of Thiago > Milczarek Sayão > *Date: *Wednesday, November 29, 2023 at 05:59 > *To: *openjfx-dev > *Subject: *Should usin

Should using a FilteredList<> on a TableView disable column sorting?

2023-11-29 Thread Thiago Milczarek Sayão
Hi, When using a FiltereList<> on a TableView, column sorting is disabled. Is it expected? https://gist.github.com/tsayao/80dd7bb2dfd66d2ec220e27c5ae4017b -- Thiago.

Re: ESC key binding on the Scene

2023-11-21 Thread Thiago Milczarek Sayão
tform.runLater() > > > > What do you think? > > > > -andy > > > > > > *From: *openjfx-dev on behalf of Thiago > Milczarek Sayão > *Date: *Tuesday, November 21, 2023 at 02:37 > *To: *openjfx-dev > *Subject: *ESC key binding on the Scene > > H

Re: JavaFX 21.0.2 will be closed for fixes on December 4th

2023-11-21 Thread Thiago Milczarek Sayão
Hi Kevin, Some folks from the JabRef project asked to backport this: https://github.com/openjdk/jfx/pull/1173 JabRef project issue: https://github.com/JabRef/jabref/issues/5867 I don't know if it fits the backport rationale. -- Thiago. Em seg., 20 de nov. de 2023 às 21:59, Kevin Rushforth

ESC key binding on the Scene

2023-11-21 Thread Thiago Milczarek Sayão
Hi, I would like to use ESC to close Stages. The problem is that if the focus is on a TextField, it consumes the event. ESC is the key binding to Undo on the TextField, but it's always consumed, even if there's nothing to undo. Is this correct? Should it not propagate if there's nothing to

Re: Wayland

2023-11-19 Thread Thiago Milczarek Sayão
3 às 07:57, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > Hi, > > It seems there are some opportunities to explore with Wayland: > > For kiosks (Ubuntu frame): > https://mir-server.io/ > > https://wayland.app/protocols/ > There are some inter

Re: CFV: New OpenJFX Committer: Martin Fox

2023-11-16 Thread Thiago Milczarek Sayão
Vote: Yes Em qui., 16 de nov. de 2023 12:54, Kevin Rushforth < kevin.rushfo...@oracle.com> escreveu: > I hereby nominate Martin Fox [1] to OpenJFX Committer. > > Martin is an OpenJFX community member, who has contributed 12 commits > [2] to OpenJFX. > > Votes are due by November 30, 2023 at

Re: CFV: New OpenJFX Committer: Florian Kirmaier

2023-11-16 Thread Thiago Milczarek Sayão
Vote: Yes Em qui., 16 de nov. de 2023 12:38, Kevin Rushforth < kevin.rushfo...@oracle.com> escreveu: > I hereby nominate Florian Kirmaier [1] to OpenJFX Committer. > > Florian is an OpenJFX community member, who has contributed 24 commits > [2] to OpenJFX. > > Votes are due by November 30, 2023

Re: Wayland

2023-11-16 Thread Thiago Milczarek Sayão
vements and keys). -- Thiago Em sex., 10 de nov. de 2023 às 09:43, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > Hi Johan, > > Robot will be a challenge. > > For mouse and keyboard simulation this could work: > https://www.kernel.org/doc/html/v4.12/input/uin

Re: My JavaFX Christmas Wishlist

2023-11-15 Thread Thiago Milczarek Sayão
Hi, I would choose: - Wayland - Vulkan rendering - Copyable labels - A pay raise for Kevin :) Em qua., 15 de nov. de 2023 07:25, Dirk Lemmermann escreveu: > Hi guys, > > I already mentioned this at the JavaFX BOF at DEVOXX and also posted this > on Twitter but wanna make sure it gets

Re: Wayland

2023-11-10 Thread Thiago Milczarek Sayão
> > The main worry I had in the past was how to deal with the robot, where we > need to get pixels from the screen -- did you tackle that? > > - Johan > > On Fri, Nov 3, 2023 at 1:14 AM Thiago Milczarek Sayão < > thiago.sa...@gmail.com> wrote: > >> Hi, >&g

Re: Wayland

2023-11-02 Thread Thiago Milczarek Sayão
for the use of another toolkit (outside of the gtk rendering scope). wayland-client, here I go. -- Thiago. Em sáb., 21 de out. de 2023 às 18:12, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > EGL is the way to go for Linux on Wayland and X11. > > I don't

Re: Making the Stages MODAL by using native modality functionality

2023-11-02 Thread Thiago Milczarek Sayão
Hi, Hold on this question, it might not be necessary. Looking into it. Em qui., 2 de nov. de 2023 às 10:21, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > Hi, > > On Linux, the current behavior of SetEnabled(true / false) does not work > very well. > Ideally

Making the Stages MODAL by using native modality functionality

2023-11-02 Thread Thiago Milczarek Sayão
Hi, On Linux, the current behavior of SetEnabled(true / false) does not work very well. Ideally it should use native MODALITY. On GTK MODAL means APPLICATION_MODAL. MODAL as in JavaFX would be archived by using Window groups: https://docs.gtk.org/gtk3/ctor.WindowGroup.new.html I would make

Re: Several GTK issues on latest Ubuntu release

2023-10-24 Thread Thiago Milczarek Sayão
; Application.start. Also, in this case it's not really about the scene > dimensions, the stage doesn't even apply its own dimensions that were > explicitly set before. > On 10/23/2023 4:39 PM, Thiago Milczarek Sayão wrote: > > Forgot to mention: except for the system tray, I'm not looking in

Re: Several GTK issues on latest Ubuntu release

2023-10-23 Thread Thiago Milczarek Sayão
Forgot to mention: except for the system tray, I'm not looking into that. Em seg., 23 de out. de 2023 11:36, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > Hi Cristopher, > > https://github.com/openjdk/jfx/pull/1249 > > We noticed it and I'm working on a fix.

Re: Several GTK issues on latest Ubuntu release

2023-10-23 Thread Thiago Milczarek Sayão
Hi Cristopher, https://github.com/openjdk/jfx/pull/1249 We noticed it and I'm working on a fix. There's one issue that is probably a mutter bug: https://gitlab.gnome.org/GNOME/mutter/-/issues/3092 -- Thiago Em seg., 23 de out. de 2023 10:05, Christopher Schnick escreveu: > Hello, > > a

Re: Wayland

2023-10-21 Thread Thiago Milczarek Sayão
-the-linux-graphics-stack-from-glx-to-egl/ https://blogs.igalia.com/carlosgc/2023/04/03/webkitgtk-accelerated-compositing-rendering/ https://blog.gtk.org/2021/05/10/adventures-in-graphics-apis/ It's been nice to learn. Em seg., 16 de out. de 2023 20:51, Thiago Milczarek Sayão < thiago

Exploring the prism es2 land - couple of questions

2023-10-20 Thread Thiago Milczarek Sayão
Hi, I have some questions on prism es2. 1) Why is a Context created on each platform GLFactory if there is a GLContext? 2) What is the use of the Dummy Window? I'm working on using EGL instead of GLX, so it will work on Wayland. Thanks.

Re: Wayland

2023-10-16 Thread Thiago Milczarek Sayão
or a wl_display. -- Thiago. Em dom., 15 de out. de 2023 às 16:06, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > Hi, > > Update: It now works on wayland with -Dprism.order=sw > > > > Em dom., 15 de out. de 2023 às 10:49, Thiago Milczarek Sayão < > thiago.s

Re: Wayland

2023-10-15 Thread Thiago Milczarek Sayão
Hi, Update: It now works on wayland with -Dprism.order=sw Em dom., 15 de out. de 2023 às 10:49, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > Hi, > > https://github.com/openjdk/jfx-sandbox/tree/tsayao_wayland > > I did some experiments here. So far, so good

Wayland

2023-10-15 Thread Thiago Milczarek Sayão
Hi, https://github.com/openjdk/jfx-sandbox/tree/tsayao_wayland I did some experiments here. So far, so good. 1) Replaced GDK events for Gtk Signals - It's the way to go for newer gtk. 2) Replaced drawing directly in the window and added a GtkDrawingArea with a GtkHeaderBar which allows control

Re: How to request javafx pixels rather than receiving it?

2023-10-14 Thread Thiago Milczarek Sayão
Hi, Please, ignore. I've found a solution with the existing flow. Em sáb., 14 de out. de 2023 às 14:44, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > Hi, > I'm doing some experimenting on new ways to implement the gtk glass > backend (mainly targeting wayland suppo

How to request javafx pixels rather than receiving it?

2023-10-14 Thread Thiago Milczarek Sayão
Hi, I'm doing some experimenting on new ways to implement the gtk glass backend (mainly targeting wayland support). JavaFX View implementations receives the data to be drawn. I want to be able to request it synchronously. If JavaFX needs to paint I need it to request the glass backend without

Fix Scene colors for the colorblind

2023-09-28 Thread Thiago Milczarek Sayão
Hi, Wild question coming. Has anyone dealt with Scene colors for people that are color blind? We have some warning icons that are red that sometimes end up on a green background. Ideas welcome. Thanks.

Accessibility on Linux

2023-08-29 Thread Thiago Milczarek Sayão
Hi, The company I work for has some people with low vision. The main complaint is that the text cursor is not followed on screen amplification (ZOOM). I did a quick look and ATK (Accessibility Toolkit) might handle this. Would this contribution be welcomed? I still don't know the amount of

Vulkan

2023-06-22 Thread Thiago Milczarek Sayão
Hi, Just curiosity. Would a Vulkan implementation offer any improvement over OpenGL in the case of JavaFX? I see that GTK has a Vulkan pipeline. Wayland too, it feels so fast and fluid. And why metal and not Vulkan since it's cross platform and metal isn't? Warning: It may be a stupid

Re: Platform preferences API

2023-06-16 Thread Thiago Milczarek Sayão
rectly to the clicked > spot. Skins could use those kinds of non-visual preferences in the > future. > > > On Fri, Jun 16, 2023 at 2:09 AM Thiago Milczarek Sayão > wrote: > > > > I think we should wait and don't do this in the short term. > > > > Man

Re: Platform preferences API

2023-06-15 Thread Thiago Milczarek Sayão
I think we should wait and don't do this in the short term. Many recent apps don't care for platform appearance at all. Take Microsoft windows for an example, there are many layers of "evolution" and they all look different on the same OS. Linux will be a nightmare, you have many desktop

Re: [External] : Text Surrounding

2023-06-11 Thread Thiago Milczarek Sayão
> Let me ask another question: is the current IME support in > TextArea/TextField adequate? > > > > Thank you > > -andy > > > > > > > > > > *From: *Thiago Milczarek Sayão > *Date: *Friday, June 9, 2023 at 03:54 > *To: *Andy Goryachev , openjfx-

Re: [External] : Text Surrounding

2023-06-10 Thread Thiago Milczarek Sayão
east I can ask one question regarding the "surrounding" > feature: how much text does it expect from the control? Is one line or > paragraph enough? > > > > Let me ask another question: is the current IME support in > TextArea/TextField adequate? > > > >

Intellij Idea project gradle import bug

2023-06-09 Thread Thiago Milczarek Sayão
Hi, The systemTests module is not being correctly imported on Intellij, so I reported a bug here: https://youtrack.jetbrains.com/issue/IDEA-322108/Intellij-Idea-fails-to-import-JavaFx-gradle-project-correctly Just letting Idea users know. -- Thiago.

Text Surrounding

2023-06-09 Thread Thiago Milczarek Sayão
Hi Andy, I understand you're working on a Rich Text control. While working on IME (Input Method Editor) for Linux, I noticed that there is a feature called "surrounding" that it supports to give the IME information about the text being inputted. More info here:

Re: How to run an app headless?

2023-06-09 Thread Thiago Milczarek Sayão
y created for this, as it is more a solution for embedded > systems. > I think there is real value in a separate, small, first-class Glass > platform that works headless (at the same level as gtk/mac/win) and that is > explicitly targeting running apps in headless mode. > > - Johan > &

How to run an app headless?

2023-06-08 Thread Thiago Milczarek Sayão
Hi, I'm building javafx with: ./gradlew -PincludeMonocle build And trying to test with: java @/home/tsayao/jfx/build/run.args -Dglass.platform=Monocle -Dmonocle.platform=Headless -Dprism.order=sw WindowTest.java But it seems monocle was not included: java.lang.ClassNotFoundException:

IME Attributes

2023-06-01 Thread Thiago Milczarek Sayão
Hi, View.java has those attributes: @Native public final static byte IME_ATTR_INPUT = 0x00; @Native public final static byte IME_ATTR_TARGET_CONVERTED = 0x01; @Native public final static byte IME_ATTR_CONVERTED = 0x02; @Native public final static

Re: [External] : Re: PR to new language features from project amber

2023-04-22 Thread Thiago Milczarek Sayão
there is a PR under review to add a section to the JDK dev > guide that addresses this point, stating that refactoring changes in stable > code are discouraged. See https://github.com/openjdk/guide/pull/101 > > -- Kevin > > > On 4/22/2023 7:13 AM, Thiago Milczarek Sayão wrote: &

Re: Linux IME work

2023-04-22 Thread Thiago Milczarek Sayão
it's done. This is also a step to get rid of X11 calls and make space for Wayland. If anyone is willing to provide feedback, please do it on the PR. -- Thiago. Em seg., 3 de abr. de 2023 às 08:32, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > I have submitted a Dra

Re: PR to new language features from project amber

2023-04-22 Thread Thiago Milczarek Sayão
evin.rushfo...@oracle.com> escreveu: > The minimum JDK version is 17, so JavaFX cannot use any features that > are only available in a later JDK. Further, we cannot use any preview > features. > > -- Kevin > > > On 4/22/2023 6:59 AM, Thiago Milczarek Sayão wrote: > > Hi,

PR to new language features from project amber

2023-04-22 Thread Thiago Milczarek Sayão
Hi, Can I submit PR for pattern matching or enhanced switches? I was thinking about creating an umbrella project like "Adopt new language features from project amber" and submit "per module" and "per feature" PRs. -- Cheers

Re: Linux IME work

2023-04-03 Thread Thiago Milczarek Sayão
I have submitted a Draft PR here: https://github.com/openjdk/jfx/pull/1080 It's not 100% right yet, I need some feedback to work on it. Em seg., 20 de mar. de 2023 às 09:50, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > Hi, > > I'm working on IME (Input Method E

Linux IME work

2023-03-20 Thread Thiago Milczarek Sayão
Hi, I'm working on IME (Input Method Editor) on Linux as the current solution using XIM is probably not working and XIM is known to be outdated. I'm basing it on https://docs.gtk.org/gtk3/class.IMContext.html Which is built on top of Ibus (Intelligent Input Bus). To my understanding there's an

Gradle help

2023-03-09 Thread Thiago Milczarek Sayão
Hi, https://github.com/openjdk/jfx/pull/1009 For this PR, Intellij Idea is not importing the systemTests dependencies correctly. I noticed that it's this part: dependencies { testImplementation project(":graphics").sourceSets.test.output testImplementation

Re: Toolkit decorations experiment

2023-02-02 Thread Thiago Milczarek Sayão
/SceneDecorationTest.java To move/resize the window, it uses native API, sketched here: https://github.com/openjdk/jfx/pull/1013 -- Thiago Em ter., 31 de jan. de 2023 às 11:15, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > Hi, > > I'm doing some experiments with tool

Re: Some classes could be sealed

2023-02-01 Thread Thiago Milczarek Sayão
> > > > Currently this is enforced at runtime in NodeHelper. > > > > --John > > > > On 01/02/2023 15:47, Thiago Milczarek Sayão wrote: > > > > Hi, > > > > NodeHelper.java has this: > > > > throw new UnsupportedOperationException( > >

Some classes could be sealed

2023-02-01 Thread Thiago Milczarek Sayão
Hi, NodeHelper.java has this: throw new UnsupportedOperationException( "Applications should not extend the " + nodeType + " class directly."); I think it's replaceable with selead classes. Am I right? The benefit will be compile time error instead of runtime. -- Thiago.

Re: CFV: New OpenJFX Committer: Hima Bindu Meda

2023-02-01 Thread Thiago Milczarek Sayão
Vote: YES Em qua., 1 de fev. de 2023 às 10:45, Kevin Rushforth < kevin.rushfo...@oracle.com> escreveu: > I hereby nominate Hima Bindu Meda [1] to OpenJFX Committer. > > Hima is a member of the JavaFX team at Oracle who has contributed 10 > commits [2] to OpenJFX. > > Votes are due by February

Re: CFV: New OpenJFX Committer: Jay Bhaskar

2023-02-01 Thread Thiago Milczarek Sayão
Vote: YES Em qua., 1 de fev. de 2023 às 10:45, Kevin Rushforth < kevin.rushfo...@oracle.com> escreveu: > I hereby nominate Jay Bhaskar [1] to OpenJFX Committer. > > Jay is a member of the JavaFX team at Oracle who has contributed 11 > commits [2] to OpenJFX. > > Votes are due by February 15,

Toolkit decorations experiment

2023-01-31 Thread Thiago Milczarek Sayão
Hi, I'm doing some experiments with toolkit decorations (instead of platform decorations). The goal is to allow for modern-looking apps, with "hamburger buttons" or tabs (like firefox or chrome) on the decoration space. It is coming into shape (nowhere near finished). It's CSS styleable.

How to calculate distance from Stage to Root accounting possible CSS transformations?

2023-01-29 Thread Thiago Milczarek Sayão
Hi, I want to calculate where to display resize cursors when resizing an TRANSPARENT Stage + Scene with rounded borders. - Stage --- Scene Root I don't think we would have to be pixel-exact, the resize cursors could be displayed between Stage and begin of Root actual content. The actual

Move/Resize undecorated windows

2023-01-28 Thread Thiago Milczarek Sayão
Hi, I did a PR (Draft) with move/resize for Linux: https://github.com/openjdk/jfx/pull/1013 To move forward I would need help for other platforms, like Windows and Mac. I am aware of this other PR: https://github.com/openjdk/jfx/pull/594 But it would not work on Linux, because the window

Re: StageStyle.TOOLKIT_DECORATED

2023-01-27 Thread Thiago Milczarek Sayão
Looking further into it, seems this is the way to go: https://github.com/openjdk/jfx/pull/594 Em qui., 26 de jan. de 2023 às 21:08, Thiago Milczarek Sayão < thiago.sa...@gmail.com> escreveu: > I have begun to implement a StageStyle variation called TOOLKIT_DECORATED > (better na

StageStyle.TOOLKIT_DECORATED

2023-01-26 Thread Thiago Milczarek Sayão
I have begun to implement a StageStyle variation called TOOLKIT_DECORATED (better naming welcome). It would be JavaFX's version of: https://docs.gtk.org/gtk4/class.HeaderBar.html The goal is to allow a Toolkit decorated window that accepts controls inside the decoration such as a "hamburger

Re: TableViewBuilder idea

2023-01-22 Thread Thiago Milczarek Sayão
ne question: how does this approach work with language localization, > given that "label" is a constant? > > On Sun, Jan 22, 2023 at 1:08 AM Thiago Milczarek Sayão > wrote: > > > > Hi, > > > > TableView data usually comes from a database a

Re: TableViewBuilder idea

2023-01-22 Thread Thiago Milczarek Sayão
is the way to go. After > all, most entities are not written with JavaFX properties. > > On Sun, Jan 22, 2023 at 2:08 AM Thiago Milczarek Sayão < > thiago.sa...@gmail.com> wrote: > >> Hi, >> >> TableView data usually comes from a database and is mapped to java >

TableViewBuilder idea

2023-01-21 Thread Thiago Milczarek Sayão
Hi, TableView data usually comes from a database and is mapped to java objects (I don't have actual statistics on this but it's probably a true assertion). It Would be very useful if we could just copy database mapped objects to javafx observables and say: Display it on a tableview. Configuration

Re: Removing gtk2 support

2023-01-04 Thread Thiago Milczarek Sayão
use wheel. > > These problems only occur when GTK3 is used on Linux. To avoid this > problem, we have to set jdk.gtk.version to 2. > > I haven't found any information about this problem. Does anyone know what > may be the cause? > > On Wed, Jan 4, 2023 at 7:28 PM Thiago Milczarek Sayão

Removing gtk2 support

2023-01-04 Thread Thiago Milczarek Sayão
Would a merge request to remove gtk2 support on the JavaFX 21 release be welcome? --Thiago.

Re: CFV: New OpenJFX Committer: John Hendrikx

2023-01-03 Thread Thiago Milczarek Sayão
Vote: YES Em ter., 3 de jan. de 2023 às 12:17, Kevin Rushforth < kevin.rushfo...@oracle.com> escreveu: > I hereby nominate John Hendrikx [1] to OpenJFX Committer. > > John is an OpenJFX community member, who has contributed 16 commits [2] > to OpenJFX. > > Votes are due by January 17, 2023 at

Re: Plans for gtk glass backend

2022-11-14 Thread Thiago Milczarek Sayão
o fix it, but can help > where I can: > > https://bugs.openjdk.org/browse/JDK-8248435 > > If not, that's fine :) > > --John > > On 14/11/2022 13:54, Thiago Milczarek Sayão wrote: > > Hi, > > > > I have some plans to work on gtk glass backend, no

Plans for gtk glass backend

2022-11-14 Thread Thiago Milczarek Sayão
Hi, I have some plans to work on gtk glass backend, not necessarily in this order: 1) Unify WindowContextBase and WindowContextTop - those were separated for applet support that were removed 2) Remove gtk2 Support 3) Add gesture support 4) Rework AlwaysOnTop, exploring _NET_WM_STATE_ABOVE 5) Fix

Re: Help testing 8260528 / PR #915

2022-11-09 Thread Thiago Milczarek Sayão
machine. Everything fine! > > Best regards, > Greg > > Thiago Milczarek Sayão writes: > > > Hi Gregor, > > > > Last time you helped with testing. > > I have improved the PR in: > > https://github.com/openjdk/jfx/pull/915 > > > >

Re: requestFocus on setScene - is it right?

2022-11-08 Thread Thiago Milczarek Sayão
s(Node). > > --John > On 07/11/2022 15:38, Thiago Milczarek Sayão wrote: > > It was a problem in the past gtk glass, but now it checks if visible to > request the focus. > > But, there are two situations: > > 1 - Most common - there is one Scene and it's created before

  1   2   >