Re: [External] : Re: Missing 'vcruntime.h'

2022-08-16 Thread Nir Lisker
Nodejs, Rust, F sharp, Selenium... those are indeed some questionable entries for JavaFX. On Tue, Aug 16, 2022 at 6:25 PM John Neffenger wrote: > On 8/15/22 10:18 PM, Nir Lisker wrote: > > I also have entries there that don't exist. I suspect they have to do > > with building WebKit. Turns out t

Re: [External] : Re: Missing 'vcruntime.h'

2022-08-16 Thread John Neffenger
On 8/15/22 10:18 PM, Nir Lisker wrote: I also have entries there that don't exist. I suspect they have to do with building WebKit. Turns out they don't hurt. Right, they don't hurt. They're not for WebKit, though, and I found they over-complicate the sample as a starting-point for editing. It

Re: [External] : Re: Missing 'vcruntime.h'

2022-08-15 Thread Nir Lisker
> > I tried editing that file, too, but I couldn't get it working. It also > has almost 80 program and SDK directory entries on its paths that aren't > on my system at all, so I was reluctant even to start with it. > I also have entries there that don't exist. I suspect they have to do with buildi

Re: [External] : Re: Missing 'vcruntime.h'

2022-08-15 Thread John Neffenger
On 8/15/22 12:32 AM, Nir Lisker wrote: (I have '%SystemRoot%\system32' which is exported to Cygwin correctly). That works, too. I have to admit, my troubles on Windows at the time were self-inflicted. I was trying to reduce my PATH to its minimum (shown formatted below), but I left off 'Windo

Re: [External] : Re: Missing 'vcruntime.h'

2022-08-15 Thread Nir Lisker
Thanks John. I managed to fix my issue by replacing the paths in the wiki's 'windows_tools.properties' file. As for your fix, I did delete the build folder and had the VS150COMNTOOLS variable defined, but didn't know about '/cygdrive/c/Windows/System32' (I have '%SystemRoot%\system32' which is exp

Re: [External] : Re: Missing 'vcruntime.h'

2022-08-14 Thread John Neffenger
On 8/13/22 7:29 AM, Nir Lisker wrote: I figured out that that error (which appeared during compilation of native decora shaders) came from a missing entry in windows.tools.properties: While working on pull request openjdk/jfx#488, I found the sample 'windows_tools.properties' file in the Wiki

Re: [External] : Re: Missing 'vcruntime.h'

2022-08-13 Thread Nir Lisker
I figured out that that error (which appeared during compilation of native decora shaders) came from a missing entry in windows.tools.properties: WINDOWS_VS_INCLUDE=C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.33.31629/include (There were many other entries there, but al

Re: [External] : Re: Missing 'vcruntime.h'

2022-08-13 Thread Kevin Rushforth
Sure, I'll do that when I get a chance. As long as you set VS150COMNTOOLS, you shouldn't ever need to edit them, but it might be useful as a sanity check to compare with yours. Our GHA builds only set that one variable (and do not set MSVC_VER or VSINSTALLDIR).     VS150COMNTOOLS: "C:\\Program

Re: Missing 'vcruntime.h'

2022-08-12 Thread Nir Lisker
Kevin, can you update the windows_tools.properties file for the build page on the wiki [1] for VS 2022 since I see that we updated to use that version? [1] https://wiki.openjdk.org/pages/viewpage.action?pageId=66650334 On Sat, Aug 13, 2022 at 2:06 AM Nir Lisker wrote: > I see the file under \VC

Re: Missing 'vcruntime.h'

2022-08-12 Thread Nir Lisker
I see the file under \VC\Tools\MSVC\14.33.31629\include\vcruntime.h of the VS installation. The file calling it is under C:/Program Files (x86)/Windows Kits/10/include/10.0.17763.0/ucrt\corecrt.h. Is it supposed to look for some env variable to find it? I have MSVC_VER, VSINSTALLDIR and VS150COMNTO

Re: Missing 'vcruntime.h'

2022-08-12 Thread Kevin Rushforth
vcruntime.h is included with the Visual Studio compiler and has been for ages. I can't think of anything recently that would have changed relative to that. -- Kevin On 8/12/2022 2:12 PM, Nir Lisker wrote: Hi, I have just run gradle clean and gradle build, and I'm getting an error: C:/Progr

Missing 'vcruntime.h'

2022-08-12 Thread Nir Lisker
Hi, I have just run gradle clean and gradle build, and I'm getting an error: C:/Program Files (x86)/Windows Kits/10/include/10.0.17763.0/ucrt\corecrt.h(10): fatal error C1083: Cannot open include file: 'vcruntime.h': No such file or directory Indeed, vcruntime.h is not in that folder. Do I need