Re: RFR: 8089373: Translation from character to key code is not sufficient [v2]

2024-02-19 Thread Michael Strauß
On Fri, 9 Feb 2024 03:37:17 GMT, Martin Fox wrote: >> On Windows a common shortcut like Ctrl+'+' could only be invoked from the >> main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not >> have enough context to know whether it should return a result from the main >>

Re: RFR: 8089373: Translation from character to key code is not sufficient [v2]

2024-02-09 Thread Andy Goryachev
On Fri, 9 Feb 2024 03:37:17 GMT, Martin Fox wrote: >> On Windows a common shortcut like Ctrl+'+' could only be invoked from the >> main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not >> have enough context to know whether it should return a result from the main >>

Re: RFR: 8089373: Translation from character to key code is not sufficient [v2]

2024-02-09 Thread Martin Fox
On Thu, 8 Feb 2024 19:26:42 GMT, Andy Goryachev wrote: >> Martin Fox has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >>

Re: RFR: 8089373: Translation from character to key code is not sufficient [v2]

2024-02-09 Thread Martin Fox
On Thu, 8 Feb 2024 19:20:32 GMT, Andy Goryachev wrote: >> Martin Fox has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >>

Re: RFR: 8089373: Translation from character to key code is not sufficient [v2]

2024-02-08 Thread Martin Fox
> On Windows a common shortcut like Ctrl+'+' could only be invoked from the > main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not > have enough context to know whether it should return a result from the main > keyboard or the keypad. > > This PR alters getKeyCodeForChar

Re: RFR: 8089373: Translation from character to key code is not sufficient [v2]

2023-05-10 Thread Martin Fox
> Note: the Java-side changes in this PR are also in #694 which fixes the same > issue (and more) on Linux. Unfortunately the Linux Robot code is not working > making it difficult to test on that platform (see #718). > > KeyCharacterCombinations allow the specification of accelerators based on