On Fri, 10 Nov 2023 23:39:21 GMT, Nir Lisker wrote:
>> Moves the filter setting of the samplers from the device parameters
>> configuration to the use-site, allowing for dynamic changes in the sampler.
>> This PR does internal plumbing work only to bring it close to the ES2
>> pipeline. A
On Fri, 1 Dec 2023 10:07:37 GMT, Ambarish Rapte wrote:
>> I agree with 2. and I also think that `TextureParameters` would be a better
>> name for this.
>>
>> This should also follow in below method names and such (ex.
>> `setTextureParameters()` instead of `setTextureData()`)
>
> These
On Fri, 1 Dec 2023 09:14:28 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DContext.cc line 367:
>
>> 365: {
>>
On Fri, 10 Nov 2023 23:39:21 GMT, Nir Lisker wrote:
>> Moves the filter setting of the samplers from the device parameters
>> configuration to the use-site, allowing for dynamic changes in the sampler.
>> This PR does internal plumbing work only to bring it close to the ES2
>> pipeline. A
On Wed, 15 Nov 2023 11:39:30 GMT, Lukasz Kostyra wrote:
>> 1. Not when it will be promoted to public API. Adding record components
>> breaks backwards compatibility, so making this a record will not allow
>> adding more configuration later on. What might be possible is making it an
>>
On Wed, 15 Nov 2023 13:00:54 GMT, Nir Lisker wrote:
>> You're right, there's no implicit conversion from scoped enums to integers.
>> While one could get very creative with C++, maybe just using an unscoped
>> enum is easier. You might want to prefix the constants with `MT_` or
>> something
On Thu, 9 Nov 2023 02:45:34 GMT, Michael Strauß wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Addressed review comments
>
> modules/javafx.graphics/src/main/native-prism-d3d/D3DPhongMaterial.cc line 39:
>
>> 37:
On Mon, 13 Nov 2023 01:23:13 GMT, Michael Strauß wrote:
>> About 2, I tried that initially and got into problems iterating over the
>> enum in `D3DMeshView.cc` line 293. How would you perform the iteration?
>
> You're right, there's no implicit conversion from scoped enums to integers.
> While
On Fri, 10 Nov 2023 15:24:13 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/paint/TextureData.java
>> line 12:
>>
>>> 10: */
>>> 11: // Here we can support mipmaps, wrapping modes (which exists internally
>>> and can be pulled out), addressing modes etc.
On Fri, 10 Nov 2023 23:39:21 GMT, Nir Lisker wrote:
>> Moves the filter setting of the samplers from the device parameters
>> configuration to the use-site, allowing for dynamic changes in the sampler.
>> This PR does internal plumbing work only to bring it close to the ES2
>> pipeline. A
On Fri, 10 Nov 2023 23:39:21 GMT, Nir Lisker wrote:
>> Moves the filter setting of the samplers from the device parameters
>> configuration to the use-site, allowing for dynamic changes in the sampler.
>> This PR does internal plumbing work only to bring it close to the ES2
>> pipeline. A
On Fri, 10 Nov 2023 23:33:12 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/native-prism-d3d/D3DPhongMaterial.h line 41:
>>
>>> 39: self_illumination,
>>> 40: num_map_types
>>> 41: };
>>
>> 1. Types generally seem to use PascalCase in this library, and constants
>>
> Moves the filter setting of the samplers from the device parameters
> configuration to the use-site, allowing for dynamic changes in the sampler.
> This PR does internal plumbing work only to bring it close to the ES2
> pipeline. A followup PR will create the public API.
>
> Summary of the
13 matches
Mail list logo
