Re: RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v6]

2022-12-11 Thread Karthik P K
On Sat, 10 Dec 2022 15:42:23 GMT, Kevin Rushforth wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/skin/SliderSkin.java >> line 410: >> >>> 408: thumb.setOnMouseExited(me -> { >>> 409: Tooltip t = getSkinnable().getTooltip(); >>> 410: if (t !=

Re: RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v6]

2022-12-10 Thread Ambarish Rapte
On Thu, 8 Dec 2022 10:34:34 GMT, Karthik P K wrote: >> Cause: When slider is dragged for first time after tooltip appears, >> setOnMousePressed event was not invoked, hence dragStart was null in the >> subsequently invoked event handler (setOnMouseDragged). >> >> Fix: Initialized dragStart in

Re: RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v6]

2022-12-10 Thread Kevin Rushforth
On Thu, 8 Dec 2022 10:34:34 GMT, Karthik P K wrote: >> Cause: When slider is dragged for first time after tooltip appears, >> setOnMousePressed event was not invoked, hence dragStart was null in the >> subsequently invoked event handler (setOnMouseDragged). >> >> Fix: Initialized dragStart in

Re: RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v6]

2022-12-10 Thread Kevin Rushforth
On Fri, 9 Dec 2022 16:31:57 GMT, Andy Goryachev wrote: >> Karthik P K has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add check whether consumeAutoHidingEventsProperty is bound > > modules/javafx.controls/src/main/java/javafx/scene/contr

Re: RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v6]

2022-12-09 Thread Andy Goryachev
On Thu, 8 Dec 2022 10:34:34 GMT, Karthik P K wrote: >> Cause: When slider is dragged for first time after tooltip appears, >> setOnMousePressed event was not invoked, hence dragStart was null in the >> subsequently invoked event handler (setOnMouseDragged). >> >> Fix: Initialized dragStart in

Re: RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v6]

2022-12-09 Thread Andy Goryachev
On Thu, 8 Dec 2022 10:34:34 GMT, Karthik P K wrote: >> Cause: When slider is dragged for first time after tooltip appears, >> setOnMousePressed event was not invoked, hence dragStart was null in the >> subsequently invoked event handler (setOnMouseDragged). >> >> Fix: Initialized dragStart in

Re: RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v6]

2022-12-09 Thread Karthik P K
On Thu, 8 Dec 2022 10:34:34 GMT, Karthik P K wrote: >> Cause: When slider is dragged for first time after tooltip appears, >> setOnMousePressed event was not invoked, hence dragStart was null in the >> subsequently invoked event handler (setOnMouseDragged). >> >> Fix: Initialized dragStart in

Re: RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v6]

2022-12-08 Thread Karthik P K
> Cause: When slider is dragged for first time after tooltip appears, > setOnMousePressed event was not invoked, hence dragStart was null in the > subsequently invoked event handler (setOnMouseDragged). > > Fix: Initialized dragStart in initialize method. > > Test: Added system test to validate