On Thu, 1 Sep 2022 05:35:09 GMT, Ambarish Rapte wrote:
>> I still don't understand. What is `VertexType`? I see a comment on `VsInput`
>> "// this is a .hlsl mirror of the vertex format, see VertexTypes.h". If the
>> gradle file has `"/DVertexType=VsInput"`, shouldn't it be fine with
>>
On Tue, 30 Aug 2022 18:37:38 GMT, Nir Lisker wrote:
>>> What do you mean by "revert the type function parameter here"?
>>
>> `VsOutput main(VsInput vsInput)`: in the declaration, the type of function
>> parameter `VsInput vsInput` should be reverted with change in build.gradle.
>> `VsOutput
On Fri, 26 Aug 2022 17:34:41 GMT, Ambarish Rapte wrote:
>> What do you mean by "revert the type function parameter here"? Doesn't the
>> type parameter match after a change to the gradle file?
>
>> What do you mean by "revert the type function parameter here"?
>
> `VsOutput main(VsInput
On Tue, 23 Aug 2022 19:45:40 GMT, Nir Lisker wrote:
> What do you mean by "revert the type function parameter here"?
`VsOutput main(VsInput vsInput)`: in the declaration, the type of function
parameter `VsInput vsInput` should be reverted with change in build.gradle.
`VsOutput main(VsInput
On Tue, 2 Aug 2022 17:38:06 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed method
>
> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/vs2ps.h line 26:
>
>> 24: */
>> 25:
>> 26:
On Tue, 2 Aug 2022 15:10:50 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed method
>
> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/Mtl1VS.hlsl line 32:
>
>> 30: //float2
On Tue, 2 Aug 2022 18:01:06 GMT, Ambarish Rapte wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Renamed method
>
> modules/javafx.graphics/src/main/native-prism-d3d/hlsl/vs2ps.h line 38:
>
>> 36: float3
On Tue, 2 Aug 2022 09:47:21 GMT, Nir Lisker wrote:
>> Refactoring and renaming changes to some of the D3D pipeline files and a few
>> changes on the Java side. These are various "leftovers" from previous issues
>> that we didn't want to touch at the time in order to confine the scope of
>>
On Tue, 2 Aug 2022 09:47:21 GMT, Nir Lisker wrote:
>> Refactoring and renaming changes to some of the D3D pipeline files and a few
>> changes on the Java side. These are various "leftovers" from previous issues
>> that we didn't want to touch at the time in order to confine the scope of
>>
> Refactoring and renaming changes to some of the D3D pipeline files and a few
> changes on the Java side. These are various "leftovers" from previous issues
> that we didn't want to touch at the time in order to confine the scope of the
> changes. They will make future work easier.
>
> Since
10 matches
Mail list logo
