Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v6]

2022-08-09 Thread Andy Goryachev
On Tue, 9 Aug 2022 15:14:15 GMT, Kevin Rushforth wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >>

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v6]

2022-08-09 Thread Kevin Rushforth
On Mon, 8 Aug 2022 20:30:01 GMT, Andy Goryachev wrote: >> The goal of this change is to make sure jfx repo can be imported as a gradle >> project in eclipse and all nested projects in the workspace compile with no >> errors. >> >> - updated .classpath entries in apps/ >> - added utf-8 prefs

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v6]

2022-08-09 Thread Nir Lisker
On Tue, 9 Aug 2022 15:11:49 GMT, Kevin Rushforth wrote: >> This is up to Kevin. It's changing the build file specifically to remove a >> warning for Eclipse Mac users. I don't mind. Might need to do the same for >> the other OS-specific folders. > > While not ideal, I suppose it's OK. I'm

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v6]

2022-08-09 Thread Kevin Rushforth
On Tue, 9 Aug 2022 00:52:36 GMT, Nir Lisker wrote: >> I respectfully disagree. >> I see no harm in creating empty directories in this case if it solves the >> problem. >> We can log a bug against eclipse, and it will be fixed in several years, if >> ever. > > This is up to Kevin. It's

Re: RFR: 8290473: update Eclipse .classpath in apps, buildSrc [v6]

2022-08-08 Thread Nir Lisker
On Mon, 8 Aug 2022 15:38:35 GMT, Andy Goryachev wrote: >> On Linux there is no such warning., neither is there on Windows if I add a >> non-existing folder (to simulate the ones for other OS's). I posted the >> screenshots on the mailing list. If Eclipse for Mac is the only one >> producing