On Mon, 24 Apr 2023 15:27:48 GMT, Kevin Rushforth wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adress review comments
>
> Looks good.
@kevinrushforth could you please sponsor the PR?
-
PR Comment:
On Mon, 24 Apr 2023 05:18:48 GMT, Karthik P K wrote:
>> Usage of `getBounds()` method instead `getVisualBounds()` was giving
>> unreliable screen bound values and color value was read very close to the
>> edge of the window.
>>
>> Updated the code to use `getVisualBounds()` instead of
> Usage of `getBounds()` method instead `getVisualBounds()` was giving
> unreliable screen bound values and color value was read very close to the
> edge of the window.
>
> Updated the code to use `getVisualBounds()` instead of `getBounds()` and
> moved the coordinates inside the window from
On Fri, 21 Apr 2023 13:52:55 GMT, Karthik P K wrote:
>> Usage of `getBounds()` method instead `getVisualBounds()` was giving
>> unreliable screen bound values and color value was read very close to the
>> edge of the window.
>>
>> Updated the code to use `getVisualBounds()` instead of
On Fri, 21 Apr 2023 13:52:55 GMT, Karthik P K wrote:
>> Usage of `getBounds()` method instead `getVisualBounds()` was giving
>> unreliable screen bound values and color value was read very close to the
>> edge of the window.
>>
>> Updated the code to use `getVisualBounds()` instead of
On Thu, 20 Apr 2023 15:27:37 GMT, Kevin Rushforth wrote:
>> When the app enters full screen mode in MacBook Pro M1, there will be still
>> a black strip on the top because of the notch. So assigning small value will
>> not fetch green color from app window. It requires at least y=40.
>> So I
> Usage of `getBounds()` method instead `getVisualBounds()` was giving
> unreliable screen bound values and color value was read very close to the
> edge of the window.
>
> Updated the code to use `getVisualBounds()` instead of `getBounds()` and
> moved the coordinates inside the window from
On Thu, 20 Apr 2023 14:32:58 GMT, Karthik P K wrote:
>> tests/system/src/test/java/test/robot/helloworld/CustomSecurityManagerTest.java
>> line 208:
>>
>>> 206:
>>> 207: for (int col = 0; col < 2; col++) {
>>> 208: int x = col == 0 ? 1 : screenWidth.get() -
On Thu, 20 Apr 2023 14:32:07 GMT, Karthik P K wrote:
>> tests/system/src/test/java/test/robot/helloworld/CustomSecurityManagerTest.java
>> line 202:
>>
>>> 200: if (row == 0) {
>>> 201: // avoid the top area as it might contain
>>> OS-specific UI (Macs with
On Thu, 20 Apr 2023 12:22:54 GMT, Kevin Rushforth wrote:
>> Usage of `getBounds()` method instead `getVisualBounds()` was giving
>> unreliable screen bound values and color value was read very close to the
>> edge of the window.
>>
>> Updated the code to use `getVisualBounds()` instead of
On Thu, 20 Apr 2023 08:36:59 GMT, Karthik P K wrote:
> Usage of `getBounds()` method instead `getVisualBounds()` was giving
> unreliable screen bound values and color value was read very close to the
> edge of the window.
>
> Updated the code to use `getVisualBounds()` instead of
On Thu, 20 Apr 2023 08:36:59 GMT, Karthik P K wrote:
> Usage of `getBounds()` method instead `getVisualBounds()` was giving
> unreliable screen bound values and color value was read very close to the
> edge of the window.
>
> Updated the code to use `getVisualBounds()` instead of
Usage of `getBounds()` method instead `getVisualBounds()` was giving unreliable
screen bound values and color value was read very close to the edge of the
window.
Updated the code to use `getVisualBounds()` instead of `getBounds()` and moved
the coordinates inside the window from where the
13 matches
Mail list logo
