Re: RFR: 8311895: CSS Transitions [v17]

2024-06-05 Thread Michael Strauß
On Tue, 4 Jun 2024 21:14:54 GMT, Kevin Rushforth wrote: >> I think it's fine. Another option is to link to the part of the reference >> where they are. > > I would prefer to keep them in one place (scene) and link to the ones there > (`../scene/doc-files/`). I've linked to the files in `scene/

Re: RFR: 8311895: CSS Transitions [v17]

2024-06-05 Thread Kevin Rushforth
On Sat, 25 May 2024 20:49:08 GMT, Nir Lisker wrote: >> I've included the images that are also used in the CSS reference >> documentation. Now there are two copies of these images in two different >> `doc-files` folders, but I guess that's okay. > > I think it's fine. Another option is to link t

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Michael Strauß
On Sat, 25 May 2024 19:39:12 GMT, Nir Lisker wrote: > I still don't know what happens when a value is programmatically set while a > css transition is in progress. What I understood is that binding the property > will not allow the transition to start/continue, but didn't see where setting > a

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Nir Lisker
On Sat, 25 May 2024 21:04:24 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html >> line 690: >> >>> 688: changed, it smoothly transitions to the new value over a >>> period of time. Implicit transitions are supported >>> 689:

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Michael Strauß
On Sat, 25 May 2024 19:35:56 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 57 commits: >> >> - Merge branch 'refs/heads/master' into feature/css-transitions >> - extract magic string to

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Michael Strauß
On Sat, 25 May 2024 19:28:56 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 57 commits: >> >> - Merge branch 'refs/heads/master' into feature/css-transitions >> - extract magic string to

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Nir Lisker
On Sat, 25 May 2024 20:37:44 GMT, Michael Strauß wrote: >> modules/javafx.graphics/src/main/java/javafx/animation/Interpolator.java >> line 277: >> >>> 275: * @since 23 >>> 276: */ >>> 277: public enum StepPosition { >> >> I think it would be helpful to include (or link to) image

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Michael Strauß
On Sat, 25 May 2024 17:40:01 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 57 commits: >> >> - Merge branch 'refs/heads/master' into feature/css-transitions >> - extract magic string to

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Michael Strauß
On Sat, 25 May 2024 10:40:05 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 57 commits: >> >> - Merge branch 'refs/heads/master' into feature/css-transitions >> - extract magic string to

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-25 Thread Nir Lisker
On Fri, 24 May 2024 11:18:35 GMT, Michael Strauß wrote: >> Implementation of [CSS >> Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). >> >> ### Future enhancements >> CSS transitions requires all participating objects to implement the >> `Interpolatable` interface.

Re: RFR: 8311895: CSS Transitions [v17]

2024-05-24 Thread Michael Strauß
> Implementation of [CSS > Transitions](https://gist.github.com/mstr2/c72f8c9faa87de14926978f517a6018a). > > ### Future enhancements > CSS transitions requires all participating objects to implement the > `Interpolatable` interface. For example, targeting `-fx-background-color` > only works if