On Tue, 22 Aug 2023 06:03:01 GMT, John Hendrikx wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>>
> 1. Creating a new `javafx.scene.ContainsProperties` interface that declares
> two methods:
> - public ObservableMap getProperties();
> - public boolean hasProperties();
>
> 2. Node, MenuItem, and Toggle now extend ContainsProperties interface.
>
> 3. Making implemented methods in Node,
On Mon, 21 Aug 2023 15:56:59 GMT, Andy Goryachev wrote:
>> 1. Creating a new `javafx.scene.ContainsProperties` interface that declares
>> two methods:
>> - public ObservableMap getProperties();
>> - public boolean hasProperties();
>>
>> 2. Node, MenuItem, and Toggle now extend
> 1. Creating a new `javafx.scene.ContainsProperties` interface that declares
> two methods:
> - public ObservableMap getProperties();
> - public boolean hasProperties();
>
> 2. Node, MenuItem, and Toggle now extend ContainsProperties interface.
>
> 3. Making implemented methods in Node,
On Fri, 18 Aug 2023 22:42:22 GMT, Andy Goryachev wrote:
> > (unless we are also willing to create a new shared interface that Node,
> > MenuItem, and Toggle all inherit)
>
> that would be a clean(er) design, at the expense of slight runtime overhead
> traversing the interface table. could
On Fri, 18 Aug 2023 22:32:12 GMT, Kevin Rushforth wrote:
> (unless we are also willing to create a new shared interface that Node,
> MenuItem, and Toggle all inherit)
that would be a clean(er) design, at the expense of slight runtime overhead
traversing the interface table.
could there be any
> Adding new
> `boolean hasProperties()`
> method to MenuItem and Toggle only.
>
> This change requires CSR.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
review comments
-
Changes:
- all:
On Fri, 18 Aug 2023 17:06:57 GMT, Andy Goryachev wrote:
> Adding new
> `boolean hasProperties()`
> method to MenuItem and Toggle only.
>
> This change requires CSR.
Hmm. I also think might not want to put it in `Toggle` (unless we are also
willing to create a new shared interface that Node,
On Fri, 18 Aug 2023 22:08:35 GMT, John Hendrikx wrote:
>> Adding new
>> `boolean hasProperties()`
>> method to MenuItem and Toggle only.
>>
>> This change requires CSR.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/MenuItem.java line
> 532:
>
>> 530: /**
>> 531: *
On Fri, 18 Aug 2023 17:06:57 GMT, Andy Goryachev wrote:
> Adding new
> `boolean hasProperties()`
> method to MenuItem and Toggle only.
>
> This change requires CSR.
On second thought, I don't think you should add `hasProperties` to the `Toggle`
interface. Adding it to `MenuItem` should be
On Fri, 18 Aug 2023 22:18:29 GMT, John Hendrikx wrote:
> I don't think you should add `hasProperties` to the `Toggle` interface
I think it's ok - the interface declares getProperties(), so it makes sense to
add it there. Alternatively, there should have been "ContainsProperties"
interface.
On Fri, 18 Aug 2023 17:06:57 GMT, Andy Goryachev wrote:
> Adding new
> `boolean hasProperties()`
> method to MenuItem and Toggle only.
>
> This change requires CSR.
modules/javafx.controls/src/main/java/javafx/scene/control/MenuItem.java line
532:
> 530: /**
> 531: * Tests if
Adding new
`boolean hasProperties()`
method to MenuItem and Toggle only.
This change requires CSR.
-
Commit messages:
- test
- has properties
Changes: https://git.openjdk.org/jfx/pull/1215/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=1215=00
Issue:
13 matches
Mail list logo
