On Mon, 29 Jan 2024 14:16:00 GMT, Nir Lisker wrote:
>> I was also going to suggest `xxImpl` with a short javadoc comment. That is a
>> pattern we use elsewhere. I don't dislike the current name, but I can see
>> Jose's point.
>
> Changed to `xxImpl` with a doc comment.
Thanks. You missed the o
On Mon, 29 Jan 2024 12:44:07 GMT, Kevin Rushforth wrote:
>> Probably you won't like `xxImpl` either?
>> I'm not sure we should start adding `runMustBeOnFxThread` to every method
>> name out there that should run on the FX thread. In this case, maybe we
>> could simply add a small javadoc with a
On Mon, 29 Jan 2024 09:20:27 GMT, Jose Pereda wrote:
>>> However, I'm not sure about the method naming `OnFxThread`, as it might
>>> imply that what it does is already done on the FX thread, therefore not
>>> needing to be wrapped up by `runOnFxThread`.
>>
>> I understand what you mean, but th
On Sat, 27 Jan 2024 21:31:32 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/util/Utils.java line
>> 1008:
>>
>>> 1006: * @param runnable a {@code Runnable} encapsulating the code
>>> 1007: */
>>> 1008: public static void runOnFxThread(Runnable runna
On Sat, 27 Jan 2024 21:56:59 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line
>> 903:
>>
>>> 901: }
>>> 902:
>>> 903: private void playFromOnFxThread(String cuePoint) {
>>
>> I take that adding these private `xxOnFxThread` methods is
On Sat, 27 Jan 2024 19:43:22 GMT, Jose Pereda wrote:
> However, I'm not sure about the method naming `OnFxThread`, as it might imply
> that what it does is already done on the FX thread, therefore not needing to
> be wrapped up by `runOnFxThread`.
I understand what you mean, but the way I see
On Sat, 27 Jan 2024 19:27:25 GMT, Jose Pereda wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update documentation on AnimationTimer methods
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/util/Utils.java li
On Sat, 27 Jan 2024 17:26:45 GMT, Nir Lisker wrote:
>> Added a utility method to run code on the FX thread if it's not already, and
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Sat, 27 Jan 2024 18:27:21 GMT, Nir Lisker wrote:
> The API looks good now...
As for the implementation, the only two things I see that are needed are:
1. Move the checks for `parent != null ` back to the original methods (i.e.,
before delegating). Without this, we are not conforming the spec
On Sat, 27 Jan 2024 18:27:21 GMT, Nir Lisker wrote:
> I think that the update to the CSR from an hour ago included all the changes
> already.
I missed that. Thanks.
-
PR Comment: https://git.openjdk.org/jfx/pull/1352#issuecomment-1913288090
On Sat, 27 Jan 2024 18:06:24 GMT, Kevin Rushforth wrote:
> The API looks good now, so you should be able to update the CSR.
I think that the update to the CSR from an hour ago included all the changes
already.
-
PR Comment: https://git.openjdk.org/jfx/pull/1352#issuecomment-191328
On Sat, 27 Jan 2024 17:26:45 GMT, Nir Lisker wrote:
>> Added a utility method to run code on the FX thread if it's not already, and
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Sat, 27 Jan 2024 17:52:52 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line
>> 1008:
>>
>>> 1006: if (parent != null) {
>>> 1007: throw new IllegalStateException("Cannot start when
>>> embedded in another animation");
On Sat, 27 Jan 2024 17:51:52 GMT, John Hendrikx wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update documentation on AnimationTimer methods
>
> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java
On Sat, 27 Jan 2024 17:26:45 GMT, Nir Lisker wrote:
>> Added a utility method to run code on the FX thread if it's not already, and
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Sat, 27 Jan 2024 17:26:45 GMT, Nir Lisker wrote:
>> Added a utility method to run code on the FX thread if it's not already, and
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
> Added a utility method to run code on the FX thread if it's not already, and
> changed the animation methods to use it.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Update documentation on AnimationTimer methods
-
Ch
17 matches
Mail list logo
