Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v7]

2024-04-25 Thread Andy Goryachev
On Thu, 25 Apr 2024 12:55:48 GMT, Oliver Kopp wrote: > Can you help me Sure! So I copied the test class (renamed, since we have another one with the name of TextAreaTest to `tests\system\src\test\java\test\com\sun\glass\ui\win`, same dir where WinTextRangeProviderTest.java resides. Here is t

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v7]

2024-04-25 Thread Oliver Kopp
On Fri, 19 Apr 2024 17:33:39 GMT, Andy Goryachev wrote: >> I am new to testing in the JFX project. It seems that `test.` is required as >> package prefix. Thus, I did not use the approach of package-private methods >> and classes, but needed to make the class and the tested method public. >> >

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v7]

2024-04-23 Thread Oliver Kopp
On Fri, 19 Apr 2024 17:33:39 GMT, Andy Goryachev wrote: >> I am new to testing in the JFX project. It seems that `test.` is required as >> package prefix. Thus, I did not use the approach of package-private methods >> and classes, but needed to make the class and the tested method public. >> >

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v7]

2024-04-22 Thread Kevin Rushforth
On Fri, 19 Apr 2024 18:27:12 GMT, Oliver Kopp wrote: > > I think you need to add > > The mentioned issue is fixed. Now, I get > > ``` > java.lang.UnsatisfiedLinkError: 'void > com.sun.glass.ui.win.WinTextRangeProvider._initIDs()' > at > javafx.graphics@23-internal/com.sun.glass.ui.win.W

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v7]

2024-04-19 Thread Oliver Kopp
On Fri, 19 Apr 2024 17:49:45 GMT, Kevin Rushforth wrote: > I think you need to add The mentioned issue is fixed. Now, I get java.lang.UnsatisfiedLinkError: 'void com.sun.glass.ui.win.WinTextRangeProvider._initIDs()' at javafx.graphics@23-internal/com.sun.glass.ui.win.WinTextRangePro

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v7]

2024-04-19 Thread Kevin Rushforth
On Fri, 19 Apr 2024 17:33:39 GMT, Andy Goryachev wrote: > > module `javafx.graphics` does not export `com.sun.glass.ui.win` to unnamed > > module @0x1e6454ec. > > I think you need to add > > ``` > --add-exports javafx.graphics/com.sun.glass.ui.win=ALL-UNNAMED > ``` Correct. > @kevinrushforth

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v7]

2024-04-19 Thread Andy Goryachev
On Fri, 19 Apr 2024 11:03:31 GMT, Oliver Kopp wrote: > module `javafx.graphics` does not export `com.sun.glass.ui.win` to unnamed > module @0x1e6454ec. I think you need to add --add-exports javafx.graphics/com.sun.glass.ui.win=ALL-UNNAMED to graphics/src/test/addExports (see line 7) @kevinru

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v7]

2024-04-19 Thread Oliver Kopp
On Fri, 19 Apr 2024 10:33:33 GMT, Oliver Kopp wrote: >> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max` compa

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v7]

2024-04-19 Thread Oliver Kopp
> Fixes https://bugs.openjdk.org/browse/JDK-8330462. > > If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then > an addition of `start` to it leads to a negative value. This is "fixed" by > using `Math.max` comparing the `maxLength` and `maxLength + start`. Oliver Kopp h