Re: RFR: 8331214: Doc: update spec for SpinnerFactory classes [v2]

2024-05-07 Thread drmarmac
On Tue, 7 May 2024 15:39:29 GMT, Andy Goryachev wrote: >> I guess that's because IntelliJ doesn't process the javafx properties. > > that's why _some say_ eclipse is better: > > ![Screenshot 2024-05-07 at 08 37 > 11](https://github.com/openjdk/jfx/assets/107069028/2aa137f6-affc-4aa9-8bcc-c1194d

Re: RFR: 8331214: Doc: update spec for SpinnerFactory classes [v2]

2024-05-07 Thread Andy Goryachev
On Tue, 7 May 2024 15:27:55 GMT, Kevin Rushforth wrote: >> Updated. I checked this variant with IntelliJ: While I can follow the link, >> it doesn't show the wrapAround field's javadoc, just the >> wrapAroundProperty's javadoc which is empty. > > I guess that's because IntelliJ doesn't process

Re: RFR: 8331214: Doc: update spec for SpinnerFactory classes [v2]

2024-05-07 Thread Kevin Rushforth
On Tue, 7 May 2024 06:11:59 GMT, drmarmac wrote: >> That one should work everywhere, since it is equivalent. Worth >> double-checking, though. > > Updated. I checked this variant with IntelliJ: While I can follow the link, > it doesn't show the wrapAround field's javadoc, just the wrapAroundPro

Re: RFR: 8331214: Doc: update spec for SpinnerFactory classes [v2]

2024-05-06 Thread drmarmac
On Mon, 6 May 2024 23:22:36 GMT, Kevin Rushforth wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/SpinnerValueFactory.java >> line 417: >> >>> 415: * integer values. >>> 416: * >>> 417: * If {@link #wrapAroundProperty wrapAround} is {@code true}, the >>> {@c

Re: RFR: 8331214: Doc: update spec for SpinnerFactory classes [v2]

2024-05-06 Thread Kevin Rushforth
On Mon, 6 May 2024 21:46:29 GMT, Andy Goryachev wrote: >> drmarmac has updated the pull request incrementally with one additional >> commit since the last revision: >> >> javaDoc updates according to code review > > modules/javafx.controls/src/main/java/javafx/scene/control/SpinnerValueFactor

Re: RFR: 8331214: Doc: update spec for SpinnerFactory classes [v2]

2024-05-06 Thread Kevin Rushforth
On Mon, 6 May 2024 21:35:40 GMT, drmarmac wrote: >> `{@link #wrapAroundProperty wrapAround}` does not resolve **in Eclipse** (it >> does in javadoc output). >> >> This might be Eclipse limitation, but it would be awfully nice to have it >> resolved in Eclipse. > > I also fixed the min/max link

Re: RFR: 8331214: Doc: update spec for SpinnerFactory classes [v2]

2024-05-06 Thread Andy Goryachev
On Mon, 6 May 2024 21:32:07 GMT, drmarmac wrote: >> This PR updates the javadoc for the SpinnerFactory wrap-around behavior >> introduced in #1431. > > drmarmac has updated the pull request incrementally with one additional > commit since the last revision: > > javaDoc updates according to c

Re: RFR: 8331214: Doc: update spec for SpinnerFactory classes [v2]

2024-05-06 Thread drmarmac
On Mon, 6 May 2024 17:59:14 GMT, Andy Goryachev wrote: >> I don't think this will help. This is the same issue I mentioned in PR #1389 >> -- you need to link to the property _method_, so I think changing to the >> following will do it: >> >> >> * If {@link #wrapAroundProperty wrapAround} >>

Re: RFR: 8331214: Doc: update spec for SpinnerFactory classes [v2]

2024-05-06 Thread drmarmac
On Mon, 6 May 2024 16:27:52 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/SpinnerValueFactory.java >> line 420: >> >>> 418: * the minimum value to the maximum value (and vice versa). As a >>> consequence of that, the number >>> 419: * of ste

Re: RFR: 8331214: Doc: update spec for SpinnerFactory classes [v2]

2024-05-06 Thread drmarmac
> This PR updates the javadoc for the SpinnerFactory wrap-around behavior > introduced in #1431. drmarmac has updated the pull request incrementally with one additional commit since the last revision: javaDoc updates according to code review - Changes: - all: https://git.openj