Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v8]

2022-11-29 Thread Nir Lisker
On Tue, 29 Nov 2022 18:37:23 GMT, Kevin Rushforth wrote: >> interesting - there is technically no change, as `TableColumnBase` >> implements `EventTarget`. >> @hjohn does javadoc produce a different result? > > I checked, and yes it does produce a different result: > > Current: > > > public c

Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v8]

2022-11-29 Thread Kevin Rushforth
On Tue, 29 Nov 2022 18:24:29 GMT, Andy Goryachev wrote: >> modules/javafx.controls/src/main/java/javafx/scene/control/TableColumn.java >> line 134: >> >>> 132: * @since JavaFX 2.0 >>> 133: */ >>> 134: public class TableColumn extends TableColumnBase { >> >> This class is part of the public A

Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v8]

2022-11-29 Thread Kevin Rushforth
On Tue, 29 Nov 2022 16:55:34 GMT, John Hendrikx wrote: >> Note: I ran into a `javac` compiler bug while replacing types with diamond >> operators (ecj has no issues). I had two options, add a >> `SuppressWarnings("unused")` or to use a lambda instead of a method >> reference to make `javac` h

Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v8]

2022-11-29 Thread Andy Goryachev
On Tue, 29 Nov 2022 18:12:26 GMT, Kevin Rushforth wrote: >> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 23 commits: >> >> - Merge branch 'master' of https://git.openjdk.org/jfx into >> feature/fix-easy-warnings

Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v8]

2022-11-29 Thread Andy Goryachev
On Tue, 29 Nov 2022 16:55:34 GMT, John Hendrikx wrote: >> Note: I ran into a `javac` compiler bug while replacing types with diamond >> operators (ecj has no issues). I had two options, add a >> `SuppressWarnings("unused")` or to use a lambda instead of a method >> reference to make `javac` h

Re: RFR: JDK-8297414: Remove easy warnings in javafx.controls [v8]

2022-11-29 Thread John Hendrikx
> Note: I ran into a `javac` compiler bug while replacing types with diamond > operators (ecj has no issues). I had two options, add a > `SuppressWarnings("unused")` or to use a lambda instead of a method reference > to make `javac` happy. I choose the later and added a comment so it can be >