On Mon, 24 Jul 2023 12:43:57 GMT, Hima Bindu Meda wrote:
>> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1).
>> Verified the updated version build, sanity tests and stability. No issues
>> have been observed.
>
> Hima Bindu Meda has updated the pull request incrementally with one
> additional
On Mon, 24 Jul 2023 12:43:57 GMT, Hima Bindu Meda wrote:
>> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1).
>> Verified the updated version build, sanity tests and stability. No issues
>> have been observed.
>
> Hima Bindu Meda has updated the pull request incrementally with one
> additional
On Mon, 24 Jul 2023 02:50:30 GMT, Jay Bhaskar wrote:
> > Oh, I see that now. What led me to ask this question was that there is an
> > alternative implementation in `#if PLATFORM(JAVA)`, which implies that we
> > removed the call to `stripLeadingAndTrailingHTMLSpaces` and that it is
> > still
> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1).
> Verified the updated version build, sanity tests and stability. No issues
> have been observed.
Hima Bindu Meda has updated the pull request incrementally with one additional
commit since the last revision:
Remove check for PLATFORM(JAVA)
On Sun, 23 Jul 2023 15:55:39 GMT, Johan Vos wrote:
> > Oh, I see that now. What led me to ask this question was that there is an
> > alternative implementation in `#if PLATFORM(JAVA)`, which implies that we
> > removed the call to `stripLeadingAndTrailingHTMLSpaces` and that it is
> > still pr
On Fri, 21 Jul 2023 16:52:27 GMT, Jay Bhaskar wrote:
> absoluteLinkURL
Agree
-
PR Comment: https://git.openjdk.org/jfx/pull/1180#issuecomment-1647113499
On Sun, 23 Jul 2023 10:28:18 GMT, yosbits wrote:
> I found a change to turn off DFGJIT by default, is this a fix for some
> problem?
>
> modules/javafx.web/src/main/java/com/sun/webkit/WebPage.java
The Change is required, as it is making issues with complex js code written for
a website.
---
On Fri, 21 Jul 2023 17:04:44 GMT, Kevin Rushforth wrote:
> Oh, I see that now. What led me to ask this question was that there is an
> alternative implementation in `#if PLATFORM(JAVA)`, which implies that we
> removed the call to `stripLeadingAndTrailingHTMLSpaces` and that it is still
> pres
On Thu, 20 Jul 2023 15:36:28 GMT, Hima Bindu Meda wrote:
> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1).
> Verified the updated version build, sanity tests and stability. No issues
> have been observed.
I found a change to turn off DFGJIT by default, is this a fix for some problem?
modules
On Thu, 20 Jul 2023 15:36:28 GMT, Hima Bindu Meda wrote:
> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1).
> Verified the updated version build, sanity tests and stability. No issues
> have been observed.
@johanvos or @tiainen Can one you be the second reviewer?
-
PR Comment: ht
On Thu, 20 Jul 2023 15:36:28 GMT, Hima Bindu Meda wrote:
> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1).
> Verified the updated version build, sanity tests and stability. No issues
> have been observed.
Looks good. Testing is green.
-
Marked as reviewed by kcr (Lead).
PR Revi
On Thu, 20 Jul 2023 15:36:28 GMT, Hima Bindu Meda wrote:
> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1).
> Verified the updated version build, sanity tests and stability. No issues
> have been observed.
> You can include this in the next "cherry-pick" update, if you prefer.
> You can inc
On Thu, 20 Jul 2023 15:36:28 GMT, Hima Bindu Meda wrote:
> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1).
> Verified the updated version build, sanity tests and stability. No issues
> have been observed.
You can include this in the next "cherry-pick" update, if you prefer.
-
PR
On Thu, 20 Jul 2023 15:36:28 GMT, Hima Bindu Meda wrote:
> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1).
> Verified the updated version build, sanity tests and stability. No issues
> have been observed.
Oh, I see that now. What led me to ask this question was that there is an
alternative i
On Fri, 21 Jul 2023 14:24:17 GMT, Kevin Rushforth wrote:
> Is this new code or was it moved / refactored from elsewhere? If new code,
> what is its purpose, and who is calling it?
It was taken from last webkit update, as it was giving undefined reference
error for current webkit update.
> ```
On Thu, 20 Jul 2023 15:36:28 GMT, Hima Bindu Meda wrote:
> Updated JavaFX Webkit to GTK WebKit 2.40 (616.1).
> Verified the updated version build, sanity tests and stability. No issues
> have been observed.
I have two questions. Because of the large number of files, I can't use the
"diffs" vie
Updated JavaFX Webkit to GTK WebKit 2.40 (616.1).
Verified the updated version build, sanity tests and stability. No issues have
been observed.
-
Commit messages:
- Update WebKit to 616.1
Changes: https://git.openjdk.org/jfx/pull/1180/files
Webrev: https://webrevs.openjdk.org/?rep
17 matches
Mail list logo
