The proposal to merge lp:~m2j/openlp/i18n into lp:openlp has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/93633
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/93633
Your team OpenLP Core is subscribed to branch lp:o
The proposal to merge lp:~m2j/openlp/i18n into lp:openlp has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/93633
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/93633
Your team OpenLP Core is subscribed to branc
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/93633
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/93633
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
Meinert Jordan has proposed merging lp:~m2j/openlp/i18n into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #802166 in OpenLP: "Allow different scripture notations"
https://bugs.launchpad.net/openlp/+bug/802166
For more details, see:
https://code.launchpad.net/~m2
I have no Qt 4.8 available so this would have been untested. As the only
difference to my implementation is the fact, that the localized strings are
pulled from CLDR (http://cldr.unicode.org) instead of our translators I did not
implement this.
If you like it to be implemented, I will have to fi
Maybe use a conditional import so that if the person is using 4.8, they use the
Qt function.
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/93489
Your team OpenLP Core is requested to review the proposed merge of
lp:~m2j/openlp/i18n into lp:openlp.
___
Meinert Jordan has proposed merging lp:~m2j/openlp/i18n into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #802166 in OpenLP: "Allow different scripture notations"
https://bugs.launchpad.net/openlp/+bug/802166
For more details, see:
https://code.launchpad.net/~m2
The proposal to merge lp:~m2j/openlp/i18n into lp:openlp has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/91591
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/91591
Your team OpenLP Core is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/91591
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/91591
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
The proposal to merge lp:~m2j/openlp/i18n into lp:openlp has been updated.
Commit Message changed to:
i18n for scripture references.
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/91591
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/91591
Your team OpenLP Core
I've replaced the placeholder text with greyed out text.
So Andreas archieved that I made it more userfriendly as people can just add
another separator without retyping the default list (initially I wanted to do
this, but I choose the other solution out of lazyness).
--
https://code.launchpad.ne
Meinert Jordan has proposed merging lp:~m2j/openlp/i18n into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
mahfiaz (mahfiaz)
Andreas Preikschat (googol)
Related bugs:
Bug #802166 in OpenLP: "Allow different scripture notations"
https://bugs.launchpad.ne
Review: Needs Information
Ah... partial approval. Before I can approve this completely we need to sort
out in which versions setPlaceholderText available is
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89545
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89545
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
Andreas: You've assigned the comma for several seperator types? Well, why
you're wondering, that it does just select not the intended one of the
possibilities?
Other than that I can't reproduce this.
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89545
Your team OpenLP Core is subscribed
Maybe a placeholder text is not the right thing to use (because the user might
just want to change or add another separator). A placeholder text might be
useful in a search bar (nobody is likely going to search for the placeolder
text ("Search...")).
--
https://code.launchpad.net/~m2j/openlp/i1
And you have to be careful! setPlaceholderText is not available in all PyQt
versions (though it works here)!
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89545
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://
Review: Needs Fixing
I have changed the verse separator to "," and when I search Genesis 1,1 it
returns the whole chapter instead of just the first verse.
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89545
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Review: Approve
Maybe restricting user from inputting numbers, as Meinert said on IRC, would be
even better.
But even without that I really like it!
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89545
Your team OpenLP Core is subscribed to branch lp:openlp.
_
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89545
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
Review: Approve
This looks fine to me, but being linguistically-challenged, I can't test it out
properly. Maybe we can get Andreas to do that?
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89545
Your team OpenLP Core is subscribed to branch lp:openlp.
___
The proposal to merge lp:~m2j/openlp/i18n into lp:openlp has been updated.
Commit Message changed to:
i18n and customisation of scripture reference strings.
more optional scripture reference separators and alternative unicode hypens
fix RegEx for scripture references with trailing list separator
Meinert Jordan has proposed merging lp:~m2j/openlp/i18n into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89545
i18n for scripture references.
I've implemented i18n for scripture reference strings.
Translation is
Now I decided to use the second solution as I feel, that it might easier for
translators to translate four strings with knows terms, then to search for a
new term, which covers all cases.
While looking at the regular expression, I realized, that did not handle
trailing list separators correctly
line 37: OK. I will change this.
lines 261ff: In case of verse, range and list I'm calling the values
'separator'. In case of end, I'm calling it 'end mark' all over the GUI as it
does not separate anything. So I see two meaningful solutions:
1) Rename the value in the tooltip to something gene
Review: Needs Fixing
line 37 comment should not be at the end of the line and using the string is
fine.
261,266 etc can we have common text as the tool tip seems to be duplicated 4
times
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89111
Your team OpenLP Core is subscribed to branch l
Meinert Jordan has proposed merging lp:~m2j/openlp/i18n into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89111
i18n for scripture references.
I've implemented i18n for scripture reference strings.
Translation is
The proposal to merge lp:~m2j/openlp/i18n into lp:openlp has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89111
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89111
Your team OpenLP Core is subscribed
Meinert Jordan has proposed merging lp:~m2j/openlp/i18n into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89111
i18n for scripture references.
I've implemented i18n for scripture reference strings.
Translation is
The proposal to merge lp:~m2j/openlp/i18n into lp:openlp has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/88937
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/88937
Your team OpenLP Core is subscribed
Meinert Jordan has proposed merging lp:~m2j/openlp/i18n into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/88937
I've enabled translation of bible references. Some replacement hypens should
are introduced.
(reopen
Review: Needs Fixing
Need to update against head
Need to get window build updated sooner than this merge goes in.
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/88930
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: h
Meinert Jordan has proposed merging lp:~m2j/openlp/i18n into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/88930
locale.strcoll does not work correct on Windows with utf-8
[http://sgehrig.wordpress.com/2008/12
The proposal to merge lp:~m2j/openlp/i18n into lp:openlp has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/44934
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/44934
Your team OpenLP Core is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/44934
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https:
Review: Approve
Approved but do not like the formating of lines like 798-803
The code is much harder to read.
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/44934
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://
m2j has proposed merging lp:~m2j/openlp/i18n into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/44934
While walking through the German translation, I observed a couple of problems
in the internationalization.
39 matches
Mail list logo
