Commenting out this assert everything seems to be OK.
Indeed: http://openocd.zylin.com/297
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd
-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd
Commenting out this assert everything seems to be OK.
This will eventually cause a crash and must be fixed.
The fix is easy: just provide a storage for in_value when using callbacks or
checking against value/mask.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1
loader is 130K.
What's the maximum theoretical performance according to the datasheets?
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd
for USB is 1ms, whereas it can be in the us range
for e.g. ZY1000.
You may be able to find out where you're loosing performance due to USB
latency and then optimize it to use larger read/writes.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http
Please read latest HACKING and push to gerrit for review.
Thanks!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development
Comments welcome!
https://docs.google.com/present/view?id=dhftn35p_14s2xxcbt3
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development
a week.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd
OpenOCD to build clean of clang
warnings, but it will
be some time until we're there.
At that point we will probably make 0 clang warnings a requirement for
new patches.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
Setting up the commit-msg hook isn't possible using http only:
scp -p -P 29418 usern...@openocd.zylin.com:hooks/commit-msg .git/hooks/
http://repo.or.cz/w/openocd.git/blame?f=HACKING
Any suggestions?
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866
Should we?
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd
On Wed, Nov 2, 2011 at 9:06 PM, Tomek CEDRO tomek.ce...@gmail.com wrote:
On Wed, Nov 2, 2011 at 8:03 PM, Øyvind Harboe oyvind.har...@zylin.com wrote:
Should we?
What does these scripts do? Will they work on FreeBSD? :-P :-)
They allow you to check patches for coding style, remove whitespace
Please post to Gerrit for review. See latest HACKING doc for details.
Thanks!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development
and build system is new, so I've been
using simple warning fixes to take it for a spin.
3. w.r.t. the review process, I was thinking if we should have a rule
like: a patch can be submitted if a week has gone without feedback
and it looks good, or a second reviewer approves it.
--
Øyvind Harboe - Can
has been split in two, then copy and paste code can be
avoided more easily for ir/drscan versions of the same command.
clang is new to me, so I'm still learning to interpret it's warnings into
sensible refactorings.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866
.
checkpatch is run without any options.
(I'm sure Spencer will post more details on how we run the tests...)
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing
, I'd like us not to increase # of warnings
with new patches, but that check is not enforced yet via Gerrit
verification flag.
http://openocd.zylin.com/jenkins/job/openocd-clang/2/warningsResult/
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http
2011/10/28 Peter Stuge pe...@stuge.se:
ger...@openocd.zylin.com wrote:
-DumpTargets:
+DumpTargets:;
Hm?
Syntactically a declaration can't follow a label, so add an empty statement.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http
On Fri, Oct 28, 2011 at 12:23 AM, Peter Stuge pe...@stuge.se wrote:
Øyvind Harboe wrote:
2011/10/28 Peter Stuge pe...@stuge.se:
ger...@openocd.zylin.com wrote:
-DumpTargets:
+DumpTargets:;
Hm?
Syntactically a declaration can't follow a label, so add an empty
statement.
I don't
On Fri, Oct 28, 2011 at 12:59 AM, Peter Stuge pe...@stuge.se wrote:
Øyvind Harboe wrote:
I don't like the change so much. It ends up declaring the exact same
variable twice, and other odd noise, to silence a warning. Is there
no better way?
Reusing the 'target' variable name here is bad
easier with
command line, than to try to explain how to use a web interface.
I don't use Windows myself, so from that point of view TortoiseGit is a
non-starter. I see that there is a tortoisehg for Linux.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
How about going to openocd.zylin.com and checking which patches are
still outstanding every few days?
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
On Wed, Oct 26, 2011 at 3:09 PM, jim norris u17...@att.net wrote:
Assuming I've done my commits. How do I see what the
patch will look like before I do the 'git push review'?
git format-patch origin/master
= produces patch files
--
Øyvind Harboe - Can Zylin Consulting help on your
interative allows you to edit a commit if you will.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https
around interactive rebase is oversimplifying git(and DVCS
in general).
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
Could someone take checkpatch for a spin and report back to the
list on if/how we should use in w/Gerrit+Jenkins review?
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd
On Tue, Oct 25, 2011 at 9:48 AM, Spencer Oliver s...@spen-soft.co.uk wrote:
On Oct 25, 2011 8:34 AM, Øyvind Harboe oyvind.har...@zylin.com wrote:
Could someone take checkpatch for a spin and reporter back to the
list on if/how we should use in w/Gerrit+Jenkins review?
I think it is used
We're still working on tweaking a few things, but it is up and running now.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development
concepts
out of the window. Where is the interactive rebase functionality?
I find that Eclipse EGit is starting to become useful and there is a
lot of development push on EGit.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
Use interactive rebasing:
git rebase --help
When you're done rebasing, just type git push review and all the updated
patches will be updated in gerrit.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
Nice?
Unused code and bugs... For instance, not used retval means missing check
and error propagation = real bug.
http://openocd.zylin.com/jenkins/job/openocd-gerrit/70/warningsResult/?
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http
clean scan-build for verification flag to be set.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https
We're having problems with the new server.
More info tomorrow.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
a failure.
Hopefully this will drive us towards zero scan-build warnings.
Also, -O3 is added, which can yield an occasional extra warning
compared to -O2(default).
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
out the nits of the system. I need to retrigger some builds
before you see the status quo.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd
updated patch!
oyvind@titan:~/workspace/openocd$ git push review
Stand back... and your patch should go green...
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing
Could someone try this on OpenOCD and report back?
I'd like to see this run on the Jenkins server so that we can be sure
that we run with the minimum # of includes.
Reducing the # of includes is good from an architectural point of
view to reduce cohesion between parts of the system.
--
Øyvind
. Next time it's up to you ;-)
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman
in the output of the latest
build.
- Make a fix
- Commit
- git push review
http://openocd.zylin.com/jenkins/job/openocd/lastBuild/console
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
of course. The header can say FreeBSD though.
Copy header from Jim project.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development
directory '/tmp/scan-build-2011-10-21-1' because
it contains no reports.
This is with Ubuntu.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd
I upgraded to Ubuntu 11.10 from Ubuntu 11.04 and now it works :-)
Looks like this is bleeding edge stuff...
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development
for a week on this one
and there is a known workaround.
It's speeding things along nicely that you're helping to fill
in the information.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
On Thu, Oct 20, 2011 at 7:35 AM, Peter Stuge pe...@stuge.se wrote:
Øyvind Harboe wrote:
I'm thinking a bit about how I can draw up some graphs on this...
Graphing number of commits is easy, but graphing the review is
difficult.
Before we got Gerrit going I decided that I could no longer
On Thu, Oct 20, 2011 at 8:38 AM, Peter Stuge pe...@stuge.se wrote:
Øyvind Harboe wrote:
Some graphing I've been thinking about:
- plot a number that shows the redundancy in maintainers. I.e. are we
relying on a single maintainer or are there multiple maintainers
I've so far taken infinitely
was broken.
Things have improved infinitely after we introduced Gerrit. Patches
are now being submitted again.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing
round of applause to Spencer who's spent
the time fixing the OpenOCD process by reading up on and setting up the
Gerrit+Jenkins server
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
your approval, then that input will be very much
appreciated and result in real improvements to code and patches
being committed more rapidly.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
of testing automatically, including everything
you mentioned.
Definitely we want -Werror and we already do. We're also considering
adding clang static analysis, but that's some ways off still.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http
to the developers upstream? OpenOCD
just uses Gerrit. What you've find may be a beauty spot depending
on who you ask.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development
Patches pushed Gerrit most welcome! :-)
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de
Is there a way to upload patches to Gerrit w/o ssh?
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https
Please read HACKING and post to Gerrit.
Thanks!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https
to configure and us Gerrit, then that's
really a non-issue, because maintainers are not going to spend their
time to save the contributors this effort.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
we'll accept in terms
of errors like we do for gcc(-Werror -Wall is minimum acceptable
for patches now).
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
and submitting to the repository.
I'm thinking a bit about how I can draw up some graphs on this...
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd
Does anyone want to take clang static analyzer for a spin on openocd?
http://clang-analyzer.llvm.org/scan-build.html
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd
On Tue, Oct 18, 2011 at 9:46 PM, Spencer Oliver s...@spen-soft.co.uk wrote:
On 18/10/2011 18:18, Øyvind Harboe wrote:
Does anyone want to take clang static analyzer for a spin on openocd?
http://clang-analyzer.llvm.org/scan-build.html
seems jenkins already has a plugin for that :)
https
Cool!
Could I ask you to work through and fix some of the bugs and
submit them to Gerrit?
I'd like to see patches having to pass clang static analyzer unscathed before
they're ready for review :-)
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http
Even if you're not a maintainer, your help to review and comment
on patches in Gerrit will be very much appreciated.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd
If someone wants to test out the DCC performance before and
after this patch, it would be much appreciated!
http://openocd.zylin.com/27
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
What's a good way to check that I've addressed all the comments
to a patch series?
Going over it manually?
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing
.
The maintainers role is then to comment and say yay or nay.
No software required to be installed locally, which allows maintainers to
help out without their development system at hand. Very important
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http
There is some in the OpenOCD manual, but we would very much welcome
patches for more!
Did you check out the documentation you could find in the OpenOCD manual?
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
I checked on the http://openocd.sourceforge.net/doc//pdf/openocd.pdf. I did
a find on rtos keyword, and find nothing about this.
Perhaps that pdf is old, try openocd.texi from HEAD of master.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http
Please submit all outstanding patch series to Gerrit.
Read latest HACKING docs for tips on how to get started.
By doing this you will be helping to save maintainers time so that
we can focus on reviewing and commenting.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free
that the open-source crowd can spend their valuable time on
producing free and open-source software instead of boring tasks like
web hosting, I believe.
I thought it was easier to recall than a.b1-d72-df-sd2-eapps.com
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866
If someone wants to contribute a patch with documentation on how
to use gerrit, that would be most welcome!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing
How do I push a patch series to gerrit?
Does gerrit have a concept of patch series or are all patches islands?
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development
, etc.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
:
remote: breakpoint : indentation
remote:
remote: Signed-off-by: Øyvind Harboe oyvind.har...@zylin.com
remote:
remote: Change-Id: Icdb8f72dbb516cd0dfc612c3d61b6801f6382be6
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
Ah gotit.
I need a unique id per patch, I thought the id had to be unique per series.
I thought that patches would be displayed as series within the same
patch id rather
than this depends on scheme.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http
Anyway you can check this site to find any hoster with a code review
ability:
http://en.wikipedia.org/wiki/Comparison_of_open_source_software_hosting_facilities
No gerrit listed. I've asked sourceforge if they can install it, but
I'm not holding
my breath.
--
Øyvind Harboe - Can Zylin
sourceforge does not offer gerrit. Is there a hosting service that does?
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development
causes all warnings to produce
errors. This is to force us to fix all errors as we go along.
Please submit a patch to fix the warnings.
Thanks!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
I find gerrit intriguing as a way of managing patches.
Can I have a show of hands of contributors for/against/don't care/don't know?
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
http://code.google.com/p/gerrit/
I have no idea what it does, but I'm very excited! :-)
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd
No mailing list???
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo
+// 2011-09-27 MWi Flash type 2 added, algorithm start address now relocateable
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development
Can someone review these patches and comment?
Thanks!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https
Merged.
Thanks!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo
Merged.
Thanks!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo
Merged.
Thanks!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo
the site and edit your account via the
Account Maintenance link.
Direct any questions to ad...@berlios.de, or reply to this email.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd
On Sat, Oct 1, 2011 at 12:45 AM, Jim Larson jlar...@pacifier.com wrote:
Any consideration of using github (github.com)? I've been pretty happy with
them and they have a huge user base.
I haven't used them. Would you mind explaining the major features of github
to the list?
--
Øyvind Harboe
So what happens in the transitional period?
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https
On Thu, Sep 29, 2011 at 8:42 AM, Steve Bennett ste...@workware.net.au wrote:
It lives in both openocd and jimtcl, but openocd uses it's own version.
Because --disable-nvp is used when building OpenOCD?
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
))
+ {
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development
Merged.
Thanks!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo
Merged.
Thanks!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo
]);
+
+ return retval;
+}
5. Bug:
+ // Wait for busy clear
+ retval = stm32lx_wait_until_bsy_clear(bank);
+ return retval;
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
Please merge the two patches into one:
git rebase -i origin/master
= squash your patches together
read HACKING for further tips.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com
() or remove.
+ retval = stm32lx_write_rdp(bank, 0xAA);
+ if (retval != ERROR_OK)
+ {
+ LOG_ERROR(failed to write RDP byte);
+ return retval;
+ }
+ }
6.
--
Øyvind Harboe - Can Zylin
I'll let it cool off for a few days. Please give word if further work
is required and
we should submit an updated patch.
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd
Merged.
Thanks!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo
Merged.
Thanks!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo
);
+
+ if (master_bank == NULL) {
+ return;
+ }
+
5. propagate (just return) the error code, do not change it:
+ if (kinetis_ftfl_command(bank, w0, w1, w2) != ERROR_OK) {
+ return ERROR_FLASH_OPERATION_FAILED;
+ }
+
+
--
Øyvind Harboe - Can
Merged.
Thanks!
--
Øyvind Harboe - Can Zylin Consulting help on your project?
US toll free 1-866-980-3434
http://www.zylin.com/
___
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd
to LOG_DEBUG()? Certainly remove
stm32lx_write_rdp: because LOG_ERROR() adds that info already.
+retval = stm32lx_unlock_option_byte(bank);
+if (retval != ERROR_OK)
+{
+LOG_ERROR(stm32lx_write_rdp: failed to unlock option byte);
+return retval;
--
Øyvind Harboe - Can
1 - 100 of 3196 matches
Mail list logo
