Re: [Openocd-development] NAND: add erase_page callback

2009-12-16 Thread Marek Vasut
Dne Po 14. prosince 2009 21:55:25 David Brownell napsal(a): > On Monday 14 December 2009, Marek Vasut wrote: > > Dne Po 14. prosince 2009 02:46:26 David Brownell napsal(a): > > > On Sunday 13 December 2009, Marek Vasut wrote: > > > > I'd send followup patch that'd clean that mess up altogether ...

Re: [Openocd-development] NAND: add erase_page callback

2009-12-14 Thread Øyvind Harboe
On Tue, Dec 15, 2009 at 1:42 AM, Marek Vasut wrote: > Dne Po 14. prosince 2009 21:55:25 David Brownell napsal(a): >> On Monday 14 December 2009, Marek Vasut wrote: >> > Dne Po 14. prosince 2009 02:46:26 David Brownell napsal(a): >> > > On Sunday 13 December 2009, Marek Vasut wrote: >> > > > I'd se

Re: [Openocd-development] NAND: add erase_page callback

2009-12-14 Thread Dean Glazeski
On Mon, Dec 14, 2009 at 6:42 PM, Marek Vasut wrote: > Dne Po 14. prosince 2009 21:55:25 David Brownell napsal(a): > > On Monday 14 December 2009, Marek Vasut wrote: > > > Dne Po 14. prosince 2009 02:46:26 David Brownell napsal(a): > > > > On Sunday 13 December 2009, Marek Vasut wrote: > > > > > I

Re: [Openocd-development] NAND: add erase_page callback

2009-12-14 Thread Marek Vasut
Dne Po 14. prosince 2009 21:55:25 David Brownell napsal(a): > On Monday 14 December 2009, Marek Vasut wrote: > > Dne Po 14. prosince 2009 02:46:26 David Brownell napsal(a): > > > On Sunday 13 December 2009, Marek Vasut wrote: > > > > I'd send followup patch that'd clean that mess up altogether ...

Re: [Openocd-development] NAND: add erase_page callback

2009-12-14 Thread David Brownell
On Monday 14 December 2009, Marek Vasut wrote: > Dne Po 14. prosince 2009 02:46:26 David Brownell napsal(a): > > On Sunday 13 December 2009, Marek Vasut wrote: > > > I'd send followup patch that'd clean that mess up altogether ... it's > > > cleaner and much easier to track back in git log. > > >

Re: [Openocd-development] NAND: add erase_page callback

2009-12-14 Thread Marek Vasut
Dne Po 14. prosince 2009 02:46:26 David Brownell napsal(a): > On Sunday 13 December 2009, Marek Vasut wrote: > > I'd send followup patch that'd clean that mess up altogether ... it's > > cleaner and much easier to track back in git log. > > Go for it then. :) > Merge the erase patch then. :) ___

Re: [Openocd-development] NAND: add erase_page callback

2009-12-13 Thread David Brownell
On Sunday 13 December 2009, Marek Vasut wrote: > > I'd send followup patch that'd clean that mess up altogether ... it's cleaner > and much easier to track back in git log. Go for it then. :) ___ Openocd-development mailing list Openocd-development@l

Re: [Openocd-development] NAND: add erase_page callback

2009-12-13 Thread Marek Vasut
Dne Ne 13. prosince 2009 21:06:32 David Brownell napsal(a): > On Sunday 13 December 2009, Marek Vasut wrote: > > > > > Either provide the > > > > > current logic in a separate routine that gets patched into the > > > > > ops vector of any driver that doesn't have it, or ... > > > > We can do so in

Re: [Openocd-development] NAND: add erase_page callback

2009-12-13 Thread David Brownell
On Sunday 13 December 2009, Marek Vasut wrote: > > > > > > Either provide the > > > > current logic in a separate routine that gets patched into the > > > > ops vector of any driver that doesn't have it, or ... > > We can do so in one go in a separate patch if you want to do this kind of > clean

Re: [Openocd-development] NAND: add erase_page callback

2009-12-13 Thread Marek Vasut
Dne Ne 13. prosince 2009 06:36:47 David Brownell napsal(a): > On Saturday 12 December 2009, Marek Vasut wrote: > > > Also, can you restructure it so that you don't just add a bit > > > "if (there's a custom erase_page) { ... }"? That's the sort > > > of thing which is easier to just require. > > >

Re: [Openocd-development] NAND: add erase_page callback

2009-12-12 Thread Dean Glazeski
On Sat, Dec 12, 2009 at 11:36 PM, David Brownell wrote: > On Saturday 12 December 2009, Marek Vasut wrote: > > > Also, can you restructure it so that you don't just add a bit > > > "if (there's a custom erase_page) { ... }"? That's the sort > > > of thing which is easier to just require. > > > >

Re: [Openocd-development] NAND: add erase_page callback

2009-12-12 Thread David Brownell
On Saturday 12 December 2009, Dean Glazeski wrote: > > > > Also, can you restructure it so that you don't just add a bit > > "if (there's a custom erase_page) { ... }"? That's the sort > > of thing which is easier to just require. > > > > So, does this mean we restructure the entire NAND core to

Re: [Openocd-development] NAND: add erase_page callback

2009-12-12 Thread David Brownell
On Saturday 12 December 2009, Marek Vasut wrote: > > Also, can you restructure it so that you don't just add a bit > > "if (there's a custom erase_page) { ... }"?  That's the sort > > of thing which is easier to just require. > > Require? Why? No other driver probably needs it/will find it useful.

Re: [Openocd-development] NAND: add erase_page callback

2009-12-12 Thread Marek Vasut
Dne Ne 13. prosince 2009 05:21:36 Dean Glazeski napsal(a): > > Also, can you restructure it so that you don't just add a bit > > "if (there's a custom erase_page) { ... }"? That's the sort > > of thing which is easier to just require. > > So, does this mean we restructure the entire NAND core to

Re: [Openocd-development] NAND: add erase_page callback

2009-12-12 Thread Dean Glazeski
> > Also, can you restructure it so that you don't just add a bit > "if (there's a custom erase_page) { ... }"? That's the sort > of thing which is easier to just require. > So, does this mean we restructure the entire NAND core to get rid of if (nand->function) {nand->function()} blocks for just

Re: [Openocd-development] NAND: add erase_page callback

2009-12-12 Thread Marek Vasut
Dne Ne 13. prosince 2009 03:25:07 David Brownell napsal(a): > On Saturday 12 December 2009, Marek Vasut wrote: > > > I was wondering why to merge something that doesn't have any > > > users ... :) > > > > I have pxa3xx nand driver ready that will need this, preparing ground to > > deploy it. > > M

Re: [Openocd-development] NAND: add erase_page callback

2009-12-12 Thread David Brownell
On Saturday 12 December 2009, Marek Vasut wrote: > > > I was wondering why to merge something that doesn't have any > > users ... :) > > I have pxa3xx nand driver ready that will need this, preparing ground to > deploy > it. Mmkay... > > And was also curious what's wrong with the standard er

Re: [Openocd-development] NAND: add erase_page callback

2009-12-12 Thread Marek Vasut
Dne So 12. prosince 2009 22:39:43 David Brownell napsal(a): > On Saturday 12 December 2009, Marek Vasut wrote: > > Dne So 12. prosince 2009 00:41:48 Marek Vasut napsal(a): > > > included is a patch that adds possibility to supply erase_page function > > > in a driver, overriding the default behavio

Re: [Openocd-development] NAND: add erase_page callback

2009-12-12 Thread David Brownell
On Saturday 12 December 2009, Marek Vasut wrote: > Dne So 12. prosince 2009 00:41:48 Marek Vasut napsal(a): > > > > included is a patch that adds possibility to supply erase_page function in > > a driver, overriding the default behaviour of core.c > > Hi, any updates ? Thanks I was wondering why

Re: [Openocd-development] NAND: add erase_page callback

2009-12-12 Thread Marek Vasut
Dne So 12. prosince 2009 00:41:48 Marek Vasut napsal(a): > Hi, > > included is a patch that adds possibility to supply erase_page function in > a driver, overriding the default behaviour of core.c > Hi, any updates ? Thanks ___ Openocd-development mail

[Openocd-development] NAND: add erase_page callback

2009-12-11 Thread Marek Vasut
Hi, included is a patch that adds possibility to supply erase_page function in a driver, overriding the default behaviour of core.c From 7fa880bfe5a541b1b5df520cf023268491d4ca2e Mon Sep 17 00:00:00 2001 From: Marek Vasut Date: Sat, 12 Dec 2009 00:39:54 +0100 Subject: [PATCH] NAND: Add erase_page