And it is only used at one place in PLM, so the macro can be removed and
code inserted at that place.
regards,
Anders Widell
2013-12-09 16:13, Hans Feldt skrev:
If PLM is now the only user of this please change PLM instead.
/Hans
On 12/09/2013 08:31 AM, ramesh.bet...@oracle.com wrote:
The macro definitions of m_KEY_CMP and m_GET_BIT are wrong: macro
parameters must always be surrounded with parentheses in the macro
expression:
#define m_KEY_CMP(t, k1, k2) memcmp(k1, k2, (size_t)(t)-params.key_size)
#define m_GET_BIT(key, bit) ((bit 0) ? 0 : ((int)((*((key) + (bit
3))) (7
There are printf() and fprintf() calls in this code:
2013-12-05 13:51, ramesh.bet...@oracle.com skrev:
+ printf(\nMQSV:MQD:ON);
if (mqd_lib_req(lib_create) != NCSCC_RC_SUCCESS) {
fprintf(stderr, mqd_lib_req FAILED\n);
Since stdout and stderr are redirected to /dev/null
osaf/libs/core/common/daemon.c | 8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
use _Exit instead of exit in daemon_exit. The change was done due to
that exit() is not thread safe, see e.g. ticket #651.
To make it possible to dump e.g. coverage data on termination
a weak
Summary: base: use _Exit instead of exit in daemon_exit [#581]
Review request for Trac Ticket(s): 581
Peer Reviewer(s): AndersW,HansF,Ramesh
Pull request to:
Affected branch(es): default(4.4)
Development branch: default
Impacted area Impact y/n
Ack with comment. The ticket number is still not surrounded with square
brackets [#581] in the first line of the commit message.
regards,
Anders Widell
2013-12-10 10:37, Hans Nordeback skrev:
Summary: base: use _Exit instead of exit in daemon_exit [#581]
Review request for Trac Ticket(s): 581
Hi,
I will add saImmOm_A_2_13.h to the spec file.
Thanks,
Zoran
-Original Message-
From: Sirisha Alla [mailto:sirisha.a...@oracle.com]
Sent: den 10 december 2013 08:13
To: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 3 of 3] IMMTOOLS: Add support of NO_DANGLING flag
Ack with the comments I sent out in earlier mails.
Good work, this code is in need of some clean-up and this is a step in
the right direction!
regards,
Anders Widell
2013-12-05 13:51, ramesh.bet...@oracle.com skrev:
Summary: Clean up unused code in base [#537]
Review request for Trac
Summary: smfd: Possible to change SMF config parameters from a campaign
Review request for Trac Ticket(s): 652
Peer Reviewer(s): bertil
Pull request to:
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Ok, I will close both of them when this is fixed.
regards,
Anders Widell
2013-12-10 15:57, Hans Nordebäck skrev:
a ticket for this already exists
http://sourceforge.net/p/opensaf/tickets/320/ /BR HansN
-Original Message-
From: Anders Widell [mailto:anders.wid...@ericsson.com]
Summary: AMF: allow change of nodegroup in SG
Review request for Trac Ticket(s): 569
Peer Reviewer(s): Nags
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es): default
Development branch: IF ANY GIVE THE REPO URL
Impacted area Impact
osaf/services/saf/amf/amfd/sg.cc | 99 +--
1 files changed, 94 insertions(+), 5 deletions(-)
The SG configuration attribute saAmfSGSuHostNodeGroup cannot be changed. If an
application starts off with a node group such as SCs it cannot get out of it
without
osaf/services/saf/amf/amfd/sg.cc | 64 +--
1 files changed, 35 insertions(+), 29 deletions(-)
No functional changes. Just variable rename and some shorter lines in sg.cc
diff --git a/osaf/services/saf/amf/amfd/sg.cc b/osaf/services/saf/amf/amfd/sg.cc
---
Will consider this comment while submitting the patch.
Thanks,
Ramesh.
On 12/9/2013 8:43 PM, Hans Feldt wrote:
If PLM is now the only user of this please change PLM instead.
/Hans
On 12/09/2013 08:31 AM, ramesh.bet...@oracle.com wrote:
osaf/libs/core/include/ncs_osprm.h | 8
1
14 matches
Mail list logo
