Please keep the trace.
- su->saAmfSUFailover =
static_cast(sut->saAmfSutDefSUFailover);
- TRACE("Modified
saAmfSutDefSUFailover to '%u' for Su'%s'",
-
osaf/services/saf/logsv/lgs/lgs_filehdl.c | 4
osaf/services/saf/logsv/lgs/lgs_stream.c | 2 +-
2 files changed, 1 insertions(+), 5 deletions(-)
In case of close(), the first thing Linux does is deallocate the file
descriptor; then it starts flushing pending written data. If this proces
Ack
Thanks
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:osafde...@gmail.com]
> Sent: 30 April 2014 10:31
> To: Nagendra Kumar; Praveen Malviya; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 3 of 7] amfd: add and use SU method set_term_sta
Summary: log: Log should not retry when close() returns EINTR [#147]
Review request for Trac Ticket(s): 147
Peer Reviewer(s): Mathi/Lennart
Affected branch(es): 4.4.x; default
Development branch: default
Impacted area Impact y/n
--
The trace is there in the setter method, OK?
/HansF
On 2 May 2014 09:05, Nagendra Kumar wrote:
> Please keep the trace.
> - su->saAmfSUFailover =
> static_cast(sut->saAmfSutDefSUFailover);
> - TRACE("Modi
OK I will declare them private for now until we have a common macro for it.
/HansF
On 30 April 2014 13:49, Hans Nordebäck wrote:
> ack, only code review, one comment shouldn't copy and assignment operators
> be disabled? I.e. declare them private, or use google style
>
> DISALLOW_COPY_AND_ASSIGN(
Ack from me.
Tested.
Did not re-review the code.
/AndersBj
reddy.neelaka...@oracle.com wrote:
> Summary:Imm:Make immcfg aware of safImmService admin owner for
> opensafImm=opensafImm,safApp=safImmService [#840]
> Review request for Trac Ticket(s): 840
> Peer Reviewer(s): AndersBj, Zoran
> Affec
Ok. Please modify the trace as "Modified saAmfSutDefSUFailover to '%u' for Su
'%s'".
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:osafde...@gmail.com]
> Sent: 02 May 2014 13:05
> To: Nagendra Kumar
> Cc: Praveen Malviya; Hans Nordeback; opensaf-devel@lists.sourceforge.net
> Subj
ah ok sorry now I see yes it should be kept as you say in sutype.
I talked about su.
/HansF
On 2 May 2014 10:29, Nagendra Kumar wrote:
> Ok. Please modify the trace as "Modified saAmfSutDefSUFailover to '%u' for Su
> '%s'".
>
> -Nagu
>
>> -Original Message-
>> From: Hans Feldt [mailto:os
Ack
Thanks
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:osafde...@gmail.com]
> Sent: 30 April 2014 10:31
> To: Nagendra Kumar; Praveen Malviya; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 5 of 7] amfd: add and use set_su_switch [#713]
>
Ack
Thanks
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:osafde...@gmail.com]
> Sent: 30 April 2014 10:31
> To: Nagendra Kumar; Praveen Malviya; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 6 of 7] amfd: add and use SU get_node_ptr [#713]
Ack
Thanks
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:osafde...@gmail.com]
> Sent: 30 April 2014 10:31
> To: Nagendra Kumar; Praveen Malviya; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 7 of 7] amfd: add and use SU is_in_service [#713
Ack, I will push.
Thanks,
Hans
> -Original Message-
> From: Alex Jones [mailto:ajo...@genband.com]
> Sent: den 29 april 2014 16:04
> To: Hans Feldt
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [PATCH 1 of 1] amfd: fix infinite loop when processing CLM node
> tracking [#877]
>
>
1. Can we move all the initialization in default constructor and fill dn
name after words.
2. Other pointers are not necessary to initialize, any specific reason for
doing it?
Thanks
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:osafde...@gmail.com]
> Sent: 30 April 2
Ack
Thanks
-Nagu
> -Original Message-
> From: Alex Jones [mailto:ajo...@genband.com]
> Sent: 29 April 2014 19:34
> To: hans.fe...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: [devel] [PATCH 1 of 1] amfd: fix infinite loop when processing CLM
> node tracking [#877]
>
Hi Alex,
Good catch and nice work!!!
I think this is your first patch in Amf and we welcome you and your
contribution in Amf and would expect more contributions from you in future.
Thanks and Cheers...
-Nagu
> -Original Message-
> From: Alex Jones [mailto:ajo...@genband.com]
> Sent: 29
00-README.conf | 18 ++
osaf/libs/saf/include/saAis.h| 4
osaf/libs/saf/include/saAis_B_5_14.h | 17 +
3 files changed, 39 insertions(+), 0 deletions(-)
Add declarations of saAisNameLend() and saAisNameBorrow() to saAis.h.
Up
osaf/libs/agents/saf/imma/Makefile.am |1 +
osaf/libs/agents/saf/imma/aisa_api.c | 131 ++
osaf/libs/saf/libSaImm/libSaImmOm.map |2 +
3 files changed, 134 insertions(+), 0 deletions(-)
The functions saAisNameLend() and saAisNameBorrow() are defined in
s
osaf/libs/core/common/Makefile.am |1 +
osaf/libs/core/common/include/osaf_extended_name.h | 232 +
osaf/libs/core/common/osaf_extended_name.c | 184
osaf/libs/core/leap/sysf_def.c |3 +
4 files changed, 42
Summary: Extended Name Type [#191]
Review request for Trac Ticket(s): 191
Peer Reviewer(s): Mathi, AndersBj
Pull request to:
Affected branch(es): default(4.5)
Development branch: default
Impacted area Impact y/n
Docs
Hi Neelakanta,
I have 2 comments on next block:
867 if(!isSchemaChangeEnabled && ownerHandle1) {
868 error = immutil_saImmOmAdminOwnerFinalize(ownerHandle1);
869 if (SA_AIS_OK != error) {
870 fprintf(stderr, "error -
> -Original Message-
> From: Nagendra Kumar [mailto:nagendr...@oracle.com]
> Sent: den 2 maj 2014 12:31
> To: Hans Feldt; Praveen Malviya; Hans Nordebäck
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: Re: [devel] [PATCH 4 of 7] amfd: add SU constr/destr [#713]
>
> 1.Can we move
Ok.
-Nagu
> -Original Message-
> From: Hans Feldt [mailto:hans.fe...@ericsson.com]
> Sent: 02 May 2014 17:18
> To: Nagendra Kumar; Praveen Malviya; Hans Nordebäck
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: RE: [devel] [PATCH 4 of 7] amfd: add SU constr/destr [#713]
>
>
>
> >
osaf/services/saf/logsv/config/logsv_classes.xml | 5 +-
osaf/services/saf/logsv/lgs/lgs_imm.c| 58 +++-
2 files changed, 61 insertions(+), 2 deletions(-)
The OpenSAF integrator can either use the log service configuration object or
the environment
variables t
osaf/services/saf/logsv/lgs/lgs_imm.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
On UML based on ubuntu, the following code fails consistently.
if ((val_str = getenv(LOGSV_MAX_LOGRECSIZE)) != NULL) {
val_uint = strtoul(val_str, NULL, 0);
Summary: log: ignore environment variables when config object exists [#841]
Review request for Trac Ticket(s): #841
Peer Reviewer(s): lennart.l...@ericsson.com
Pull request to: <>
Affected branch(es): opensaf-4.3.x, 4.4.x, default
Development branch: <>
Impacted
I have already acked, but one more comment, the member initialization
in a constructor e.g AVD_SU can be used, (if you are not using e.g. init
function)
AVD_SU::AVD_SU(const SaNameT *dn)
: term_state(false),
su_switch(AVSV_SI_TOGGLE_STABLE),
...
{
}
/Regards Hans
On 05/02/14 13:47,
There are some problems found testing this one. Investigating...
/Hans
> -Original Message-
> From: Nagendra Kumar [mailto:nagendr...@oracle.com]
> Sent: den 2 maj 2014 13:57
> To: Hans Feldt; Praveen Malviya; Hans Nordebäck
> Cc: opensaf-devel@lists.sourceforge.net
> Subject: RE: [devel]
osaf/services/saf/amf/amfd/include/su.h | 22 +++-
osaf/services/saf/amf/amfd/su.cc| 80 +++-
2 files changed, 46 insertions(+), 56 deletions(-)
diff --git a/osaf/services/saf/amf/amfd/include/su.h
b/osaf/services/saf/amf/amfd/include/su.h
--- a/osaf/se
Summary: v2 amfd SU constr/destr
Review request for Trac Ticket(s): 713
Peer Reviewer(s): Nags & Hans
Pull request to: <>
Affected branch(es): default
Development branch: default
Impacted area Impact y/n
Docs
ack, code review only/Regards HansN
On 05/02/14 15:01, Hans Feldt wrote:
> osaf/services/saf/amf/amfd/include/su.h | 22 +++-
> osaf/services/saf/amf/amfd/su.cc| 80
> +++-
> 2 files changed, 46 insertions(+), 56 deletions(-)
>
>
> diff --git a/osaf/se
New patch please, see inline.
Thanks,
Hans
On 25 April 2014 13:13, wrote:
> osaf/services/saf/avsv/avd/avd_csi.c | 46
> ---
> osaf/services/saf/avsv/avd/avd_sgproc.c | 17 ++
> osaf/services/saf/avsv/avd/include/avd_csi.h | 1 +
> 3 files chang
Hi zoran,
while pushing, i will incorporate your comments.
/Neel.
On Friday 02 May 2014 05:09 PM, Zoran Milinkovic wrote:
> Hi Neelakanta,
>
> I have 2 comments on next block:
> 867 if(!isSchemaChangeEnabled && ownerHandle1) {
> 868 error =
> immutil_saImmOmAdmi
Summary: amfnd: fix process of proxy/proxied termination on OpenSAF shutdown
[#629]
Review request for Trac Ticket(s): #629
Peer Reviewer(s): Hans F, Nagendra
Pull request to:
Affected branch(es): default
Development branch:
Impacted area Impact y/n
--
osaf/services/saf/amf/amfnd/clc.cc | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
May 2 15:22:11 linux osafamfnd[2990]: NO
'safSu=Management-SU1,safSg=Management-2N,safApp=ManagementApp' Presence State
INSTANTIATED => TERMINATION_FAILED
May 2 15:22:38 li
Summary: amfd: fix SU in-service macro [#493]
Review request for Trac Ticket(s): #493
Peer Reviewer(s): Hans F, Nagendra, Praveen
Pull request to: Hans F
Affected branch(es): default
Development branch:
Impacted area Impact y/n
--
osaf/services/saf/amf/amfd/include/su.h | 13 +
1 files changed, 9 insertions(+), 4 deletions(-)
May 2 18:56:32 linux osafamfnd[12420]: NO Assigned
'safSi=Dataplane-Np1-SI-1,safApp=DataplaneApp' STANDBY to
'safSu=Dataplane-SU1,safSg=Dataplane-Np1,safApp=DataplaneApp'
May 2 18:56
37 matches
Mail list logo
