Re: [devel] [PATCH 0/5] Review Request for ntf: add new test cases in ntf apitest [#2958]

2018-11-13 Thread mohan
Hi minh, I republished those patches. please check it and push into the community. Thanks Mohan High Availability Solutions Pvt. Ltd. www.hasolutions.in - Original Message - Subject: [PATCH 0/5] Review Request for ntf: add new test cases in ntf apitest [#2958] From: "Mohan

[devel] [PATCH 1/5] ntf: add new test case of API saNtfInitialize() of apitest v2 [#2958]

2018-11-13 Thread Mohan Kanakam
--- src/ntf/apitest/tet_saNtfInitialize.cc | 8 1 file changed, 8 insertions(+) diff --git a/src/ntf/apitest/tet_saNtfInitialize.cc b/src/ntf/apitest/tet_saNtfInitialize.cc index 8538193..80f86e2 100644 --- a/src/ntf/apitest/tet_saNtfInitialize.cc +++ b/src/ntf/apitest/tet_saNtfInitiali

[devel] [PATCH 5/5] ntf: add new test case of API saNtfNotificationReadFinalize() of apitest [#2958]

2018-11-13 Thread Mohan Kanakam
--- src/ntf/apitest/tet_saNtfNotificationReadFinalize.cc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/ntf/apitest/tet_saNtfNotificationReadFinalize.cc b/src/ntf/apitest/tet_saNtfNotificationReadFinalize.cc index 531afd2..d0260aa 100644 --- a/src/ntf/apitest/tet_saNtfNotification

[devel] [PATCH 4/5] ntf: add new test case of API saNtfFinalize() of apitest [#2958]

2018-11-13 Thread Mohan Kanakam
--- src/ntf/apitest/tet_saNtfFinalize.cc | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/ntf/apitest/tet_saNtfFinalize.cc b/src/ntf/apitest/tet_saNtfFinalize.cc index 84cd846..adf2167 100644 --- a/src/ntf/apitest/tet_saNtfFinalize.cc +++ b/src/ntf/apitest/tet_saNtfFinalize.cc @@ -1

[devel] [PATCH 3/5] ntf: add new test case of API saNtfDispatch() of apitest v2 [#2958]

2018-11-13 Thread Mohan Kanakam
--- src/ntf/apitest/tet_saNtfDispatch.cc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/ntf/apitest/tet_saNtfDispatch.cc b/src/ntf/apitest/tet_saNtfDispatch.cc index 5fea4ef..d4d46f2 100644 --- a/src/ntf/apitest/tet_saNtfDispatch.cc +++ b/src/ntf/apitest/tet_saNtfDispatch.cc

[devel] [PATCH 2/5] ntf: add new test case of API saNtfSelectionObjectGet() of apitest [#2958]

2018-11-13 Thread Mohan Kanakam
--- src/ntf/apitest/tet_saNtfSelectionObjectGet.cc | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/ntf/apitest/tet_saNtfSelectionObjectGet.cc b/src/ntf/apitest/tet_saNtfSelectionObjectGet.cc index 6da2c78..c4ca1c8 100644 --- a/src/ntf/apitest/tet_saNtfSelectionObjectGet.cc ++

[devel] [PATCH 0/5] Review Request for ntf: add new test cases in ntf apitest [#2958]

2018-11-13 Thread Mohan Kanakam
Summary: ntf: add new test case of API saNtfInitialize() of apitest v2 [#2958] Review request for Ticket(s): 2958 Peer Reviewer(s):minh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2958 Base revision: f8a6848a1cdbff0b518c3db

[devel] [PATCH 1/1] amfd: Give assignment for pre-instantiated su after the node joins cluster [#2960]

2018-11-13 Thread Minh Chau
If the SU is unlock-in/unlock before the node joins cluster, the SU is instantiated and in unlocked state. However, when the node completes joining the cluster, amfd assumes all applications' SU uninstantiated and starts the instantiation, thus the instantiated/unlocked SU is forgot to give the

[devel] [PATCH 0/1] Review Request for amfd: Give assignment for pre-instantiated su after the node joins cluster [#2960]

2018-11-13 Thread Minh Chau
Summary: amfd: Give assignment for pre-instantiated su after the node joins cluster [#2960] Review request for Ticket(s): 2960 Peer Reviewer(s): Hans, Nagu, Gary Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2960 Base revisio

Re: [devel] [PATCH 0/5] Review Request for ntf: add new test cases in apitest [#2958]

2018-11-13 Thread Minh Hon Chau
Hi Mohan, ack for series with minor comments in the sub-patches. Thanks Minh On 9/11/18 11:55 pm, Mohan Kanakam wrote: Summary: ntf: add new test case of API saNtfInitialize() of apitest [#2958] Review request for Ticket(s): 2958 Peer Reviewer(s):minh Pull request to: *** LIST THE PERSON WITH

Re: [devel] [PATCH 1/5] ntf: add new test case of API saNtfInitialize() of apitest [#2958]

2018-11-13 Thread Minh Hon Chau
Hi Mohan, A minor comment, we could use nullptr instead. Thanks Minh On 9/11/18 11:55 pm, Mohan Kanakam wrote: --- src/ntf/apitest/tet_saNtfInitialize.cc | 8 1 file changed, 8 insertions(+) diff --git a/src/ntf/apitest/tet_saNtfInitialize.cc b/src/ntf/apitest/tet_saNtfInitializ

Re: [devel] [PATCH 3/5] ntf: add new test case of API saNtfDispatch() of apitest [#2958]

2018-11-13 Thread Minh Hon Chau
Hi Mohan, A minor comment, I think you meant to add saNtfDispatch_04. Thanks Minh On 9/11/18 11:55 pm, Mohan Kanakam wrote: --- src/ntf/apitest/tet_saNtfDispatch.cc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/ntf/apitest/tet_saNtfDispatch.cc b/src/ntf/apitest/tet_s

Re: [devel] Review Request for amf: update PR [#2918]

2018-11-13 Thread Minh Hon Chau
Hi Gary, ack from me. Thanks/Minh On 14/11/18 1:28 pm, Gary Lee wrote: Hi A small update to the AMF PR for #2918. * Renumbered 2.2.18 Excessive assignments to 2.2.19 * Added 2.2.18 Network partitioning * Added timers to Section 3.3 https://sourceforge.net/p/opensaf/tickets/_discuss/thr

[devel] Review Request for amf: update PR [#2918]

2018-11-13 Thread Gary Lee
Hi A small update to the AMF PR for #2918. Renumbered 2.2.18 Excessive assignments to 2.2.19 Added 2.2.18 Network partitioning Added timers to Section 3.3 https://sourceforge.net/p/opensaf/tickets/_discuss/thread/cae26fce/0d37/attachment/OpenSAF_AMF_PR_new.odt.gz Thanks Gary ___

[devel] [PATCH 1/1] imm: fix introduceMsg resent in every 0.1 second [#2959]

2018-11-13 Thread Vu Minh Nguyen
It is expected that resending introduceMsg should happen every 05 seconds if the previous send has not yet received the response e.g because of having network issue or having the active IMMD unresponsive. However, in some cases, the re-send is done every 0.1 second. This patch adds a few code to m

[devel] [PATCH 0/1] Review Request for imm: fix introduceMsg resent in every 0.1 second [#2959]

2018-11-13 Thread Vu Minh Nguyen
Summary: imm: fix introduceMsg resent in every 0.1 second [#2959] Review request for Ticket(s): 2959 Peer Reviewer(s): Lennart, Hans, Gary Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2959 Base revision: 5bb2174a323a97f626ce3