SA_AIS_ERR_EXIST;
}
/Neel.
On Thursday 04 September 2014 05:37 PM, Anders Bjornerstedt wrote:
Ack from me with the nano-optimization suggested below
reddy.neelaka...@oracle.com wrote:
osaf/services/saf/immsv/immnd/ImmModel.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions
Actually no it was not.
Now I see the problem: the negation of impl-mDying.
/AndersBj
Anders Bjornerstedt wrote:
Hi Neel,
Ok.
The nano-optimization was actually a correction to make the patch
effective :-)
/AndersBj
Neelakanta Reddy wrote:
Hi Anders,
Just realized
Ack from me.
Agree with Mathi that you should keep the printout of mds-dest in hex.
/AndersBj
reddy.neelaka...@oracle.com wrote:
osaf/libs/core/mds/mds_c_api.c| 6 +++---
osaf/services/saf/immsv/immnd/immnd_evt.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff
Ack from me.
This ticket was more cmplex to fix than I had anticipated.
Good work!
Minor comments below mostly on minor improvements on performance and
clarity.
Bur also one case where longDnsAllowed values greater than one are
interpreted as 'false' but
should be interpreted as 'true'.
That
Ack from me.
AndersBj
Hans Feldt wrote:
osaf/libs/agents/saf/imma/imma_db.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/osaf/libs/agents/saf/imma/imma_db.c
b/osaf/libs/agents/saf/imma/imma_db.c
--- a/osaf/libs/agents/saf/imma/imma_db.c
+++
Hi Zoran,
The basic problem that must be solved is to make loading possible if the
data that is loaded contains long-DNs.
The patch/fix does solve that problem by the added line in
getLongDnsAllowed()
But the patch also tries to check if the database is consistent between
the value of
Hans Feldt wrote:
-Original Message-
From: Anders Widell [mailto:anders.wid...@ericsson.com]
Sent: den 26 augusti 2014 13:13
To: Zoran Milinkovic; reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 1 of 1] immtools: fix the use of
Ack from me.
/AndersBj
Hans Feldt wrote:
osaf/libs/common/immsv/include/immsv_api.h | 2 +-
osaf/services/saf/immsv/immloadd/imm_loader.cc | 2 +-
osaf/services/saf/immsv/immnd/ImmModel.cc | 12 ++--
osaf/services/saf/immsv/immnd/ImmModel.hh | 2 +-
Ack from me on PATCH 1 of 2 (first of two patches) with the following
adjustments
Hans Feldt wrote:
osaf/libs/common/immsv/include/immsv_api.h | 8 +++
osaf/services/saf/immsv/immloadd/imm_loader.cc | 23 +++-
osaf/services/saf/immsv/immnd/ImmModel.cc | 69
Ack on this one with comments in-line.
We need to write a defect ticket to do a bit of validation for the
attribute value.
Hans Feldt wrote:
osaf/services/saf/immsv/immnd/immnd_evt.c | 26 +++---
1 files changed, 23 insertions(+), 3 deletions(-)
diff --git
Other n
Comments (indicate scope for each y above):
-
changeset 1363957909068feedd9f2bd94686bcb655b42b2b
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Tue, 19 Aug 2014 10:00:02 +0200
IMM: Update immsv
osaf/services/saf/immsv/README | 201 ++--
1 files changed, 149 insertions(+), 52 deletions(-)
diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README
--- a/osaf/services/saf/immsv/README
+++ b/osaf/services/saf/immsv/README
@@ -1649,7
n
Other n
Comments (indicate scope for each y above):
-
changeset 8755648e8fc94bd5050ab7b3544c16af3e046949
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Wed, 20 Aug 2014 09:23:06 +0200
IMM
osaf/services/saf/immsv/README | 21 ++---
1 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README
--- a/osaf/services/saf/immsv/README
+++ b/osaf/services/saf/immsv/README
@@ -343,7 +343,22 @@ will be
osaf/services/saf/immsv/README | 39 +++
1 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README
--- a/osaf/services/saf/immsv/README
+++ b/osaf/services/saf/immsv/README
@@ -328,6
Other n
Comments (indicate scope for each y above):
-
changeset bab578a4d9cd8af7a06f0ddfaf0f1dea0f84e4f4
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Wed, 20 Aug 2014 10:48:41 +0200
IMM: Document
Ack with a few comments.
1) Using a config attribute changeable at runtime instead of a build
time configuration
such as an environment variable, is more flexible but less secure. That
is, it is more
risky from a security point of view. Anyone that gets temporary access
to a terminal
with
Hi Neel,
I am reviewing #25 and #957 and I just have an initial comment about
immutils.
Both patches update immutils (I actually dont remember the reason why
#35 needed to update immutils but it
must be due to reasons of convenience in the implementation of #35).
The problem is that
Hi Neel,
Good work.
Ack from me on this patch with just the following comment.
If you have time ...
We use four spaces (not tab) as indentation in ImmModel.cc
There are even some accidental indentation changes, where there is no change
except a change of indentation. Such as line 10973 in
Ack.
Code review only.
/AndersBj
nagendr...@oracle.com wrote:
osaf/services/saf/amf/amfd/compcstype.cc | 13 ++---
osaf/services/saf/amf/amfd/imm.cc| 3 ++-
osaf/services/saf/amf/amfd/include/imm.h | 2 +-
osaf/services/saf/amf/amfd/su.cc | 18
Hi Neel.
There is some valuable work done in this patch and most of it is ok.
But in its current state I have to give it a NACK.
It needs some adjustments and extension before it can be pushed.
There are two main problems:
1) The PBE is the main OI for the object involved and we actually want
osaf/services/saf/immsv/README| 26 +++---
osaf/services/saf/immsv/immnd/ImmModel.cc | 14 ++
2 files changed, 33 insertions(+), 7 deletions(-)
This enhancement removes the restriction of not allowing a class schema change
to add a default to an
will not be deallocated while you are blocked.
2) You are inside a callback that got an instance as callback argument
= it is safe to borrow the
string inside the callback because the callback arguments con only be
de-allocated after you
return from the callback.
/AndersBj
Anders Bjornerstedt wrote:
Hi Praveen
Ack on the third (tools) patch.
/AndersBj
Zoran Milinkovic wrote:
osaf/tools/safimm/immadm/Makefile.am | 1 +
osaf/tools/safimm/immadm/imm_admin.c | 14 +--
osaf/tools/safimm/immcfg/Makefile.am | 1 +
osaf/tools/safimm/immcfg/imm_cfg.c | 22 --
The fourth patch (testcases) I have to giva a conditional ACK due to
some minor problems that need fixing.
1) Executing regular immoitest (without --longDn) the test case
'immoitest 3 6 fails for some reason that has to do
with long DNs. That old testcase explicitly does a negative test on long
.
On Wednesday 16 July 2014 08:23 PM, Anders Bjornerstedt wrote:
osaf/services/saf/immsv/README| 24
+---
osaf/services/saf/immsv/immnd/ImmModel.cc | 2 +-
2 files changed, 22 insertions(+), 4 deletions(-)
This enhancement removes the restriction of not allowing
osaf/services/saf/immsv/README| 24 +---
osaf/services/saf/immsv/immnd/ImmModel.cc | 2 +-
2 files changed, 22 insertions(+), 4 deletions(-)
This enhancement removes the restriction of not allowing a class schema change
to add a default to an attribute
n
Comments (indicate scope for each y above):
-
changeset 1bb3322830595313f59c11bc6330cafcd8d6d3fb
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Fri, 11 Jul 2014 10:26:17 +0200
IMM: Allow class schema change
osaf/services/saf/immsv/README| 19 ++-
osaf/services/saf/immsv/immnd/ImmModel.cc | 6 --
2 files changed, 18 insertions(+), 7 deletions(-)
This enhancement removes the restriction of not allowing a class schema change
to add a default to an attribute
osaf/services/saf/immsv/immnd/ImmModel.cc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
If the 'longDnsAllowed' attribute in the OpenSAF IMM service object
'safRdn=immManagement,safApp=safImmService' is set to a non-zero value,
then long DNs are allowed in the cluster.
This patch
Other n
Comments (indicate scope for each y above):
-
changeset 4e3a21c8b98795aa657857664f247b201f7b0a76
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Thu, 10 Jul 2014 14:25:06 +0200
IMM: RDN limitation
pointer.
Yes, as long as the NTF API is clear about ownership and possible
transfer of ownership of data,
then you do what you have to do.
/AndersBj
Thanks,
Minh
On 7/7/2014 6:22 PM, Anders Bjornerstedt wrote:
Anders Bjornerstedt wrote:
About null terminated or not strings in SaNameT
n
Other n
Comments (indicate scope for each y above):
-
changeset 015ee3f5d468ff8ec89667554aef729b34a76cc1
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Wed, 09 Jul 2014 10:27:19 +0200
imm: Provide
osaf/services/saf/immsv/immnd/ImmModel.cc | 94 --
1 files changed, 86 insertions(+), 8 deletions(-)
The six validation cases described in the ticket are implemented by this
changeset:
For the object 'opensafImm=opensafImm,safApp=safImmService':
1) 0PBE reject
About null terminated or not strings in SaNameT.
The IMM handles this issue like this (not BEFORE the long DN support).
1) The actual max length of DNs supported by the IMM is 255 bytes, not 256.
This is to allow all SaNameT values to be null termianted which is a
HUGE simplification in
all
Anders Bjornerstedt wrote:
About null terminated or not strings in SaNameT.
The IMM handles this issue like this (not BEFORE the long DN support).
That should have been: (note BEFORE the long DN support).
/AndersBj
1) The actual max length of DNs supported by the IMM is 255 bytes
n
Other n
Comments (indicate scope for each y above):
-
changeset c00c6b5c7c16ca68cc0fcdfa0847611c6fc848ee
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Mon, 07 Jul 2014 12:13:11 +0200
IMM: PBE
osaf/services/saf/immsv/immnd/ImmModel.cc| 85 +--
osaf/services/saf/immsv/immnd/ImmModel.hh| 2 +-
osaf/services/saf/immsv/immpbed/immpbe_daemon.cc | 13 +---
3 files changed, 80 insertions(+), 20 deletions(-)
The OpenSAF IMM service object
Other n
Comments (indicate scope for each y above):
-
changeset 83fa169f43de5cb6b7fb70048bffc68f7fa4c390
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Thu, 05 Jun 2014 14:55:19 +0200
IMM: Add config
osaf/libs/common/immsv/include/immsv_api.h | 2 +
osaf/services/saf/immsv/immloadd/imm_loader.cc | 10 +++-
osaf/services/saf/immsv/immnd/ImmModel.cc | 24 +
osaf/services/saf/immsv/immnd/ImmModel.hh | 1 +
samples/immsv/OpensafImm.xml | 64
I have to NACK this patch due to some issues commented below.
Mainly performance related.
Zoran Milinkovic wrote:
osaf/libs/common/immsv/immsv_evt.c | 56 +-
osaf/libs/common/immsv/include/immsv_evt.h | 4 +
osaf/libs/common/immsv/include/immsv_evt_model.h |
n
Comments (indicate scope for each y above):
-
changeset cbe82be1d276a85c33ee4c6f64961b2984414e6b
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Thu, 22 May 2014 16:25:05 +0200
imm: Add upgrade support
osaf/services/saf/immsv/immnd/ImmModel.cc | 15 ++-
1 files changed, 10 insertions(+), 5 deletions(-)
Only allow admin-operation directly targeting implementer if protocol4.5
is allowed. This is an addition to enhancement [#799] not any defect fix.
diff --git
osaf/services/saf/immsv/immnd/ImmModel.cc | 15 ++-
osaf/services/saf/immsv/immnd/immnd_evt.c | 8 +++-
2 files changed, 17 insertions(+), 6 deletions(-)
Symptoms are during upgrade to OpenSAF 4.5:
May 16 12:01:03 SC-2 local0.err osafimmnd[427]: ER Can not sync Ccb that is
Comments (indicate scope for each y above):
-
changeset 985b194fb146b2080667e5437c411fa44262a193
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Wed, 21 May 2014 12:09:02 +0200
imm: Add upgrade support for saImmOmValidate
n
Comments (indicate scope for each y above):
-
changeset e8d651611b7260f371e50f3aa19e717fe23c415b
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Tue, 20 May 2014 11:07:54 +0200
imm: Add upgrade flag
osaf/libs/common/immsv/include/immsv_api.h | 1 +
osaf/services/saf/immsv/README | 46 ++---
osaf/services/saf/immsv/immnd/ImmModel.cc | 31
osaf/services/saf/immsv/immnd/ImmModel.hh | 1 +
osaf/services/saf/immsv/immnd/immnd_init.h
Some comments below.
Zoran Milinkovic wrote:
Hi Neelakanta,
Find my answers inline.
Best regards,
Zoran
-Original Message-
From: Neelakanta Reddy [mailto:reddy.neelaka...@oracle.com]
Sent: den 15 maj 2014 11:49
To: Zoran Milinkovic
Cc: opensaf-devel@lists.sourceforge.net
osaf/services/saf/immsv/README | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
See osaf/services/saf/immsv/README for details on IMMA_OI_CALLBACK_TIMEOUT.
diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README
---
One comment below.
mathi.naic...@oracle.com wrote:
Summary: log: saflogger to return EXIT_FAILURE when SaLogWriteLogCallbackT
fails - v2 [#884]
Review request for Trac Ticket(s): #884
Peer Reviewer(s): Lennart
Pull request to: LIST THE PERSON WITH PUSH ACCESS HERE
Affected branch(es):
Ack from me.
Tested.
Did not re-review the code.
/AndersBj
reddy.neelaka...@oracle.com wrote:
Summary:Imm:Make immcfg aware of safImmService admin owner for
opensafImm=opensafImm,safApp=safImmService [#840]
Review request for Trac Ticket(s): 840
Peer Reviewer(s): AndersBj, Zoran
Affected
Other n
Comments (indicate scope for each y above):
-
EXPLAIN/COMMENT THE PATCH SERIES HERE
changeset f3bd590108f2bdb2bada136baf9b31bc8d963460
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Tue, 29 Apr 2014 16:17
osaf/libs/agents/saf/imma/imma_oi_api.c | 6 -
osaf/services/saf/immsv/README | 84 +++-
osaf/services/saf/immsv/immnd/ImmModel.cc| 14 +++
osaf/tools/safimm/immadm/imm_admin.c | 7 +-
Anders Björnerstedt wrote:
This patch only affects the ccb-operation callbacks for ccb-
create/delete/modify.
It does not append anything to a user error string since the callback never
reached the user. It adds an error string in the imm server where there
previously could
be no string,
It would be possible but I am not sure it is desirable.
I dont see any problem with the current names and I do see the current
labeling as clear,
related 1:1 to the SaVersionT setting you need to set to get access to
that API version.
For SaAis.h the difference is that it is not in itself any
Other n
Comments (indicate scope for each y above):
-
changeset 31109d862e0218f9da84d3bbd152916f32aed31f
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Tue, 01 Apr 2014 19:16:46 +0200
IMM: 2PBE - PBE
osaf/libs/common/immsv/immpbe_dump.cc| 9 +
osaf/services/saf/immsv/immpbed/immpbe_daemon.cc | 12
2 files changed, 13 insertions(+), 8 deletions(-)
An SMF campaign enables the PBE (with 2PBE) and immediately attempts
to update a PRTA. This fails because the
Ack with two minor comments, only one of which requires a small change.
I tested for both config objecs and persistent RTOs and the patch works.
I.e. it removes the implementer-name for config objects and does not
remove it for PRTOs.
See minor comments below
reddy.neelaka...@oracle.com wrote:
n
Comments (indicate scope for each y above):
-
changeset 69367fc0e7f73a6f87fde79ec5b2857a84b058d7
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Wed, 12 Mar 2014 11:42:54 +0100
IMM: OM/OI Replace SaNameT
osaf/libs/agents/saf/imma/imma_oi_api.c | 39 +++-
osaf/libs/agents/saf/imma/imma_om_api.c | 113 +-
osaf/libs/saf/include/saImmOi_A_2_11.h |2 +
osaf/libs/saf/include/saImmOi_A_2_14.h | 122 +++
osaf/libs/saf/include/saImmOm_A_2_13.h |2
n
Comments (indicate scope for each y above):
-
Updated patch to have oi-callbacks following same pattern of replacing SaNameT
with SaConstStringT.
changeset 93b69f7c6e0d47523299bd87d33a122b9468fc3e
Author: Anders Bjornerstedt
Too late for the 4.2 patch.
/AndersBj
Neelakanta Reddy wrote:
Hi zoran,
Reviewed the patches for 4.2.x, 4.3.x, 4.4.x(default).
Tested with 4.2.x .
Ack for all patches.
/Neel.
On Friday 21 February 2014 10:07 PM, Zoran Milinkovic wrote:
Summary: IMM: add support for forwards
not exist,
className.c_str());
err = SA_AIS_ERR_NOT_EXIST;
/Neel
On Friday 21 February 2014 09:05 PM, Anders Bjornerstedt wrote:
Summary: IMM: Use existing PBE mutation record to guard against
concurrent class create/delete [#757]
Review request for Trac Ticket(s): 757
Ack from me (4.2 patch 2).
Zoran Milinkovic wrote:
osaf/tools/safimm/immcfg/imm_cfg.c | 31 -
osaf/tools/safimm/immcfg/imm_import.cc | 178
++-
osaf/tools/safimm/immlist/imm_list.c|6 -
osaf/tools/safimm/immload/imm_loader.cc | 150
ACK from me 4.2 patch 1 with adjustment to comment, see below.
In principle something about this flag compatibility stuff should also
go into the README,
but we will have to take that later and separately.
/AndesBJ
Zoran Milinkovic wrote:
osaf/services/saf/immsv/immnd/ImmModel.cc| 39
Ack from me 4.3 patch 1 with same adjustment to the comment marked below.
Zoran Milinkovic wrote:
osaf/libs/common/immsv/immpbe_dump.cc |2 +-
osaf/services/saf/immsv/immloadd/imm_loader.cc | 140
-
osaf/services/saf/immsv/immnd/ImmModel.cc | 36
Ack from me 4.4/4.5 patch 1 with same adjustment to the comment.
/AndersBj
--
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow
Ack from me 4.4/4.5 patch 2.
/AndersBj
--
Flow-based real-time traffic analytics software. Cisco certified tool.
Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
Customize your own dashboards, set
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 8b350adb3b0eaec83a6bbe758e4d5a222cf916cf
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Fri, 21 Feb 2014 16:09:37 +0100
osaf/services/saf/immsv/immnd/ImmModel.cc | 100 ++---
1 files changed, 48 insertions(+), 52 deletions(-)
The existing mutation record for PBE operations includes records for
class-create and class-delete.
These are now used to detect any pre-existing and on-going PBE
the compiler warning.
I will of course fix this before pushing.
/AndersBj
-Original Message-
From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: den 12 februari 2014 20:03
To: reddy.neelaka...@oracle.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: [devel
osaf/services/saf/immsv/immd/immd_sbevt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/osaf/services/saf/immsv/immd/immd_sbevt.c
b/osaf/services/saf/immsv/immd/immd_sbevt.c
--- a/osaf/services/saf/immsv/immd/immd_sbevt.c
+++ b/osaf/services/saf/immsv/immd/immd_sbevt.c
Other n
Comments (indicate scope for each y above):
-
changeset ac8dba937e3c38152205ff05f52e824c7f250444
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Fri, 14 Feb 2014 09:03:58 +0100
IMM: Change
n
Comments (indicate scope for each y above):
-
changeset dcdaf601ce95927192d9d722b11bd8a249c6d93d
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Fri, 14 Feb 2014 10:22:02 +0100
IMM: Adjust log message severity
n
Other n
Comments (indicate scope for each y above):
-
changeset 87a45acdd97cfda3d6f3b54eecab083cea5d758e
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Fri, 14 Feb 2014 15:03:27 +0100
IMM: Improved
I will add the term 'validation error' into the syslog message stemming
from the completed continuation.
Note that according to the spec, the oi can reply on the completed
callback with error codes BAD_OPERATION,
NO_RESOURCES or NO_MEMORY.
Any other error code will be converted to
and disconnect are not handled in the callback-reply logic. So
will let them be as is for now.
The final ccb abort printout I will keep as in the current patch, i.e.
reduce severity from WArning to NOtice.
An aborted CCB is after all no indication of any systemic problem.
/AndersBj
Anders
osaf/services/saf/immsv/immnd/ImmModel.cc | 27 ---
1 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
--- a/osaf/services/saf/immsv/immnd/ImmModel.cc
+++
osaf/services/saf/immsv/immpbed/immpbe_daemon.cc | 343 +-
1 files changed, 203 insertions(+), 140 deletions(-)
Risk for discrepancy between 2PBE slave and primary is reduced further
by having the slave wait for ok_to_prepare trigger from primary for
the weak-ccb associated
osaf/services/saf/immsv/immnd/ImmModel.cc | 33 --
1 files changed, 18 insertions(+), 15 deletions(-)
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
--- a/osaf/services/saf/immsv/immnd/ImmModel.cc
+++
osaf/services/saf/immsv/README.NO_DANGLING | 36 -
1 files changed, 29 insertions(+), 7 deletions(-)
diff --git a/osaf/services/saf/immsv/README.NO_DANGLING
b/osaf/services/saf/immsv/README.NO_DANGLING
--- a/osaf/services/saf/immsv/README.NO_DANGLING
+++
osaf/libs/saf/include/saImmOm_A_2_13.h | 7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/osaf/libs/saf/include/saImmOm_A_2_13.h
b/osaf/libs/saf/include/saImmOm_A_2_13.h
--- a/osaf/libs/saf/include/saImmOm_A_2_13.h
+++ b/osaf/libs/saf/include/saImmOm_A_2_13.h
@@ -46,11
osaf/services/saf/immsv/README | 27 +++
1 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README
--- a/osaf/services/saf/immsv/README
+++ b/osaf/services/saf/immsv/README
@@ -318,7 +318,7 @@ is
Ok but it would not be wrong even if your focus is on conversion to c++
here, if the new
c++ code just happened not to use SaNameT at that inner level. Just
saves time long term
without causing any problem.
/AndersBj
Hans Feldt wrote:
Yes we are aware of that, just trying to do one logical
REview comments on API/library patch for NO_DANGLING.
Zoran Milinkovic wrote:
osaf/libs/agents/saf/imma/imma_om_api.c | 64
+++-
osaf/libs/saf/include/saImmOm_A_2_13.h | 13 ++
2 files changed, 66 insertions(+), 11 deletions(-)
diff --git
Review comments on server side patch for NO_DANGLING search.
I was pleasantly surprised that this enhancement resulted in relatively
moderate addition of code.
Good job Zoran.
A few comments below.
Zoran Milinkovic wrote:
osaf/services/saf/immsv/immnd/ImmModel.cc | 101
Ack from me if the comment below is fixed.
/AndersBj
Anders Bjornerstedt wrote:
REview comments on API/library patch for NO_DANGLING.
Zoran Milinkovic wrote:
osaf/libs/agents/saf/imma/imma_om_api.c | 64
+++-
osaf/libs/saf/include/saImmOm_A_2_13.h | 13
Ok will fix that in README before pushing.
/AndersBj
Neelakanta Reddy wrote:
Hi Anders,
Reviewed the patch.
Ack.
README is not updated with the immadm changes, related to #642.
/Neel.
On Tuesday 17 December 2013 11:16 PM, Anders Bjornerstedt wrote:
osaf/services/saf/immsv/README
search
API.
changeset 801c15787543ba3e9b436883886c7781fb63845c
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Mon, 16 Dec 2013 15:56:32 +0100
IMM: Update README to document support for NO_DANGLING search [#50]
Complete diffstat:
--
osaf/services/saf
osaf/services/saf/immsv/README | 17 +-
osaf/services/saf/immsv/README.NO_DANGLING | 47 +-
2 files changed, 61 insertions(+), 3 deletions(-)
diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README
---
Ack from me.
/AndersBj
Zoran Milinkovic wrote:
Summary: IMM: Add support for NO_DANGLING flag [#49]
Review request for Trac Ticket(s): 49
Peer Reviewer(s): Neel, Anders
Pull request to: Zoran
Affected branch(es): default(4.4)
Development branch: default(4.4)
Need to correct myself in one of my own review comments.
So far I have sent three mails. This is in the first one.'
See below.
Anders Bjornerstedt wrote:
Hi Zoran.
Server side patch looks much better :-)
I still have some detail comments though.
Not all of them in this mail, but just to let
Additional comments (fourth review mail for #49).
18) ImmModel::ccbObjectCreate
Log message:
AttrFlagIncludes(SA_IMM_ATTR_PERSISTENT)) ==
omi-second-mClassInfo-mAttrMap.end()) {
LOG_NO(ERR_INVALID_PARAM:
Need to correct my own review comments again.
Just goes to show that this code is really hard to review.
See below.
Anders Bjornerstedt wrote:
Additional comments (fourth review mail for #49).
18) ImmModel::ccbObjectCreate
Log message
Additional comments (fifth review mail for #49).
This is the final mail for this RR, i.e. this set of patches.
21) ImmModel::ccbObjectModify
+s1.clear();
+s2.clear();
+// Exclude objects for adding from the original object
Better:
//Create the set s1 of
Additional comments.
9) In checkNoDanglingReferencesModify (to be renamed
validateNoDanglingRefsModify):
+LOG_NO(ERR_FAILED_OPERATION: NO_DANGLING
reference (%s) does not exist,
+av-getValueC_str());
Says the reference does not
Additional comments (third reply mail).
11) In ImmModel::addNoDanglingReferences(ObjectInfo *object)
Comment should explain that this function extracts all NO_DANGLING
references that exist in object
and insert them into sReverseRefObjectMap.
Thats with 'object' as source and the object matching
n
Comments (indicate scope for each y above):
-
changeset 323733e1c28b4e101e9bb87084e2a8db9931e879
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Tue, 03 Dec 2013 13:13:21 +0100
IMM: Discard node for self
osaf/services/saf/immsv/immnd/immnd_evt.c | 7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
If an IMMND receives a discard-node message and the node to be discarded
is the node the IMMND is executing on, then this is a clear indication of
cluster network partitioning, or split
n
Comments (indicate scope for each y above):
-
changeset 3bf3cece1ea7d11d76ac3f7cd1df0577388dc70f
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Mon, 02 Dec 2013 16:33:20 +0100
IMM: Update the README file
101 - 200 of 230 matches
Mail list logo
