Re: [opensc-devel] [opensc-commits] svn opensc changed[3802] Enable PCSC by default.

2009-11-02 Thread Martin Paljak
On 02.11.2009, at 19:08, Andreas Jellinghaus wrote: > yes and no. ctapi is always compiled in, so we should allow that > case. but we can still have a big fat warning if neither openct > nor pcsc is compiled in. Yes, but *why*? I don't see a good reason for this other than pure legacy. CT-API

Re: [opensc-devel] [opensc-commits] svn opensc changed[3802] Enable PCSC by default.

2009-11-02 Thread Andreas Jellinghaus
I think it is best to have: * disable -> don't even try * enable -> needs to be there * detect -> see if it is there with "detect" as default. (or if we want to keep it simple: only detect, no enable/disable.) and it would be nice to have a big fat warning, if neither pcsc nor openct was found/en

Re: [opensc-devel] [opensc-commits] svn opensc changed[3802] Enable PCSC by default.

2009-11-02 Thread Jim Rees
Remind me why we don't just dispense with OpenCT and incorporate the pcsc reader drivers directly into OpenSC. Is there a license issue? Are there people using pcsc as a separate package without OpenSC? Are there problems for non-linux installs? ___ op

Re: [opensc-devel] [opensc-commits] svn opensc changed[3802] Enable PCSC by default.

2009-11-02 Thread Andreas Jellinghaus
Am Montag 02 November 2009 14:38:07 schrieb Ludovic Rousseau: > Normal users should use: > $ ./configure && make && sudo make install > and have a working configuration in a standard case. I agree with that. With the old default settings neither pcsc not openct would be build in, thus no reader su

Re: [opensc-devel] [opensc-commits] svn opensc changed[3802] Enable PCSC by default.

2009-11-02 Thread Martin Paljak
On 02.11.2009, at 16:12, Alon Bar-Lev wrote: > On Mon, Nov 2, 2009 at 4:07 PM, Peter Stuge wrote: >> Ludovic Rousseau wrote: Please follow openssl/zlib/iconv logic. >>> >>> I think "detect" is wrong. If pcsc-lite is not installed you will >>> not have a working configuration but you will not

Re: [opensc-devel] [opensc-commits] svn opensc changed[3802] Enable PCSC by default.

2009-11-02 Thread Peter Stuge
Alon Bar-Lev wrote: > >> I think "detect" is wrong. If pcsc-lite is not installed you will > >> not have a working configuration but you will not be warned either. > > > > I tried to suggest a method of addressing this; check that support > > for some reader type has been enabled, and refuse to con

Re: [opensc-devel] [opensc-commits] svn opensc changed[3802] Enable PCSC by default.

2009-11-02 Thread Alon Bar-Lev
On Mon, Nov 2, 2009 at 4:07 PM, Peter Stuge wrote: > Ludovic Rousseau wrote: >> > Please follow openssl/zlib/iconv logic. >> >> I think "detect" is wrong. If pcsc-lite is not installed you will >> not have a working configuration but you will not be warned either. > > I tried to suggest a method o

Re: [opensc-devel] [opensc-commits] svn opensc changed[3802] Enable PCSC by default.

2009-11-02 Thread Peter Stuge
Ludovic Rousseau wrote: > > Please follow openssl/zlib/iconv logic. > > I think "detect" is wrong. If pcsc-lite is not installed you will > not have a working configuration but you will not be warned either. I tried to suggest a method of addressing this; check that support for some reader type h

Re: [opensc-devel] [opensc-commits] svn opensc changed[3802] Enable PCSC by default.

2009-11-02 Thread Alon Bar-Lev
configure should detect whatever it can by default should disable all default feature that are not available. This is how most [well behaved] configurations do. But for sure disabling pcsc if openct is enabled is bad idea, as users may like them both and you start to add some of YOUR logic into th

Re: [opensc-devel] [opensc-commits] svn opensc changed[3802] Enable PCSC by default.

2009-11-02 Thread Ludovic Rousseau
2009/11/2 Alon Bar-Lev : > You should follow the "detect" logic. > Please follow openssl/zlib/iconv logic. I think "detect" is wrong. If pcsc-lite is not installed you will not have a working configuration but you will not be warned either. If you want I can add code to disable pcsc if openct is

Re: [opensc-devel] [opensc-commits] svn opensc changed[3802] Enable PCSC by default.

2009-11-02 Thread Alon Bar-Lev
You should follow the "detect" logic. Please follow openssl/zlib/iconv logic. On Mon, Nov 2, 2009 at 3:38 PM, Ludovic Rousseau wrote: > 2009/11/2 Alon Bar-Lev : >> This is simply wrong. >> It will completely fail if pcsc is absent. > > Yes. You have to use --disable-pcsc if you do not want to use

Re: [opensc-devel] [opensc-commits] svn opensc changed[3802] Enable PCSC by default.

2009-11-02 Thread Ludovic Rousseau
2009/11/2 Alon Bar-Lev : > This is simply wrong. > It will completely fail if pcsc is absent. Yes. You have to use --disable-pcsc if you do not want to use pcsc. It will fail by design. > Please refer to the "detect" logic for openssl/zlib/iconv, > Please fix. > > Also, I must say I reject of ena

Re: [opensc-devel] [opensc-commits] svn opensc changed[3802] Enable PCSC by default.

2009-11-02 Thread Peter Stuge
Alon Bar-Lev wrote: > This is simply wrong. > It will completely fail if pcsc is absent. > > Please refer to the "detect" logic for openssl/zlib/iconv, > Please fix. Agree! > Also, I must say I reject of enabling optional features without > explicit instruction. Yes! In this case, at the very

Re: [opensc-devel] [opensc-commits] svn opensc changed[3802] Enable PCSC by default.

2009-11-02 Thread Alon Bar-Lev
This is simply wrong. It will completely fail if pcsc is absent. Please refer to the "detect" logic for openssl/zlib/iconv, Please fix. Also, I must say I reject of enabling optional features without explicit instruction. But... people wish to push something. Alon. On Mon, Nov 2, 2009 at 12:52