[opensource-dev] Fwd: Successful Build Nr. 208114 for oz_viewer-development (39db065f8899) on Darwin

2010-08-15 Thread Oz Linden
The first build of the new open Development repo is available now. Begin forwarded message: > From: buildad...@lindenlab.com > Date: August 15, 2010 12:18:39 EDT > To: o...@lindenlab.com > Subject: Successful Build Nr. 208114 for oz_viewer-development (39db065f8899) > on Darwin > > > > urls

[opensource-dev] Review Request: Restructure loops that use breaks without need (reviewboard test)

2010-12-01 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/2/ --- Review request for Viewer. Summary --- This review is mostly a first tes

Re: [opensource-dev] Review Request: VWR-20962 CTRL-\ Last chatter

2010-12-14 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/16/ --- (Updated 2010-12-14 07:03:25.753345) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations

2010-12-17 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/32/#review48 --- indra/llvfs/lldiriterator.h

Re: [opensource-dev] Review Request: Update returnability of objects based on new encroachment rules

2010-12-23 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/56/#review73 --- indra/llcommon/llversionviewer.h

Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations

2010-12-23 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/32/#review80 --- As noted below, it would be more efficient to do the translation fro

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

2010-12-23 Thread Oz Linden
> On 2010-12-23 06:46:09, Vadim ProductEngine wrote: > > indra/llkdu/llimagej2ckdu.h, line 58 > > > > > > Please add a comment that these methods aren't actually public, i.e. > > were made public only to be called from un

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

2010-12-27 Thread Oz Linden
> On 2010-12-24 13:25:16, Aleric Inglewood wrote: > > I'm going to respectfully disagree with Aleric on one minor style point. When comparing equality between a literal or constant and a variable, putting the constant value has an advantage: it avoids the "=" vs "==" error: if (FOO_LIMIT ==

[opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

2011-01-05 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/70/ --- Review request for Viewer. Summary --- This is a simple change to corre

Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations

2011-01-05 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/32/ --- (Updated Jan. 5, 2011, 8:33 a.m.) Review request for Viewer. Changes -

Re: [opensource-dev] Review Request: (STORM-550) LLDir::getNextFileInDir fails for some complex wildcard combinations

2011-01-05 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/32/#review112 --- Just one policy question with this... This implementation uses llw

Re: [opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

2011-01-06 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/70/ --- (Updated Jan. 6, 2011, 10:20 a.m.) Review request for Viewer. Summary (upd

Re: [opensource-dev] Review Request: Show TOS (and other login dialogs) if --login is specified

2011-01-12 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/76/#review142 --- Ship it! Looks good to me. - Oz On Jan. 10, 2011, 10:28 a.m., J

Re: [opensource-dev] Review Request: Storm-844 "More" should be "Less" when Media Control is open

2011-01-12 Thread Oz Linden
> On Jan. 12, 2011, 6:16 a.m., Boroondas Gupte wrote: > > doc/contributions.txt, lines 369-371 > > > > > > Sorting issue numbers in doc/contributions.txt is a Good Thing(TM), but > > unrelated to the issue at hand, thus

Re: [opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

2011-01-17 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/87/#review172 --- indra/llui/llnotifications.cpp

Re: [opensource-dev] Review Request: VWR-24420: PNG images which specify "background color" lose alpha layer when imported.

2011-01-17 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/74/#review174 --- Ship it! - Oz On Jan. 9, 2011, 6:59 a.m., Thickbrick Sleaford wr

Re: [opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express

2011-01-17 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/68/#review175 --- Given that we are in the process of moving to VS2010, I suggest tha

[opensource-dev] Review Request: DN-202: More aggressive caching of display names

2011-01-18 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/104/ --- Review request for Viewer. Summary --- Changes the caching of avatar d

Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: ll_apr_warn_status: APR: No such file or directory

2011-01-20 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/83/#review212 --- Ship it! - Oz On Jan. 14, 2011, 12:48 p.m., Aleric Inglewood wro

Re: [opensource-dev] Review Request: VWR-24317: Incorrect start up warnings: WARNING: remove: Attempting to remove filename: /ramdisk/imprudence/cache/textures/*/*.texture

2011-01-20 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/84/#review213 --- Ship it! - Oz On Jan. 16, 2011, 6:12 a.m., Aleric Inglewood wrot

Re: [opensource-dev] Review Request: VWR-24317: Fix of debug warning (printing of unassigned variable)

2011-01-20 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/87/#review214 --- Ship it! - Oz On Jan. 17, 2011, 5:32 a.m., Aleric Inglewood wrot

Re: [opensource-dev] Review Request: STORM-2 As a User, I want to set my own default views with specific UI layout so I can tailor my Viewer experience to the activities I'm most interested in.

2011-01-21 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/98/#review238 --- decided this morning that this change will not be integrated yet, s

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-01-24 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review246 --- If the file is generated, what is it doing checked into the source

Re: [opensource-dev] Review Request: make PREHASH variables char const* const

2011-01-24 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review248 --- Given that Boroondas reports that the message.cpp in the viewer so

Re: [opensource-dev] Review Request: Constraints in XUI files don't match the constraints imposed elsewhere in the viewer/server code.

2011-01-27 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/57/ --- (Updated Jan. 27, 2011, 6:55 a.m.) Review request for Viewer and Kent Quirk.

[opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/ --- Review request for Viewer. Summary --- During initialization, if there

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-28 Thread Oz Linden
d have to figure out how to do that, but that's ok). - Oz --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/#review265 ---------

Re: [opensource-dev] Review Request: Do not fail when no scp command is found, unless it is actually needed to fetch something

2011-01-29 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/127/ --- (Updated Jan. 29, 2011, 5:01 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters

2011-02-02 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/132/#review309 --- indra/newview/llworld.cpp

Re: [opensource-dev] Review Request: VWR-17050 No nearby people when over approxiamately 1000 meters

2011-02-03 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/132/#review316 --- Ship it! - Oz On Feb. 2, 2011, 3:39 p.m., Twisted Laws wrote: >

Re: [opensource-dev] Review Request: Make viewer-autobuild work under Visual Studio 2005 Express Edition.

2011-02-05 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/136/ --- (Updated Feb. 5, 2011, 3:25 a.m.) Review request for Viewer. Changes

[opensource-dev] Review Request: OPEN-7: allow specification of the config-file with env var AUTOBUILD_CONFIG_FILE

2011-02-06 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/140/ --- Review request for Viewer. Summary --- This change allows the environm

[opensource-dev] Review Request: OPEN-8: allow specification of the configuration with env var AUTOBUILD_CONFIGURATION

2011-02-06 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/141/ --- Review request for Viewer. Summary --- This patch adds support for spe

Re: [opensource-dev] Review Request: OPEN-8: allow specification of the configuration with env var AUTOBUILD_CONFIGURATION

2011-02-08 Thread Oz Linden
rious issue not to be ignored. - Oz --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/141/#review342 ------- On Feb

Re: [opensource-dev] Review Request: OPEN-7: allow specification of the config-file with env var AUTOBUILD_CONFIG_FILE

2011-02-08 Thread Oz Linden
- Oz --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/140/#review343 --- On Feb. 6, 2011, 5:39 p.m., Oz Linden wrote: > > --

Re: [opensource-dev] Review Request: Use consistent path for all *.py scripts

2011-02-10 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/129/#review353 --- Ship it! Those changes look good. For future reference, there's

[opensource-dev] Review Request: open-2 (improved progress messages during dependency checks) and open-31 (more standardized short form option switches)

2011-02-12 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/150/ --- Review request for Viewer. Summary --- I combined open-31 into this be

Re: [opensource-dev] Review Request: open-2 (improved progress messages during dependency checks) and open-31 (more standardized short form option switches)

2011-02-13 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/150/ --- (Updated Feb. 13, 2011, 5:21 a.m.) Review request for Viewer. Changes ---

Re: [opensource-dev] Review Request: open-2 (improved progress messages during dependency checks) and open-31 (more standardized short form option switches)

2011-02-14 Thread Oz Linden
and half of silence at the default level is a bit to far down the silent side. Besides, in that particular case, if I thought I was updating because I gave a command to update, it might be important to remind me that nothing is being changed. - Oz ----------- This is an automatically generated e-mail

[opensource-dev] Review Request: storm-1037: remove the 'hide url' checkboxes from parcel management

2011-03-03 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/171/ --- Review request for Viewer. Summary --- This patch removes the two "Hid

[opensource-dev] Review Request: storm-1038: crash in texture cache pruning

2011-03-03 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/172/ --- Review request for Viewer. Summary --- If the viewer is started when t

Re: [opensource-dev] Review Request: Nearby chat history is displaying both Display Names and user.names when the Display Name is not changed from default.

2011-03-04 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/153/#review421 --- Ship it! - Oz On March 4, 2011, 5:11 a.m., ardy.lay wrote: > >

Re: [opensource-dev] Review Request: Corrected a call to the Mac-specific command "Rez" that had the wrong case.

2011-03-11 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/196/#review445 --- Ship it! Subject to verification that it works in TeamCity, this

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

2011-03-12 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/ --- (Updated March 12, 2011, 6:33 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

2011-03-12 Thread Oz Linden
> On March 11, 2011, 3:53 a.m., Boroondas Gupte wrote: > > indra/newview/llselectmgr.cpp, lines 6574-6587 > > > > > > Memory reuse is good, I guess, but having variable names that only > > describe the variable's con

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

2011-03-12 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/199/#review448 --- If the comments here are addressed, I think this is probably a goo

[opensource-dev] Review Request: OPEN-45: Correctly include the pass-through options when displaying the configure and build commands

2011-03-16 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/213/ --- Review request for Viewer and Alain Linden. Summary --- Extended the _

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

2011-03-17 Thread Oz Linden
> On March 12, 2011, 7:16 a.m., Oz Linden wrote: > > indra/llcharacter/llbvhloader.cpp, line 1199 > > <http://codereview.secondlife.com/r/199/diff/1/?file=1179#file1179line1199> > > > > I think it would be clearer to either add a new constant > >

Re: [opensource-dev] Review Request: Suggested fix for OPEN-45

2011-03-17 Thread Oz Linden
March 17, 2011, 3:02 p.m.) > > > Review request for Viewer, Oz Linden and Boroondas Gupte. > > > Summary > --- > > Suggested fix for OPEN-45. I'd like to decouple Executable as much as > possible from assumptions and state of autobuild. To that end

Re: [opensource-dev] Review Request: STORM-323: redundant popups

2011-03-24 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/230/ --- (Updated March 24, 2011, 4:34 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-323: redundant popups

2011-03-24 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/230/#review493 --- Ship it! - Oz On March 24, 2011, 4:34 a.m., Lance Corrimal wrot

Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played

2011-03-28 Thread Oz Linden
> On March 26, 2011, 8:55 a.m., Boroondas Gupte wrote: > > indra/newview/llgesturemgr.cpp, lines 536-537 > > > > > > If the iterator will not be used outside the loop, please declare it > > with the assignment in the

Re: [opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played

2011-03-28 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/231/#review508 --- indra/newview/llgesturemgr.cpp

Re: [opensource-dev] Review Request: Enable CURLOPT_ENCODING for Inventory caps, which uses the LLURLRequest code path

2011-03-31 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/242/ --- (Updated March 31, 2011, 7:32 a.m.) Review request for Viewer, Oz Linden

Re: [opensource-dev] Review Request: STORM-1044 Improved message template checking.

2011-04-01 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/174/#review532 --- Ship it! - Oz On March 3, 2011, 2:20 p.m., Kelly Washington wro

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

2011-04-04 Thread Oz Linden
> On March 13, 2011, 5:34 a.m., Boroondas Gupte wrote: > > indra/newview/llfloaterchat.cpp, lines 416-419 > > > > > > If storing return values of functions (or inline computations), just so > > we don't have to call t

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-05 Thread Oz Linden
> On April 5, 2011, 12:35 p.m., Vadim ProductEngine wrote: > > indra/newview/llnearbychatbar.h, line 118 > > > > > > Remove the class prefix: it may cause compilation problems on Linux. Does cause failure on Linux...

[opensource-dev] Review Request: Allow override of the autobuild platform for configuration testing

2011-04-06 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/253/ --- Review request for Viewer, Brad Kittenbrink and Alain Linden. Summary -

Re: [opensource-dev] Review Request: OPEN-57: Allow override of the autobuild platform for configuration testing

2011-04-06 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/253/ --- (Updated April 6, 2011, 3:32 a.m.) Review request for Viewer, Brad Kittenbr

Re: [opensource-dev] Review Request: STORM-610 : Changes to Environment Editor: water color change is not saved

2011-04-06 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/254/#review570 --- Ship it! - Oz On April 6, 2011, 3:02 p.m., Merov Linden wrote:

Re: [opensource-dev] Review Request: STORM-1088: bundled winmm.dll shim crashes on start-up on some systems.

2011-04-18 Thread Oz Linden
, windows_volume_catcher of llqtwebkit is functional. Same applies to Second Life 2.6.3 (226792) Apr 17 2011 07:01:06 (Second Life Developer), built by Oz Linden with a prior version of my patch. media_plugin_quicktime functionality untested, voice capture untested. The patch contains debug output, which

Re: [opensource-dev] Review Request: STORM-1088: bundled winmm.dll shim crashes on start-up on some systems.

2011-04-20 Thread Oz Linden
e > installed viewer, causes the above mentioned viewer to start up without issue > and function apparently properly - sound works (FMOD), media_plugin_webkit > works, voice is audible, windows_volume_catcher of llqtwebkit is functional. > Same applies to Second Life 2.6.3 (226792) Ap

Re: [opensource-dev] Review Request: CHOP-658 moving panels and floaters into a new static library project viewer_components/viewerui

2011-05-21 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/302/ --- (Updated May 21, 2011, 4:06 a.m.) Review request for Viewer and Richard Nel

Re: [opensource-dev] Review Request: CHOP-658 moving panels and floaters into a new static library project viewer_components/viewerui

2011-05-21 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/302/#review711 --- The diff file you uploaded does not contain mercurial changeset id

Re: [opensource-dev] Review Request: Update autobuilds default VC version to 2010

2011-06-03 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/305/ --- (Updated June 3, 2011, 7:43 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: Viewer cache size increase to 10GB.

2011-06-04 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/318/#review718 --- indra/newview/llfloaterpreference.cpp

Re: [opensource-dev] Review Request: Viewer cache size increase to 10GB.

2011-06-04 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/318/#review719 --- Ship it! - Oz On June 3, 2011, 12:56 p.m., Log Linden wrote: >

Re: [opensource-dev] Review Request: OPEN-77 Adding ability for Prebuilt.cmake to pass necessary additional options to 'autobuild install'

2011-06-07 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/327/#review734 --- This should not be needed, and is not a good general way to solve

Re: [opensource-dev] Review Request: OPEN-77 Adding ability for Prebuilt.cmake to pass necessary additional options to 'autobuild install'

2011-06-08 Thread Oz Linden
> On June 7, 2011, 7:07 p.m., Oz Linden wrote: > > This should not be needed, and is not a good general way to solve the > > problem. > > > > See comment in the jira: > > https://jira.secondlife.com/browse/OPE

Re: [opensource-dev] Review Request: VWR-24889: When a bake texture upload fails, retry instead of giving up.

2011-06-10 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/152/#review438 --- indra/newview/lltexlayer.h

Re: [opensource-dev] Review Request: VWR-24889: When a bake texture upload fails, retry instead of giving up.

2011-06-13 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/152/#review740 --- indra/newview/lltexlayer.h

Re: [opensource-dev] Review Request: VWR-24889: When a bake texture upload fails, retry instead of giving up.

2011-06-15 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/152/#review747 --- Ship it! - Oz On June 13, 2011, 2:39 p.m., Thickbrick Sleaford

Re: [opensource-dev] Review Request: STORM-899 'No attachments worn' text on blank 'Attachments' accordion remains in English for all locales

2011-06-15 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/326/#review748 --- Ship it! - Oz On June 7, 2011, 2:32 p.m., Jonathan Yap wrote: >

Re: [opensource-dev] Review Request: STORM-787 Mute Gestures Button

2011-06-15 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/336/#review749 --- Ship it! - Oz On June 12, 2011, 1:09 p.m., Jonathan Yap wrote:

Re: [opensource-dev] Review Request: STORM-1339 Crash in LLPanelPlaces::onTeleportButtonClicked

2011-06-15 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/339/#review750 --- Ship it! - Oz On June 15, 2011, 8:50 a.m., Vadim ProductEngine

Re: [opensource-dev] Review Request: STORM-1352 Crash in LLNearbyChatScreenChannel::showToastsBottom()

2011-06-20 Thread Oz Linden
> On June 16, 2011, 4:23 p.m., Boroondas Gupte wrote: > > indra/newview/llnearbychathandler.cpp, lines 375-382 > > > > > > This function's return type should be changed to bool, if it's intended > > for use with std::

Re: [opensource-dev] Review Request: Changes to fix CHOP-662.

2011-06-22 Thread Oz Linden
reply, visit: > http://codereview.secondlife.com/r/357/ > --- > > (Updated June 20, 2011, 8:21 p.m.) > > > Review request for Viewer, Oz Linden, Seth ProductEngine, and Alain Linden. > > > Summary > --- > >

Re: [opensource-dev] Review Request: Check for null ptr to hopefully prevent crash in LLToolPie

2011-06-22 Thread Oz Linden
w.secondlife.com/r/359/ > --- > > (Updated June 21, 2011, 8:53 a.m.) > > > Review request for Viewer, Oz Linden and Vadim ProductEngine. > > > Summary > --- > > checking for null gAgentAvatarp should hopefully prevent the crash. I can't > reproduce it so I d

Re: [opensource-dev] Review Request: Local Bitmap Browser implementation.

2011-06-22 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/347/#review811 --- indra/llmath/llvolumemgr.cpp

Re: [opensource-dev] Review Request: VWR-21522: Prevent unintended 10L sale

2011-06-29 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/365/#review824 --- Just a couple of minor items to address and this looks good. rem

[opensource-dev] Review Request: Change pre-login viewer display URL to prepare for new community information display

2011-07-16 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/399/ --- Review request for Viewer. Summary --- This changes the URL from which

Re: [opensource-dev] Review Request: Change pre-login viewer display URL to prepare for new community information display

2011-07-16 Thread Oz Linden
This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/399/#review883 ------- On July 16, 2011, 6:12 a.m., Oz Linden wrote: > > ---

Re: [opensource-dev] Review Request: STORM-1487 Gestures -> Get more leads to wrong URL

2011-07-21 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/401/#review902 --- Ship it! - Oz On July 19, 2011, 11:20 a.m., Vadim ProductEngine

Re: [opensource-dev] Review Request: OPEN-76 Fix autobuild so that --config-file option is honoured by subsequent (possibly recursive) commands

2011-07-22 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/335/ --- (Updated July 22, 2011, 6:35 a.m.) Review request for Viewer and Alain Lind

Re: [opensource-dev] Review Request: OPEN-54: Making CMake variable name for JsonCpp include dir(s) consistent

2011-07-27 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/257/#review933 --- Ship it! - Oz On April 8, 2011, 4:41 a.m., Boroondas Gupte wrot

[opensource-dev] Review Request: STORM-1534: Derive Credits lists of contributors and translators from doc/ files

2011-08-02 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/427/ --- Review request for Viewer. Summary --- In the Help>About Second Life d

Re: [opensource-dev] Review Request: STORM-1534: Derive Credits lists of contributors and translators from doc/ files

2011-08-03 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/427/ --- (Updated Aug. 3, 2011, 5:56 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: STORM-1534: Derive Credits lists of contributors and translators from doc/ files

2011-08-03 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/427/ --- (Updated Aug. 3, 2011, 5:59 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: STORM-1534: Derive Credits lists of contributors and translators from doc/ files

2011-08-03 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/427/ --- (Updated Aug. 3, 2011, 2:58 p.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: STORM-1534: Derive Credits lists of contributors and translators from doc/ files

2011-08-06 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/427/ --- (Updated Aug. 6, 2011, 6:14 a.m.) Review request for Viewer. Changes

Re: [opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)

2011-08-08 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/432/#review957 --- Ship it! I don't agree with your early return rationale, but let'

Re: [opensource-dev] Review Request: STORM-1534: Derive Credits lists of contributors and translators from doc/ files

2011-08-12 Thread Oz Linden
//codereview.secondlife.com/r/427/#review955 ------- On Aug. 6, 2011, 6:14 a.m., Oz Linden wrote: > > --- > This is an automatically generated e-mail. To r

Re: [opensource-dev] Review Request: STORM-1543 During busy mode inventory offers get silently deleted instead of thrown into trash

2011-08-22 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/444/#review985 --- indra/newview/llappviewer.cpp

Re: [opensource-dev] Review Request: STORM-1542 Update viewer 2 search url back to search.sl.com

2011-08-22 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/446/#review986 --- Ship it! - Oz On Aug. 22, 2011, 4:26 a.m., Vadim ProductEngine

[opensource-dev] Review Request: storm-1578: change default Away timeout to never

2011-08-31 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/459/ --- Review request for Viewer. Summary --- Simple change to the Away timeo

Re: [opensource-dev] Review Request: STORM-64: Local Bitmaps 2.0 implementation.

2011-09-04 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/347/#review1012 --- indra/newview/lllocalbitmaps.cpp

[opensource-dev] Review Request: STORM-1578, STORM-1589: Away improvements

2011-09-14 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/473/ --- Review request for Viewer. Summary --- Remove the viewer side automati

Re: [opensource-dev] Review Request: STORM-1577 Convert chat translation to third party paid translation services (take 2)

2011-09-15 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/466/#review1028 --- I'd like to see Doxygen style descriptions for all the classes, m

Re: [opensource-dev] Review Request: STORM-1577 Convert chat translation to third party paid translation services (take 2)

2011-09-16 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/466/#review1030 --- Ship it! - Oz On Sept. 15, 2011, 2:57 p.m., Vadim ProductEngin

[opensource-dev] Review Request: storm-1602: GPU Table Updates

2011-09-19 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/480/ --- Review request for Viewer. Summary --- This displays just the gpus_res

  1   2   3   4   5   6   7   >