Re: [openstack-dev] [all][i18n] do we need translation mark for strings in tests?

2016-10-03 Thread Dolph Mathews
On Sat, Oct 1, 2016 at 5:24 PM Ihar Hrachyshka wrote: > Akihiro Motoki wrote: > > > Hi, > > > > I noticed strings in tests (unit tests or others) have translation marks > > (_, _LE and so on). > > Do we need translation marks for them? > > > > I don't

Re: [openstack-dev] [all][i18n] do we need translation mark for strings in tests?

2016-10-02 Thread Ihar Hrachyshka
Matt Riedemann wrote: On 10/1/2016 5:49 PM, Matt Riedemann wrote: No you shouldn't need to mark strings for translation in test code. I believe we have a hacking rule for marking LOG.info/warning/error messages for translation but it should skip test directories.

Re: [openstack-dev] [all][i18n] do we need translation mark for strings in tests?

2016-10-01 Thread Matt Riedemann
On 10/1/2016 5:49 PM, Matt Riedemann wrote: No you shouldn't need to mark strings for translation in test code. I believe we have a hacking rule for marking LOG.info/warning/error messages for translation but it should skip test directories. Ah I guess the hacking rule is nova-specific:

Re: [openstack-dev] [all][i18n] do we need translation mark for strings in tests?

2016-10-01 Thread Matt Riedemann
On 10/1/2016 9:48 AM, Akihiro Motoki wrote: Hi, I noticed strings in tests (unit tests or others) have translation marks (_, _LE and so on). Do we need translation marks for them? I don't think so for most cases from various reasons below. Only exception is to test translations. From

Re: [openstack-dev] [all][i18n] do we need translation mark for strings in tests?

2016-10-01 Thread Ihar Hrachyshka
Akihiro Motoki wrote: Hi, I noticed strings in tests (unit tests or others) have translation marks (_, _LE and so on). Do we need translation marks for them? I don't think so for most cases from various reasons below. Only exception is to test translations. From

[openstack-dev] [all][i18n] do we need translation mark for strings in tests?

2016-10-01 Thread Akihiro Motoki
Hi, I noticed strings in tests (unit tests or others) have translation marks (_, _LE and so on). Do we need translation marks for them? I don't think so for most cases from various reasons below. Only exception is to test translations. >From translators: - Effort to translate strings in tests