Re: [openstack-dev] [oslo] Require documenting changes with versionadded and versionchanged

2015-10-19 Thread Ihar Hrachyshka
> On 16 Oct 2015, at 13:02, Victor Stinner wrote: > > Le 15/10/2015 17:54, Joshua Harlow a écrit : >> I had this problem with deprecation versioning (the debtcollector >> library functions take a version="XYZ", removal_version="ABC" params, >> see >>

Re: [openstack-dev] [oslo] Require documenting changes with versionadded and versionchanged

2015-10-19 Thread Davanum Srinivas
Victor, I'd like to continue the fast paced oslo releases. Last fire drill showed, a few projects that depended on internals of how things we implemented in oslo libraries. Examples were oslo.policy switching to requests from urllib3 and the oslo.utils how it deals with exceptions for example.

Re: [openstack-dev] [oslo] Require documenting changes with versionadded and versionchanged

2015-10-16 Thread Victor Stinner
Le 15/10/2015 17:54, Joshua Harlow a écrit : I had this problem with deprecation versioning (the debtcollector library functions take a version="XYZ", removal_version="ABC" params, see http://docs.openstack.org/developer/debtcollector/examples.html#further-customizing-the-emitted-messages) and

Re: [openstack-dev] [oslo] Require documenting changes with versionadded and versionchanged

2015-10-16 Thread Joshua Harlow
Victor Stinner wrote: Le 15/10/2015 17:54, Joshua Harlow a écrit : I had this problem with deprecation versioning (the debtcollector library functions take a version="XYZ", removal_version="ABC" params, see

[openstack-dev] [oslo] Require documenting changes with versionadded and versionchanged

2015-10-15 Thread Victor Stinner
Hi, I propose that changes must now be documented in Oslo libraries. If a change is not documented, it must *not* be approved. IMHO it's very important to document all changes. Otherwise, it becomes really hard to guess if a specific parameter or a specific function can be used just by

Re: [openstack-dev] [oslo] Require documenting changes with versionadded and versionchanged

2015-10-15 Thread Brant Knudson
On Thu, Oct 15, 2015 at 5:52 AM, Victor Stinner wrote: > Hi, > > I propose that changes must now be documented in Oslo libraries. If a > change is not documented, it must *not* be approved. > > IMHO it's very important to document all changes. Otherwise, it becomes > really

Re: [openstack-dev] [oslo] Require documenting changes with versionadded and versionchanged

2015-10-15 Thread Joshua Harlow
Brant Knudson wrote: On Thu, Oct 15, 2015 at 5:52 AM, Victor Stinner > wrote: Hi, I propose that changes must now be documented in Oslo libraries. If a change is not documented, it must *not* be approved. IMHO it's very

Re: [openstack-dev] [oslo] Require documenting changes with versionadded and versionchanged

2015-10-15 Thread Victor Stinner
Le 15/10/2015 12:52, Victor Stinner a écrit : I started to do this for the oslo.config library: https://review.openstack.org/#/c/235232/ More changes. oslo.concurrency: https://review.openstack.org/#/c/235416/ oslo.serialization: https://review.openstack.org/#/c/235297/ oslo.utils:

Re: [openstack-dev] [oslo] Require documenting changes with versionadded and versionchanged

2015-10-15 Thread Victor Stinner
Le 15/10/2015 16:34, Brant Knudson a écrit : Submitters don't know what release their change is going to get into. They might submit the review when version 1.1.0 is current so they mark it with added in 1.2.0, but then the change doesn't get merged until after 1.4.0 is tagged. Also, the

Re: [openstack-dev] [oslo] Require documenting changes with versionadded and versionchanged

2015-10-15 Thread Doug Hellmann
Excerpts from Joshua Harlow's message of 2015-10-15 08:54:47 -0700: > Brant Knudson wrote: > > > > > > On Thu, Oct 15, 2015 at 5:52 AM, Victor Stinner > > wrote: > > > > Hi, > > > > I propose that changes must now be documented in Oslo