Re: [openstack-dev] Garbage patches for simple typo fixes

On 9/23/2017 10:11 AM, Doug Hellmann wrote: Excerpts from Huang Zhiteng's message of 2017-09-23 10:00:00 +0800: On Sat, Sep 23, 2017 at 8:34 AM, Zhipeng Huang wrote: Hi Paul, Unfortunately I know better on this matter and it is not the matter of topic dispute as many

Re: [openstack-dev] Garbage patches for simple typo fixes

On 2017-09-25 12:12:23 -0400 (-0400), Anita Kuno wrote: > When I click this link I see two items. Perhaps the list can be > named 'help wanted list' and the point about it being the top 5 or > having a maximum of 5 items can be made in the text. Having a top > 5 list with 2 items may confuse the

Re: [openstack-dev] Garbage patches for simple typo fixes

On 2017-09-22 06:11 PM, Mike Perez wrote: On 21:21 Sep 21, Matt Riedemann wrote: I just wanted to highlight to people that there seems to be a series of garbage patches in various projects [1] which are basically doing things like fixing a single typo in a code comment, or very narrowly

Re: [openstack-dev] Garbage patches for simple typo fixes

On 22/09/17 14:47 -0400, Doug Hellmann wrote: Excerpts from Davanum Srinivas (dims)'s message of 2017-09-22 13:47:06 -0400: Doug, Howard (cc'ed) already did a bunch of reaching out especially on wechat. We should request his help. Howard, Can you please help with communications and follow up?

Re: [openstack-dev] Garbage patches for simple typo fixes

On 22/09/17 14:20 +, Jeremy Stanley wrote: On 2017-09-22 08:30:21 -0400 (-0400), Amrith Kumar wrote: [...] When can we take some concrete action to stop these same kinds of things from coming up again and again? Technical solutions to social problems rarely do more than increase

Re: [openstack-dev] Garbage patches for simple typo fixes

On 23/09/17 12:25 -0400, Doug Hellmann wrote: Excerpts from Qiming Teng's message of 2017-09-23 23:55:34 +0800: To some extent, I think Zhipeng is right. There are times we as a community have to do something beyond mentoring new developers. One of the reasons behind these patches are from the

Re: [openstack-dev] Garbage patches for simple typo fixes

On Fri, 22 Sep 2017, Paul Belanger wrote: This is not a good example of encouraging anybody to contribute to the project. Yes. This entire thread was a bit disturbing to read. Yes, I totally agree that mass patches that do very little are a big cost to reviewer and CI time but a lot of the

Re: [openstack-dev] Garbage patches for simple typo fixes

On Fri, Sep 22, 2017 at 1:25 AM, Chris Smart wrote: > On Fri, 22 Sep 2017, at 12:21, Matt Riedemann wrote: >> I just wanted to highlight to people that there seems to be a series of >> garbage patches in various projects [1] which are basically doing things >> like fixing a single

Re: [openstack-dev] Garbage patches for simple typo fixes

One thing that we could consider is adding ‘topy’ [i] to our gating. [i] https://pypi.python.org/pypi/topy On 9/23/17, 2:47 AM, "Michael Johnson" wrote: A recent extreme example:

Re: [openstack-dev] Garbage patches for simple typo fixes

Excerpts from Qiming Teng's message of 2017-09-23 23:55:34 +0800: > To some extent, I think Zhipeng is right. There are times we as a > community have to do something beyond mentoring new developers. One of > the reasons behind these patches are from the management chain of those > companies. They

Re: [openstack-dev] Garbage patches for simple typo fixes

On Fri, Sep 22, 2017 at 04:47:27PM -0700, Michael Johnson wrote: > A recent extreme example: > https://review.openstack.org/#/c/494981/1/specs/version0.8/active_passive_loadbalancer.rst Haha, buddy, let me fix your name! ;) > I would love to have a boilerplate statement I can use as a template >

Re: [openstack-dev] Garbage patches for simple typo fixes

To some extent, I think Zhipeng is right. There are times we as a community have to do something beyond mentoring new developers. One of the reasons behind these patches are from the management chain of those companies. They need numbers, and they don't care what kind of contributions were made.

Re: [openstack-dev] Garbage patches for simple typo fixes

> On 2017. Sep 23., at 9:11, Doug Hellmann wrote: > > Excerpts from Huang Zhiteng's message of 2017-09-23 10:00:00 +0800: >> On Sat, Sep 23, 2017 at 8:34 AM, Zhipeng Huang wrote: >>> Hi Paul, >>> >>> Unfortunately I know better on this matter and

Re: [openstack-dev] Garbage patches for simple typo fixes

Excerpts from Huang Zhiteng's message of 2017-09-23 10:00:00 +0800: > On Sat, Sep 23, 2017 at 8:34 AM, Zhipeng Huang wrote: > > Hi Paul, > > > > Unfortunately I know better on this matter and it is not the matter of topic > > dispute as many people on this thread who has

Re: [openstack-dev] Garbage patches for simple typo fixes

On 09/22/2017 08:34 PM, Zhipeng Huang wrote: > Hi Paul, > > Unfortunately I know better on this matter and it is not the matter of > topic dispute as many people on this thread who has been disturbed and > annoyed by the padding/trolling. > > So yes I'm sticking with stupid because it hurts

Re: [openstack-dev] Garbage patches for simple typo fixes

On Sat, Sep 23, 2017 at 8:34 AM, Zhipeng Huang wrote: > Hi Paul, > > Unfortunately I know better on this matter and it is not the matter of topic > dispute as many people on this thread who has been disturbed and annoyed by > the padding/trolling. > > So yes I'm sticking

Re: [openstack-dev] Garbage patches for simple typo fixes

Hi Paul, Unfortunately I know better on this matter and it is not the matter of topic dispute as many people on this thread who has been disturbed and annoyed by the padding/trolling. So yes I'm sticking with stupid because it hurts the OpenStack community as a whole and hurts the reputation of

Re: [openstack-dev] Garbage patches for simple typo fixes

On Fri, Sep 22, 2017 at 10:26:09AM +0800, Zhipeng Huang wrote: > Let's not forget the epic fail earlier on the "contribution.rst fix" that > almost melt down the community CI system. > > For any companies that are doing what Matt mentioned, please be aware that > the dev community of the country

Re: [openstack-dev] Garbage patches for simple typo fixes

A recent extreme example: https://review.openstack.org/#/c/494981/1/specs/version0.8/active_passive_loadbalancer.rst I would love to have a boilerplate statement I can use as a template for things like this. I feel bad -1/-2 these as I want to encourage involvement, but they are a drain on the

Re: [openstack-dev] Garbage patches for simple typo fixes

Hi Doug, Absolutely glad to help on this matter. We could take this offline first via email or irc chat and then comes up with a solution for the broader community to review On Sat, Sep 23, 2017 at 2:47 AM, Doug Hellmann wrote: > Excerpts from Davanum Srinivas (dims)'s

Re: [openstack-dev] Garbage patches for simple typo fixes

On 08:50 Sep 22, Doug Hellmann wrote: > Excerpts from Tom Barron's message of 2017-09-22 08:10:35 -0400: > > > > On 09/21/2017 10:21 PM, Matt Riedemann wrote: > > > I just wanted to highlight to people that there seems to be a series of > > > garbage patches in various projects [1] which are

Re: [openstack-dev] Garbage patches for simple typo fixes

On 15:04 Sep 22, Jeremy Stanley wrote: > On 2017-09-22 14:50:55 + (+), Rajath Agasthya (rajagast) wrote: > > On 9/21/17, 10:19 PM, "Jeremy Freudberg" wrote: > > > 3) Delay spin-up of resource-intensive/long-running CI jobs > > > until after some initial review

Re: [openstack-dev] Garbage patches for simple typo fixes

On 21:21 Sep 21, Matt Riedemann wrote: > I just wanted to highlight to people that there seems to be a series of > garbage patches in various projects [1] which are basically doing things > like fixing a single typo in a code comment, or very narrowly changing http > to https in links within docs.

Re: [openstack-dev] Garbage patches for simple typo fixes

Excerpts from Ildiko Vancsa's message of 2017-09-22 13:20:31 -0600: > Hi All, > > Another forum we try to put emphasis on this is the Upstream Institute > trainings we have before the Summits and on some smaller events as well. > > We usually try to spend some quality time on review best

Re: [openstack-dev] Garbage patches for simple typo fixes

Hi All, Another forum we try to put emphasis on this is the Upstream Institute trainings we have before the Summits and on some smaller events as well. We usually try to spend some quality time on review best practices and on metrics as well. The aim is to make people realize that if they need

Re: [openstack-dev] Garbage patches for simple typo fixes

Excerpts from Davanum Srinivas (dims)'s message of 2017-09-22 13:47:06 -0400: > Doug, > Howard (cc'ed) already did a bunch of reaching out especially on > wechat. We should request his help. > > Howard, > Can you please help with communications and follow up? > > Thanks, > Dims Thanks, Dims and

Re: [openstack-dev] Garbage patches for simple typo fixes

On 09/22/2017 09:26 AM, Matt Riedemann wrote: > On 9/22/2017 7:10 AM, Tom Barron wrote: >> FWIW I think it is better not to attribute motivation in these cases. >> Perhaps the code submitter is trying to pad stats, but perhaps they are >> just a new contributor trying to learn the process with a

Re: [openstack-dev] Garbage patches for simple typo fixes

Doug, Howard (cc'ed) already did a bunch of reaching out especially on wechat. We should request his help. Howard, Can you please help with communications and follow up? Thanks, Dims On Fri, Sep 22, 2017 at 1:43 PM, Doug Hellmann wrote: > Excerpts from Matt Riedemann's

Re: [openstack-dev] Garbage patches for simple typo fixes

Excerpts from Matt Riedemann's message of 2017-09-22 08:26:31 -0500: > On 9/22/2017 7:10 AM, Tom Barron wrote: > > FWIW I think it is better not to attribute motivation in these cases. > > Perhaps the code submitter is trying to pad stats, but perhaps they are > > just a new contributor trying to

Re: [openstack-dev] Garbage patches for simple typo fixes

Oops hit send to early. 1) git-review shows some community guidelines 2) auto-review of known lower-quality patches And those do relieve some reviewer burden. On Fri, Sep 22, 2017 at 12:43 PM, Jeremy Freudberg wrote: > You're right. The amount of wasted reviewer time

Re: [openstack-dev] Garbage patches for simple typo fixes

You're right. The amount of wasted reviewer time is far more drastic+problematic then the amount of "wasted" CI resources. My prior email did contain these suggestions: On Fri, Sep 22, 2017 at 11:04 AM, Jeremy Stanley wrote: > On 2017-09-22 14:50:55 + (+), Rajath

Re: [openstack-dev] Garbage patches for simple typo fixes

On Sep 22, 2017 07:59, "Matt Riedemann" wrote: On 9/22/2017 9:50 AM, Rajath Agasthya (rajagast) wrote: > On 9/21/17, 10:19 PM, "Jeremy Freudberg" > wrote: > > 3) Delay spin-up of resource-intensive/long-running CI jobs until after > some >

Re: [openstack-dev] Garbage patches for simple typo fixes

On 2017-09-22 14:50:55 + (+), Rajath Agasthya (rajagast) wrote: > On 9/21/17, 10:19 PM, "Jeremy Freudberg" wrote: > > 3) Delay spin-up of resource-intensive/long-running CI jobs > > until after some initial review has been added or time has > > passed.

Re: [openstack-dev] Garbage patches for simple typo fixes

On 9/22/2017 9:24 AM, Csatari, Gergely (Nokia - HU/Budapest) wrote: Isn't it possible to ignore these patches in stackalytics? If the motivation is to look better there, this would solve the problem. That's a technical solution to a social problem. See my reply elsewhere in this thread. How

Re: [openstack-dev] Garbage patches for simple typo fixes

On 9/22/2017 9:59 AM, Matt Riedemann wrote: Figuring out what is useless or not is probably not worth the effort here. We already skip long running tempest dsvm jobs in certain patches, like with docs or unit test only changes. Updating a code comment in code isn't going to catch that. And

Re: [openstack-dev] Garbage patches for simple typo fixes

On 9/22/2017 9:50 AM, Rajath Agasthya (rajagast) wrote: On 9/21/17, 10:19 PM, "Jeremy Freudberg" wrote: 3) Delay spin-up of resource-intensive/long-running CI jobs until after some initial review has been added or time has passed. Authorized contributors,

Re: [openstack-dev] Garbage patches for simple typo fixes

On 9/21/17, 10:19 PM, "Jeremy Freudberg" wrote: 3) Delay spin-up of resource-intensive/long-running CI jobs until after some initial review has been added or time has passed. Authorized contributors, not necessarily synonymous with cores, can override the

Re: [openstack-dev] Garbage patches for simple typo fixes

Mailing List (not for usage questions) <openstack-dev@lists.openstack.org> Subject: Re: [openstack-dev] Garbage patches for simple typo fixes On 2017-09-22 08:30:21 -0400 (-0400), Amrith Kumar wrote: [...] > When can we take some concrete action to stop these same kinds of > things fr

Re: [openstack-dev] Garbage patches for simple typo fixes

On 2017-09-22 08:30:21 -0400 (-0400), Amrith Kumar wrote: [...] > When can we take some concrete action to stop these same kinds of > things from coming up again and again? Technical solutions to social problems rarely do more than increase complexity for everyone involved. Communication,

Re: [openstack-dev] Garbage patches for simple typo fixes

On 9/22/2017 7:10 AM, Tom Barron wrote: FWIW I think it is better not to attribute motivation in these cases. Perhaps the code submitter is trying to pad stats, but perhaps they are just a new contributor trying to learn the process with a "harmless" patch, or just a compulsive clean-upper who

Re: [openstack-dev] Garbage patches for simple typo fixes

Excerpts from Tom Barron's message of 2017-09-22 08:10:35 -0400: > > On 09/21/2017 10:21 PM, Matt Riedemann wrote: > > I just wanted to highlight to people that there seems to be a series of > > garbage patches in various projects [1] which are basically doing things > > like fixing a single typo

Re: [openstack-dev] Garbage patches for simple typo fixes

Thanks Matt for highlighting this (again). Please also see http://openstack.markmail.org/thread/iaqsha7hbiitwqe2 http://markmail.org/thread/k62gcehxg6gv5ep4 http://markmail.org/thread/n753w3wljii67yug When can we take some concrete action to stop these same kinds of things from coming up again

Re: [openstack-dev] Garbage patches for simple typo fixes

On 09/21/2017 10:21 PM, Matt Riedemann wrote: > I just wanted to highlight to people that there seems to be a series of > garbage patches in various projects [1] which are basically doing things > like fixing a single typo in a code comment, or very narrowly changing > http to https in links

Re: [openstack-dev] Garbage patches for simple typo fixes

On Fri, 22 Sep 2017, at 12:21, Matt Riedemann wrote: > I just wanted to highlight to people that there seems to be a series of > garbage patches in various projects [1] which are basically doing things > like fixing a single typo in a code comment, or very narrowly changing > http to https in

Re: [openstack-dev] Garbage patches for simple typo fixes

Thanks for being brave enough to say it publicly. Not sure how many more times I can stomach reading such classic patches as "Optimize the link address" or "Replace six.iteritems() with .items()". Yes, it is still possible for us to be an open community while also minimizing the amount of useless

Re: [openstack-dev] Garbage patches for simple typo fixes

Wow, Matt, that's excellent timing. Day for day, an exact year after the last thread of this kind [1]. Thanks for speaking up, I didn't want to it'd seem like encouraging a stereotype or prejudice towards certain kind of contributions (or contributors) but I've also been rolling my eyes a lot

Re: [openstack-dev] Garbage patches for simple typo fixes

+1000 Thanks for bringing this up, I fully agree that we need to do something about it. Some time ago I even had an idea of creating a case when we intentionally exclude a person from a team for constantly doing things like this and ignoring our comments. Although I understand it slightly

Re: [openstack-dev] Garbage patches for simple typo fixes

Let's not forget the epic fail earlier on the "contribution.rst fix" that almost melt down the community CI system. For any companies that are doing what Matt mentioned, please be aware that the dev community of the country you belong to is getting hurt by your stupid activity. Stop patch

[openstack-dev] Garbage patches for simple typo fixes

I just wanted to highlight to people that there seems to be a series of garbage patches in various projects [1] which are basically doing things like fixing a single typo in a code comment, or very narrowly changing http to https in links within docs. Also +1ing ones own changes. I've been