[Openvpn-devel] OpenVPN 2.1_rc15 GCC 2.96 incompatibility

2009-01-27 Thread Jos Vos
Hi, While there were some incompatibilities with older GCC releases resolved from RC9 to RC15 (I didn't try the releases RC10-RC14), a new incompatibility was introduced concerning the C preprocessor in ssl.c: #ifdef's in macro calls do not seem to be allowed with GCC 2.96. Attached a brute-force

Re: [Openvpn-devel] OpenVPN 2.1_rc15 GCC 2.96 incompatibility

2009-01-27 Thread Matthias Andree
On Tue, 27 Jan 2009, Jos Vos wrote: > While there were some incompatibilities with older GCC releases > resolved from RC9 to RC15 (I didn't try the releases RC10-RC14), > a new incompatibility was introduced concerning the C preprocessor > in ssl.c: #ifdef's in macro calls do not seem to be allowe

[Openvpn-devel] [PATCH] Fix non-C89 comments

2009-01-27 Thread Matthias Andree
Hi, openvpn uses non-C89 //-style comments in two places. Patch to convert these to /* ... */ style comments attached. Best -- Matthias Andree Index: proto.h === --- proto.h (Revision 3896) +++ proto.h (Arbeitskopie) @@ -66,15 +66,

Re: [Openvpn-devel] [PATCH] Fix non-C89 comments

2009-01-27 Thread Alon Bar-Lev
Sent this to James. Did not apply. My queue is at: http://svn.openvpn.net/projects/openvpn/contrib/alon On 1/27/09, Matthias Andree wrote: > Hi, > > openvpn uses non-C89 //-style comments in two places. Patch to convert > these to /* ... */ style comments attached. > > Best > > -- > > Matthi

Re: [Openvpn-devel] OpenVPN 2.1_rc15 GCC 2.96 incompatibility

2009-01-27 Thread Jos Vos
On Tue, Jan 27, 2009 at 04:45:19PM +0100, Matthias Andree wrote: > Come on, nobody needs support for outdated operating systems and rogue > releases of GCC. There has never been a GCC 2.96, and Redhat 7.3 has > been out of security support for more than half a decade now, and if > OpenVPN 2.1 brea

Re: [Openvpn-devel] OpenVPN 2.1_rc15 GCC 2.96 incompatibility

2009-01-27 Thread Alon Bar-Lev
Added to: http://svn.openvpn.net/projects/openvpn/contrib/alon/BETA21-oldgcc Up to james to merge. On 1/27/09, Jos Vos wrote: > Hi, > > While there were some incompatibilities with older GCC releases > resolved from RC9 to RC15 (I didn't try the releases RC10-RC14), > a new incompatibility wa

Re: [Openvpn-devel] OpenVPN 2.1_rc15 GCC 2.96 incompatibility

2009-01-27 Thread Matthias Andree
On Tue, 27 Jan 2009, Jos Vos wrote: > On Tue, Jan 27, 2009 at 04:45:19PM +0100, Matthias Andree wrote: > > > Come on, nobody needs support for outdated operating systems and rogue > > releases of GCC. There has never been a GCC 2.96, and Redhat 7.3 has > > been out of security support for more th

Re: [Openvpn-devel] [PATCH] Fix non-C89 comments

2009-01-27 Thread Matthias Andree
On Tue, 27 Jan 2009, Alon Bar-Lev wrote: > Sent this to James. > Did not apply. > > My queue is at: > http://svn.openvpn.net/projects/openvpn/contrib/alon Perhaps the choice of version control system used for OpenVPN could deserve a second thought -- Mercurial or better Git might support such mo

Re: [Openvpn-devel] [PATCH] Fix non-C89 comments

2009-01-27 Thread Alon Bar-Lev
On 1/27/09, Matthias Andree wrote: > On Tue, 27 Jan 2009, Alon Bar-Lev wrote: > > > Sent this to James. > > Did not apply. > > > > My queue is at: > > http://svn.openvpn.net/projects/openvpn/contrib/alon > > > Perhaps the choice of version control system used for OpenVPN could > deserve a se

Re: [Openvpn-devel] [PATCH] Fix non-C89 comments

2009-01-27 Thread David Sommerseth
Alon Bar-Lev wrote: On 1/27/09, Matthias Andree wrote: On Tue, 27 Jan 2009, Alon Bar-Lev wrote: > Sent this to James. > Did not apply. > > My queue is at: > http://svn.openvpn.net/projects/openvpn/contrib/alon Perhaps the choice of version control system used for OpenVPN could deserv

Re: [Openvpn-devel] [PATCH] Fix non-C89 comments

2009-01-27 Thread James Yonan
Matthias Andree wrote: On Tue, 27 Jan 2009, Alon Bar-Lev wrote: Sent this to James. Did not apply. My queue is at: http://svn.openvpn.net/projects/openvpn/contrib/alon Perhaps the choice of version control system used for OpenVPN could deserve a second thought -- Mercurial or better Git migh