[Openvpn-devel] [PATCH v11] Implement the --tls-export-cert feature

2024-01-12 Thread Gert Doering
From: Arne Schwabe This is a re-implementation of the --tls-export-cert feature. This was necessary to due to missing approval to re-license the old (now removed) code. The re-implementation is based on the following description of the feature provided by David: Add an option to export

[Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature

2024-01-12 Thread cron2 (Code Review)
Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email ) Change subject: Implement the --tls-export-cert feature .. Patch

[Openvpn-devel] [M] Change in openvpn[master]: Keep exported certificate files for following calls

2024-01-12 Thread plaisthos (Code Review)
Attention is currently required from: flichtenheld. Hello flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/487?usp=email to look at the new patch set (#2). Change subject: Keep exported certificate files for following calls

[Openvpn-devel] [M] Change in openvpn[master]: Implement the --tls-export-cert feature

2024-01-12 Thread plaisthos (Code Review)
Attention is currently required from: cron2, flichtenheld, plaisthos. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed:

[Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit test and test export of PEM to file

2024-01-12 Thread plaisthos (Code Review)
Attention is currently required from: plaisthos. Hello cron2, flichtenheld, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=email to look at the new patch set (#5). The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied

[Openvpn-devel] [XS] Change in openvpn[master]: CMakeLists.txt: Don't fail on missing compile_commands.json

2024-01-12 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos, stipa. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/495?usp=email to look at the new patch set (#3). The following approvals got outdated and were

[Openvpn-devel] [L] Change in openvpn[master]: Windows: enforce 'block-local' with WFP filters

2024-01-12 Thread flichtenheld (Code Review)
Attention is currently required from: cron2, d12fk, plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/489?usp=email ) Change subject: Windows: enforce 'block-local' with WFP filters

[Openvpn-devel] [S] Change in openvpn[master]: NTLM: when NTLMv1 is requested, try NTLMv2 instead

2024-01-12 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/500?usp=email to review the following change. Change subject: NTLM: when NTLMv1 is requested, try NTLMv2 instead

[Openvpn-devel] [S] Change in openvpn[master]: NTLM: add length check to add_security_buffer

2024-01-12 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/496?usp=email to review the following change. Change subject: NTLM: add length check to add_security_buffer

[Openvpn-devel] [S] Change in openvpn[master]: proxy-options.rst: Add proper documentation for --http-proxy-user-pass

2024-01-12 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/498?usp=email to review the following change. Change subject: proxy-options.rst: Add proper documentation for --http-proxy-user-pass

[Openvpn-devel] [S] Change in openvpn[master]: --http-proxy-user-pass: allow to specify in either order with --http-...

2024-01-12 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/499?usp=email to review the following change. Change subject: --http-proxy-user-pass: allow to specify in either order with --http-proxy

[Openvpn-devel] [S] Change in openvpn[master]: NTLM: increase size of phase 2 response we can handle

2024-01-12 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/497?usp=email to review the following change. Change subject: NTLM: increase size of phase 2 response we can handle

[Openvpn-devel] [XS] Change in openvpn[master]: CMakeLists.txt: Don't fail on missing compile_commands.json

2024-01-12 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/495?usp=email ) Change subject: CMakeLists.txt: Don't fail on missing compile_commands.json

[Openvpn-devel] [XS] Change in openvpn[master]: CMakeLists.txt: Don't fail on missing compile_commands.json

2024-01-12 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. Hello flichtenheld, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/495?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed:

[Openvpn-devel] [XS] Change in openvpn[master]: CMakeLists.txt: Don't fail on missing compile_commands.json

2024-01-12 Thread stipa (Code Review)
Attention is currently required from: flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/495?usp=email ) Change subject: CMakeLists.txt: Don't fail on missing compile_commands.json

[Openvpn-devel] [XS] Change in openvpn[master]: CMakeLists.txt: Don't fail on missing compile_commands.json

2024-01-12 Thread flichtenheld (Code Review)
Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/495?usp=email ) Change subject: CMakeLists.txt: Don't fail on missing compile_commands.json